Jump to content

Roaddoctor

Members
  • Content count

    1,189
  • Joined

  • Last visited

  • Days Won

    1

Reputation Activity

  1. Like
    Roaddoctor reacted to raiwa in Paypal payment pro credit card number issue   
    Hello Eric,
    The easiest step could be to add a placeholder text to the input field saying something like "no blank spaces"
    If you are using PayPal direct payment, you would need to edit the payment module:
    includes/modules/payment/paypal_pro_dp.php
    find line 161 and modify to:
    ' <td>' . tep_draw_input_field('cc_number_nh-dns', '', 'id="paypal_card_num" placeholder="' . $this->_app->getDef('module_dp_field_card_number_placeholder') . '"') . '</td>' . then add the language definition to: includes/apps/paypal/languages/english/modules/DP/DP.php:
    its a bit different done in the paypal app than in other language files:
    module_dp_field_card_number_placeholder = no blank spaces Then the second step could be to add a pattern check to the input filed which will show an error message if blank spaces are used.
    This is a html5 input validation and shows if they try to hit the form submit ("Confirm Order" button).
    This would look like follows:
    ' <td>' . tep_draw_input_field('cc_number_nh-dns', '', 'id="paypal_card_num" placeholder="' . $this->_app->getDef('module_dp_field_card_number_placeholder') . '" pattern="^\S+$"') . '</td>' . Then if you wish to auto remove blank spaces, try:
    line 212:
    'ACCT' => str_replace(' ', '', $HTTP_POST_VARS['cc_number_nh-dns']),  
  2. Like
    Roaddoctor got a reaction from frankl in [Addon] Google Customer Reviews GCR & Seller Ratings   
    Google updated the code to include Products as an optional field which I believe will extend to product reviews, not just site reviews.  What is needed to get those GTIN submitted?
    <script src="https://apis.google.com/js/platform.js?onload=renderOptIn" async defer></script> <script> window.renderOptIn = function() { window.gapi.load('surveyoptin', function() { window.gapi.surveyoptin.render( { // REQUIRED FIELDS "merchant_id": xxxxxxx, "order_id": "ORDER_ID", "email": "CUSTOMER_EMAIL", "delivery_country": "COUNTRY_CODE", "estimated_delivery_date": "YYYY-MM-DD", // OPTIONAL FIELDS "products": [{"gtin":"GTIN1"}, {"gtin":"GTIN2"}] }); }); } </script>  
  3. Like
    Roaddoctor got a reaction from Bob Stein, VisiBone in modification paypal SHA 256   
    @@douglaswalker
     
    Only your local cert and the intermediary need to be sha-2
    If you are seeing sha-1 at the issuers root, that is ok/normal still, at least I think so. I'm reading up on this now.
  4. Like
    Roaddoctor reacted to zpupster in formatting the customer_telephone   
    this the function i used in invoice.php
     
    <?php function format_telephone($phone_number) {     $cleaned = preg_replace('/[^[:digit:]]/', '', $phone_number);     preg_match('/(\d{3})(\d{3})(\d{4})/', $cleaned, $matches);     return "({$matches[1]}) {$matches[2]}-{$matches[3]}"; } ?> called it here:
    <td class="main"><?php echo format_telephone($order->customer['telephone']); ?></td> this works,
     
    but should i put the function in a different area of oscommerce.  
  5. Like
    Roaddoctor got a reaction from Tsimi in [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo   
    @@Tsimi
     
    Yes
  6. Like
    Roaddoctor reacted to Tsimi in 2334BS - Enhanced Contact Us   
    Thanks John!
     
    The contact_us.php file in the zip files had some minor bugs that i could fix thanks to burt and whitehat.
    The attached file is based on my version of the reCaptcha (tsimi reworked)
    New file attached.
     
     
     
    another alternative to use instead the reCaptcha ist this here;
     
    read
  7. Like
    Roaddoctor reacted to Tsimi in Looking for an Add-on   
    I think I got Jim's Add-on Get 1 Free working on a osC 2.3.4 shop now. Need to do some more testing just to make sure everything is OK.
    After that i need to fix the admin/get_1_free.php file to work with the latest 2.3.4 correctly. Currently it messes up the left column in the admin area.
     
    Did just some light testing and it seems to work just fine. The only downside is i can't say, buy any product from category A and get product Y free it is just
    product to product based. So I need to add all products one by one from category A to get product Y free. But no big deal though with my amount of products.
  8. Like
    Roaddoctor reacted to multimixer in Login with PayPal - Content Width setting ignored   
    You can't display 3 modules of "half width" in a row: 3 x 0,5 = 1,5
     
    Beside that, it looks that you didn't change the paypal login to unsemantic, you have
    <div class="contentContainer grid-50"> <div class="contentContainer grid-50"> <div class="contentContainer grid_8"> In regular 960 the grids total must be 24, in unsemantic I guess 100
  9. Like
    Roaddoctor got a reaction from joli1811 in Paypal App - Incorporation of mods in new admin/orders.php   
    Darn those stray "."'s... caught that once I realized it wasn't a speck of dirt on the monitor.  :)
    Yes! Thank you @Jan Zonjee
  10. Like
    Roaddoctor reacted to greasemonkey in Paypal App - Incorporation of mods in new admin/orders.php   
    @@Roaddoctor Just one VERY small issue. You have a stray "." in admin/orders.php
     
    This;
    <!-- // BOF Separate Pricing Per Customer --> <p><strong><?php echo TABLE_HEADING_CUSTOMERS_GROUPS .":" ; ?></strong> . <?php echo $order->customer['customers_group_name']; ?></p> <!-- // EOF Separate Pricing Per Customer --> Should be;
    <!-- // BOF Separate Pricing Per Customer --> <p><strong><?php echo TABLE_HEADING_CUSTOMERS_GROUPS .":" ; ?></strong> <?php echo $order->customer['customers_group_name']; ?></p> <!-- // EOF Separate Pricing Per Customer -->
  11. Like
    Roaddoctor got a reaction from techhouse in Quantity Price Breaks   
    Would anyone have a 2.3.3.4 version of /includes/modules/product_listing.php that is suited to work with QPBPP_osc2.3.1_v2.0?
    The version in the 2.3package is 2.2 era, and the instructions do not include any manual step instructions for that file, so I'm sort of stuck.
     
    Thanks for the assistance.
  12. Like
    Roaddoctor got a reaction from jraiche in [Contribution] Discount Coupon Codes   
    I have this module working well on 2.3.3.4 - Thanks to all who contributed!
     
    I know it's not "important", but I am trying to stamp out every little E_NOTICE that comes along... This module has few I have yet to sort. Anybody have a thought on this one?
     
    E_NOTICE Error Count: 2
    Error: Undefined property: order::$coupon
    File: includes/classes/order.php
    Line: 325 and 371
     
    Line: 325 is:

    if ( is_object( $this->coupon ) ) {
    from code block

    if ( is_object( $this->coupon ) ) { $applied_discount = 0; $discount = $this->coupon->calculate_discount( $this->products[$index], $valid_products_count ); if( $discount['applied_discount'] > 0 ) $valid_products_count++; $shown_price = $this->coupon->calculate_shown_price( $discount, $this->products[$index] ); $this->info['subtotal'] += $shown_price['shown_price']; $shown_price = $shown_price['actual_shown_price']; } else { $shown_price = $currencies->calculate_price($this->products[$index]['final_price'], $this->products[$index]['tax'], $this->products[$index]['qty']); $this->info['subtotal'] += $shown_price; }
     
    and Line 371

    if ( is_object( $this->coupon ) ) {
    from code block

    if( is_object( $this->coupon ) ) { $this->info['total'] = $this->coupon->finalize_discount( $this->info ); }
     
    any pointers appreciated
    Dave
  13. Like
    Roaddoctor got a reaction from kymation in Google XML Sitemap SEO with Ultimate SEO in osc 2.3.3.4   
    assuming Linux os, check the write permissions for the *.xml files
  14. Like
    Roaddoctor got a reaction from smellypoopants in Shipping Quote in Cart 2.3.3.4 - Support Thread   
    This is the official support thread for Shipping Quote in Cart 2.3.3.4
    V1.0 released for your testing and feedback.
     
    I will post the link to the add-on as soon as it is uploaded
     
    Please try it out and let me know if there are any problems.Enjoy.
     
    Dave
  15. Like
    Roaddoctor reacted to Jack_mcs in Additional Orders Info   
    I hadn't tried this in 2.3.3.4 but I just did and see the error you found. To fix it, in admin/includes/functions/general.php, find
    $prod_query = tep_db_query("select p.products_id from " . TABLE_PRODUCTS . " p left join " . TABLE_PRODUCTS_DESCRIPTION . " pd on p.products_id = pd.products_id where pd.products_name = '" . tep_db_prepare_input($product['name']) . "' and p.products_model = '" . tep_db_prepare_input($product['model']) . "'"); and replace it with
    $prod_query = tep_db_query("select p.products_id from " . TABLE_PRODUCTS . " p left join " . TABLE_PRODUCTS_DESCRIPTION . " pd on p.products_id = pd.products_id where pd.products_name = '" . tep_db_input($product['name']) . "' and p.products_model = '" . tep_db_input($product['model']) . "'");
  16. Like
    Roaddoctor got a reaction from benny2012 in [Contribution] iOSC - mobile version of OSC on your iPhone   
    Rainer - somethings amiss with my Winrar apparently... The "missing files" are getting truncated each time I zip the package up... I will resolve this before any future upload. I think it has something to do with my version of winrar and a path character limit of 260... sorry about that.
     
    benny2012 - sorry for the inconvenience caused
  17. Like
    Roaddoctor got a reaction from nfteam in FedEx - Web Services v9   
    That is a standard message when the module does not have an address (or Zip code minimally) to calculate... or as the message reads the item is possibly too heavy for fedex.
     
    Check yuor installation
  18. Like
    Roaddoctor reacted to IWAS in [Contribution] iOSC - mobile version of OSC on your iPhone   
    OK, I got it to work with the main site still using Chemos seo URLs 2.2d.
     
    You have to rename mobile_product_info.php to something different like mobile_producto_inform.php. Then give it a filename in includes/filenames.php like this
     
    define('FILENAME_MPRODUCT_INFO', 'mobile_producto_inform.php');
     
     
    Then in mobile/includes/modules/products.php change FILENAME_PRODUCT_INFO to FILENAME_MPRODUCT_INFO
     
    do the same in catalog/mobile_shopping_cart.php
     
    and only the second one in the file now called catalog/mobile_producto_inform.php (NOT THE REQUIRES STATEMENT AT THE TOP)
  19. Like
    Roaddoctor got a reaction from Skittles in FedEx - Web Services v9   
    you also might want to scrub your entire site for any references containing "fedex1" and convert the relevent lines to webservices equivelents.
    I was getting errors when removing the old module until I did that.
  20. Like
    Roaddoctor got a reaction from dave@whatsthebigidea.com in FedEx - Web Services v9   
    All-
     
    I will be posting a new and vastly improved version of theis module within a day or two... just a few more details to iron out.
     
    - Added "Ship-Seperate" (FedEx Real Time quote users) aka "ready-to-ship" (UPS users) functionality
    - added seperate surcharges for ground, express, intl, etc....
    - improved the rate presentation with item count, weight, and transit days for ground services.
    - Several more minor enhancements
     
    If there is anyone with developer coding skills that can help me iron out a few last bugs,,,, I could use a little help. Message me please and I will call you.
     
    Almost there....
×