Would you upgrade your store to the latest Phoenix in osCommerce Online Merchant Community Bootstrap Edition Posted July 17 Quote For anyone who's curious, Linux patch files are not the recommended way to request updates to projects that are on GitHub. They're Windows "fc" output, not Linux patch. I feel it would be a waste of time to set up a whole repository for this one set of changes, especially as GB is likely to ignore PRs (we've, ah, exchanged words in the past). Actually I'm hoping that the community here would be willing to push for changes. Quote In general, there is no need to comment out code that is in source control. If these were true patch files, that would be a legit complaint. But I want to provide some context, and these changes are going to have to be manually examined and OK'd anyway... Quote I would also point out that if you make your living from Phoenix and do not support it, Burt is not going to be terribly interested in changing comments and language files to support you. From his perspective, he is already doing work for free for you in providing the functionality in the releases. Now you want him to do more work in an area where he really doesn't care. And other than your pedantic corrections, you're not willing to contribute anything. Not even the time to learn how to make coding contributions in a format convenient to him. I am trying to help out here. I guess I should refrain from suggesting to my clients that they purchase some of GB's modules. I don't make much of my living from Phoenix, and if that's going to be the reaction from the community, I'll just leave and find a more profitable use of my time. Regarding "pedantic" corrections, these are high visibility glitches that tell non-computer types that the people who put out osCommerce just don't care about even trying to look competent. "Welcome on [my store]?" I won't blame GB for most of them -- they look like mistakes that non-native English speakers (or poorly educated Americans) would make. A polished, professional-looking product is a big selling point among business people (who are the majority of osC shop owners). Quote I personally would oppose some of these changes, e.g. converting double spaces after periods to single spaces. OK, that's a debatable one, but I prefer to have the text file match as closely as possible. It's also confusing to non-computer savvy people (like shop owners) trying to find certain text strings by searching for a pattern with one space, when there are two in the file. Even I have had problems with that. Quote And I'm not terribly excited at the idea of adding verbose comments to cover off-the-wall situations like Options -Indexes not working. It's actually quite a common problem, terribly baffling to non-computer experts. The more help we can give these people, the better they'll feel about choosing osC. Or, we can make it a sadistic intelligence test. I don't care. Quote Nor do I favor adding cryptic comments like "(MINIMUM Tare Weight)" to the configuration description. If a merchant shipping stuff doesn't know what a "tare weight" is, they've got problems. The original text was positively misleading, giving a totally wrong idea about how total shipping weight was calculated. The tare is actually a fixed percentage of the total product weight, with a MINIMUM amount (applicable for small shipments). I'm just adding some information that I would hope would be useful for a shop owner to understand what's going on. I also added a fix so that purely virtual orders (no physical product shipped) wouldn't get tagged with the minimum shipping weight. (I carried that over from Frozen -- is it no longer necessary?) Quote Adding comments to the sample data SQL to talk about files in the images/sample directory is not productive. Well, if you've got a better suggestion, I'm listening. If there are instructions anywhere on loading the sample data, perhaps that would be a better place. I put the comment in just in case someone would be wondering where and how they load the sample images if they want the store samples. Quote The same way it currently prompts people to remove the .github directory. The contents of which you apparently haven't read, as it explains the process to make pull requests. I've been wondering why the .github directory is shipped with the product. Totally useless. And I do know how to make a PR, but explained up top why I choose not to. Don't get snarky over this! Quote I would agree with changing "setup" to "set up" and "checkout" to "check out" when used as a verb, but I really doubt that you can find a way to make that exciting to Burt. I notice that you don't change login to log in. Perhaps that means that I changed them all already. But I wouldn't bet on it. I looked for incorrect "login" and didn't see any, so maybe you already caught any. As for GB not finding it "exciting" to make such mundane corrections, well, I find a polished, professional-looking product to be more exciting (and appealing) that something crappy looking. Tastes vary, I guess.