Jump to content


  • Content count

  • Joined

  • Last visited

  • Days Won


MrPhil last won the day on May 9 2020

MrPhil had the most liked content!

Profile Information

Recent Profile Visitors

114,255 profile views
  1. They're Windows "fc" output, not Linux patch. I feel it would be a waste of time to set up a whole repository for this one set of changes, especially as GB is likely to ignore PRs (we've, ah, exchanged words in the past). Actually I'm hoping that the community here would be willing to push for changes. If these were true patch files, that would be a legit complaint. But I want to provide some context, and these changes are going to have to be manually examined and OK'd anyway... I am trying to help out here. I guess I should refrain from suggesting to my clients that they purchase some of GB's modules. I don't make much of my living from Phoenix, and if that's going to be the reaction from the community, I'll just leave and find a more profitable use of my time. Regarding "pedantic" corrections, these are high visibility glitches that tell non-computer types that the people who put out osCommerce just don't care about even trying to look competent. "Welcome on [my store]?" I won't blame GB for most of them -- they look like mistakes that non-native English speakers (or poorly educated Americans) would make. A polished, professional-looking product is a big selling point among business people (who are the majority of osC shop owners). OK, that's a debatable one, but I prefer to have the text file match as closely as possible. It's also confusing to non-computer savvy people (like shop owners) trying to find certain text strings by searching for a pattern with one space, when there are two in the file. Even I have had problems with that. It's actually quite a common problem, terribly baffling to non-computer experts. The more help we can give these people, the better they'll feel about choosing osC. Or, we can make it a sadistic intelligence test. I don't care. If a merchant shipping stuff doesn't know what a "tare weight" is, they've got problems. The original text was positively misleading, giving a totally wrong idea about how total shipping weight was calculated. The tare is actually a fixed percentage of the total product weight, with a MINIMUM amount (applicable for small shipments). I'm just adding some information that I would hope would be useful for a shop owner to understand what's going on. I also added a fix so that purely virtual orders (no physical product shipped) wouldn't get tagged with the minimum shipping weight. (I carried that over from Frozen -- is it no longer necessary?) Well, if you've got a better suggestion, I'm listening. If there are instructions anywhere on loading the sample data, perhaps that would be a better place. I put the comment in just in case someone would be wondering where and how they load the sample images if they want the store samples. I've been wondering why the .github directory is shipped with the product. Totally useless. And I do know how to make a PR, but explained up top why I choose not to. Don't get snarky over this! I looked for incorrect "login" and didn't see any, so maybe you already caught any. As for GB not finding it "exciting" to make such mundane corrections, well, I find a polished, professional-looking product to be more exciting (and appealing) that something crappy looking. Tastes vary, I guess.
  2. I have some clients using older osC versions that I upgrade to Phoenix. I'm fine with that, except that there are a number of silly errors in the code that I need to fix at each Phoenix release, and I'd really like to see GB incorporate the following changes into (or soon after). They are in two attached files. One is 'fc' (file compare) format, which Linux tools may be be able to read, but each change should be manually examined anyway. Phoenix_patches 1075patch
  3. Phoenix, not
  4. MrPhil

    PayPal App v5.018 Log In with PayPal is now dead

    Have you read the full thread, as well as related ones in the PayPal section? "Login with PayPal" is gone, replaced by "Connect". There are some suggested code changes to get this to work.
  5. MrPhil

    Login with Paypal

    IIRC, 5.010 is indeed the last full installation, and there are a number of incremental updates following it, up to 5.018. I haven't looked to see if all the updates will be applied in one "update" click, or if you have to update several times to get to 5.018, but you might want to keep an eye on what it's doing. I recall that there are gaps in the sequence (i.e., there are not 8 updates to get to 5.018). There have been some recent changes to PayPal (e.g., Connect vs Login), so 5.018 isn't the last word, but I think Harald has to manually do some code changes to bring it up to date. I don't know what his plans are there.
  6. MrPhil

    International SEO

    Google site:forums.oscommerce.com hreflang to see lots of discussion on this subject.
  7. MrPhil

    Auto Update Currencies

    If the code only looks at the time of day, and doesn't keep track of the day on which it was last run, it's not very good code. Anyway, if you can't run a proper "cron" job, look at "poor man's cron" examples that do track when the last time something was run was, and kick off the run if enough time has passed. Such code would be started from some place in osC such as application_top.php. I think there may be a poor man's cron in one of the mass mailing add-ons, where you don't want to dump an avalanche of emails on the system, but just dribble out a few at a time, then wait for the next run of osC that's a few minutes later. I don't know if anyone has generalized a PMC to run arbitrary modules at arbitrary times/dates, but that would be a great feature for osC. Perhaps you would be better off if you worked with your host to understand what their limitations are on cron jobs. It's understandable that they want to keep out-of-control scripts off their servers, but cron is a necessary part of any non-trivial website. You got burned once by not understanding what they allowed, but that doesn't mean you can't craft a cron job that they will allow.
  8. MrPhil

    Auto Update Currencies

    Does your host actually not let you run cron (on a Linux server), or do they restrict the kinds of things you can run, such as PHP scripts using 'php'? Mine does the latter, but they allow using cURL to run PHP scripts.
  9. MrPhil

    Login with PayPal saying return url is wrong

    I'll include it in the next release of Frozen patches. This is a separate issue from the Login/Connect with PayPal in the other thread, or does it affect it, too?
  10. MrPhil

    Login with PayPal saying return url is wrong

    Is this issue the same as (or related to) ? If it is, at the very least please put a pointer in that thread pointing to this one.
  11. MrPhil

    Ezsocial for osC2.3.4BS v1.0a

    Are the interface and logo unchanged, or is osC's implementation going to have to be completely redone, anyway? It sounds like the latter to me, but I guess it hasn't settled down yet.
  12. MrPhil

    Ezsocial for osC2.3.4BS v1.0a

    Since Google+ has mostly gone away, should we be thinking about removing it from stores? I never used it, but my understanding is that it's only available for "G Suite", whatever that is. Do the Google+ functions on osC still do anything, or are they just an embarrassment that osC hasn't been updated in ages? If it should go away, I can add that to my Frozen patch set. It will be up to others to fix Edge and the official product.
  13. MrPhil

    Database Optimizer

    Keep in mind that it's more than just changing function names mysql_ to mysqli_. Some parameter lists in the calls will also be changed, so you need to check those.
  14. MrPhil

    Upgrading to the latest version

    You've got two entirely separate things here: 1) conversion of the DB from old schema to new, and 2) selective editing of DB content. I wouldn't try to mix them -- do (1) then (2). You'll often get yourself in trouble if you try to transfer table-by-table. I find it better to change the DB layout (schema) from old to new in one go, and then edit content at my leisure, either in the .sql backup, or on the live DB using phpMyAdmin. My preferred method is to dump both the old and new databases in .sql file format, including the table creation commands (which gives you the layout). It's not rocket science to compare each table, field-by-field, and update the old DB's .sql file; it's just painstaking and meticulous work. If there are add-ons and other customizations to the old store, that is really the only way to do it. If new fields are added, you may have to synthesize appropriate data for them. Has anyone come up with a tool yet to take an old .sql dump and a new one, and generate the SQL needed to update the old DB to the new one's schema (leaving alone add-on changes)? You'd still have to eyeball the SQL to check what it's doing. Of course this requires getting your hands dirty in the depths of the database, and is not for the faint of heart. So long as you keep a backup of the database you're modifying, and know how to use that backup to restore the DB (if you've modified a live one on the system), you shouldn't cause a catastrophe -- you can always start over.
  15. MrPhil

    Login with Paypal

    Login with PayPal has been changed to Connect with PayPal. See if anything in helps you.