killerwhale65

Thanks for your valuable feedback, i will try and see how to incorporate your suggestions in future versions. About the admin, that is correct the way you see it. I know this interface is basic, but it does what it needs to do: edit/remove comments, delete pictures and clean the thumbnails folder. About the OTF contrib: picture sizes are hardcoded in the gallery.php and gallery_user.php files for now. You will be able to change them later in the admin. This is no error, this is correct, no pictures are supposed to show up, only the filenames/picture numbers

new version 0.6 I have just uploaded the newest version of Photo Gallery for osCommerce. In this version, the already announced admin module has been introduced. Currently you will be able to edit/remove comments (usefull to fight SPAM), delete pictures and clean up the thumbnails folder. Also some smaller bugs were solved. Direct download: http://addons.oscommerce.com/info/6181 Visit the project website for more information: http://oscommerce-photo-gallery.micrographx.be Have fun!

Unfortunately, it is wrong to use links this way, because it will loose session data like currency and language once you click on it. You need to link using the tep_href_link function, otherwise you will get situations like switching to the default language or currency when you click on the link. So this solution may solve your problem, but it creates another huge problem for the user. I would suggest not to use this solution.

Well, as you can see, clicking 'edit' moved you to a page with the URL http://www.chocolategelt.com/catalog/gallery_process.php/edit/yes/pID/1/cID/8339 This URL is not what it is supposed to be http://www.chocolategelt.com/catalog/gallery_process.php?edit=yes&pID=1&cID=8339 Notice the difference? Most likely you are using some contribution that breaks your URL into pieces. But with the broken pieces it does not work anymore because the URL is transferring variables, and with the "broken pieces URL", those variables are lost because the = and & signs are lost. So it cannot work this way.

Try changing the link value to: $link = 'gallery_process.php?edit=yes&pID=1&cID=8339'; That works only for the picture i have uploaded, so only for testing purposes. When i enter this link directly in the address bar of my browser, then it works and no errors appear.

Your login system does not work. When i log in i get a "page cannot be displayed", however it turns out that i am logged in. In gallery_user.php, please give me the value of the variable $link, around line 280.

Simply change the layout of your gallery.php file, to match the one of your other files. The gallery is made with the layout of the default template, so any changes you have done to the default template will also have to be done in the gallery. In your case it looks like you are having 1 colum too much.

Can you undo these changes so we can start from there? I have created a test account on your website.

Can you give me a direct link to the gallery? I tried www.chocolategelt.com/gallery.php but that does not work.

There must be something with the location of the highslide.js file, that is my best guess. I am out of options here, i would need FTP access to dig further. Please look here as how it is supposed to behave, cause i think that, although you said the previous version worked, the previous version also did not show the popups on your site because of the javascript error: http://www.minitair.be/gallery.php Let me know if you find a solution.

this error has become irrelevant now that i know your javascript is not working. You could have known sooner because when you click a picture it does not open a popup but loads the pic in a new page. We lost a lot of time now. In gallery.php, change line 25: <script type="text/javascript" src="highslide/highslide.js"></script> to: <script type="text/javascript" src="http://designrecollections.co.uk/ribbonrie/highslide/highslide.js"></script> If that does not work, you will need to change the location of the js file in the code above to match with your situation.

something is wrong with your file, use this: <?php require('includes/application_top.php'); require(DIR_WS_LANGUAGES . $language . '/gallery_user.php'); if (isset($_GET['edit']) && $_GET['edit']=='yes') { $cID = $_GET['cID']; $pID = $_GET['pID']; $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE cID=".$cID." AND pID=".$pID)) or die(mysql_error()); if ($sql['title']=='') { $titel = SET_TITLE; } else { $titel = stripslashes($sql['title']); } if ($sql['description']=='') { $desc = SET_DESCRIPTION; } else { $desc = stripslashes($sql['description']); } ?> <form name="form" action="gallery_user.php" method="post" target="_parent"> <input type="text" name="title" value="<?php echo $titel;?>" onClick="this.select()"> <input type="hidden" name="cID" value="<?php echo $_GET['cID'];?>"> <input type="hidden" name="pID" value="<?php echo $_GET['pID'];?>"> <textarea name="description" onClick="this.select()"><?php echo $desc;?></textarea> <input type="submit" value="save" name="edittitle"> </form> <?php } else { $naam = addslashes($_POST['comment_naam']); $tekst = addslashes($_POST['comment_tekst']); $cID =$_POST['cID']; $pID = $_POST['pID']; //echo $naam." ///".$tekst." ".$cID." ///".$pID; $bestaande_comment = mysql_fetch_array(mysql_query("SELECT comment FROM gallery WHERE cID=".$cID." AND pID=".$pID)) or die(mysql_error()); if ($bestaande_comment['comment'] != '') {$spacer='<-->';} $nieuw_comment = $bestaande_comment['comment'].$spacer.$naam."///".$tekst; mysql_query("UPDATE gallery SET comment='".$nieuw_comment."' WHERE cID=".$cID." AND pID=".$pID); header("Location: gallery.php?autoload=".$cID.$pID); } ?> Look out when pasting this that the linebreaks are kept. I always have the problem when pasting code from the forum that the linebreaks are lost and that the code becomes 1 long line. I have registered on your site for testing ... First thing i notice is a problem with the highslide javascript. Where have you placed it? Because it says that the hs variable is not defined, so i thing the highslide.js file is not in /highslide.

What version of PHP and MySQL are you using? Try the following: Replace line 7: $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE cID=".$_GET['cID']." AND pID=".$_GET['pID'])) or die(mysql_error()); with: $cID = $_GET['cID']; $pID = $_GET['pID']; $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE cID=".$cID." AND pID=".$pID)) or die(mysql_error()); Let me know if any errors. If that still does not work, in the code i posted just above, replace the 3rd and last line with (dont do this if the above solution works!): $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE cID='".$cID."' AND pID='".$pID."'")) or die(mysql_error()); This error is when you try to add a title/description, but what if you add a comment from the public part, does that work?

Make those lines a comment, by placing // in front of them, so that this code is not executed. Not possible in this version, but planned for the future, see the website. If you want, you can tweak it of course, but you will have to add the date field to the database yourself, and then sort your query by date.

Can you export the gallery table once and paste te SQL file here? I can take a look and see if there are any differences between MYSQL4 & 5.

Please comment out lines 35 - 43.

I am using these versions as well. Comment out lines 35 - 43. Above line 35 type: echo $cID." ".$pID; Now add a new comment. After clicking OK you should see a white page. Let me know the text on that page. Are you on a live site? If so please let me know the URL so i can check for myself.

Comments is already planned, and i have added images. You can see future plans here: http://oscommerce-photo-gallery.micrograph...?content=future The problem here is that i cannot reproduce any errors. And as long i do not know what is wrong, i cannot fix it. Some people run it without problems, others run into problems. I have running 2 copies without problems myself, one on my system and one on a clients live website. Have you tried the bugfix: http://www.oscommerce.com/forums/index.php?sho...t&p=1302705 There is a small "how to use" guide on the website: http://oscommerce-photo-gallery.micrograph...php?content=use error1: replace line 35 with $bestaande_comment = mysql_fetch_array(mysql_query("SELECT comment FROM gallery WHERE cID=".$cID." AND pID=".$pID)) or die(mysql_error()); and give me the new error Error2 is probably connected with error1.

Thanks, i have updated the installation instructions.

seems like you did it wrong. Please use the files provided in the ZIP file, and do the bugfix from there. Right now you have replaced the wrong lines, hence the new error. It may help everyone to know that the new lines are very similar to the old ones, except for some variables that are now inside either the addslashes() function, or stripslashes() function.

There seems nothing wrong with this. The error simply does not make sense. The only thing i can think of is that you are using quotes in your title and/or description. To solve this you need to apply the temporary bugfix from post#75

This error says that in line 7, the SQL statement mentions a colum called 'gallery_user.php' in the WHERE part. If you have copied the line i mentioned to replace in the earlier post, then this is impossible. Line 7 should read: $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE cID=".$_GET['cID']." AND pID=".$_GET['pID'])) or die(mysql_error()); Whereas, following the error you provide, your line 7 reads something like: $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE 'gallery_user.php'=".$_GET['cID']." AND pID=".$_GET['pID'])) or die(mysql_error()); Please paste your entire gallery_process.php content here.

Bugfix: There is a bug when using special characters in the title, description or comment. A temporary solution: 1. in gallery_process.php Change line 11 into: $titel = stripslashes($sql['title']); Change line 16 into: $desc = stripslashes($sql['description']); Change lines 29 & 30 into: $naam = addslashes($_POST['comment_naam']); $tekst = addslashes($_POST['comment_tekst']); 2. in gallery_user.php Change line 28 into: mysql_query("UPDATE gallery SET title='".addslashes($_POST['title'])."', description='".addslashes($_POST['description'])."' WHERE cID=".$cID." AND pID=".$pID) or die(mysql_error()); Change line 298 into: echo '<b>'.stripslashes($commentaar[0]) . "</b>: ".stripslashes($commentaar[1]).'<hr style="border:0px;border-top:1px solid #666666;">'; 3. in gallery.php Change line 175 into: echo '<div style="font-style:italic;border:1px solid #666666;background:#ffffcc">'.stripslashes($fotos['description']).'</div><p>'; Change line 183 into: echo '<b>'.stripslashes($commentaar[0]) . "</b>: ".stripslashes($commentaar[1]).'<hr style="border:0px;border-top:1px solid #666666;">'; Permanent solution will follow in the next update.

thanks for the offer, but i own micrographx.be and corresponding hosting. If the situation requires (ie this contrib gets more and more popular) i can see about a standalone donain. all files are in the same folder where you have uploaded gallery.php. The stylesheet is called stylesheet.css and is also in the same folder. can you please explain in more detail what you want? Please replace line 7 in gallery_process.php with this: $sql = mysql_fetch_array(mysql_query("SELECT title, description FROM gallery WHERE cID=".$_GET['cID']." AND pID=".$_GET['pID'])) or die(mysql_error()); It will not solve the problem, but it will show a more detailed error. I think there is an error in your database. Also, what exactly did you enter as description/title? Did you use ' or " signs?

UPDATE: A new version has been uploaded: http://addons.oscommerce.com/info/6181 Added: -commenting system -title and description per picture project website I have created a small website for this project. You can view it here: http://oscommerce-photo-gallery.micrographx.be You will find every information you need there, from installation instructions, to "how to use"-information. As well as screenshots, hints and tips, and how the development of future versions is going. Support and feature requests stay in this topic and this topic only. Please do not create a new topic for help as i will not see it and thus will not be able to help! Enjoy! Matt