Latest News: (loading..)

JvdP

Members
  • Content count

    53
  • Joined

  • Last visited

About JvdP

Profile Information

  1. Hi Jim, Thank you for completing this release. I know it was much more work than you ever expected but you did a great job. I am very happy with the result which is even better than I hoped it would be. It was a pleasure to test your work. Regards, Jerome
  2. Thanks Jim for figuring this out, Already did products_filter.php, general.php's are dealed with by the original contribution. Tested join (" . TABLE_SPECIALS . " s) versus LEFT join (" . TABLE_SPECIALS . " s) one more time. I am very positive only LEFT join has the correct counter. Though, don't ask me why. Regards, Jerome
  3. Not sure about that, without a left join it didn't include all matching products in the count. It appears code has to be changed in catalog/products_filter.php as well starting on line 141: // Start Enable & Disable Categories V1.6.6 (http://addons.oscommerce.com/info/326) $listing_sql .= "p.products_id, p.products_model, p.manufacturers_id, m.manufacturers_name, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, IF(s.status, s.specials_new_products_price, p.products_price) as final_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id left join " . TABLE_MANUFACTURERS . " m on p.manufacturers_id = m.manufacturers_id join products_description pd on p.products_id = pd.products_id join products_to_categories p2c on p.products_id = p2c.products_id left join (" . TABLE_CATEGORIES . " c) on (p2c.categories_id = c.categories_id) " . $sql_array['from'] . " where p.products_status = '1' and pd.language_id = '" . (int) $languages_id . "' and c.categories_status = '1' " . $sql_array['where'] . " "; // End Enable & Disable Categories V1.6.6 (http://addons.oscommerce.com/info/326) This is to avoid disabled products are listed in the results after all when same specificaions are in both enabled and disabled categories. Am I correct (not sure on brackets, gave no different testresults)? Is there more code to be changed? Regards, Jerome
  4. Worth testing a equi join, it might ne a little less "buggier". I have tested this on mysql 5. Don't know the differences with mysql 4. Thanks for your feedback!
  5. Hi Jim, One of my contributions is Enable & Disable Categories. The counter of the filter options includes products in disabled categhories as well. When executing a filter these products are included in the search result. But when clicking on them a "no products found" message is displayed. To solve this incompatability I tried the following code in catalog\includes\classes\specifications.php, starting on line 81: // Start Enable & Disable Categories V1.6.6 (http://addons.oscommerce.com/info/326) $raw_query_from = " from (" . TABLE_PRODUCTS . " p) join (" . TABLE_PRODUCTS_TO_CATEGORIES . " p2c) on (p.products_id = p2c.products_id) left join (" . TABLE_SPECIALS . " s) on (p.products_id = s.products_id) left join (" . TABLE_CATEGORIES . " c) on (p2c.categories_id = c.categories_id) "; $raw_query_where = " where p.products_status = '1' and c.categories_status = '1'"; // End Enable & Disable Categories V1.6.6 (http://addons.oscommerce.com/info/326) I tested this and all seems to be working fine. So I don't think it will be nescessary to change any other code. What do you think? Regards, Jerome
  6. OK, that explains why nobody ran in to this one. I did not really break the code because the function was in two different places. I have SecurityPro 1.0.2 installed; indeed I found the function in includes/functions/security.php as well. Having them in both places gives a HTTP 500 error. Either one of the tep_clean_get__recursive($get_var) functions should be disabled to fix this problem. So found a code conflict with a third contribution here! Regards, Jerome
  7. Hi Jim, You did a great job!! I found one coding error in includes/functions/products_specifications.php on Line 17: function tep_clean_get__recursive ($get_var) { should be: function tep_clean_get_recursive ($get_var) { Took me days to discover this one. I wonder why nobody ran into this. I Installed the new version in my test store with all the contributions. During installation I found no code conflicts with the following contributions: Article Manager v1.0 1.57.1 Contribution Tracker 1.7.15 Detailed Monthly Sales 1.1 FCKeditor for Product Descriptions 2.7 Google XML Sitemap SEO 1.1 Guestbook for osC(MS2) v1.0 2.0 Information Pages Unlimited v1.0 2.05 Newsletter & Subscribers 055 Optional Related Products 1.0 4.0 Order Editor 5.0.6.6 oscThumb 1.0.1 Purchase Without Account 2.1 QTpro v1.0 - Quantity Tracking Professional 4.51b Secure your site with an IP trap 2.1 Ultimate SEO URLs 2.7 "Dynamenu" for osCommerce - Dynamic Fly-Out, Drop-Down, Tree Category Menu 1.1.2 Add a BACK button in the product_info 1.2 Add image background nav bars may2009 Add Order ID colum 1 admin - copy, move and delete multiple products 2.5c Admin Categories Shows Manufacturer 1 Admin Panel Facelift Revision 1.0 1.0 Attribute Sets Plus 1.3.3b AutoBackup Database in Admin 2.8 Bank Transfer Payment Option may2009 Breadcrumb for Admin 1b Category Specials 2.1 Check Permissions 1.0 1.3 Credit Class & Gift Voucher 5.21 Custom Server Error Pages 1.1 Dutch TPGpost (for new checkout) 2.4 Enable & Disable Categories 1.6.6 European Bank Transfer 1.9.3 Featured Products 1.6.4 Graphical Borders 1.1 Holiday settings 1.0.1 iDEAL Easy - ABNAMRO 1.2 Image Manager 1.1 Left and Right Column Control 1.0 New Google Sitemap Generator 1.2 NL_Taalpakket_v2 3.3 Previous - Next - With detailed info 3.5 Product Listing in Columns 2.2.8 Protect your site via htaccess jul2008 Quicker Product Edit v1 2.1 Request Product Info V 1.0 1.1 RMA Returns system 2.6 Security Pro 1.0.2 SiteMonitor 1.7 U HTML Emails 2.1 Updated spiders.txt dec2008 Who's Online Enhancement 3.5.4 [TiM's] Safer Database Input Method mar2009 Note: Some contributions require a update to their newer versions. I found conflicting code in two contributions but could easly fix them myself: 1. UltraPics - MS2 Image Addon Pack! 2.07.01 Merged code in product_info.php: // Products Specifications // BOF MaxiDVD: Modified For Ultimate Images Pack! $product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, p.products_image_med, p.products_image_lrg, p.products_image_sm_1, p.products_image_xl_1, p.products_image_sm_2, p.products_image_xl_2, p.products_image_sm_3, p.products_image_xl_3, p.products_image_sm_4, p.products_image_xl_4, p.products_image_sm_5, p.products_image_xl_5, p.products_image_sm_6, p.products_image_xl_6, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id, pd.products_tab_1, pd.products_tab_2, pd.products_tab_3, pd.products_tab_4, pd.products_tab_5, pd.products_tab_6 from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'"); 2. Header Tags SEO V 3.0 3.1.4 Merged code in admin/categories.php: // Products Specifications /*** Begin Header Tags SEO ***/ $description_query = tep_db_query ("select language_id, products_name, products_description, products_head_title_tag, products_head_desc_tag, products_head_keywords_tag, products_url, products_tab_1, products_tab_2, products_tab_3, products_tab_4, products_tab_5, products_tab_6 from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int) $products_id . "' "); while ($description = tep_db_fetch_array ($description_query) ) { If I find conflicts during actually testing the store I will report these later. Regards Jerome
  8. To be honest; I don't think that would be possible. Lets say we have a image filter. If this filter is used to filter colors for a product than a red square image might apply to red, rot, rood, rouge and rojo but it won't apply for all images if the name of the color is actually placed in the picture. The only possibility I can think of is to introduce an universal language which applies to all languages when individual languages are left empty. Though, there is not any part of osCommerce, not even with alpha 3, designed this way. So why this contribution? Or am I missing the point?
  9. Jim, Congratulations with the first RC of this contribution. I will install it in our teststore to check for any conflicts with existing contributions. To be honest very little contributions will prefer above this one. So I don't expect that much problems. A big thank you so far! Regrads, Jerome
  10. Hello Jim, You've done a great job on the manual. However, it is not easy for me to judge since played with this contribution for quite some time now. I do have the following suggestions: 3.4. Specification Groups Only the first sentence applies to specification groups. However important to mention, the other text does not explain specification groups but how specifications and filters may apply. 3.6. Specification Values I would move this paragraph after paragraph 3.3 since it gives more information on thye specifications. This to avoid confusing with paragraph 3.5 dealing with filters. 3.5. Filters As well it might be good to explain why specification values don't have to match the filter data. Appendix A states: See Section 3 for more detailed information on the use of these settings, shouldn't this actually be section 4.1? Anyway, I am happy to see this contribution is reaching its first RC. Not in the least I like to thank Elijah as well for the effort the past few days. I would do too if I had more PHP knowledge. Regards, Jerome
  11. Hi Jim, thanks for the update! Have a few bugs: When editing a Specification the "Enter Specification Values as" pulldown is set to "Text Box", even when the Specification is saved different before. When entering Filter Values or Specification Values, it would be handy if the specification, being worked on, is mentioned somewhere. When clicking preview not all specifications are displayed. I think only text box entered specifications are displayed. However, all specifications are stored in the database correctly. Still a persisting bug: specifications linked to a particular category an its subcategories (say the group Hardware) filters are not working for the subcategories when the Hardware category is selected in the catalog. Hardware is empty by itself but specifications are set to different types of Hardware in the subcategories. Regards, Jerome
  12. You are not doing something wrong, it is already on the list. I think this the first point in post 113?
  13. Yes I found this in IE indeed. I always test our store in 5 browsers. But since IE is still the most commonly used browser I use that one for primary testing. And yes, my change seems to work in Firefox as well.
  14. Thanks for the explanation. That's clear, so you can have different predefined values for specifications while filtering with another set of data. Never thought of that but very useful, especially when using other filterclasses than exact, like ranges for example.
  15. I think line 384 of products_specifications.php should be changed from : $box_text .= tep_draw_radio_field ($filter_name, $filter['id'], $checked, 'onChange="this.form.submit();"') . ' ' . $filter['text']; to $box_text .= tep_draw_radio_field ($filter_name, $filter['id'], $checked, 'onClick="this.form.submit();"') . ' ' . $filter['text']; Am I right? Regards Jerome