Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Frank Heinen

Archived
  • Posts

    195
  • Joined

  • Last visited

Everything posted by Frank Heinen

  1. Another problem, in resizing images who are smaller then the requested image size. Line 126 of includes/classes/oscthumb.php if ($width > $image_size[0] || $height > $image_size[1]) { should be: if ($width > $image_size[0] && $height > $image_size[1]) { Explaination: If an image is smaller then the requested width but larger then the requested image height then it does need to be resized and limited to the requested limits (note the height and width are maximum width and height). As it is now then it doesn't resize it. Example: Image height: 600 pixels Image width: 100 pixels Requested height: 120 pixels Requested width: 120 pixels Now it need to be resized to: height: 120 pixels width: 20 pixels At the moment it doesn't resized it and shows the 600 x 100 pixel image.
  2. Line 232 of includes/classes/oscthumb.php is setting the wrong directory link: if ($image_watermark) { $params .= "&fltr[]=wmi|watermarks/".WATERMARK_IMAGE."|".WATERMARK_IMAGE_POSITION."|".WATERMARK_IMAGE_OPACITY."|".WATERMARK_IMAGE_MARGIN; } For default directory it should be: if ($image_watermark) { $params .= "&fltr[]=wmi|phpThumb/watermarks/".WATERMARK_IMAGE."|".WATERMARK_IMAGE_POSITION."|".WATERMARK_IMAGE_OPACITY."|".WATERMARK_IMAGE_MARGIN; } For the next version a watermark directory definition (adjustable from the admin or defined in the config.php) would better.
  3. Sorry that I left the sort option on ON.... The sort option now works. Although that there are still problems in this module. I'm working on an update....
  4. Someone should really really update all varnames. Options_id and option_id, options_values_id and options_value_id etc etc etc are easy to look over problems and where mostly the problems in V2.3 beta!!!
  5. Take the one from Berkendam. Thats the last & the best one!
  6. Regarding the file permissions: Is there some kind of way to change all files to 777 before installing CI and CIPs and when you're done installing modules then change the file permissions back to the original rights?
  7. This is a very nice contrib but the shipment selection doesn't work in all casus. The old version V1.5 does. I my case the Ship2Pay doesn't show TPG Post (dutch shipment methode). This problem has been noted by others on the dutch forums of osCommerce so it's not something I did wrong. This code who responceble for this is: admin/includes/classes/shipping // class constructor function shipping_s2p() { global $shipping_classes, $quotes; for ($i=0, $n=sizeof($quotes); $i<$n; $i++) { for ($j=0, $n2=sizeof($quotes[$i]['methods']); $j<$n2; $j++) { $this->modules[] = array('class' => $quotes[$i]['id'] . '_' . $quotes[$i]['methods'][$j]['id'], 'file' => $quotes[$i]['id'] . '.php'); } } } I hope you can resolve the problem with this info.
  8. Anybody have a template working with a € sign?
  9. Thanks allot Amanda, you saved my weekend!! I hope I can help you (and others on this forum) someday....
  10. I'm lost :blink: I really don't understand it anymore..... The following 3 pieces of code should contain the problem: product_info.php: buy (single product) <tr><td width="6"></td><td class=ps2 align=right><?php echo $products_price; ?></td><td align=right width=135><?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_image_submit('button_in_cart.gif', IMAGE_BUTTON_BUY_NOW); ?></td><td width="10"></td></tr> 2gether.php: buy now button (2 gether special) echo tep_draw_hidden_field('products_id', $product_a['products_id']) . tep_draw_hidden_field('buy_tinn_add', $product_b['products_id']) . tep_image_submit('button_buy_now.gif', IMAGE_BUTTON_BUY2GETHER); application_top.php: add product to cart case 'add_product' : if (isset($_POST['products_id']) && is_numeric($_POST['products_id'])) { if (tep_get_products_stock($_POST['products_id']) > 0) { $cart->add_cart($_POST['products_id'], $cart->get_quantity(tep_get_uprid($_POST['products_id'], $_POST['id']))+1, $_POST['id']); } } if (isset($_POST['buy_tinn_add']) && is_numeric($_POST['buy_tinn_add'])) { if (tep_get_products_stock($_POST['buy_tinn_add']) > 0) { $cart->add_cart($_POST['buy_tinn_add'], $cart->get_quantity(tep_get_uprid($_POST['buy_tinn_add'], $_POST['id']))+1, $_POST['id']); } } tep_redirect(tep_href_link($goto, tep_get_all_get_params($parameters))); break; If I disable or the button in the 2gether.php file or the second if (buy_tinn_add) the add to cart from a single product works. If I don't disable any of these code then it adds allways the 2gether special offer (2 products) to the cart....
  11. Thanks for the trust in my programming skills. ;) I've been looking at it for 4 hours now. I really don't know why this occurs, hoped someone had solved the same problem... I'll go try again tonight.
  12. Most of the problems are solved now. Its almost working but I have one problem left: The 2gether discount works but if I now order the (single) product on the page I get the 2gether products in my cart..... What could be wrong? Where should I look?
  13. Does somebody have a working version of this contrib with all the problems mentioned (and solved) in this topic solved??
  14. This is an error I get: http://sklep.vico.pl/prduct_list.php?row=0...=0&currency=PLN Event thread: click Error: name: ReferenceError message: Security error: attempted to read protected variable This should be in this code I think (line 120 & 121 of prductlist.php): document.write ("<tr onclick=\"parent.add_product('"+pnum+"','"+pdesc+"','"+pprice+"','"+precid+"','"+row+"');\" onmouseover=\"this.style.backgroundColor='#86A5D2';\" onmouseout=\"this.style.backgroundColor='';\">" +"<td>"+pdesc2+"</td><td align='right' width=80> "+currency_left+" "+pprice+" "+currency_right+"</td></tr>"); Only can't find the solution.... Any javascript specialist in da house?
  15. Joel: I see, only on my server it works... Can't find the problem yet, I hope to find it tonight.
  16. Duch: It's a javascript problem. Don't now why it doesn't work at the moment. On my server it works fine: www.fhs-ecommerce.nl/testshop/compbuild.php. I'll look this evening what the problem is.
  17. The newest version (V2.2.1) works in: Internet Explorer Firefox Opera Netscape
  18. Danny: The time I have for programming on this contrib this week is limited. I hope I can check this problem and solve it. With the old code it worked. We only couldn't change the quantity. But the products were added in staid of replaced in the shopping card. Empo, do you have any idea for this? Gwyn: Good idea, this is definitely possible. Only to make this a real flexible Custom Product Builder the code has to change a quite a bit. My idea for the future of PC Pro Creator: 1. Make the row ammount flexible. It should be possible to add and remove rows in the admin module. The new row text should configurable (multi language). 2. Making standard configuration loads possible. Like a standard PC configuration or a standard bike (in your case). 3. Making row dependence flexible and adjustable in the admin section. 4. Making a template structure for the print preview module or making the print preview adjustable. To make this work at the moment you should tweak the module. - Change the language files - Disable rows if needed - Disable dependence of the first three rows (motherboard, CPU and memory). This should do the job I think... gregory: Do you have the shop online that we can look what the problem is? If not please give more details.
  19. Chris and Danny: Probably the assembly section doesn't work. The code had to much problems to sort it out directly... I'll have a look at it what the best solution is and how to make this work. Danny: About the wish to have a costum PC seen as one product in the shopping cart won't work (as far as I can see). The osCommerce structure doesn't allow this... About the problem of losing the old PC configuration when ordering a new one. At my test shop I found the problem if you order twice the same product the first product order is overwritten...
  20. The amount problem is in this code: (compbuild.php) switch ($HTTP_GET_VARS['action']) { case 'add_products' : $products_count=explode(",",$HTTP_GET_VARS['products_id']); for ($i = 0, $n = count($products_count); $i < $n-1; $i++) { $cart->add_cart($products_count[$i], $cart-get_quantity(tep_get_uprid($products_count[$i], $HTTP_POST_VARS['id']))+1, $HTTP_POST_VARS['id']); tep_redirect(tep_href_link($goto, tep_get_all_get_params($parameters))); break; } Look at: $cart->add_cart($products_count[$i], $cart-get_quantity(tep_get_uprid($products_count[$i], $HTTP_POST_VARS['id']))+1, $HTTP_POST_VARS['id']); This is the function that calls the code above: (builder2.js) function mainform_onsubmit(form,sact,fields) { if (form.sum.value=="0"){ alert ("You must have products in order"); return false; } for (i=0;i<fields;i++){ ammount[i+1]=form.elements["qty"+i].selectedIndex+1; } var urltemp="compbuild.php?action=add_products&products_id="; form.product.value=""; form.pid.value=""; form.price.value=""; form.ammount.value=""; form.recid.value=""; for (i=0;i<=fields;i++){ form.product.value+=product[i]+"::"; form.pid.value+=pid[i]+"::"; form.price.value+=price[i]+"::"; form.ammount.value+=ammount[i]+"::"; form.recid.value+=recid[i]+"::"; if (recid[i]) urltemp+=recid[i]+","; } var lines=form.select1.length for (i=1;i<lines;i++){ if (form.select1.options(i).selected){ form.product.value+=form.select1.options(i).value+";;"; form.price.value+=form.select1.options(i).price; form.pid.value+=form.select1.options(i).pid; form.recid.value+=form.select1.options(i).recid; form.ammount.value+=(form.qty100.selectedIndex+1)+";;"; } } if (sact==2){ form.action=urltemp; form.target="_self"; form.submit(); }else if (sact==1){ form.action="print.php"; form.target="_blank"; form.submit(); } } Look at: var urltemp="compbuild.php?action=add_products&products_id="; The bold text part isn't giving the ammount of the selected product. Now I can completely change the code to make it work but why is this code used and what should these functions do? In other words is this code a completely wrong or is there just a small mistake... Please help.
  21. Irfan, samo: Sorry I haven't got a clue whats wrong there. In my test shop the admin section of the contrib working fine... Brent Wesley: In my test shop I only have cheap products ;). The problem is in the fact that javascript floats dont have a thousands point separator and the decimal point separator should always be a point and no comma. So I should remove the thousand separator before the calculations and add it when its being displayed. Danny, Guillaume: I'll look at it. duch: Please send it to me then I can integrate it. If you want to help you could look where the tax problem is and how it should be solved.
  22. PC Pro Creator V2.2: Changes: - Deselect line fix - Some minor multi languages fixes - Print preview updated - Quantity box "enabled" - Decimal Point and Thousands Point bug fixed. Todo: - Check english language file - Add german and spanish - Modify/fix TAX functionality. - Dynamic pop-up box size (depending on content with adjustable max lines) - Option for loading preset computer configurations. - Add sub-catergory support. Need some help with the language files (checking the english, adding german, spanish and more). I didn't have any time to test this version so please test it. Keep reporting problems and whishes so I and anyone who can help can develop this contrib to a bug free and flexible contrib.
  23. Disable/remove row 67 till 74 from builder2.js. I haven't tested it but it should work. Maybe I should integrate this as a setting in the next version.
  24. StoneBridge Computing: I'll put this on the todo list... For version 2.3 (I hope). Zolti (and Duch): In the next version the decimal point and the thousand point problem is solved. You can set it how you want. Duch: -Be patient... I went indoor skying in Bottrop Oberhausen yesterdag evening with all my colleges because the company exists for 12,5 year so the development stopped for 1 one day. :) I'll hope to do this today or tomorrow. I have some problems left in the print.php. If I solved this I'll upload the version. pcboy123: Perfect idea. :thumbsup: But I think this is a step to far at the moment. I'll put it on the todo list but first the contrib should function flawless and the code should be cleaned. Also some more important issues like the tax issue should be solved... ratava: 1- In V2.2 (which I'm going to upload) you can do this.... 2- This is the first issue which I'll try to solve after uploading version V2.2 3- Also on the todo list. Will be solved in V2.3 (I hope).
×
×
  • Create New...