Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

kittmaster

Members
  • Content count

    100
  • Joined

  • Last visited

Everything posted by kittmaster

  1. I'll take a closer look at this. Maybe include a trapable error fix and rebuild this section of the code to avoid this problem all together Chris
  2. Maybe not you, but someone was asking if it works, the link demostrates that it does. If you ran the proper sql's then the DB is not in error most likely a code update is the issue. No, Xmas and family trump all things that need doing. This is non-negotiable for me. Merry xmas all, I'll be back at it after the holiday Chris
  3. Yes go and check the site link that I provided above or on the last page. With XMAS on the horizon, most will be busy with the holidays. Check back with us next week and most likely it will be updated then. Chris
  4. Joe Already set up that way as suggested, I'm still diggin around. Xmas is killing me......LOL......got to get them gifts.......I'll be on this for the next few hours or until fix is found..........god willing..... Here is the code as it stands: global $order,$ot_coupon,$currency; $coupon_amount= tep_round($ot_coupon->pre_confirmation_check($order->info['subtotal']), $currencies->currencies[$currency]['decimal_places']); // $cc_id /* you will need to uncomment this if your tax order total module is AFTER shipping eg you have all of your tax, including tax from shipping module, in your tax total. if ($coupon_result['coupon_type']=='S') { //if not zero rated add vat to shipping $coupon_amount = tep_add_tax($coupon_amount, '17.5'); } */ $coupon_amount_out = $currencies->format($coupon_amount) . ' '; if ($coupon_result['coupon_minimum_order']>0) $coupon_amount_out .= 'on orders greater than ' . $currencies->format($coupon_result['coupon_minimum_order']) . ' and has been discounted from the final total.'; if (!tep_session_is_registered('cc_id')) tep_session_register('cc_id'); $cc_id = $coupon_result['coupon_id']; if ( strlen($cc_id)>0 && $coupon_amount==0 ) { $err_msg = ERROR_REDEEMED_AMOUNT . ERROR_REDEEMED_AMOUNT_ZERO; //<BR><STRONG>Please Note:</STRONG><BR>If the form fields are missing, just click on the payment option button below to view the form fields <I>again</I>; } else { $err_msg = ERROR_REDEEMED_AMOUNT . $coupon_amount_out; tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, 'payment_error='.$this->code.'&error=' . urlencode($err_msg), 'SSL')); } if ($HTTP_POST_VARS['submit_redeem_coupon_x']) tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, 'payment_error='.$this->code.'&error=' . urlencode(ERROR_NO_REDEEM_CODE), 'SSL')); }
  5. You guys may want to wait until we can get this sorted out. Right now we are in the process of correcting these issues. The code in the last few pages are for the people who have PHP skills who can apply this information to their sites to get it working correctly. The only operative word here is to have some patience while we get the final fixes in place Chris
  6. I'll look at that, I'll must have forgot the message redirector for that section since I've rewritten part of that section.
  7. I've also sent vouchers via email for testing for those willing to try it Chris
  8. Joe I think it would be a real value to add a case switch to that setup. If voucher value is > than 0, then display voucher value within table " Apply my $XXX.XX E-Gift Credit" > checkbox and I'm not sure but if no voucher is present, table is invisible completely to clean up the screen Chris
  9. Yep I forgot to mention the test code is 123 try that Chris
  10. Ok I've done some serious modifications for the redeem message area of this contrib. The current redeems are not (IMO) not fixed correctly...........sooooo.. Here is my site: http://www.gforceperformanceaudio.com/shoppingbeta/ the site is a beta site and you'll need to sign up for an account, the products are real, but obviously this is for testing only to see if the functionality of the redeeming system can be tested out. The more you beat it up the more we can iron out the reliability and find anything I've missed to be corrected. Let me know if it works for you and as expected. If it does and we are all in agreement I'll post the multiple changes to files tomorrow if I get feedback, if I hear nothing, then I'll assume its still not right and not update the contrib area. Its not just the language files, its the actual functional files that need amending. So give it a whirl, give me some feedback. And we'll go from here Chris
  11. yeah because the message redeem has been hacked so many times for both a non functioning module to double repeated error message with incorrect points, it keeps selecting the wrong messages for the right transaction. I'm working on it as we speak, but most likely won't have a final update until late tonight or tomorrow Chris
  12. Ok I'll be clear on how my site is set up so it will verify if you have the same setup as mine. My versions and fixes downloaded from the CCGV page are as follows: Credit Class and Gift Voucher 5.14 Baby Boy 22 Jul 2005 Since the last 2 upgrade haven't been added, here is an update for ya'll labeled as CCGV 5.14, no major updated, but 5.13 was getting a little outdated. This is the FULL PACKAGE and included the PayPal fix and brettsg's 4 fixes. I don't take no credit for this, just re-packaged and included all of the replaced files for everybody to have the updated version. Enjoy! CCGV Easier to Understand Payment Addon v1.2 aarondwyer 20 Nov 2005 Here we go again. This should nail it this time. I had missed a very small but vital piece of code in the readme.html. This has now been tested by others and works fully. Ignore v1.1 and v1.0 listed in this contribution area, just use this one. Aaron Redeem message fix scranmer 9 Nov 2005 This is a correction to the redeem message at checkout_payment.php which informs the customer when a voucher has been applied. It now also shows a warning if the voucher does not meet the criteria. eg order ?5 minimum order value ?20 message will show:- The coupon has been successfully applied for ***HOWEVER:No reducion available, please see the coupon restrictions*** order ?5 minimum order value ?0 5% discount message will show :- The coupon has been successfully applied for ?0.25 HTH Si. French fix + others for 5.14 shawkes 1 Aug 2005 I have translated the ot_gv.php to english and have included a couple of admin files that I found to have a problem. If you use a shared ssl cert and you have admin setup to use ssl for all links, the link in emails is not right. In the files I changed the variable referred to was HTTP_SERVER changing that to HTTP_CATALOG_SERVER fixes it for shared ssl users and should also work for others. Only the changed files are included in the zip file There are all kinds of other "fixes" but these are the files that are on my site with all my other modifications and therefore works as designed. I don't know why they keep the other crap on the there, they should have an archive the rest for other users and only keep what really works for the current setups, but I don't run this place so............ I'm seeing that it works for cooch, therefore I know that what I've done should be fine. I'd have to go back and verify seeing if your setup is identical to what we used here. Or you can just revert the simple change that you made and you'll be back where you started. If you revert does the site work as it should??? Send a link to your site so we can see what's going on Chris
  13. I finally found the fix for the issue with the voucher less than the value of the total order...........I'll add information to the contribution area http://www.oscommerce.com/community/contributions,282 BTW 5.15 is not a final fix, I found the install into the database when adding and removing the module to still be in french!!!!! I found this out by accident! I'm glad this fix is done, let me know how you guys make out, I've tested it six ways to sunday on a heavily modified site.........70+ contribs and seems to all be in order. let me know how you make out Chris
  14. The error is telling you what is wrong, it is looking for "ERROR_REDEEMED_AMOUNT_ZERO" which is stored in the catalog/includes/language/add_ccgvdc_english.php FILE, YOU must edit the file by adding this information by copying and pasting the following: define('ERROR_REDEEMED_AMOUNT_ZERO', 'a valid coupon number. HOWEVER: No reduction will be applied, please see the coupon restrictions that was sent within your offer email***'); at the very bottom of that file just before the ?> at the end of the file!!! This will solve your problem of the wrong error message showing up Hope this helps Chris
  15. If the shipping is deducted from the total amount as well it will subtract the gross total. If the total value falls below the value of the minimum that is set then it will flag that error. Try this. Create a product that is say $100 and whatever shipping. Then send a $25 voucher with a $1 minimum purchase requirement. Buy the product and the message should come up as "you've redeemed a $25 voucher from a minimum of the $1 blah blah blah. See if that is what happens and you'll know if it is wokring correctly. I found that if the voucher value is greater than the grand total but not inclusive to shipping that error shows up. I may look at this after I finish my current issue which I think I have a final solution that I'm testing now The email should have the restriction limits added when it is purchased or sent, or mass displayed somewhere but it isn't, I may modify that to fix this issue Chris
  16. The problem isn't in the CC module itself, its in the files I mentioned above. There is a part of the code that denies any module that is enabled if the voucher value is greater than the total. So it doesn't pass the data to ANY payment module that is active and just writes the order into the orders field in the database. This makes sense if the voucher is being applied at the time of purchase but if it isn't then the amount should be passed to whatever module is active for payment and that doesn't happen because of the way the JONYO code is written. Sit tight were working on it Chris
  17. Well it still isn't working properly, I'm posting this for those that might have some insite now that I'm showing them were to look. By no means is it a fix, but it should help me and others get this thing figured ASAP. I'm sure most have it working just haven't give or sold many vouchers where this problem would stand out. The coupons are easy because those are the most common. I hope to have this solved today, but no guarantee....... B)
  18. Which then leads to catalog\checkout_confirmation.php // ################# Added CGV Contribution ##################" // CCGV Contribution $order_total_modules = new order_total; $order_total_modules->collect_posts(); $order_total_modules->pre_confirmation_check(); // if ( ( is_array($payment_modules->modules) && (sizeof($payment_modules->modules) > 1) && !is_object($$payment) ) || (is_object($$payment) && ($$payment->enabled == false)) ) { if ( (is_array($payment_modules->modules)) && (sizeof($payment_modules->modules) > 1) && (!is_object($$payment)) && (!$credit_covers) ) { // ################# End Added CGV Contribution ##################" tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, 'error_message=' . urlencode(ERROR_NO_PAYMENT_MODULE_SELECTED), 'SSL')); } if (is_array($payment_modules->modules)) { $payment_modules->pre_confirmation_check(); } // load the selected shipping module require(DIR_WS_CLASSES . 'shipping.php'); $shipping_modules = new shipping($shipping); // ################# Added CGV Contribution ##################" // require(DIR_WS_CLASSES . 'order_total.php'); // $order_total_modules = new order_total; // ################# End Added CGV Contribution ##################" So this is the final check to determine the output values from the pre_confirmation_check() function to determine if it goes to the installed payment module that was selected. This is where the final code execution needs to be validated and overruled based upon if the voucher should be used or not
  19. Ok I've modified my code as follows: $gv_query=tep_db_query("select amount from " . TABLE_COUPON_GV_CUSTOMER . " where customer_id = '" . $customer_id . "'"); $gv_result=tep_db_fetch_array($gv_query); $gv_payment_amount = $gv_result['amount']; if ($order->info['total'] - $gv_payment_amount <= 0 ) { if(!tep_session_is_registered('credit_covers')) tep_session_register('credit_covers'); $credit_covers = true; //die( "Is True" ); //used for diagnostic value comparison to see if voucher against total is less than or equal or NOT } else{ // belts and suspenders to get rid of credit_covers variable if it gets set once and they put something else in the cart $credit_covers = false; //die( "Is False" ); //used for diagnostic value comparison to see if voucher against total is less than or equal or NOT if(!tep_session_is_registered('credit_covers')) tep_session_unregister('credit_covers'); } And the values of true and false can be applied if the voucher is greater than or less than, and I validated its functions values with the die statements for diagnotics. If the final total is less then a value of true is returned, if the final total is greater it returns false, but for some reason that variable 'credit_covers' isn't the final control of whether or not the value less than the GV dumps to paypal (in my case) Looking for some help..............I'm pluggin away, but not sure what it is. I'll keep pluggin away, I hope someone can chime in here for some support. Getting closer but no cigar......yet Chris
  20. Others, please check out my previous post regarding my voucher issue http://forums.oscommerce.com/index.php?s=&...ndpost&p=761900 Thanks Chris
  21. You need to add this line to the catalog/includes/language/add_ccgvdc_english.php file and you'll be good to go. define('ERROR_REDEEMED_AMOUNT_ZERO', 'a valid coupon number. HOWEVER: No reduction will be applied, please see the coupon restrictions that was sent within your offer email***');
  22. That is because you've installed the module, uninstalled it........looks like 7 times........you need to access the database directly and delete all of them. Uninstall the module, and then reinstall it ONCE. It looks like the implosion routine of the version you have is not working correctly which is a major down fall of some of the versions. Find the "french fix" 5.14 and the "easy to understand" checkout add ons and that should fix this problem for you.
  23. OK I found the problem with the voucher greater than value of the total cost. It is found in the catalog/includes/classes/order_total.php. A refresher: If a gift voucher is present for the voucher holder, and that user decides to purchase a product but NOT use the voucher the current transaction, it bypasses the payment module, adds the order to the database, but no payment can be made because it was bypassed because the voucher value is greater than the order total. It is mentioned in the comments of the authors file: // pre_confirmation_check is called on checkout confirmation. It's function is to decide whether the // credits available are greater than the order total. If they are then a variable (credit_covers) is set to // true. This is used to bypass the payment method. In other words if the Gift Voucher is more than the order // total, we don't want to go to paypal etc. The code that deals with this is: $gv_query=tep_db_query("select amount from " . TABLE_COUPON_GV_CUSTOMER . " where customer_id = '" . $customer_id . "'"); $gv_result=tep_db_fetch_array($gv_query); $gv_payment_amount = $gv_result['amount']; // if ($order->info['total'] - $total_deductions <= 0 ) { if ($order->info['total'] - $gv_payment_amount <= 0 ) { if(!tep_session_is_registered('credit_covers')) tep_session_register('credit_covers'); $credit_covers = true; } else{ // belts and suspenders to get rid of credit_covers variable if it gets set once and they put something else in the cart if(!tep_session_is_registered('credit_covers')) tep_session_unregister('credit_covers'); } I've tried to comment it out, and when the voucher is present and the order is less, then the order passes to paypal (in my case) and is normal. However, if I try ANY transaction using the existing voucher, this code is missing and a $messagestack error of "select a payment module" error appears. So what this code needs a conditional switch with a function bypass of this code if the checkbox to "use voucher value" is NOT selected and allow processing as normal and a switch that if the checkbox IS active that this code is used to allow the proper processing of the voucher variable to deduct from the total cost value. I believe that once this is done the voucher system will be 100% Its late here now 1AM my time and bed time.........if someone can come up with a hack i'll try it out. If not I'll continue on it some more tomorrow Chris
  24. You can disable the hold queue so that your point is overruled. The queue is for people that have soft product such as downloadable files etc etc. If the queue isn't held and someone purchases a GV and then kills the paypal transfer then they'd have X amount of $$$ to go BACK and apply a non existant $XXX voucher that has never been paid for and the user can then download any of the soft product is under the $XXX value. Chris
  25. I'm trying to solve a problem with font formatting retention. The example is from the contact us page, when the user types in their comment the fonts are taken from the stylesheet. When the http_post_vars takes that info typed into the form, it for some reason converts it back to times roman which isn't the font that is used throughout my site (Verdana). How do I maintain the font integrity? The information is in question is from the $enquiry variable which gets passed back to the html email which the customer sees is different from the font used within the rest of the formatted email from the script. Ideas on what the fix is? here is the code if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'send')) { $name = tep_db_prepare_input($HTTP_POST_VARS['name']); $email_address = tep_db_prepare_input($HTTP_POST_VARS['email']); $enquiry = tep_db_prepare_input($HTTP_POST_VARS['enquiry']); if (tep_validate_email($email_address)) { tep_mail(STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS, EMAIL_SUBJECT, $enquiry, $name, $email_address); if(SEND_CONTACT_US_RESPONSE=='true') tep_mail($name, $email_address, CONTACT_US_RESPONSE_EMAIL_SUBJECT, CONTACT_US_RESPONSE_EMAIL_TEXT . EMAIL_FORMAT_FIX . "\n\n".$enquiry, STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS); I've tried to paste this" <link rel="stylesheet" type="text/css" href="stylesheet.css"> before it and within it, but I get parse errors because it doesn't seem to belong there. This is driving me nuts Thanks Chris
×