Jump to content

bcwright

Members
  • Content count

    23
  • Joined

  • Last visited

  • Days Won

    1

Reputation Activity

  1. Like
    bcwright got a reaction from Fredi in From Frozen to Phoenix   
    Unfortunately, Burt, you are doing a bang-up job of doing that all by yourself.
    I would have been willing to donate both time and money to your project, but because I've been preoccupied lately with a moving into a new house and getting everything reorganized, hadn't been on here much for a while. It is more than a little disingenuous of you to complain that "nobody contributes" when you have never bothered to give a link to where I might contribute or what size of contribution you wanted; instead you removed me from your private Phoenix club, even though I don't think I've ever been one of the "whiners" that you keep complaining about - until now, anyway, and I think that I have reason.
    I'm sure that now you'll claim that I'm one of your "enemies" club that you always fantasize about, but nothing could be further from the truth. I'd very much like to see this succeed, but it's obvious that I'm not wanted in your private clique.
    Bruce
  2. Like
    bcwright got a reaction from Fredi in From Frozen to Phoenix   
    Unfortunately, Burt, you are doing a bang-up job of doing that all by yourself.
    I would have been willing to donate both time and money to your project, but because I've been preoccupied lately with a moving into a new house and getting everything reorganized, hadn't been on here much for a while. It is more than a little disingenuous of you to complain that "nobody contributes" when you have never bothered to give a link to where I might contribute or what size of contribution you wanted; instead you removed me from your private Phoenix club, even though I don't think I've ever been one of the "whiners" that you keep complaining about - until now, anyway, and I think that I have reason.
    I'm sure that now you'll claim that I'm one of your "enemies" club that you always fantasize about, but nothing could be further from the truth. I'd very much like to see this succeed, but it's obvious that I'm not wanted in your private clique.
    Bruce
  3. Like
    bcwright got a reaction from valquiria23 in Quill.js Product Description WYSIWYG Editor   
    The problem with the Quill.js contribution was that apparently quilljs.com deleted the old version of the Javascript from their site, resulting in a broken link. :(
    I've uploaded a new version that should fix that problem and also upgraded it to the latest version (from 0.19.10 to 1.3.6), which supports things like header levels, block quotes, and hanging indents.
    I'd caution that there are risks with using any HTML editor on any public-facing part of your site (including but not limited to product reviews etc); many of them have serious vulnerabilities such as cross-site scripting and so forth. Quilljs attempts to clean the HTML to avoid at least the worst vulnerabilities, but who knows if they've plugged all the possible holes. A lot of other Javascript-based HTML editors out there have known vulnerabilities and shouldn't be used on client-facing sites, but you should be able to use most of them safely in the Admin area.
    Bruce
  4. Like
    bcwright got a reaction from Bobber in Best WYSIWYG Text Editor For Admin Side v2.3.4.1 CE   
    The problem with the Quill.js contribution was that apparently quilljs.com deleted the old version of the Javascript from their site, resulting in a broken link. :(
    I've uploaded a new version that should fix that problem and also upgraded it to the latest version (from 0.19.10 to 1.3.6), which supports things like header levels, block quotes, and hanging indents.
    I'd caution that there are risks with using any HTML editor on any public-facing part of your site (including but not limited to product reviews etc); many of them have serious vulnerabilities such as cross-site scripting and so forth. Quilljs attempts to clean the HTML to avoid at least the worst vulnerabilities, but who knows if they've plugged all the possible holes. A lot of other Javascript-based HTML editors out there have known vulnerabilities and shouldn't be used on client-facing sites, but you should be able to use most of them safely in the Admin area.
    Bruce
  5. Like
    bcwright got a reaction from jraiche in Quill.js Product Description WYSIWYG Editor   
    Hi. The problem is obviously caused by the re-use of the ID numbers, since a simpleminded cut and paste of this code will duplicate them throughout the web page if you have multiple textareas which use the quilljs editor and you don't modify them for each textarea and its associated toolbar and editor. HTML ID numbers need to be unique within each web page.
     
    However the problem is relatively easy to solve, and based on Josiah's code for calling quilljs I have implemented a drop-in replacement for tep_draw_textarea_field() which requires only including the new function at the beginning of any pages where you want to use it, and then changing any of the tep_draw_textarea_field() calls that you want to replace into tep_draw_jquill_field() calls. The parameter lists are the same, which simplifies the conversion, and if quilljs is not available it reverts to tep_draw_textarea_field(). Additionally I have added the code to allow images to be embedded in the rich text area (but you'll have to upload them separately and put a link to the image source since there is no upload support). It should be safe to use on both the admin and the customer side of the shop.
     
    The current version still uses the links to quilljs.com; if you use it on your site you might want to consider the trade-offs of continuing to use their site or moving the Javascript and css code to your own site. Obviously moving them to your own site means that you'll have to serve up the code yourself, which could take up bandwidth (the files are about 400k) and you wouldn't get any updates unless you downloaded the quilljs code again from their site, but on the other hand you're insulated from any new bugs that might get introduced or from their site going down in the future.
     
    Even better, this should work with virtually any version of osCommerce that still uses the tep_* functions, so it isn't restricted to 2.3.
     
    This looks like a great way to avoid all of the problems with the Htmlarea contributions, which apparently don't work on a lot of modern browsers (although I haven't tried them out).
     
    I am putting all of this together into a contribution that I will add to Josiah's quilljs contribution thread.
     
    Bruce
×