Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Ian

Archived
  • Posts

    1,089
  • Joined

  • Last visited

Everything posted by Ian

  1. Devon, The problem is caused by the redeem process. Originally the redeem process forced you to login. This ensured the redeemed Voucher was associated with a customer account. A lot of people did not like this, so I changed it so that if you were not logged in the voucher could still be redeemed, by storing the details in a session variable. Once you do log in/create an account the value is then associated with your customer id. What is happening in your case, is that you had the voucher amount in a session (in your logged off state) You then came back and created a different account, because the session can not distinguish, the GV Value was given to the new account. Od course this problem will only occur when you are redeemin/creating accounts on the same computer.
  2. Thats one of the problems with post 19/5 snapshots. Create_account_process no longer exists and one of the reasons why my contribution will not work on these sanpshots. Now you know why I'm up to version 5 and there are still the odd bugs, coz I have to keep rewriting the code for new snapshots, rather than just concentrating on stabilization. :cry:
  3. I very much doubt it, the Gift Voucher system relies on using a customer account to track the purchase/redeem of vouchers. 5.1 will partly resolve this by forcing the sending of the GV email during checkout rather than relying on the 'send' link. However, this still leaves the problem of what happens when some one does not use the full value of the GV during purchase. It might be possible to solve this by letting them re-enter the code again at a later time to access the balance. the 2 above would then mean the GV system would be able to work without linking the GV to a customer account.
  4. Joe I've double checked my code and cannot see a reason for this. Is the rest of the email formatted correctly? Can you email me a copy of your gv_mail.php file?
  5. Yes, There is still a problem with authnet ADC. It's easily fixed though In checkout_process.php // load the selected shipping module require(DIR_WS_CLASSES . 'shipping.php'); $shipping_modules = new shipping($shipping); require(DIR_WS_CLASSES . 'order.php'); $order = new order; ******************************* Authorize.net contribution code goes here ********************************* // load the before_process function from the payment modules $payment_modules->before_process(); require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; What needs to be done is to move the require/instantiation of the order_total modules to before the authnet code. So, // load the selected shipping module require(DIR_WS_CLASSES . 'shipping.php'); $shipping_modules = new shipping($shipping); require(DIR_WS_CLASSES . 'order.php'); $order = new order; require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; ******************************* Authorize.net contribution code goes here ********************************* // load the before_process function from the payment modules $payment_modules->before_process(); HTH
  6. 5.04 is in fact ready, it's out with a couple of people for testing. However this is still written against a pre-19th May snapshot and that is how it will be initially released. The reason for this is that it is a bugfix update from 5.03 and I would upset a lot of people if the bugfix update did not work on the snapshot they first used. :D I'll release a 5.04A which is compatible with newer snapshots straight after(only admin code affected) Both should appear over the weekend.
  7. Devon Is this with a standard payment method, or are you using something else, like paypal or authorize.net etc.
  8. Joe, With such a great surname how can I not help (or is that really your surname and not just a ploy to attract my attention :lol: ) Is the problem you are having with Gift Vouchers sent by admin or gift vouchers sent by a customer to a friend.
  9. Yes, The cvs updates after 18/5 included a complete re-write of the split_page_results class. Because of this any contribution using this class will be broken :cry: I haven't had a chance to go thru everything to work out the changes yet.
  10. Unfortunatel no, The discount module simply uses the cart total. The code would need to be changed somewhat to not discount special prices.
  11. teebee, Very weird, I do have a possible explanation. First does the sent to friend email have an sid in the redeem link ? If so this could possibly explain what is happening
  12. what did the admin->Gift Vouchers sent have to say about this.
  13. The Loaded file version will always differ from core osc files as they use a separate cvs. The only way to tell if the files are actually different is to use a file compare utility such as beyond compare. However I can say that you should will OK with manafucturers.php as their is no custom code in their.
  14. The 5.04 code is now ready, however rather than release now, I was hoping there would be a couple of people who could test the install before a proper contribution release. Let me know if you want to give it a try.
  15. Ryan, Hard to say, the 5.04 version is ready and I would like to see how that goes before releasing a post 18/5 version. Most of the problems would be on the admin side, because of the changes to the split_page_results class. I've already made a small start on this in a new cvs branch but you are probably looking to the weekend for a pre-release version.
  16. Martin, The code i suggested fixed a problem for me where no tax was being charged on Gift Vouchers. The problem is that $sendto is being set to false, becuase of this there is no way that osCommerce can know which country the buyers is from and so can't calculate the tax. Try removing the line altogether, and see if that helps.
  17. I think it's the Credit Class code, actually I know it's the cresit class code. in checkout_shipping.php find this code if (($order->content_type == 'virtual') || ($order->content_type == 'virtual_weight') ) { if (!tep_session_is_registered('shipping')) tep_session_register('shipping'); $shipping = false; $sendto = false; and change $sendto = false; to if ($order->content_type != 'virtual_weight') $sendto = false;
  18. BTW the contribution is based on being insatlled on 5/18 code or earlier. Don't even try installing on later code, it just won't work.
  19. Been a while since I was here, apart from being busy, the topic reply notifications seems to have gotten switched off.:( For those having trouble with the tax calculations, 5.03 seems to have been a bit of a disaster here. However 5.04 wil be released tonight. I'm just finishing the updated install docs. There are full instructions for updating from 5.03. (not too difficult) You also get the benefit of the new product/category restriction code.
  20. Chris, To get back to the real world, and yoyr shipping problems. In checkout_shipping.php look for this line $total_count = $cart->count_contents(); It's line 64 in my version. Try changing it to $total_count = $cart->count_contents_virtual();
  21. Chris, I know this is off topic, but Douglas Adams is a real hero of mine (Despite his penchant for Mac computers - yikes flame wars.) From the TV version my favourite funny quote, Arthur Dent meeting slartyfartbast for the first time.
  22. Melinda, I'm confused, so confused that your PM has caused my left frontal lobe to retire to a holiday apartment in the Maldives. Please explain, before the right frontal lobe gets ideas of it own as well.
  23. Oh don't give me none more of that Old Janx Spirit No, don't you give me none more of that Old Janx Spirit For my head will fly, my tongue will lie, my eyes will fry and I may die Won't you pour me one more of that sinful Old Janx Spirit
  24. Storeman,, I bowed to pressure from others when I created the combined redeem box. I now really regret it as it severely limits the credit class code. Wait for 5.04, it returns the system to multiple redeem boxes. There will be precise instructions for upgrading from 5.03. Also the tax stuff is now sorted, and the display routines now conform to current cvs standards (in that there is no html in the modules thmeselves) all html is now in an includes modules file. I hope to have everything finished tonight ready for release sometime tommorrow. When it's done I'll also help as much as I can with the module for entering tax number, as I know this is something that lots of others want as well.
×
×
  • Create New...