Jump to content

burt

Team
  • Content count

    14,883
  • Joined

  • Last visited

  • Days Won

    607

Posts posted by burt


  1. On 9/6/2019 at 8:39 AM, kgtee said:

    When the shop allows free shipping above certain order value, the question asking customer to select a shipping method still crops up during checkout. This happens when there are more than one shipping modules installed. This question is redundant and should be able to be eliminated by rewriting the program logic.

    I believe I have fixed this as a by-product of the checkout_shipping.php "prettification".  Could you check ? 

    In the demo site I have 2 shipping methods, with the order_total "free shipping" if greater than $20 in cart.


  2. The answer is pretty simple;  you do whatever it takes to get it working as you want...

    • hook
    • ht module
    • content module
    • js / jquery
    • hack code

    The less intrusive way...is...in my opinion...the better way.  

    For the buy buttons, the simplest way is a piece of .js as a Hook.  1 file, done - set and forget. 

    There is a hook bit that I posted just yesterday, scan back through my last few posts...

     


  3. Should anyone wish to see the proposed new layout for the checkout pages;

    https://template.me.uk/phoenix/checkout_shipping.php

    You'll obviously need an account and something in your cart to get there!

    Please feel free to give constructive feedback. 

    Do be aware that only the shipping and confirmation pages show the proposed new style, the rest are not yet converted.


  4. 19 minutes ago, Jack_mcs said:

    @burtIn one of the upgrades you added a call to hooks in the aaplication_top after the require('includes/functions/html_output.php'); statement. I'm wondering if  am missing something in my understanding of hooks. I thought you had to initialize and call them. Is that not correct? If I add a hook to the hooks/shop/ directory it doesn't get called. So am I doing something wrong or just not understanding the use?

    https://github.com/gburton/CE-Phoenix/blob/master/includes/application_top.php#L104-L106

    These three lines "fire up" the Hooks System.

    You then need to;

    • register your Hook
    • call your Hook

    There is a pre-placed register;

    https://github.com/gburton/CE-Phoenix/blob/master/includes/application_top.php#L422

    Which means that if you want to do something on (eg) conditions.php you can without performing a "register" (you would obviously still need to "call" your hook).

    For a fairly simple example of registering your own hook, and calling it, see;

    https://github.com/gburton/CE-Phoenix/blob/master/checkout_shipping.php#L15
    and
    https://github.com/gburton/CE-Phoenix/blob/master/checkout_shipping.php#L335

    Which works with;

    https://github.com/gburton/CE-Phoenix/blob/master/includes/hooks/shop/progress/progress_hooks.php

    Have a play.  Hooks are very powerful, more so than Content Modules in my opinion.


  5. Excellent work @puddlec - loads of people will be very happy with this!

    There is one small change I'd potentially make;  add in an array of good pages such like;

    var $good_pages = ['categories.php', 'manufacturers.php'];

    and then in the function, global $PHP_SELF and check it against the good_pages;

    if (in_array(basename($PHP_SELF, $this->good_pages)) {
      ...
    }

    This will then load the scripts only on the pages that need them rather than on all pages.

    And add textarea[name^="manufacturers_description"] to the selector (for manufacturer descriptions).

    Note:  untested!


  6. I'm pretty sure it's possible with no core changes, in Phoenix. 

    I think older versions of CE (and certainly all flavours of 2.3.4.1 and older) would need core code changes.

    Who's going to have a go at a no core code change TinyMCE implementation ?


  7. Please be aware that if you've made a post that you see as a bug..it may just disappear (temporarily) once it's been fixed in core.
    If you want to have more chat about something that has disappeared...it's a Github Issue as that means it has gone "technical".

    I do things this way to maximise the time I can give (remember that I do 99% of the heavy lifting) to making Phoenix better, moving forward day by day.


  8. Phoenix 1.0.2.3

    Thank You to Phoenix Club members for making the hard work much easier.

    https://forums.oscommerce.com/clubs/1-phoenix/

    Demo Site:

    https://template.me.uk/phoenix/index.php

    This Update;

    • align items in form
      TY @raiwa
    • add extra siteWide hook call
      TY @raiwa
    • modernise radio
    • modernise tickbox
    • Disallow non-buyer ability to write review
      TY @Heatherbell
    • Update FontAwesome to latest version
    • Add New Password Forgotten Module
    • Fix Manufacturer Info sidebox
    • Allow Shopowner to choose layout of Sub-Category List
    • Fix output of category description
      TY @Moxamint
    • Minor updates to some boxes
    • Update version to 1.0.2.3

    SQL to run prior to update

    INSERT INTO configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) VALUES ('Allow all Reviews?', 'ALLOW_ALL_REVIEWS', 'false', 'Allow customers to leave reviews on all products (true) or only on products they have purchased (false)', '1', '22', 'tep_cfg_select_option(array(\'true\', \'false\'), ', now());

    How to Update if on 1.0.2.2

    • Download this Zip: 1.0.2.3.zip
    • Unzip it
    • Upload it
    • Go to admin > tools > security checks and correct any listed problems

    How to Update if on earlier version

    • Find version you are on
    • Go back through this discussion and perform updates to get to 1.0.2.2
    • Then follow "how to update if on 1.0.2.2" instructions

    After Update

    • Install new "Forgot Password" content module (login)
    • Uninstall AND then Re-Install "Sub Category List" content module (index_nested)
    • Visit admin > tools > security checks and perform any needed actions
    • Enjoy the hard work that went into this update

    - OR -

    You can download and install a brand new 1.0.2.3

    After New Installation is complete

    • Visit admin > tools > security checks and perform any needed actions
    • Enjoy the hard work that went into 1.0.2.3
×