Jump to content
Latest News: (loading..)

burt

Team
  • Content count

    13,163
  • Joined

  • Last visited

  • Days Won

    475

Everything posted by burt

  1. burt

    Content module coding help

    It would be so cool if more people would ask these sorts of questions instead of just doing what they think is right. Kudos to you. which are lines 2 and 3 ? use basename(__FILE__) to call the template, and rename the template file appropriately (see code in point 4) the first function name in a class cannot be the same name as the "parent" class name (in php 7) use __construct or put an empty function in as so; function blah() { } You are displaying here: if (in_array(basename($PHP_SELF), $pages_array)) { $oscTemplate->addContent($template, $this->group); } so you might as well load the whole thing here; if (in_array(basename($PHP_SELF), $pages_array)) { ob_start (); include('/includes/modules/content/' . $this->group . '/templates/tpl_' . basename(__FILE__)); $template = ob_get_clean(); $oscTemplate->addContent($template, $this->group); }
  2. .css is faster loading, not by much though. If you're happy with the svg/js stick with it.
  3. Sometime in the future. You'll remember I asked for help to move things forward faster...which would have meant a month of full time developing. I didn't get the help I hoped for, so things move at the pace of a very part-time developer. Maybe one of the wannabe coders will make something for you.
  4. I was testing the differences between the js and svg and css versions. Don't know why I left it on js..... good spot guys! Changing to the .css version: Pingdom https://tools.pingdom.com/#!/djjgqq/http://template.me.uk/frozen2bs4/specials.php Reduces load time to 0.488s GT Metrix https://gtmetrix.com/reports/template.me.uk/xZZMH1i8 Reduces load time to 1.0s That is blazing fast!
  5. Just for my satisfaction, I removed the call to FontAwesome. I then tested the page again; Pingdom: https://tools.pingdom.com/#!/bFNGAJ/http://template.me.uk/frozen2bs4/specials.php Requests down from 14 to 13 Loaded time reduces from 0.674s to 0.582s GT Metrix: https://gtmetrix.com/reports/template.me.uk/HDTZvPTi Pagespeed stays at A 100 Y Slow moves from A 98 to A 99 Loaded Time reduces from 2.0s to 1.5s Page Size down from 396kb to 119kb Requests down from 15 to 14 Conclusion Shave milliseconds off the page load time. Worth doing? Maybe for some shopowners, but not for core.
  6. I'm 100% sure that things will be removed from Core, in order to make it; easier for "Team" (hahaha) to support easier for coders to code new stuff easier for shopowners to have a choice of what they want I can't imagine any scenario where osCommerce gets more things added. As for GDPR things: There is already a very good GDPR system available for these (as you put them) "business people who don't want to be computer wizards" .
  7. Made one for next iteration of CE (bootstrap 4 version). You'll be able to backport it when I release it.
  8. Here is the same page from Pingdom: https://tools.pingdom.com/#!/FovH0/http://template.me.uk/frozen2bs4/specials.php You can see here that the result is also great, at "100" with a load time of .6 of a second. Scrolling down a bit shows this: What this says is 71% of the "weight" of the page is due to loading fontawesome (FA). So if shopowner really wanted to optimise, they could remove the call to the FA script. Mostly FA is used to make buttons look pretty by having a nice little icon (eg the cart icon on the buy button); By removing the call to FA, that icon (and all the other button icons) and everything else that uses FA would disappear. Problems caused by removing FA there are a few buttons where FA icon is used with no text. From memory; - search module in header - refresh buttons in cart - delete button in cart - there may be more... Payment Icons in footer_suffix module The next step, if someone wants to take it on...is to explore the possibility of replacing the full FA with a version that just has the icons needed (ie, the ones that are just decorative)...
  9. Adding stuff in is not the way forward. The way forward is modular.
  10. Here's the latest, showing a "heavy" page "specials.php https://gtmetrix.com/compare/sEItXfZF/6gZaE1lD Frozen Page Speed: B 80 Y Slow: B 81 Frozen2BS4 Page Speed: A 100 Y Slow: A 98 A *massive* difference. Try visiting Frozen2BS4 and see how fast it is.
  11. The licensing of the adaptive-images part of this addon appears to be incompatible. You'll need to recognise that you may very well get into legal trouble either from users of your addon the owner of the AI script
  12. I've tried to clean up as best I can. I've removed one similar thread I've removed a link to your live phpmyadmin (please be super careful about what you post) I've attempted to remove the Commercial Solicitation which is banned in the open forum per the present forum rules
  13. Nice! When I first heard about GDPR I was "bloody EU meddling bas---- bureaucrats". Since it came into force, I've got my details removed from numerous sites with no questions asked. So, good for California - what you guys will see is some resistance from Shopowners to the whole idea, then when it comes these shopowners will realise "hey that was easy". And when it is in force...most "Joe Average" will find it useful. And yes, I agree...what one state does...the rest will follow.
  14. Worked a bit more on the next iteration of CE: https://tools.pingdom.com/#!/daURAX/http://template.me.uk/frozen2bs4/ Performance: A 100 https://gtmetrix.com/reports/template.me.uk/ggb79x3V Page Speed: A 94 Y Slow: A 98
  15. What does the Manifest file actually "do". In other words, who uses it and for what?
  16. Great thread @JcMagpie. Keep on going with this thread, as I am following your efforts with conclusion of putting into next round of changes in CE.
  17. Each Site Owner needs to make the decision as to how far they want to take things. What is the potential ROI for spending days or weeks or 100s/100s on fine tuning? The answer for one may be "not worth the bother", the answer for another maybe totally opposite to that. This tool gives an indication of speed and is useful to test broadly similar pages against each other in an easy to read format; Listing Page https://gtmetrix.com/compare/NAMJ2O8r/0Xh81unh Product Page https://gtmetrix.com/compare/HzKW7fMx/AWY6bbZZ Content Page https://gtmetrix.com/compare/KSvfB4ZL/gwuDwbdZ
  18. burt

    Pictures side by side

    http://template.me.uk/frozen2bs4/product_info.php?products_id=28 12 width and set to "255" However, it is obvious that Yepi has already made core edits, so all of this advice given may be null and void anyway.
  19. Deleted, my comment really doesn't add anything to the conversation about website speed. Ho hum.
  20. All of these tools do not take into account certain things; Examples: 2g/3g customers Why worry about these people? There is zero point in catering to 2g and 3g based customers in the arse-end of nowhere if you do not ship there. In addition these people know they are on a poor connection, so expect sites to be slow. I cannot imagine a shopowner in (say) New York changing his site because someone in (say) Ulaan Bator can't get a good signal. Same site, different host A site tested on one honst will outperform or underperform compared to the EXACT SAME site on another host. Even on same hosts yet different server...same applies However, as I previously stated on the "Frozen 2 BS4" thread, these sites do give an indication of what a shopowner could do. But that *must* be on a shopowner by shopowner basis, dependent on each shopowners target audience. Don't make the mistake of relying on these reports...use them for basic info only, and don't take the results of someone else site as gospel that your site should be changed. Put simply, each shopowner must decide for themself...how much money and/or time to throw at some perceived problem - and if that spending will pay dividend. Bottom line trumps everything.
  21. burt

    Add option "Quota" for product

    OP needs to provide more details. Is this a limit on each product per order? You can buy as much stuff as you want but a maximum of 6 of each item Is this a limit per order? You can buy whatever you like, but only 6 in any one order. Is this a limit per product per customer? You can buy whatever you like, but in your lifetime you can only buy 6 of Item A And so on.
  22. burt

    PayPal Standard 5.018 standard_ipn.php won't connect

    Your problem is the basename() function. That strips out the path to the IPN file. You need to somehow stop root.php from rewriting URLs that are not in the base of the site. You may also have problems with other files, such as Braintree, Stripe and some Password functions. As well as any properly coded addons which utilise the new TP system of pages... Put simply: SEO-G is a square peg that you have tried to ram into a round hole.
×