Jump to content
Latest News: (loading..)

burt

Team
  • Content count

    13,085
  • Joined

  • Last visited

  • Days Won

    477

Everything posted by burt

  1. Cannot make TLS 1.2 work

    Stripe is also a decent option if you cannot get Paypal working.
  2. Well maybe you can play around with it, or sponsor some coder to come up with the code and then give it back to the Community.
  3. I like this: function execute() { global $PHP_SELF, $cPath, $oscTemplate, $category_depth; global $current_category_id, $OSCOM_category; if (basename($PHP_SELF) == 'product_info.php') { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link('product_info.php', 'products_id=' . (int)$_GET['products_id'], 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } elseif (basename($PHP_SELF) == 'index.php') { if (isset($cPath) && tep_not_null($cPath) && ($category_depth != 'top')) { $canonical = $OSCOM_category->buildBreadcrumb($current_category_id); $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link('index.php', 'view=all&cPath=' . $canonical, 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } elseif (isset($_GET['manufacturers_id']) && tep_not_null($_GET['manufacturers_id'])) { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link('index.php', 'view=all&manufacturers_id=' . (int)$_GET['manufacturers_id'], 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } else { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link('index.php', null, 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } } else { $view_all_pages = array('products_new.php', 'specials.php'); if (in_array(basename($PHP_SELF), $view_all_pages)) { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, 'view=all', 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } } }
  4. and add $current_category_id as a global. https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/header_tags/ht_canonical.php#L32
  5. I don't think that module has ever had much attention other than adding "view=all". So...change these two lines: https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/header_tags/ht_canonical.php#L37-L38 To: if (isset($cPath) && tep_not_null($cPath) && ($category_depth == 'products')) { $canonical = []; tep_get_parent_categories($canonical, $current_category_id); $canonical[] = $current_category_id; $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link('index.php', 'view=all&cPath=' . implode('_', $canonical), 'NONSSL', false) . '" />' . PHP_EOL, $this->group); And report back your findings.
  6. This is what the Canonical URL module solves. Does it not?
  7. I plan on fixing a Final, then doing 1 round of bugfixes. Anything not noticed or not fixed...stays broken. It's time for a change.
  8. Which is *always* a good thing as most of you know by now
  9. Problems as I perceive them; there are not too many shopowners who are willing/able to spend £/$/Euro. There are a few who do and will...and it is this handful who have kept osCommerce going the past four years. there are not too many developers who will take time out of their schedule to help Paying work must come first before free work. osCommerce has historical problems The code is old fashioned The "team" is so fractured ... that there could just as easily be no team!
  10. Cannot make TLS 1.2 work

    It is *not* the Community Edition that you have @zefeena hope this helps
  11. Cannot make TLS 1.2 work

    And, as an addendum; I have just done precisely all of this on an old 2.3.3 shop and Paypal no works flawlessly.
  12. Cannot make TLS 1.2 work

    IF NOT USING COMMUNITY EDITION: Install Paypal App https://apps.oscommerce.com/fZMiN&paypal-app Once installed, it will ask you to update. Update IF YOU ARE ON THE COMMUNITY EDITION Do NOT Install the Paypal App Do NOT update. UPDATE CERTIFICATE Overwrite old Paypal Cert https://github.com/gburton/Responsive-osCommerce/blob/dbb6f769cb8f3c84164feb812bf7a0de225dd58c/ext/modules/payment/paypal/paypal.com.crt I don't think anywhere else has this updated Cert. TEST THE INSTALLATION Get your Balance. If it works...it is good. ALL VERSIONS Insert API, Password etc in the GENERAL settings Get those from Paypal Set up whatever Paypal method(s) you are wanting TEST THE INSTALLATION Perform a checkout or get a friend to Did the payment go into your paypal account? Was an Order written ?
  13. The only reason I would prefer it as an addon is that it is such a major change to the most important part of an ecomm site,...so I would like it to be more tested first before going into Edge. I hope that makes some sort of sense and is not too disappointing.
  14. Surely they would need to overwrite the whole page(s)?!? Forget the State Selector. Nothing more is being added to Community Version.
  15. Put it to an Addon. If it then gets used and is problem free it can go into the next iteration of osCommerce.
  16. If it goes on Core...and it is then found broken. Anyone in the future would then download a broken osCommerce. Is that wise?
  17. It is tested under all scenarios ? You are happy to support any and all questions that arise, and any problems that arise from payment modules? Would it be better as an addon? I only ask this as after the next few days are up...there will be no more changes on the Github and if this is added - and it is broken...it'll stay broken. As an addon, you at least have the ability to perform updates. Thoughts?
  18. https://demo.oscommerce.shop/24/ I do not know how old that Demo is. There is *loads* that has been done the Community 2.3, that does not exist in that "official" 2.4.
  19. Updated Module should change the layout of the white boxes (when configuring a module), and it should tighten the overall table into one (instead of two).
  20. I'm very happy to just say "Final" and be done with it. Anything else can be addons.
  21. @piernas updated module.zip Also requires change to /admin/includes/functions/general.php Find the function "tep_cfg_select_option" and change it to: //// // Alias function for Store configuration values in the Administration Tool function tep_cfg_select_option($select_array, $key_value, $key = '', $spacer = '<br>') { $string = ''; for ($i=0, $n=sizeof($select_array); $i<$n; $i++) { $name = ((tep_not_null($key)) ? 'configuration[' . $key . ']' : 'configuration_value'); $string .= $spacer . '<input type="radio" name="' . $name . '" value="' . $select_array[$i] . '"'; if ($key_value == $select_array[$i]) $string .= ' checked="checked"'; $string .= ' /> ' . $select_array[$i]; } return $string; }
  22. Addon installer concept

    The other option is that I let the Community Version come to an end, and those who are interested can work with 2.4 Every shopowner using Community Version has a working Responsive php7-ready shop, so it could just be left. Those who want to continue using, continue. Those who don't, use official 2.3.x, go to a different software or pitch in and help on 2.4. I have an issue with 2.4 and transparency of just what is exactly going on with it, but that is for another time.
  23. TY @burt for the cool Breadcrumb Schema https://github.com/gburton/Responsive-osCommerce/pull/634 To update your shop; make changes to /includes/classes/breadcrumb.php <--- very important to do this otherwise you end up with broken validation upload new HT module + its Language File login to admin and turn on
  24. Addon installer concept

    Addons are sometimes more complicated than first glance... An addon could consist of (eg); 1. product_info content module 2. sub modules for that content module 3. action 4. hook Not sure how you're going to approach that...but something to think about. The majority of well coded addons; dont change core code consist of up to three files [main, lang, tpl] consist of one "thing" (bm_, cm_, etc), not usually more than one It might be that your prototype deals with the "easy" addons first? And can then be extended to deal with complicated addons?
×