Jump to content
Latest News: (loading..)

burt

Team
  • Content count

    13,087
  • Joined

  • Last visited

  • Days Won

    477

Everything posted by burt

  1. Bug week is now closed. All reported bugs have been squashed. There are NO outstanding issues and NO outstanding pull requests.
  2. Bug Finding Week Bugs for implementation of anything that extended the Community Edition. Typical Examples; bugs in bootstrap calls bugs in new modules bugs in installation etc If you find bugs in the Community Edition, please report them at https://github.com/gburton/Responsive-osCommerce/issues - please take a look to see if the bug report you are about to raise is already raised as you may be able to give more information on the existing Issue. All relevant bugs will then be looked at, and worked on for FINAL. Thanks.
  3. Use a name "henry Test"... In the template the .css selector goes in as cm-pi-henry_Test (lower case with all hypens would be cool) In the main file it may be nice to have class cm_henry_test (all lowercase) instead of class cm_henry_Test (camelcase) These things are not important, just an cherry on the cake.
  4. Email your complaint to HPDL and hope he reads it and acts on it at some point in the future.
  5. Yet here is the same guy, with a far more complicated thing...and it makes no core changes. https://apps.oscommerce.com/iAvGO&faq-help-for-oscv2-3-4-bs-edge-v1-0 Seems he is not an idiot after all.
  6. For the template output, they are usually more like this. Note the .css selector which is the exact same as the cm_ module but with - (hyphen) instead of _ (undescore) <div class="col-sm-<?php echo $content_width; ?> cm-pi-gary"> STUFF HERE </div> For the tpl_, basename(__FILE__) would be cool...eg at https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/content/index/cm_i_title.php#L41 So in this example; /includes/modules/content/product_info/cm_pi_gary.php /includes/modules/content/product_info/templates/tpl_cm_pi_gary.php this with .css selector as cm-pi-gary /includes/languages/english/modules/content/product_info/cm_pi_gary.php I think that would be a minute less work for the eventual end user. Thoughts?
  7. I noticed the template of the cm_ module is formatted for a box module... Also the cm_ uses a hardcoded tpl_ link. Would it be possible to change that?
  8. Say again ? As I did not really understand well any of what you just said. In any case, email your complaints about that section of the osCommerce site to HPDL.
  9. Cooooooooooollllllllllllllllllllllllllllll
  10. This is an example of why there are 7000 addons. 90% of these should not exist in their existing format. How the hell 7000 addons is used for "marketing" osCommerce is just ... " " (lost for words).
  11. shopowner makes the change. core [let's say this particular file he changed] gets updated. shopowner updates core appropriately Result; shopowner now wonders why that cool little feature he did have...is gone. now he posts to the forum for help whoever tries to help (because it aint gonna be the idiot uploader) has no idea Damn. I see what you are saying, but WTF - it would take all of 5 minutes to create a module that is completely separate.
  12. Even when making things modular I still see addons uploaded where the addon maker is changing the module. Instead of making a whole new module and saying "turn off the core module, upload and turn on my module". It's a farce. Latest idiot: https://apps.oscommerce.com/HDvzH&grid-list-view-setting-bs-edge-v1-0
  13. [Addon] Store Times BS

    There is one and only one that supports multiple open/close per day. It is a commercial module, made by me, for the Community Bootstrap Version. If of interest, PM me.
  14. PHP7 while()each() becomes foreach()

    I think it should be OK on 5.6 as well. I could go overboard on some code changes which are php7 only, but I probably won't as (a) it'll break loads of shops still on php5.x and (b) I don't have time EG: echo (isset($_POST['q']) ? $_POST['q'] : '') => echo $_POST['q'] ?? '';
  15. PHP7 while()each() becomes foreach()

    function total() { $total = 0; foreach(array_keys($this->discounts) as $type) { $total = $total + $this->discounts[$type]['amount']; } return $total; } AND function get_all() { $discounts_array = array(); foreach(array_keys($this->discounts) as $type) { $discounts_array[] = array('description' => $this->discounts[$type]['description'], 'amount' => $this->discounts[$type]['amount']); } return $discounts_array; } Should Do It, as per (if I recall correctly); while (list($k, ) = each($v)) { => foreach(array_keys($v) as $k) { while (list(, $k) = each($v)) { => foreach($v as $k) { while (list($k, $v) = each($x)) { => foreach($x as $k => $v) { and in all three things, remove the reset($v) line of code.
  16. Probably just to moan, like a grumpy old man, hanging on to words said 5/6/7/10 years ago. You want forward movement; Why have you not done nothing to help that? Don't bother answering, it is a question just to make you think.
  17. Let me say something about this. I intend to release a "final". Very soon. Just a few bugfixes to go to do with php7. After that there will be no help (from me) on this forum, not for bugfixes, not for general advice, not for nothing. Those good guy shopowners who have supported my efforts in the last four years will still get help but it will not be at this forum (you are one of these guys). Those shopowners who have just stood on the side while the good guys helped out...will be getting as much help as they have given; none.
  18. Yes. Every single piece of code that YOU use that is the Edge Core, is first written for MY customers. Instead of telling us how osC is and has been run, and how the documentation is non-existent etc...you should be kneeling on the ground and thanking those customers that you have a responsive osCommerce shop.
  19. Regarding Privacy Policies, I was sent an email by a co....interestingly it has "before" (aka now) and "after" (gdpr). aybe have a look and see if you can get inspiration from it; BEFORE (in force now): https://www.fasthosts.co.uk/terms/privacy-policy AFTER (in force from 05/25): https://www.fasthosts.co.uk/terms/privacy-notice To my mind the gdpr version is a lot more clear, and is all common sense. Looks good I think.
  20. Complete and utter bullshit.
  21. Versioning for Apps/Modules

    just to say this; "dont force a developer to do something" let it be up to me if I want to jump from (eg) v1.0.56 to (eg) v3.1.0 those numbers might mean something at *my* end....
  22. Versioning for Apps/Modules

    If the App is at 1.9.4 on a market... Why would dev be making a 1.2.1 ? The next iteration would be 1.9.5 OR 1.10.0 OR 2.0.0, no ? Anyway, you have a minor problem to solve... osCommerce versioning, eg: 2.3.1 2.3.2 2.3.3 2.3.3.1 2.3.3.2 2.3.3.3 2.3.3.4 2.3.4 2.3.4.1 2.3.5 (ha) 2.3.6 (haha) 2.4 (lol) Which going by some standard appears to be; major.something.minor.patch
  23. https://github.com/gburton/Responsive-osCommerce/issues Not a lot of interest in reporting bugs. Anything that is not reported this week...will stay broken forever.
  24. Demo should now be more or less up and running. Thanks for the heads-up on the 404.
  25. 28d, 2018

    Popup Style Hint: No Core Changes: Works on mobile/touch screen: Coming Soon to those who "get it"
×