Jump to content
Latest News: (loading..)

burt

Team
  • Content count

    13,076
  • Joined

  • Last visited

  • Days Won

    466

Everything posted by burt

  1. I have split the chitchat out of this BSv4 thread. Thanks
  2. All the others need to look at WA state. They have an excellent API to hook into to get the exact rates per zipcode, some years back I made a order_total module hooking into it. Very simple and effective system. If WA can do it...
  3. Assuming you only need to collect the STATE sales tax and not individual counties/citys etc...that would be 5 minutes work to set up. That also assumes that you can find the exact tax rate per state etc and so on. Europeans are very used to setting up multiple tax rates, so it's just the same - instead of countries, think States. As for remitting the tax after you've collected...that would be outside the scope of the software, obviously. EDIT: If you have to collect ALL of the applicable sales taxes (state, county, city, district etc)...that would be extremely difficult.
  4. Even if not correct, your change is still not needed. If not correct, they go and change the language file.
  5. I -believe- so. Use Core Code as it stands and look at a product that has a special price, it should be something like; $99.99 $49.99 In other words, old price with a strikethru, special price in red.
  6. Imagine a scenario like this; "This Review was written by John on 01/12/2018. John gave it 5 stars out of 5." I now give you two ways: define('REVIEW_TEXT', 'This Review was written by %1$s on 01/12/2018. %1$s gave it %2$s stars out of 5.'); echo sprintf(REVIEW_TEXT, 'John', '5'); OR define('REVIEW_TEXT', 'This Review was written by %s on 01/12/2018. %s gave it %s stars out of 5.'); echo sprintf(REVIEW_TEXT, 'John', 'John', '5'); OK, both do the same thing. Now take the scenario where shopowner wants to say this: "This Product gets 5 stars from John!" Easier to do this: define('REVIEW_TEXT', 'This Product gets 2$s stars from %1$s.'); No need to even look at the main module file or the template file. In the way you understand (just using %s), an error would probably occur somewhere. At the very least it gets super complicated staying in a linear outlook...
  7. That is exactly what I am saying, so long as you also take into account the placement of variables at the other end (language file). See Mary Lamb example.
  8. Variables can be given in any order, and then used in any order... First See: https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/content/product_info/templates/tpl_cm_pi_price.php#L3 sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY_SPECIAL, $specials_price, $products_price) variable 1 = new [special] price variable 2 = old [usual] price Then See: https://github.com/gburton/Responsive-osCommerce/blob/master/includes/languages/english/modules/content/product_info/cm_pi_price.php#L16 I first use #2 (old price) in the <del> I then use #1 (new price) to show the cost Notice the difference between using %s (which is what you are thinking, I think) and use of (eg) %2$s In this way, you can do this: define('BLAH_BLAH', '%1$s had a little %2$s, its fleece was white as snow and everywhere that %1$s went the %2$s was sure to go...'); and echo sprintf(BLAH_BLAH, 'Mary', 'Lamb'); That's a dumb example, but shows the concept.
  9. So, anyway, cards are a PITA. I expect that in future release of bootstrap we will see some card sizing utilities for responsiveness.
  10. YESSSSS! This. SO much this. Thanks @14steve14 People; everything that you see in the basic Responsive Build is done for a reason, always be aware of this before offering solutions that will cause problems.
  11. These variables can be in any order.
  12. Now you clearly see the problem. Cards are "nice", but are a PITA to correctly code.
  13. @piernas this approach works but takes away all of the good stuff that Cards brings. The reason for Cards is to entirely remove the Columns and Rows...and make flexbox do its thing without them.
  14. If you take a look at the "CARDS" module now, you hopefully will see my main issue, which I cannot now un-see. http://template.me.uk/frozen2bs4/ I set the parameters as so; SM - 2 (per row) MD - 3 LG and up - 4 As I also set it to show just 6 items, what happens in LG and up, is Fugly in my opinion; item | item | item | item item | item I can't find a way to do this; item | item | item | item item | item Can anyone find the answer ? ps: not bothered about the display of the price, name etc - that'll be squished as 4 boxes is too many in a row (for MD). Only set to 4 in MD to show what I am struggling with...
  15. Some type of images system would have been high up the to-do list for a future release (probably Final). I think I've talked about it previously; shopowner uploads one large image it is resized to (say) 5 different resolutions and saved appropriately tep_image is updated to use srcset srcset automatically works out which image is best shown at which resolution Maybe in some future code?
  16. Yes...in the example (to make the galaxy image larger) I just removed the two parameters in the tep_image call; SMALL_IMAGE_WIDTH & SMALL_IMAGE_HEIGHT. Replacing those makes the images all the same size.
  17. @timray @Stephan Gebbers It's possible to do whatever is required. But as this is a test project ... it is not likely to happen that I spend my time making tweaks.
  18. Parameters for choosing how many cards per row...across viewports
  19. Changed the CARD layout to make a better use of headers and footers. Now it looks better, to my eye. Another plus point for Cards; much easier for shopowner to decide how many products per row across different viewports. 2 for SM, 3 for MD, 4 for LG etc. All done in the Module now.
  20. Front page of http://template.me.uk/frozen2bs4/ now has a second "New Products for <month>" using the CARD system. To better show (one of the) differences between using the CARD system and usual COL system, I have increased the size of the image of the Galaxy Tab. You can plainly see 1 major difference; CARD: all boxes expand to the height of the tallest box COL: boxes are set at their own individual height To my eye, I prefer that boxes are their own height. What do you guys think? The same "equal height" effect can be achieved in the COL system in a different way, easily enough. I do not see any advantage to using CARD over COL... Code (in each Template) Size: CARD: 54 lines COL: 39 lines The CARD system requires more code to achieve little of benefit. Are there benefits (other than equal height) that I am not aware of ?
  21. The whole of bsv4 is using flexbox. I found cards quite difficult to get a handle on. I wasn't able to easily make them responsive, eg; XS: 1 (in a row) SM: 2 MD: 3 LG and XL: 4 I did get that working (hard coded), but it seemed like a "hack" to have to do. I will try to get that "hacked" code into a Module for the index page -> new products and clean it up a bit.
  22. It (product page) is fully modular so can do as wanted regards layout.
  23. I gave up on trying to implement the jQuery Slim build, due to it not working with colorbox. Would have meant either; recoding colorbox removing colorbox in favour of something else similar that does work slim Slim saves a grand total of 6kb which is "not a lot". And as this mini project is for my benefit only, no need to use up more of my time on it. Thanks to all for testing. This mini project has allowed me to better understand the new features in BSv4, ready for the next major project.
×