Jump to content
Latest News: (loading..)

burt

Team
  • Content count

    13,160
  • Joined

  • Last visited

  • Days Won

    474

Everything posted by burt

  1. No tangent. Simply giving you extra knowledge so that you don't continue to give advice that is not correct.
  2. Your point would be valid, except that you have a large hole in your knowledge (targetable css). As for "not working!" - I put "untested" for a reason. Play with it. The idea of .css that works for one thing but not another is a fundamental weapon in a webmasters armoury. I've covered this in the past on a tutorial type post, see if you can find it...it might be hard to do so as it was a while back. But in general; <p>abc 123</p> <div class="whatever"> <p> def 456</p> <p> ghi 789</p> </div> <p>jkl 999</p> with this .css div.whatever p { background: red; } would affect two of the 4 paragraphs, the two in the whatever div. Apply same concept all over shop-side osCommerce as most (all?) containers have a class that can be used for targetting.
  3. Or (note: untested), don't do any of that and instead ... know that .css is targetable; div.cm-i-customer-greeting .btn:first-of-type { color: #fff; background-color: #FF0000; border-color: #46b8da; } Or, for changing the colour of a button (use bootstrap, piece changed is in red); const MODULE_CONTENT_CUSTOMER_GREETING_GUEST = 'Welcome <strong>Guest!</strong> Would you like to <a role="button" class="btn btn-danger btn-xs" href="%s">log yourself in</a> or would you prefer to <a role="button" class="btn btn-info btn-xs" href="%s">create an account</a>';
  4. burt

    PCI Compliance

    Your payment module cannot write to these fields unless it is specifically coded to do so.
  5. Exactly what Steve said. Just in case, anyone doesn't still realise; Our german friends have stringent extra data/privacy/info rules that were in place prior to GDPR and they don't seem to understand that the rest of Europe does not have these same rules. Put as simple as I can; GDPR rules and regs apply to all. German rules and regs do not apply to all.
  6. Be aware that if you remove the strip_tags function, and you have any (even tiny) mistake in your product_description HTML, your whole site when looking at that product...may (at best) look bad and at worst (page won't display).
  7. Discussion on this a while back; It seems as though I abandoned it, though cannot recall why 😕
  8. I agree. I've seen some things done and said here and elsewhere which make me raise my eyebrow. I really hope some people are saying things "for effect" rather than for real.
  9. Interesting! Sounds like he misread the whole idea which is all about placing limits on what can be done with his data. Depending on whether you'd like his custom, I'd send back an email outlining; what GDPR is that all companies are bound by it and that anyone who does not can do anything that they want with his data including selling it. Whereas you specifically state what you will do with his data, and anything not mentioned is what you won't do. But in clearer english than what I just wrote.
  10. You're missing the micro-adjustments I mentioned. These would be performed in each modules template file. https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/content/product_info/templates/tpl_cm_pi_price.php to (eg): <div class="col-sm-<?php echo $content_width; ?> cm-pi-price"> <p><?php echo (tep_not_null($specials_price)) ? sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY_SPECIAL, $specials_price, $products_price) : sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY, $products_price); ?></p> </div> To remove the massive header div and instead put the content into a paragraph.
  11. @rulegacy Did you try the way I suggested. I've just done that on a test site and it worked well. @14steve14 My way you'd just add the Tabs module as the very last sort order (eg 1000) and set width to 12. I don't understand why people are advocating core code changes when it can be done with none?
  12. I prefer not to use them, the only major difference is a "password" and "DOB". DOB is easy to turn off and if remove password from the discussion, what is left? Name, email, address <-- all needed for posting the bought goods to the buyer. Shopowner could then use some type of system to allow customers to login even if they don't have a password. Password-less login...possible?
  13. Personally, I would not allow a "potential" to become a customer unless they specifically accepted my T&C's. This then at least gives me a level of security both the day of the sale and into the future;
  14. Posted this elsewhere, but makes sense to have in this thread; At what point does a Potential customer become a Customer? after they create an account? after they actually buy something? when they sign up to a mailing list? something else That's an interesting question. Maybe shopowners should have something in their T&C explaining at what point a person becomes a customer, that wouldn't harm anything to add it in, and maybe helpful in the future should you have to prove anything to anyone. Remember also that GDPR does not apply only to customers. It applies to ANYONE who interacts with your site, it is just that most shopowners direct people to agree to GDPR T&C etc at some point after the potential customer has browsed products etc. Whichever point you determine a potential becomes a Customer... you MUST STORE the exact T&C to which a Customer signed up, why; In the future, the customer can examine the precise T&C to which he/she signed up and if necessary withdraw his consent. To show the GDPR authority in your country the exact T&C to which the customer signed up, if the customer complains to that authority. Another thing to think about is "Guest Checkout" - how do you solve the problem of the buyer giving consent per GDPR? How do you record the data? What happens if a customer says "no, I won't give Consent" - how do you record it? You can't use their email address...you don't have a customer ID. What do you do?
  15. It's pretty simple, just use common sense. Common sense tells me I need consent to re-market. How do I get that consent? Perhaps a Tickbox on create_account might be enough, linked to acceptance of T&C. In your T&C page have a paragraph about re-marketing. At what point does a person become a Customer? after they create an account? after they actually buy something? when they sign up to a mailing list? something else That's an interesting question. Maybe shopowners should have something in their T&C explaining at what point a person becomes a customer, that wouldn't harm anything to add it in, and maybe helpful in the future should you have to prove anything to anyone. Remember also that GDPR does not apply only to customers. It applies to ANYONE who interacts with your site, it is just that most shopowners direct people to agree to GDPR T&C etc at some point after the potential customer has browsed products etc. Whichever point you determine a potential becomes a Customer... you MUST STORE the exact T&C to which a Customer signed up, why; In the future, the customer can examine the precise T&C to which he/she signed up and if necessary withdraw his consent. To show the GDPR authority in your country the exact T&C to which the customer signed up, if the customer complains to that authority.
  16. Totally do-able, it is exactly as @raiwa says. Gallery 10 6 Name 20 6 Model 30 3 Price 40 3 Attributes 50 6 Buy 60 3 Reviews 70 3 Description 80 6 You are constrained by the DEPTH of the Gallery, so place a minimum height on this using CSS which would be placed in user.css @media only screen and (min-width : 768px) { div.cm-pi-gallery { min-height: 1000px; } } Change the min-height on this to better reflect your needs. You will then also need to amend tpl_ files for product_info, at the very least; remove clearfix from reviews button tpl restyle price as it would look weird as a h* Prior to the extra tpl_ change for price, you would end up with something like: Of course, how this would look in XS...is debatable, and that is why you can micromanage the layout using those tpl_ files if you so wish. My system for these modules uses only the SM layer.... however, that micro-management is where things get really complicated really quickly and hence why I did not put that level of management into Core.
  17. @KarstenBoeer If you wish to post questions in the German language, in the future please post at: https://forums.oscommerce.com/clubs/6-german-community/ I have moved this thread into the German Club.
  18. burt

    Add line breaks to comments during checkout

    $comments .= $key . ': ' . $value . PHP_EOL;
  19. burt

    28d, 2018

    Coming later on Today a couple of minor bugfixes to a couple of modules (nothing important). GDPR Testimonials GDPR Testimonial Module In the latest core update I added the ability to join Testimonial to Client as it was identifiable data (but not linked), as it is identifiable the client must be able to perform certain actions! As it is now linked, it requires one of my special GDPR modules. This module displays the Testimonials that the Client has written and allows them to do two things; Anonymize it (the blue button) Delete it (the red button) And, of course, they can port this Data using the usual "port my data" mechanism. Enjoy!
  20. Third installment of the 28d Project. I missed last year for reasons, but this year it's back. I'm running it slightly differently to previous versions, as this time there will be no option to buy each days package - that was frustratingly difficult to manage - sorry. Instead there will be a very simple "buy now" price for everything, and that will go up in price as February goes by, therefore those who can buy earlier...pay less...and those who buy later...pay more. Hit the [Follow] button in the right hand corner of this page as I shall be updating this post as the days go by. Should anyone wish to pre-buy...thank you for your consideration and support. PM me and we can arrange it. Don't know what the 28d Project is? I make code available during February (each year, usually). This is code that I have created or updated and make available for an all-in price. Had a couple of questions by PM; Edge Compatible: Yes Gold Compatible: Yes(ish), you might need to update some files to the Edge version, I will point these out in the individual "readme" for each. Certainly nothing to be worried about! PHP7 Compatible: Yes Official osCommerce Compatible: No, sorry Core Code Changes: Will be kept to an absolute minimum, you guys know I hate to change Core and I know you guys hate Core Code Changes...but sometimes, it is, unfortunately, unavoidable. Progress: I have 21 things coded and ready for finalised checking. 1 thing is being live tested by a shop. 6 or 7 things more to write; ideas would be welcomed for small to medium things Thanks for all the PMs and Feedback so far!
  21. burt

    ipv6 Support

    In addition to the above, I learned something new today - IP addresses get shortened automatically, eg 127.0.0.1 is actually 127.000.000.001 So your first example 2a01:4f8:13b:12e0:0:0:0:2 gets shortened, less than your 25 limit, all good, can be found in the geolocate DB, is actually: 2a01:4f8:13b:12e0:0000:0000:0000:0002 The second example 2607:fea8:695f:ffb1:7d67: nothing there can be shortened, so is cut off at your 25 limit...
  22. burt

    ipv6 Support

    You may need to increase the database limit for the ip_address in whos_online table. Maybe to varchar(256), that should be more than enough. https://stackoverflow.com/questions/1076714/max-length-for-client-ip-address I think your second example is not the full ipv6 ip - it is cut off at X (25?) characters, hence why you cannot find it in any ip database.
  23. A number of deleted posts in this thread have been re-instated, lets people see the whole conversation.
×