Jump to content

burt

Team
  • Content count

    13,758
  • Joined

  • Last visited

  • Days Won

    538

Everything posted by burt

  1. @@bruyndoncx - cast your mind back to when you made your own site responsive - how much effort did it take - I think a lot of time and sweat. This project is no different.. I could just have implement Bootstrap and say "that's it", but I also want to clean up some of the legacy code in the 2.3 series...some code that goes all the way back to 2000 !!, and I also want to introduce some HTML5 ready elements of code (such as the required form inputs in the example account_edit page and so on.
  2. Here's the rework of the account_edit.php page, not committed. Up it to your bootstrap test site to see how it looks... Also a couple of text changes (english.php, also remove the FORM_REQUIRED_INFORMATION from the middle of the file, and change as below): // message for required inputs define('FORM_REQUIRED_INFORMATION', '<span class="glyphicon glyphicon-asterisk form-control-feedback required"></span> Required information'); define('FORM_REQUIRED_INPUT', '<span class="glyphicon glyphicon-asterisk form-control-feedback required"></span>'); And in custom.css .required { color: #B33A3A; }
  3. Take a look at the tep_draw_button function, this is also changed. jqueryui is completely removed, shopwide 100%.
  4. I see what you mean, but we don't already have that type of architecture in the 2.3 series...so it would mean many more changes (both changes in the pages and changes in the functions/classes)...
  5. Considering doing something like this: <tr> <td class="fieldKey"><?php echo ENTRY_LAST_NAME; ?></td> <td class="fieldValue"><?php echo tep_draw_input_field('lastname', $account['customers_lastname']) . ' ' . (tep_not_null(ENTRY_LAST_NAME_TEXT) ? '<span class="inputRequirement">' . ENTRY_LAST_NAME_TEXT . '</span>': ''); ?></td> </tr> to <div class="form-group has-feedback"> <label for="inputName" class="control-label col-xs-2"><?php echo ENTRY_LAST_NAME; ?></label> <div class="col-xs-10"> <?php echo tep_draw_input_field('lastname', $account['customers_lastname'], 'required id="inputName" placeholder="' . ENTRY_LAST_NAME . '"'); ?> <span class="glyphicon glyphicon-asterisk form-control-feedback required"></span> </div> </div> Thoughts ? This changes the look as shown in the attached images.
  6. Mostly. If I have time I update the site to match the latest github. Could you show an example of something and the example function done in a page that would be better in a function ? And if you did not already have a responsive site? The answer would be the same or no ? What we're building here is a blueprint for the way forward...without input like Tsimi and Ken, the community gets what they get and has zero input on the end product. So, I ask everyone to take some time out and test the changes, make comments and then developers can work on some ideas... I'll update the test site this morning to match the latest Git.
  7. None at all - other than 3 new Header Tag modules that would need to be installed. 2 are required (datepicker and colorbox), 1 is optional (grid/list view, if not installed only grid view shows). Reason for these to be HT modules is so that the scripts are called only on the pages needed rather than site-wide.
  8. Another 10 commits done today - slowly but surely working towards the end result.
  9. 2.3.3.4 => some people pay a designer to make a one off design, some buy a template, some use the stock look, some stumble thru and make a few changes here and there. 2.3.3.4(bs) => no different. Sure, that's where I see it, only a couple of places. The admin side will be something to look at in the future, for now I'm concerned solely with the shop side. So, that function will be deprecated (maybe by tonight lol).
  10. https://github.com/gburton/osCommerce-2334-bootstrap/commit/0de7173082e767529e3ec5e8b81cc6b2d791f2b5 May well be changed as it will need a lot of testing on a number of devices once we have the Bootstrap totally in place.
  11. This function will be deprecated in the shop side by the time I'm finished with it, so far as I can see it's only used in a few places anyway.. Which pages do you see it in ?
  12. Many thanks @@Ken44 - this is the exact sort of feedback I need :) https://github.com/gburton/osCommerce-2334-bootstrap/commit/c8cb2e2ffbf37e224b5bc1f0756b93a377403899
  13. More bits and pieces added. For anyone who wants to install this themselves to test it out, all you need to do is grab the full .zip file; https://github.com/gburton/osCommerce-2334-bootstrap/archive/master.zip And install it as if it was a normal new osCommerce installation. If you can do this and test it out, and provide feedback that would be very helpful and will help to meet our target "go live" date.
  14. I can see the point you are trying to make. But I feel that taking the 2.3 in this direction is the correct thing to do; you can get with it and help out, or not. Either way, we will end up with 2.3 having Bootstrap. At the end of March I hope to unveil a fully working Bootstrapped 2.3, on which any good designer will have no problems creating a good theme.
  15. I missed your posts, sorry Carine. Most definitely agree that once we have the overall Bootstrap in place, we can then finetune it on a page by page basis to make it the best we can.
  16. https://github.com/gburton/osCommerce-2334-bootstrap This is not more than a basic 2.3.3.4 at the moment, I will be adding the Bootstrap over the next 48 hours.
  17. Thanks Matt, I need as much help as possible from as many people as possible.... This is to be a community effort, Github will be coming soon.
  18. Tested it in IE, Chrome. The youtube popup works OK. In Firefox, the opened modal includes the video => OK. But the window has no height. Reason: <object type="application/x-shockwave-flash" width="640" height="385" data="http://www.youtube.com/v/tAbsmHMAhrQ?fs=1&autoplay=1"><param name="movie" value="http://www.youtube.com/v/tAbsmHMAhrQ?fs=1&autoplay=0" /><param name="allowFullScreen" value="true" /><param name="allowscriptaccess" value="always" /><param name="wmode" value="transparent" /></object> should be <iframe width="560" height="315" src="http://www.youtube.com/embed/tAbsmHMAhrQ?autoplay=0" frameborder="0" allowfullscreen></iframe> In other words, colorbox needs the iframe? Maybe, possibly??
  19. Download and install: http://addons.oscommerce.com/info/8864 This is the support thread, if you need help after it is installed.
  20. Very well done to all, and sorry for the lateness of the announcement. Let's try to make osCommerce a force to be reckoned with once again, this coming year.
  21. you could just add a tep_session_registered into all files other than; login.php and create_account.php That should do it ? Look at how this is done in (for example) account.php.
  22. New fileset (added 2014 02 10): http://addons.oscommerce.com/info/8864 Introduction of HT modules for Information Pages Unlimited, courtesy of @@joli1811 Addition of NULLIF to all coalesce statements to solve a display problem, chapeau @@HuffYk
  23. burt

    Need to find specific item in $order

    $foundproduct = false; if (in_array(X, $cart->get_products())) { $foundproduct = true; } Change X to the ID of the product. What you do with foundproduct = true is up to you. Edit: you might needf to global the $cart in the shipping module
  24. burt

    Accessories or Related products

    Your other option is to have something custom coded if you cannot find an add-on that already fits. There are developers available for this at http://forums.oscommerce.com/forum/79-commercial-support-enquiries/ - once completed you can then share with the rest of the community. Of course asking for quotation on something like this means you get an idea of whether the cost is worth it to you, and in any case you do not need to go ahead just because you asked for a few quotes.
  25. burt

    Paypal / OSC Rounding Totals

    That's the output of the page. I need the output of the module (lower down in the source); "shipping", "tax" and "amount".
×