Jump to content


  • Content count

  • Joined

  • Last visited

  • Days Won


Everything posted by kgt

  1. Try changing line 211 if includes/modules/google.php from this: if ($value == 'ot_coupon.php' || $value == 'ot_gv.php') { to this: if ($value == 'ot_discount_coupon.php' || $value == 'ot_coupon.php' || $value == 'ot_gv.php') {
  2. I'm totally unfamiliar with Google Checkout, so I really don't know. Many payment processors don't have the ability to accept discount lines. This is a common complaint for those using Paypal, for example. To get any discounts using Paypal, you must use their aggregate order total rather than the itemized. Google may have a similar feature.
  3. That might be the case. If so, it was wrong. ;) This contribution was always written with the intention of applying discounts before tax.
  4. It's not a problem. The calculations are correct. You have your store set to display products with tax applied. Discounts happen BEFORE tax. So you cannot just add up your product prices with tax applied and subtract the discount. 1 x Prod 1: 35.5351 (without tax) 1 x Prod 2: 15.8863 (without tax) Subtotal: 51.4214 (without tax) Discount: -15 (without tax) -------- 36.4214 (without tax) x 1.196 (tax) -------- 43.56 (subtotal with discount and tax applied) + 7.20 (shipping) -------- 50.76 (total)
  5. Please turn on debugging and send me the debugging output. See the manual for help on how to do that.
  6. Is this for a fixed or percentage discount?
  7. Is this for a fixed or percentage discount?
  8. You must show me an example of what you're getting and what you expect. One does not normally apply tax to an order total line, so I suspect what you're really looking for is something else.
  9. I'm not sure what this means: "The VAT is not applied to the line of the coupon." Please read the manual describing how to actually use the coupons. There is a link to it on the coupons admin page.
  10. Please email me the code you have for checkout_process.php and checkout_confirmation.php. Fast easy checkout might be causing the problem. I recall someone else who ran into an issue who was using FEC, but I can't remember off the top of my head why.
  11. I have no idea what this means. If you use a contribution that modifies the checkout process, then that can cause this to happen. I am afraid I cannot help you without more information.
  12. Please read the README file.
  13. Did you install this in addition to the main package: Discount Coupon Codes 3.0 checkout_process bugfix, 26 Apr 2007
  14. Install the 3 most recent packages made by me (kgt): Discount Coupon Codes 3.0 discount_coupon class bugfix, 2 May 2007 Discount Coupon Codes 3.0 checkout_process bugfix, 26 Apr 2007 Discount Coupon Codes 3.0, 24 Apr 2007
  15. Is your contribution different from the module option that is already there for the 3.0 version to exclude specials? I'm just not sure I know what the difference is. I'm delighted to incorporate it into the whole package if it there's a difference.
  16. Woman. ;) Thanks for the words of encouragement - support provided on this forum is free of course, and sometimes it's difficult to keep up with everyone's needs. As those who helped me test this latest version know, it's actually quite a long testing and debugging process to get a contribution like this working to the point where I feel it's stable enough to support. It's good to know it has largely been a problem-free release. That tells me the time and effort spent before publishing this latest version has been worth it. Thanks to all who have helped out by testing and providing feedback.
  17. If you add the code that inserts into discount_coupons_to_orders to the checkout_confirmation page, what do you expect to happen??? You need to fix the code in the paypal IPN file. Some versions of that use $insert_id as the order id, some use $order_id, etc. It's too much for me to keep up with. You may email me your paypal_ipn file and I will take a look at it.
  18. Did you make edits to the paypal_ipn file? See, if the checkout process never gets to checkout_process.php, then the coupon code CANNOT be inserted into the table. It's not happening magically. That means you have edited the paypal_ipn file, which is where this is being inserted. My support for paypal IPN is limited - it's a payment module that pretty thoroughly alters the checkout process and I don't have time to keep up with all the versions of it. Double check the code you entered in that file. If you cannot figure it out, you may email it to me and I will see if I can fix it.
  19. Please review the changes you made to includes/classes/order.php and be sure you have all of the code included in the install instructions. Also, if you have debug mode on, error messages will not work, as it says in the description of the debug module setting.
  20. MVS could be the problem, but I don't think it is. The discount should be applied to the total in includes/classes/order.php. Double check your changes to that file, especially the last block of code that needs to be added. That last block is where the discount is actually applied to the order lines.
  21. I'm going to need that debug printout before I can get any farther with this. In checkout_confirmation.php, change this line: if( MODULE_ORDER_TOTAL_DONATION_DEBUG == 'true' ) print_r( "<!-- Donations DEBUG\n".print_r( $order, true )."\nEnd Donations DEBUG-->" ); to this: print_r( "<!-- Donations DEBUG\n".print_r( $order, true )."\nEnd Donations DEBUG-->" ); And then View Source in your browser to get the output. Send that to me in an email please and I will take a look at it.
  22. Do you have your module set to apply the discount to the subtotal? Modules > Order Total > Discount Coupons. If it's set to true, the discount has already been applied to the subtotal.
  23. Please see the common problems section of the install instructions.
  24. Your other problem is likely related to the fact that you're using a template, which I can't really help you with. The paypal problem depends on how you have your store and paypal set up. Paypal must accept only aggregate totals from osCommerce since they have no way of accepting a discount line.
  25. I haven't used website payments pro, so I'm not sure how it works, so I can't really answer this. If you use paypal normally, you must use aggregate totals for the discount to display, because paypal doesn't have any way to accept discount lines.