Jump to content


  • Content count

  • Joined

  • Last visited

  • Days Won


Everything posted by kgt

  1. I just uploaded a bugfix for subtotals. See if that fixes your subtotal problem.
  2. It depends on the paypal module. It would be a simple change. All you would need to do is edit the payment module. I can give generic instructions for doing so. I haven't tested this, so please make these changes on a test site. includes/modules/payment/paypal_whatever.php (whatever the name of your paypal module is) find: function before_process() { if it doesn't look like this: function before_process() { return false; } Then add this code right after the "function before_process() {" part: function before_process() { global $order; if($order->info['total'] != 0) { and before the closing } for that function, add another }. Do the same to after_process if it's not empty. So your function(s) might look like this: function before_process() { global $order; if($order->info['total'] != 0) { //existing paypal code in this function } } function after_process() { global $order; if($order->info['total'] != 0) { //existing paypal code in this function } }
  3. Yes, that is probably causing the problem. If you don't need shipping to be re-checked when the customer uses a discount, then leave the lines commented out.
  4. Can you send me a debug output for this? Instructions on how to get the debug output are in the manual.
  5. If you send me a PM or email with your email address, I will send you the updated files that should fix this. If it fixes your problem, I'll package them up.
  6. I'm sorry, I don't see what you mean by the shipping discount being applied to the subtotal. In fact the entire calculation above looks perfect to me. If the CCGV discount is off, that's because CCGV is using the shipping discount in some way. Shipping discounts aren't applied to the subtotal.
  7. You can apply the discount directly to the subtotal (or not) depending on your configuration setting in Modules > Order Total > Discount Coupon. Please see the manual for information on how to configure DCC.
  8. The next most common reason it doesn't show up is because you've missed installing some code in includes/classes/order.php. Double check the install for that file. If that one is fine, next most common is missing the changes to checkout_confirmation.php.
  9. Those lines are used to determine if shipping needs to be recalculated due to the discount being applied. If you don't care about that, then you can leave them commented out to no detriment. If you want to check ship rates, I'll need more information, such as the shipping module you're using, whether you allow free shipping, etc.
  10. I believe I have this fixed. Please send me a PM or an email with your email address and I will send you updated files to try. If they work for you, I'll release them as soon as I get upgrade instructions done.
  11. It does indeed take discounts before the subtotal and not from it. That point is made in the documentation for this contribution and several times in this very thread. The reason why has to do with how osCommerce calculates tax. You can't just take the discount from the subtotal. This would fail miserably for store owners who have multiple tax groups (think non-taxable products and taxable products in the same cart). I'm not sure what you're talking about in regards to the shipping discount. I can't seem to duplicate a shipping discount being applied to the subtotal.
  12. No, it's limited to one coupon per order. I don't have any plans to add that in at this time.
  13. Please see the readme included in the installation zip file for help with this. If you still can get it working, post back here.
  14. That will be a change you'll want to make in the paypal module. I'm away right now, so it's not easy for me to look at it myself.
  15. Send me an email with your debug output (see the manual for help with getting debug output) and I will try to see what's going on.
  16. You need to restore from a backup and try re-installing.
  17. In Modules > Order Total in your admin section, make sure the Discount Coupon option for applying the discount to the subtotal is set to false. Then I'd reorder the lines like this: Customer Loyalty Discount 1 Sub-Total 2 Discount Coupon 3 tax 4 Shipping 5 Order Total 6 That might work out of the box for you. Otherwise, you'd need to get into the code.
  18. Hopefully Tracy will be able to chime in with some help if she's around. For starters, you can make sure there's at least no ugly error message by changing that code to read: $check_user_query = tep_db_query($sql = 'SELECT dc2cg.customers_group_id FROM '.TABLE_DISCOUNT_COUPONS_TO_CUSTOMER_GROUPS.' dc2cg WHERE customers_group_id='.(int)$sppc_customer_group_id.' AND coupons_id="'.tep_db_input( $code ).'"' );] Second, make sure you added the global $sppc_customer_group_id line to the beginning of that function.
  19. These are discount coupons, not gift certificates. Discounts happen before tax, gift certificates happen after tax and apply to the entire order total. Two very different beasts.
  20. It's not set up to provide any error message when items are excluded. I will look into why it's marking coupons as used when all items are excluded. That shouldn't be happening.
  21. Make sure you uploaded the newer version of the includes/classes/discount_coupon.php file from the install zip.
  22. Try changing line 213 from: $discoun_value = number_format($GLOBALS[$class]->output[$i]['value'], 2, '.', ''); to $discoun_value = abs(number_format($GLOBALS[$class]->output[$i]['value'], 2, '.', ''));
  23. It looks like there's some debugging options in that contribution. Please see what you can find out in the way of an error message.
  24. For those that display prices with tax, or have a desire to display the discounted tax (either as a separate line or combined with the discount), I have uploaded a new version which will allow you to toggle how you want the discounted tax to be displayed. (Version 3.2): http://www.oscommerce.com/community/contributions,4269
  25. I'd love to help, but without an error message I can't exactly do anything.