Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

chooch

Pioneers
  • Posts

    1,964
  • Joined

  • Last visited

Everything posted by chooch

  1. Can someone please confirm if the JS countdown in catalog/auctions.php has the seconds clock ticking down by default, like it does in product_info.php. Thanks
  2. Just a white page with no error codes showing? Where did you add the RC2 install from, cPanel or did you upload it and install using catalog/install?
  3. I applied the code to the class and left it at that. If you are asking about getting error files from cPanel I have never done it so I can't say unless you are specific about what to look for and where to find them. I found a possible reason yet am confused why this is causing problems on a fresh install. Here's what I see, when the auction item in product info has xx seconds remaining, if I go to the catalog/auction page to view the listings the same item has an increased time of 11 seconds. If there are 30 seconds remaining on an item in catalog/auctions.php as soon as I go to auction product info I see 19 seconds remaining when I lost maybe 3 seconds maximum going between URL's, no way did I lose 11-12 seconds. Changing timezone to EST made the gap between the product info page countdown and the catalog/auctions countdown increase by over 4 hours and 50 minutes so I will keep Europe as a time setting as I'm out by 11-12 odd seconds at the moment. After I changed the timezone to EST the product info page still shows the auction as 'Auction Ended' yet the catalog/auctions listing shows nearly 5 hours remain. When I click the auction from the listings page the auction is definitely showing as Auction Ended. Basically there is one auction item, in the listing it shows it is a current live one but when clicked in product info it shows it it has ended. FWR, if these problems can not replicated by you and other posters are not highlighting similar issues then they are probably specific to my host/server. I wouldn't see the need for you to look too deeply in to anything I have suggested or brought to your attention so far because two main issues - the timing related problems and the non update of admin/auctions status are not showing correctly on a fresh install so it can't be anything other than the server configuration/settings. I will have to revisit this space in a few days time after I get some more hosting sorted out from a different source.
  4. Ahaa.... Now that was one thing I didn't think of as I didn't know about it. My host is in the USA so that could be it the cause. No FWR, the debugging code didn't help either. I will change the timezone and test a few auctionss with and without adding the debugging code. I hope to be back in a couple of hours and will test it and update the results here.
  5. FWR - there is definaitely a window of a second or a second and a half where even though the Auction Ended sign appears, the late bidder bids and wins. I have double checked this. From my subsequent test even after adding your modified code this still happens. Can you try this for yourself and see? Just check the box and wait for the Auction Ended notice to appear and then immediately bid and see what happens. Again there is a possibility it is related to my host but I don't think that is the case. If this issue is not specific to my host then it may be a fix to add the modified code to auto-refresh the auctions page when auctions end but have to a buffer so that it starts the refresh process while there is still 1 or 2 seconds on the countdown meaning when the page is refreshed not only will the Auction Ended notice appear but the checkbox and bidding button will be removed - it seems safer. If these issues don't appear on your sites then obviosly these must be related to my host as they are carried out on fresh installs of oscommerce RC2 and overwriting the files with this contribution.
  6. Ok, another update. I have tested the scenario on both a fresh install and a modified store - both have the same results. I used two different customer accounts to bid on the same item in following manner: Customer One: Places first bid of 1p Customer Two: Places first and only bid of 2p Customer One: Refreshes the page and can see clearly he has been outbid but does not bid. He then checks the t/c box and waits for auction to expire then presses 'place bid' immediately after the auction box states 'Auction Ended' What happens to me is that the Bid is added to the item and the late out of time bidder is the winner. Can someone please confirm if this is able to happen to them on their site. FWR, I suppose with the automatic refresh that you gave a modification for after the auction has ended this issue would disappear but it would be a good idea for me to be sure this issue is specific to my host. I haven't added any modifications yet as I am trying to make sure the contribution works properly with my host before fiddling with it. I still have to return to update with the outstanding issues I have in admin/auctions with status/remove.
  7. I still don't have an update about why the 'won' status isn't showing in admin/auctions - I'll keep checking. I did just notice that the Tax is no longer showing up in order totals in checkout_confirmation.php. I returned back to the modified store to check and it is the same there as well. For now what I can see is that on a fresh install and modified store no Tax is showing up at checkout. It seems that this is the case for both auction and non-auction related itms regardless of what is in the cart before going to checkout. As this happened on a fresh install it could be isolated to my sites/host but I need to take a closer look and work out whats going on and update here later.
  8. That's clear enough. I'll see tomorrow if I can work out why the status isn't changing in admin/auctions and update here. Thanks
  9. Sorry for the confusion. Once the auction has ended, does an order show up in admin/orders.php before customer checks out or does it show in admin/orders.php after customer checks out? In both sites the order in admin/orders.php only shows up after customer has checked out - is this the default set-up? The server is running php5+
  10. Thanks for checking the second issue. Is there any possibility the zip file contained an out of date or untested admin/auctions file? I tried this contribution on a modified and unmodified store - both did not allow the 'won' status to show. I am thinking it may be related to the files I downloaded - sorry for the confusion.
  11. A quick update, I'll probably give one more tonight...... FWR, definitely the installer and installer class are a breeze, it works well with adding to the database. It saves all the hassle with using phpmyadmin and alike. I added to the database on a modified shop yesterday and a fresh install today - both times I used the installer and both times no errors or problems. I have used two or three contributions with these types of installers and it saves time with the installation process. Here's what I see as possible problems or issues in the script and this is on a fresh install of RC2 and the files in the contribution overwritten on them with no modifications by me: 1) If admin sets the page not to refresh, once the auction is over nothing happens. The admin end of the auction stays the same and no emails are sent out to the winner. The page needs to refresh or some kind of navigation must take place on the site to trigger the process. Please correct me if I have got this wrong however if I am right it may be an idea to refresh the page by forced refresh automatically once the last second has ticked by and the message shows up stating "Time Remaining: Auction Ended" because by doing so everything post auction falls into place. At present its been over 10 minutes since the test auction finished and I haven't been able to see the admin/auctions page with all the bidders etc and no emails have been sent even though I have refreshed the admin pages and clicked many links in admin. 2) Ok, I have just now triggered the process by refreshing the catalog/auctions page and the whole thing went like it should. The winner was notified with the 'Congratulations You Won' email and in admin/auction I could see the bidders as the page updated. In the screenshot you see there is no button to allow me to remove or edit the winning bid - I am a bit confused here so some clarification is requested. Only the 'cleick here to delete' works but there is no Edit button or function. 3) Also the admin/orders page does not show this auction order. This happened on the modified store and I thought it was a bug but obviosuly it isn't. Once the customer uses the checkout the order shows up in admin/orders.php. So if there is a store with many items for auction there maybe some confusion for admin to keep track. To separate the admin/auctions in two by using the current page for live auction and having an identical one for auctions ended is something that may bring an improvement to the contribution. Or to have a dropbox in the mainpage with options such as "All", "Live", "Ended Paid", "Ended Unpaid" may be a good idea as it may be less confusing for admin as each page opened would bring exactly what admin wants to see. 4) For clarity, I definitely was not able to bid on an expired auction on this fresh install RC2 test site - whatever went wrong first time on the modified shop was either because of a bug created by existing modifications or by me making an error. I blame it on working on the site very late last night :lol: A suggestion here: By no means am I requesting this be added as it is simply an observation but do you think it would it be a good idea to be to set a time limit for the customer to pay for the auction otherwise it will be automatically offered to the second highest bidder and then the third, or basically be re-listed after being offered to 2 or 3 next highest bidders? If someone sets up an auction only store or a store with many auctions alongside standard products it will be next to impossible to keep track of unpaid auction winners in the current set-up. FWR and everyone else on this thread, I hope that helps.
  12. FWR thanks for the reply. I wasn't asking for a fix to anything I mentioned, I was just pointing out what I thought were bugs in the contribution including the non critical auction product info message ;) I found the issue I had with auctioned items not going to cart without re-logging in being related to items placed in the permanent cart before the auction contribution was installed so it's not really a bug as such. Also the bidding after the auction has ended was something I too couldn't replicate - I will blame that on late nights. I notice that after an item has been won and added to cart if the buyer then revisits the ended auction by clicking the item from the cart page it takes the customer to the non-auction full price item product info page whereas if the auction is set to stay visible the customer can go back to the ended auction page and view the final price, bids, number of bidders etc. Not sure if that is something deliberate or an oversight. As for the matter of removing bids in admin/auctions and so on I think that I have a problem specific to my store as what you say isn't happening. I can see the page with the listings and all bidders and so on but there is nothing that allows me to edit the bidders. I can however delete the whole auction but not do anything to the status. I will see if I can replicate this as I mentioned earlier I will add this to a fresh install of RC2 and play around with it this evening and tonight because I may use the contribution in a live store and just want to see how viable it is... and to be honest from what I recall it is a big step forward from the French auction script even though you never saw that one.
  13. PLEASE IGNORE MY UNEDITABLE POST ABOVE AND READ THIS INSTEAD I noticed in the pre-release the following things: - I was able to bid on an item after the auction ended - The item won was not added to the cart immediately, I had to log out and back in to see it - The admin/auctions.php page does not allow me to delete the highest bidder and make the second or third bidder the winner. It has no admin interaction -catalog/product_info.php?auction_show is defaulted to SSL so pages are sent to https and dont show on non SSL installed servers - Once the auction is over the message displayed is: This product is on auction. To bid, you must first log into your account or create a new account. (Click Here) . On a live auction it seems fine but would probably be better to have a separate message for expired auctions. ------------------------------------------------------- This was added on to a modified store late last night when I was half asleep so there is scope of error on my part, so I will install it again on a fresh install of RC2 later this afternoon/evening and play around with it some more to see what happens and post anything I see. I have to comment on the following: - The sending of outbid emails is a very positive touch and is a marked improvement on the French auctions contribution. - The adding of Customer ID's as opposed to names/usernames is also a good idea to keep customer details confidential Can anyone confirm what the admin/auctions.php page is supposed to do when an item is won? As my page doesn't allow me to do anything for some reason, I can only assume it allows admin to delete the highest bidder and make the second or third bidder the winner but is this supposed to be a pre-requisite before the customer pays for items won? If a customer can pay immediately after the auction therefore doing so before the auction winner can be edited in admin it defeats the object. Therefore what is the point of having the auction winner edit functions in admin unless they are specific to a live auction to remove a bid. Some insight in to this would be appreciated. Also, did the French auction contribution have a start date alongside the auction end date? FWR has put a lot of effort in to improving the existing auction contributions. Thanks for bringing the updated enhanced contribution to the community.
  14. I noticed in the pre-release the following things: - I was able to bid on an item after the auction ended - The item won was not added to the cart immediately, I had to log out and back in to see it - The admin/auctions.php page does not allow me to delete the highest bidder and make the second or third bidder the winner. It has no admin interaction This was added on to a modified store late last night when I was half asleep, so I will install it again on a fresh install of RC2 later this afternoon/evening and play around with it some more to see what happens and post anything I see.
  15. Done!! Sorry for using a strange sounding email addy but due to lack of storage space I had to use hotmail and the name is not relevant to me in any way :lol:
  16. FWR do you have your new package lined up but need it tested before release? I have some time on my hands over the next couple of days so I don't mind taking a look at it before you release it. I found the French auction script and was going to use that for a site but then found yours and realised you modified it and added features. Let me know if you need me. Thanks
  17. Credit where credit is due.... the code is cleanly written and there isn't much to moan about when it comes to bugs. The Points auto credit/expiry scripts are a real plus as well as the easy on the eye customer account Points pages and Admin layout. Deep Silver was supporting this contribution actively until people began asking repetitive questions without reading the forums and until his own live store was abused by people creating accounts just to see what the module did. Furthermore he even had a demo admin version so people could test the functions out and that too was abused so he took a step back I suppose. Anyway, congratulations to him on his new family, I'm sure we all wish him success in whatever he does.
  18. I've just upgraded from 2.0d to the latest version of Points Reward release and it was a breeze. I encountered no problems after adding the latest release on an RC2 manually upgraded shop. I was going to text-diff all the new files but decided to back up the shop and overwrite the 2.0d files and then wrap the new coding for existing files on my old ###points rewards### wraps. A big thanks to Deep Silver who made this contribution from scratch using hours upon hours of his time designing the code.
  19. Can you copy/paste the whole IPN file here so I can take a look, hopefully we can resolve it.
  20. I think there is a potential for abuse, the harm (if there is any) can only be evaluated if abused links are placed online and if people decide not to click them or if it turns in to a public relations disaster. I am inclined to agree with you that what I was thinking about is impossible to achieve but maybe I'll still try fiddling around with the code for a few days.
  21. I've just found this contribution and installed it to test. The thinking behind the contribution is good because the 404 redirects to index.php and also the 301 corrections are a great addition but the only flaw I see with the original ULTIMATE SEO URL contribution from chemo and this very useful add-on is that there is a danger of abuse www.mysite.com/my-great-product-p-362.html ## Correct URL Can be accessed by ... www.mysite.com/myloadofabsoluterubbish-p-362.html ## Not so correct So by adding this add-on www.mysite.com/myloadofabsoluterubbish-p-362.html will automatically become www.mysite.com/my-great-product-p-362.html in the browser and that is a good thing but what happens if someone maliciously adds links on their website to yours and show the link as: www.mysite.com/dont-trust-this-site-it-is-a-fraud-p-362.html I tried playing around with the code to show a 'page not found' if someone tries to abuse the SEO URLs but haven't had much joy. I know the -p-362.html is the key to arriving on a particular product page and what preceeds it is irrelavant as the URL will still direct there but I am trying to find a way to show those pages as a custom designed 'page not found'. Any tips in the right direction would be appreciated.
  22. Open: catalog/includes/modules/payment/paypal_ipn.php STEP ONE: Find this.... (start at aprox. line no.77) global $cartID, $cart_PayPal_IPN_ID, $customer_id, $languages_id, $order, $order_total_modules; .. and REPLACE it with this... #### Points/Rewards Module v1.20 balance customer points BOF #### // global $cartID, $cart_PayPal_IPN_ID, $customer_id, $languages_id, $order, $order_total_modules; global $cartID, $cart_PayPal_IPN_ID, $customer_id, $languages_id, $order, $customer_shopping_points, $customer_shopping_points, $customer_shopping_points_spending, $order_total_modules; #### Points/Rewards Module v1.10 balance customer points EOF ####*/ ------------------------------------------------------------------------------------------ STEP TWO Find this.... (start at aprox. line no.178) tep_db_perform(TABLE_ORDERS_TOTAL, $sql_data_array); } .. and add this after... #### Points/Rewards Module v1.20 balance customer points BOF #### // customer shoppping points account balanced if (USE_REDEEM_SYSTEM == 'true' && $customer_shopping_points_spending) { $points_toset = $customer_shopping_points - $customer_shopping_points_spending; tep_set_shopping_points($points_toset,$customer_id); if ($customer_shopping_points_spending && DISPLAY_POINTS_REDEEMED == 'true') { tep_add_redeemed_points($customer_id, $insert_id,$customer_shopping_points_spending); } } // customer pending points added $points_toadd = get_points_toadd($order); $rules_discounted = get_award_discounted($order); if ((USE_POINTS_SYSTEM == 'true') && ($order->info['total'] > 0) && (USE_POINTS_FOR_SPECIALS == 'true' || $rules_discounted == true)) { tep_add_pending_points($ordernum, $customer_id, $insert_id,$points_toadd); } #### Points/Rewards Module v1.20 balance customer points EOF ####*/ ------------------------------------------------------------------------------------------ STEP THREE Find this.... (start at aprox. line no.557) // unregister session variables used during checkout tep_session_unregister('sendto'); tep_session_unregister('billto'); tep_session_unregister('shipping'); tep_session_unregister('payment'); tep_session_unregister('comments'); ... and add after..... tep_session_unregister('customer_shopping_points');// Points/Rewards Module v1.20 tep_session_unregister('customer_shopping_points_spending');// Points/Rewards Module v1.20 Let us know if that works for you
  23. What have you got on line 341 of your includes/functions/redemptions.php file?
  24. You should have a checkbox which (when checked) allows the customer to spend the maximum number Points that you have set in admin. It should also show the number of Points the customer has remaining in their balance. If a checkbox is not showing up there could be two reasons that come to mind: One: that you have made an error while text-diffing your files, so you should re-trace all your steps to see if you can spot an error. Two: the customer has not been allocated any Points therefore the box will not show up at checkout until/unless they have Points in their balance. Hope that helps.
×
×
  • Create New...