Jump to content

markjugg

Members
  • Content count

    10
  • Joined

  • Last visited

1 Follower

Profile Information

  • Real Name
    Mark Stoserg
  1. I just want to say "Thanks" for this nice contribution. The instructions built with dynamic HTML were especially easy to follow, and the contribution was quickly working as advertised. The extra options for server and browser catching and compatibility for older GD versions were also appreciated features. Thanks everyone!
  2. markjugg

    Contribution 2094 - Image resize

    Here's some feedback on this contribution to help it improve: - There's no error checking on the exec() calll to mogrify. This allows it to silently fail with no feedback, possibly showing a very large image where a thumbnail should be (because the copy to the thumbnail location succeeded, but the mogrify did not). Ideally, the error checking would not only check for an error, but offer helpful suggestions for common cases. For example, if "127" is returned, that means "file not found" I think. It could suggest that the user try the command from the command line, and if it works there, perhaps safe_mode settings need to be adjusted. - It seems preferable to use "convert" instead of "mogrify". Mogrify requires first copying the large image and then downsizing it. 'convert' does not require the 'copy' command and instead produces the thumbnail directly as output. This could perhaps save a little and disk space of having two copies of the full size image available. "convert" and "mogrify" are part of the same ImageMagick package, so if one is available, the other should be as well. In the end, I never solved the "127" error code issue for myself, and am going to try the GD-based resizing solution instead, which doesn't require calling an external program, and thus avoids the safe-mode issues. Mark
  3. markjugg

    [Contribution] Purchase Order V2.3

    Here's the patch that should fix it: Thu Jul 20 14:02:40 EDT 2006 Mark Stosberg <mark@summersault.com> * bug fix to purchase order extension. Use constant instead of default string diff -rN -u old-store/account_history_info.php new-store/account_history_info.php --- old-store/account_history_info.php 2006-07-20 14:03:38.000000000 -0400 +++ new-store/account_history_info.php 2006-07-20 14:03:39.000000000 -0400 @@ -184,7 +184,7 @@ </tr> <?php // Company PO Account start - if($order->info['payment_method'] == 'Purchase Order Account') + if($order->info['payment_method'] == MODULE_PAYMENT_PO_TEXT_TITLE ) { ?> <tr> diff -rN -u old-store/checkout_process.php new-store/checkout_process.php --- old-store/checkout_process.php 2006-07-20 14:03:38.000000000 -0400 +++ new-store/checkout_process.php 2006-07-20 14:03:39.000000000 -0400 @@ -53,7 +53,7 @@ $order_total_modules = new order_total; $order_totals = $order_total_modules->process(); - if ($order->info['payment_method'] == 'Purchase Order Account') { + if ($order->info['payment_method'] == MODULE_PAYMENT_PO_TEXT_TITLE ) { $check_credit = tep_db_query("select customers_credit_left from " . TABLE_CUSTOMERS . " where customers_id ='" . $customer_id . "'"); $credit = tep_db_fetch_array($check_credit); $subamt = $credit['customers_credit_left'] - $order->info['total'];
  4. markjugg

    [Contribution] Purchase Order V2.3

    Here's a bug I noticed in 2.3.3. In a couple places, the direct English string is referenced: ./checkout_process.php:56: if ($order->info['payment_method'] == 'Purchase Order Account') { ./account_history_info.php:187: if($order->info['payment_method'] == 'Purchase Order Account') Shouldn't these refer to MODULE_PAYMENT_PO_TEXT_TITLE in case someone refines the string in another language? Mark
  5. markjugg

    [Contribution] Purchase Order V2.3

    As anyone further modified this to allow someone to use an additional payment method if the line of credit runs out? For example, maybe you want to place an order for $250, with $200 on the Purchase Order, and $50 on a credit card. I'm tried to assess how hard this customization would be. Mark
  6. markjugg

    [Contribution] Purchase Order V2.3

    Here's a patch to let customers view their own credit limit and available credit. --- old-store/account_edit.php 2006-03-22 15:26:36.000000000 -0500 +++ new-store/account_edit.php 2006-03-22 15:26:36.000000000 -0500 @@ -113,7 +113,7 @@ } } - $account_query = tep_db_query("select customers_gender, customers_firstname, customers_lastname, customers_dob, customers_email_address, customers_telephone, customers_fax from " . TABLE_CUSTOMERS . " where customers_id = '" . (int)$customer_id . "'"); + $account_query = tep_db_query("select customers_gender, customers_firstname, customers_lastname, customers_dob, customers_email_address, customers_telephone, customers_fax, customers_credit_account_status, customers_credit_status, customers_credit_amount, customers_credit_left from " . TABLE_CUSTOMERS . " where customers_id = '" . (int)$customer_id . "'"); $account = tep_db_fetch_array($account_query); $breadcrumb->add(NAVBAR_TITLE_1, tep_href_link(FILENAME_ACCOUNT, '', 'SSL')); @@ -226,11 +226,19 @@ <td class="main"><?php echo ENTRY_FAX_NUMBER; ?></td> <td class="main"><?php echo tep_draw_input_field('fax', $account['customers_fax']) . ' ' . (tep_not_null(ENTRY_FAX_NUMBER_TEXT) ? '<span class="inputRequirement">' . ENTRY_FAX_NUMBER_TEXT . '</span>': ''); ?></td> </tr> - </table></td> + + <?php if (($account['customers_credit_account_status'] == 1) && ($account['customers_credit_status'] ==1)) { ?> + <tr><td class="main">Credit Limit: </td> <td class="main"> $<?php echo $account['customers_credit_amount'] ?> </td></tr> + <tr><td class="main">Available Credit: </td><td class="main"> $<?php echo $account['customers_credit_left'] ?> </td></tr> +<?php } ?> + </table> + </td> </tr> - </table></td> + </table> + </td> </tr> - </table></td> + </table> + </td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  7. markjugg

    Virtual Mall 1.2 Support Thread

    I just want to say: I'm interested in this development with the virtual mall, but these links don't work anymore. (Although Google has a cache of one of them).
×