Jump to content

csaunders

Members
  • Content count

    32
  • Joined

  • Last visited

1 Follower

Profile Information

  • Real Name
    Christian
  1. Here's betting you've got COD on and register_globals off...(see above post)
  2. It does seem that of the three people that I know that are having this problem - the common denominators are Cash on Delivery module on, and register_globals off. Does anyone else have/can recreate this setup to confirm if this is indeed a confilcting contrib? I would myself, but am short of a testing server at the moment - d'oh! Thanks in advance, Christian
  3. If it makes you feel any better, I am having exactly the same problem. Have played around many versions of the code but to no avail. Have a feeling it's a conflict with another contrib. Let me know if you sort it out. -Christian
  4. Hey, I have just updated to the latest versions of all the files and the contribution is great. Well done! However, I'm having two really annoying little problems that I suspect are quite individual to my store (I have register_globals off and use ob_start and ob_end_flush on all my pages... long story), but I'm hoping that someone else out there might have come across the same things; 1) On the checkout_payment screen you enter the redeem code: fine. The error message reporting is all working fine and you get a message saying 'congrats - successful'. But, it doesn't update and appear in either the shopping cart infobox or the following checkout_confirmation screen. But if you enter the code a second time - BAM. It works and updates on both. It NEVER works the first time, only every subsequent time after that. 2) The other problem is that I have a very thin area of active rollover (the same as the radio button payment option rollovers) just above my 'enter you redeem code' box. I can't seem to get rid of it... Anyone else out there experienced/fixed either of the above? Thanks in advance, Christian
  5. Yeah - but it's still nice to see it put right :rolleyes:
  6. Oh! It's bloody done it again - must be something to do with the length of that line of code and the way the message board breaks the text... Let me try again. It should be: <script language="javascript"><!-- function couponpopupWindow(url) { window.open(url,'popupWindow','toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=yes, copyhistory=no, width=450, height=280, screenX=150, screenY=150, top=150, left=150') } --></script> (but without all the carriage returns - hope everyone knows what I mean...)
  7. Guys, That was originally my post re: the Javascript and the reason that it doesn't work properly is because for some reason one of the quotation marks came out as the ASCI code (')... The Javascript should read: <script language="javascript"><!-- function couponpopupWindow(url) { window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=yes,re sizable=yes,copyhistory=no,width=450,height=280,screenX=150,screenY=150,top=150,l eft=150') } --></script> Note the change just after 'popupWindow'. -Christian
  8. I'm in on this...anyone else?
  9. Hi, Firstly, big thanks to all who have been involved in making this contribution - it's fantastic. I hope that the information below helps in making it even better. I am using the latest versions of all the files for this contrib on MS2.2. Firstly, there is a small ommission of the ICW comment string in the includes/boxes/shopping_cart file. There is some Javascript at the start that makes the popup_coupon_help work: <!-- shopping_cart //--> <script language="javascript"><!-- function couponpopupWindow(url) { window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=yes,re sizable=yes,copyhistory=no,width=450,height=280,screenX=150,screenY=150,top=150,l eft=150') } //--></script> That will fix the problem for anyone who has been wondering why the popup does nothing (and generates an error). Next, I have also made some other changes to this file. Using this code, instead of having "coupon: more info" in the shopping cart infobox, you will have: "coupon: (name of coupon you entered in admin) more info" To me this makes more sense, but that's a matter of opinion. Here is the code for includes/boxes/shopping_cart: Find ~line 90: if (tep_session_is_registered('cc_id') && $cc_id) { $info_box_contents[] = array('align' => 'left','text' => tep_draw_separator()); $info_box_contents[] = array('align' => 'left','text' => '<table cellpadding="0" width="100%" cellspacing="0" border="0"><tr><td class="smalltext">' . CART_COUPON . '</td><td class="smalltext" align="right" valign="bottom">' . '<a href="javascript:couponpopupWindow(\'' . tep_href_link(FILENAME_POPUP_COUPON_HELP, 'cID=' . $cc_id) . '\')">' . CART_COUPON_INFO . '</a>' . '</td></tr></table>'); Replace with: if (tep_session_is_registered('cc_id') && $cc_id) { $coupon_query = tep_db_query("select * from " . TABLE_COUPONS . " where coupon_id = '" . $cc_id . "'"); $coupon = tep_db_fetch_array($coupon_query); $coupon_desc_query = tep_db_query("select * from " . TABLE_COUPONS_DESCRIPTION . " where coupon_id = '" . $cc_id . "' and language_id = '" . $languages_id . "'"); $coupon_desc = tep_db_fetch_array($coupon_desc_query); $text_coupon_help = sprintf($coupon_desc['coupon_name']); $info_box_contents[] = array('align' => 'left','text' => tep_draw_separator()); $info_box_contents[] = array('align' => 'left','text' => '<table cellpadding="0" width="100%" cellspacing="0" border="0"><tr><td class="infoBoxContents">' . CART_COUPON . $text_coupon_help . '<br>' . '<a href="javascript:couponpopupWindow(\'' . tep_href_link(FILENAME_POPUP_COUPON_HELP, 'cID=' . $cc_id) . '\')">' . CART_COUPON_INFO . '</a>' . '</td></tr></table>'); Next, I have some other issues to note. I don't know how many of these are specific to my shop (other contribs conflicting?), but hopefully others can reproduce them and we can fix them! I don't know if any of these have to do with the fact that I am using register_globals off...is this contrib compatible with globals off? Here are the problems I've encountered: 1) When you set the store to send out a Welcome Gift Voucher, even though you enter a Coupon Code, it still send out a randomly generated number, and not the code you enter. 2) If the voucher completely covers the cost of the cart, then credit_covers should be set to 1. However, after echoing out credit_covers in the footer of of my checkout pages, I notice that it only gets set to 1 if you refresh the current page (e.g. checkout_payment) and not if you arrived at checkout_payment through a link. For some reason the value is not being passed... 3) This may be caused by the same thing as above, but if you are at checkout_payment and you enter your coupon code, when you press redeem it sends you straight to checkout_confirmation. But, the coupon has not been recognised. When you go back (using the back button or links at the bottom of the page) and enter the coupon code again, you jump straight to the checkout_confirmation page again, but this time the coupon is recognised and the amount correctly deducted. For the above, is it possible that when you enter the coupon code and press redeem that it refreshes the current page (displaying the coupon amount in the shopping_cart infobox) and the user has to press the 'continue' button, to make it consistent with all the other shopping cart pages? At the moment this also means that the user has no opportunity to enter any comments about their order... Nearly finished... 4) Once a coupon is redeemed, the value is deducted whether or not the "use gift voucher account balance" tickbox is selected or not. It seems to ignore it. Finally, 5) If you have a gift voucher balance, and you try to buy more gift vouchers, it screws up the payment modules. Firstly, the Cash on Delivery payment module disappears, and secondly, I am using the CVV contribution and it causes it to bypass its usual card number checking procedures (amongst other things). That's it! Hopefully these problems are limited to my store, and even more hopefully others have experienced (and fixed) the same problems and can help me out. I'm not lazy - I'm just not programmer, but I am going to offer help in return by fixing all the spelling and grammar issues present, and I will have a crack at rewriting the documentation. Thanks in advance. -Christian
  10. Hope this helps someone: I installed this module and all was well except that it wasn't recording the start date, CVV or issue number. I was pulling my hair out then realised that I am running a version of MS2.2 with the register_globals off mod. To fix this simple find the following in your modded catalog/includes/classes/order.php: // >>> BEGIN REGISTER_GLOBALS link_post_variable('cc_type'); link_post_variable('cc_owner'); link_post_variable('cc_number'); link_post_variable('cc_expires'); link_post_variable('comments'); // <<< END REGISTER_GLOBALS and simply add: link_post_variable('cc_start'); link_post_variable('cc_issue'); link_post_variable('cc_cvv'); All fixed! What a relief! -Christian
  11. csaunders

    Orderlist contrib

    Tsimi, Nah - I downloaded the full contrib. Just noticed - it's weird: If I sort by 'processing' for example, then it excludes all the orders that are 'processing' - esentially doing the opposite of what it should do! I'm sure it's simple but just don't have time to look at the code right now... :blush: -Christian
  12. csaunders

    Orderlist contrib

    Tsimi, This works great for me - except the status sorting feature doesn't work... No matter what I select when I press submit I always get (Pending). Had a look at the code but can't see anything... Any ideas? Running MS2.2 Thanks, Christian
  13. csaunders

    WYSIWYG HTMLArea MS2 v1.7

    The categories.php file is way too big to post here, so here is the chunk from lines ~1062-1090: $box = new box; echo $box->infoBox($heading, $contents); echo ' </td>' . "\n"; // Add neccessary JS for WYSIWYG editor of category image if($action=='edit_category'){ if (HTML_AREA_WYSIWYG_DISABLE != 'Disable'){ echo ' <script language="JavaScript1.2" defer> var config = new Object(); // create new config object config.width = "250px"; config.height = "35px"; config.bodyStyle = "background-color: white; font-family: Arial; color: black; font-size: 12px;"; config.debug = ' . HTML_AREA_WYSIWYG_DEBUG . '; config.toolbar = [ ["InsertImageURL"] ]; config.OscImageRoot = "' . trim(HTTP_SERVER . DIR_WS_CATALOG_IMAGES) . '"; editor_generate("categories_image",config); </script> '; } } } ?> </tr> </table></td> </tr> </table> You should easily be able to find the $box line...then just replace as above. Don't forget to keep the important stuff either side of this chunk :thumbsup: -Christian
  14. csaunders

    WYSIWYG HTMLArea MS2 v1.7

    Guys, The installation instructions are slightly off they currently say: STEP 1.1g --> FIND: /admin/categories.php =========================================================================== ========= Look/search for this around line 1051: =========================================================================== ========= } else { // create category/product info $heading[] = array('text' => '<b>' . EMPTY_CATEGORY . '</b>'); $contents[] = array('text' => TEXT_NO_CHILD_CATEGORIES_OR_PRODUCTS); } break; } if ( (tep_not_null($heading)) && (tep_not_null($contents)) ) { echo ' <td width="25%" valign="top">' . "\n"; $box = new box; echo $box->infoBox($heading, $contents); echo ' </td>' . "\n"; } ?> =========================================================================== ========= And directly UNDERNEATH IT add this: =========================================================================== ========= } else { // create category/product info $heading[] = array('text' => '<b>' . EMPTY_CATEGORY . '</b>'); $contents[] = array('text' => TEXT_NO_CHILD_CATEGORIES_OR_PRODUCTS); } break; } if ( (tep_not_null($heading)) && (tep_not_null($contents)) ) { echo ' <td width="25%" valign="top">' . "\n"; $box = new box; echo $box->infoBox($heading, $contents); echo ' </td>' . "\n"; // Add neccessary JS for WYSIWYG editor of category image if($action=='edit_category'){ if (HTML_AREA_WYSIWYG_DISABLE != 'Disable'){ echo ' <script language="JavaScript1.2" defer> var config = new Object(); // create new config object config.width = "250px"; config.height = "35px"; config.bodyStyle = "background-color: white; font-family: Arial; color: black; font-size: 12px;"; config.debug = ' . HTML_AREA_WYSIWYG_DEBUG . '; config.toolbar = [ ["InsertImageURL"] ]; config.OscImageRoot = "' . trim(HTTP_SERVER . DIR_WS_CATALOG_IMAGES) . '"; editor_generate("categories_image",config); </script> '; } } } But it should say: STEP 1.1g --> FIND: /admin/categories.php =========================================================================== ========= Look/search for this around line 1051: =========================================================================== ========= } else { // create category/product info $heading[] = array('text' => '<b>' . EMPTY_CATEGORY . '</b>'); $contents[] = array('text' => TEXT_NO_CHILD_CATEGORIES_OR_PRODUCTS); } break; } if ( (tep_not_null($heading)) && (tep_not_null($contents)) ) { echo ' <td width="25%" valign="top">' . "\n"; $box = new box; echo $box->infoBox($heading, $contents); echo ' </td>' . "\n"; } ?> =========================================================================== ========= And REPLACE it with: =========================================================================== ========= } else { // create category/product info $heading[] = array('text' => '<b>' . EMPTY_CATEGORY . '</b>'); $contents[] = array('text' => TEXT_NO_CHILD_CATEGORIES_OR_PRODUCTS); } break; } if ( (tep_not_null($heading)) && (tep_not_null($contents)) ) { echo ' <td width="25%" valign="top">' . "\n"; $box = new box; echo $box->infoBox($heading, $contents); echo ' </td>' . "\n"; // Add neccessary JS for WYSIWYG editor of category image if($action=='edit_category'){ if (HTML_AREA_WYSIWYG_DISABLE != 'Disable'){ echo ' <script language="JavaScript1.2" defer> var config = new Object(); // create new config object config.width = "250px"; config.height = "35px"; config.bodyStyle = "background-color: white; font-family: Arial; color: black; font-size: 12px;"; config.debug = ' . HTML_AREA_WYSIWYG_DEBUG . '; config.toolbar = [ ["InsertImageURL"] ]; config.OscImageRoot = "' . trim(HTTP_SERVER . DIR_WS_CATALOG_IMAGES) . '"; editor_generate("categories_image",config); </script> '; } } } ?> Note the corrected position of the final ?> and the instruction to REPLACE rather than add... Hope that helps. -Christian
×