Jump to content

PandA.nl

Members
  • Content count

    312
  • Joined

  • Last visited

Everything posted by PandA.nl

  1. PandA.nl

    BTSv1.2 Support

    There are no separate templates for those infoboxes unfortunately, you will need to modify the box class for that (includes/classes/boxes.php) (or write some other alternative code for it).
  2. PandA.nl

    BTSv1.2 Support

    there are many ways to do that. My way is to install http://www.oscommerce.com/community/contributions,2027 first, and then use http://validator.w3.org/ (not all errors it reports are really bad, but missing div's tr's td'and table tags are for example)
  3. PandA.nl

    Register Globals Support

    Hi Paul, there is an already patched version available for download as a separate contribution. If you search the contribs for "globals" you must be able to find it.
  4. PandA.nl

    BTSv1.2 Support

    Hi, I was checking with FireFox and it didn't look bad. Now I checked with IE, and then the right column is far too wide indeed :blink: Maybe the difference between FF and IE could help to find the problem? Isn't it just a missing tag or something for example? Did you already check for HTML syntax errors? ( edit: btw, posting links with sid's attached isn't a good idea )
  5. PandA.nl

    BTSv1.2 Support

    It looks like it's a problem with how the box headings are setup. The box heading text only has a a small space assigned, so if a heading text contains a long word (like "Manufacturer" for example), the middle part is stretched, and together with the images next to both sides of the heading text the total box-witch becomes too large.
  6. PandA.nl

    Register Globals Support

    Ok, thanks to the "HANDY HINT FOR FINDING REGISTER GLOBALS PROBLEMS AND SOME BUG-HUNTING TIPS" (and Mike), I think I've almost found the solution. The $cart_PayPal_IPN_ID var appears to be empty because $insert_id isn't set, and the $insert_id isen't set because no order is saved into the databse. The orders is not saved into the database because because at the top of the "if (tep_session_is_registered('cartID'))" appears to be false. The strange part is that $_SESSION cartID = '' , both if the globals patch is enabled or not. But without the globals patch the empty cartID session value ($_SESSION cartID=>'') returns true and with the patch the same empty cartID session value returns false!! :blink: On my test system I changed (in modules/payment/paypal_ipn.php) function confirmation() { global $cartID, $cart_PayPal_IPN_ID, $customer_id, $languages_id, $order, $order_total_modules; if (tep_session_is_registered('cartID')) { to: function confirmation() { global $cartID, $cart_PayPal_IPN_ID, $customer_id, $languages_id, $order, $order_total_modules; if (tep_session_is_registered('payment')) { And that seems to work for now. Does anyone happen to know why $_SESSION cartID = '' returns true w.o. patch and false with the patch? And if if cartID really should be '' (registered but empty) at that time?, it seems not a very logical value for a cart id :huh:
  7. PandA.nl

    Register Globals Support

    Now that you mention it, I've seen it, but didn't think about it anymore :rolleyes: It's quite difficult error seeking though, because it's not so easy to force the error and such. Thanks for the tip anyway Mike, I will certainly take a closer look at it!
  8. PandA.nl

    Register Globals Support

    I've got some trouble i.c.w. the "official PayPal IPN module"and this register_globals patch Often (but not allways? a testorder I did seemed to have no problem) PayPal orders don't get an order number. There is no error message and customers may complete the whole PayPal payment proccess and we do get the order e-mail. But no PayPal orders appears in the database! I did some testing and it appears that when it goes wrong the $_POST['invoice'] value is empty at checkout, and the $cart_PayPal_IPN_ID var in the paypal_ipn.php module too. Can't figure out yet why it happens though :( Any ideas? Does anyone have these two (PayPal IPN and the register_globals patch) working together? thanks
  9. PandA.nl

    BTSv1.2 Support

    If you've installed the latest BTS version, the best place to create your new/modified template would be "catalog/includes/templates/new/" (where "catalog" is the place where you've installed your cart). Do really want to modify one of the included templates? If so, just take one of the main_page.tpl.php files from the other templates directories (If you like nested tables, use the stock osC template which you can find in the templates/fallback dir. If you like less tables, use the so called OneTable. You like CSS layouts, use the one from the CSS template dir.), copy it to the "new" template directory and edit it as you like. You can do the same with the stylesheet.css file, just copy one of the stylesheet.css file from another template dir to your new template dir, and start editting (or even better start with a totally new empty stylesheet, or a stylesheet that belongs to a template you bought for example). I only use plain text editors myself, but I think you could use dreamweaver (for example, I've never used it myself btw) too, as long as you do not edit anything between the <?php ?> tags, unles you know what you're doing.
  10. PandA.nl

    Please write BTS how to/FAQ

    zoo loft I will answer one of your questions at the support thread right now
  11. PandA.nl

    Please write BTS how to/FAQ

    The questions aren't silly, only this does not seem the best place to ask those questions. Better use the existing BTS support thread:
  12. PandA.nl

    BTSv1.2 Support

    glad you got it working :) The new version (BTSv1.5) is available now: http://www.oscommerce.com/community/contributions,1263 It includes some security fixes, and the template switching code has been optimized. Basic upgrade instructions are included (for upgrading from v1.4 to 1.5), full upgrade instructions will follow soon. Also two new help templates are included, it's work in progress, but I hope it will allready make it easyer to understand how the BTS works.
  13. PandA.nl

    BTSv1.2 Support

    You've made an error installing (or you've had ftp errors), better just re?nstall, it's less work/time than figuring out what's exactly wrong now.(DIR_WS_TEMPLATES_FALL and TEMPLATENAME_MAIN_PAGE means that these contants aren't defined, so probably the bts_configure.php file isn't being loaded for some reason) You are using it on ms2 I assume? B.t.w. the BTSv1.5 will be released soon (within a couple of days I think), it will include some optimisations and security fixes. Maybe you better wait for that version? /*********************************************/ And while i'm posting now anyway: I think I've found an easyer and better security fix for the $javascript and $content_template issue. Add this: unset($javascript,$content,$content_template,$boxLink,$box_id,$box_base_name); to the top of your configure_bts.php file (and use the .htaccess protection too!) feedback welcome :)
  14. PandA.nl

    [CONTRIBUTION] JTS

    Hi Andy, I should have replaced that text a long time ago by "this site is closed down" or something (I even forgot all about it). The main problem with the template was that I wasn't sure about it's copyright, this still hasn't changed, I never have found the author. Another problem was that, allthough implementing the template appeared to be a lot easyer than I thougth, the support requests it generated weren't. (and there were some more problems at the time) So I'm sorry, but really had to quit the support and close the site.
  15. PandA.nl

    Official PayPal IPN Support Thread

    :blush: I didn't read well, was looking for something different than jeff.keeling after all I was hoping it was possible to ad the order nr to the PayPal e-mails, currently I get "Item # - Notification of Payment Received from ..." in the subject or just "Notification of payment received". It seems that at least the the e-mails with the "Item #" could have the order number included in the subject.? :huh:
  16. PandA.nl

    Official PayPal IPN Support Thread

    same problem here, I took a quick look at the code, but i haven't found out how to fix this yet :(
  17. It looks like you've copied the files to the wrong places. No call to tep_draw_form is made inside "admin/print_batch.php", this function is only being used inside "admin/includes/print_batch.php". I think you should copy both print_batch.php to the right locations and try again. @branden: I still would be interested in a screenshot, since it seems very strange to me
  18. PandA.nl

    BTSv1.2 Support

    ADDITIONAL security fix: The ability to switch templates "through the url" should only be used for testing (on your local server for example). For safety I recommend to turn in off in admin, certainly on live shops! If you really want to leave it on, I suggest (there are other ways to do it, this only allows alfanumeric characters and underscores in the template names, if you never echo $tplDir that's probably overkill): Using the BTSv1.4 change (includes/configure_bts.php): define('DIR_WS_TEMPLATES', $tplDir . '/' ); to: // BOF security fix! // define('DIR_WS_TEMPLATES', $tplDir . '/' ); $tplDir = basename($tplDir); if (ereg('^[[:alnum:]|_]+$', $tplDir)) { // 'Input Validated' only allow alfanumeric characters and underscores in template name define('DIR_WS_TEMPLATES', DIR_WS_TEMPLATES_BASE . $tplDir . '/' ); } else { exit('Illegal template directory!'); } // EOF security fix! Using the BTSv1.3x you can change (includes/configure_bts.php): define('DIR_WS_TEMPLATES', $tplDir . '/' ); // BOF security fix! // define('DIR_WS_TEMPLATES', $tplDir . '/' ); $tplDir = basename($tplDir); if (ereg('^[[:alnum:]|_]+$', $tplDir)) { // 'Input Validated' only allow alfanumeric characters and underscores in template name define('DIR_WS_TEMPLATES', $tplDir . '/' ); } else { exit('Illegal template directory!'); } // EOF security fix! (the BTSv1.3 version is untested)
  19. PandA.nl

    BTSv1.2 Support

    WARNING: severe security issue with all BTS versions: the above applies to all BTS versions up to v1.4 There is a small difference with the BTS1.4, you need to update the includes/select_template*.php files to apply the above mentioned $content_template fixes (the $javascript problem/fix is as mentioned above for all versions)
  20. PandA.nl

    [CONTRIBUTION] JTS

    PLEASE DO NOT USE VERSION 1.0 ! I released a security update today: JTSv1.1 = full version. Hopefully this update covers all security problems. Sorry no time to describe any detail now, RL also takes it's time ;) (maybe later, if needed) No need to run the sql file again, delete all old files, and copy the new files to your catalog dir. This version also includes two help template files, hope you like it, might be continued later :)
  21. PandA.nl

    [Contribution] Admin Notes

    looks like the split_page_results bug change the line in split_page_results.php (admin and catalog) $offset = ($max_rows_per_page * ($current_page_number - 1)); to if ($offset < 0) $offset = 0; $offset = ($max_rows_per_page * ($current_page_number - 1)); ( http://www.oscommerce.com/community/bugs,1...limit+-20%2C+20 )
  22. PandA.nl

    BTS with Master Products MS2 1.1.5

    Nat, your question has brought me to an idea. And I wonder why I didn't think of it before :rolleyes: It would be very easy to create a BTS template that explains things like like you ask. I don't have much time the next couple of days, but it's very likely that an "explain template" for the BTS (and JTS) will be released soon :)
  23. PandA.nl

    BTS with Master Products MS2 1.1.5

    index_default.tpl.php :: is the default page (or homepage :: What's New Here? ) index_nested.tpl.php :: is loaded when youve clicked a category that contains categories index_products.tpl.php :: is loaded when the product_listing is shown on the index page If you post the lines to include it could help too. If you would have posted to the BTS support thread your chances for a quick reply would have been better btw (and still are).
  24. PandA.nl

    Register Globals Support

    Hi Fred, I'm interested in this too, mainly for testing purposes. Would it be possible to mail me your files (or some of the files), it would save me some time :)
  25. PandA.nl

    BTSv1.2 Support

    TRUE of course. Allthough most contributions aren't too difficult (only applying changes to the template file instead, for example), but it won't speed up, adding lots of contributions that's for sure. It's such a pitty osC still hasn't got a template stucture :( we can only wait for MS3 /*******************************************/ B.t.w. I've been playing a little with the BTS and made another version called the JTS (Just The Same template structure). It's (allmost) the same, only the files have been moved, and templates renamed and I also removed some bloat. The idea is to make it a little bit more MS3 compatible (allthough it's just guessing at the moment, I don't really know how the MS3 templatestucture will be of course). http://forums.oscommerce.com/index.php?showtopic=141239 (adding MS2 contri's to the JTS will be exactly as "difficult" as with the BTS btw)
×