homewetbar

Hello, It appears you can create an account but not login on the create account page. It appears the error logic and login php code was removed. I just added after else { tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')); } } } This: $error = false; if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'processLogin')) { $email_address = tep_db_prepare_input($HTTP_POST_VARS['email_address']); $password = tep_db_prepare_input($HTTP_POST_VARS['password']); // Check if email exists $check_customer_query = tep_db_query("select customers_id, customers_firstname, customers_password, customers_email_address, customers_default_address_id from " . TABLE_CUSTOMERS . " where customers_email_address = '" . tep_db_input($email_address) . "'"); if (!tep_db_num_rows($check_customer_query)) { $error = true; } else { $check_customer = tep_db_fetch_array($check_customer_query); // Check that password is good if (!tep_validate_password($password, $check_customer['customers_password'])) { $error = true; } else { if (SESSION_RECREATE == 'True') { tep_session_recreate(); } $check_country_query = tep_db_query("select entry_country_id, entry_zone_id from " . TABLE_ADDRESS_BOOK . " where customers_id = '" . (int)$check_customer['customers_id'] . "' and address_book_id = '" . (int)$check_customer['customers_default_address_id'] . "'"); $check_country = tep_db_fetch_array($check_country_query); $customer_id = $check_customer['customers_id']; $customer_default_address_id = $check_customer['customers_default_address_id']; $customer_first_name = $check_customer['customers_firstname']; $customer_country_id = $check_country['entry_country_id']; $customer_zone_id = $check_country['entry_zone_id']; tep_session_register('customer_id'); tep_session_register('customer_default_address_id'); tep_session_register('customer_first_name'); tep_session_register('customer_country_id'); tep_session_register('customer_zone_id'); tep_db_query("update " . TABLE_CUSTOMERS_INFO . " set customers_info_date_of_last_logon = now(), customers_info_number_of_logons = customers_info_number_of_logons+1 where customers_info_id = '" . (int)$customer_id . "'"); // restore cart contents $cart->restore_contents(); if (sizeof($navigation->snapshot) > 0) { $origin_href = tep_href_link($navigation->snapshot['page'], tep_array_to_string($navigation->snapshot['get'], array(tep_session_name())), $navigation->snapshot['mode']); $navigation->clear_snapshot(); tep_redirect($origin_href); } else { tep_redirect(tep_href_link(FILENAME_DEFAULT)); } } } } if ($error == true) { $messageStack->add('login', TEXT_LOGIN_ERROR); } Is this correct or will it cause future errors? Also what is changed in the checkout_shipping.php besides it directing the checkout instead of login? Thanks!

I've added an addition in the contributions addressing that product id problem. RMA System 2.5c --- Fixes --- This update fixes the problem people were having with the product id not being transfered in the admin when trying to schedule a return. --- TO DO LIST --- Here are a list of features that would invaluable but I lack the time and knowledge to make them happen right now, maybe someone else can provide these features with a future update? * Make RMA system able to handle the return of an entire order with multiple items * Make RMA system able to handle return of one item and then maybe another of the same product if multiple qtys of the item were purchased; currently you can only request a return on an item once even if you ordered 6 of the same thing and only returned 3 the first time.

Humm, You've got me there, you said it was the catalog side. I looked at the file and I could see any reason as to why it would not work if your emails and such have the correct rma # in them the only thing I could think is maybe the rma # is blending into your background color as it is different colored than the "Your RMA Number is:" text. Just a guess, otherwise I wouldn't know why it isn't working.

Thank you for your input Ashleylr, its much easier to fix something when people provide input and clues instead of freaking and just saying its broke fix it.... :thumbsup: This new step should fix all of your problems. Let me know how it works: 9) admin/includes/classes/order.php FIND: $orders_products_query = tep_db_query("select orders_products_id, products_name, products_model, products_price, products_tax, products_quantity, final_price from " . TABLE_ORDERS_PRODUCTS . " where orders_id = '" . (int)$order_id . "'"); REPLACE WITH: $orders_products_query = tep_db_query("select orders_products_id, products_name, products_model, products_price, products_tax, products_quantity, final_price, products_returned, products_id from " . TABLE_ORDERS_PRODUCTS . " where orders_id = '" . (int)$order_id . "'"); AFTER: 'name' => $orders_products['products_name'], ADD: 'id' => $orders_products['products_id'], 'return' => $orders_products['products_returned'],

Ok a few simple of things to try and see if these work. 1. If you have an order with one item already returned and one not is it distinguising between the two? Is there a red returns link for the returned one and a grey Schedule Return link for the one that has not been returned yet? 2. Try installing the code for the admin/orders.php in a clean install copy of the admin/orders.php and upload that in place of your current orders.php, let me know if that works. 3. Try changing this part of the rma code: if ($order->products[$i]['return'] != '1') { $return_link = '<a href="' . tep_href_link(FILENAME_RETURN, 'order_id=' . $oID . '&products_id=' . ($order->products[$i]['id']), 'NONSSL') . '"><u>' . '<font color="818180">Schedule Return</font>' .'</a></u>'; TO: if ($order->products[$i]['return'] != '1') { $return_link = '<a href="' . tep_href_link(FILENAME_RETURN, 'order_id=' . $oID . '&products_id=' . ($order->products[$i]['id'])) . '"><u>' . '<font color="818180">Schedule Return</font>' .'</a></u>'; Notice all I did was remove the NONSSL, a long shot but maybe that is causing a problem? Let me know on these and we'll go from there.

Ashleylr, I downloaded a fresh osCommerce install and tried installing using the admin/orders.php code I supplied in the contribution instructions just to check since multiple people seem to be having a problem with this. It worked perfectly, so you and the others that are having this problem must have modified your admin files somehow I would think. The code that pulls the product id $order->products[$i]['id'] is also used in the catalog/account_history_info.php so if it works there so the customer can create a return it should work in admin the same as I borrowed much of the code from the link in catalog/account_history_info.php to create a return item link to create the admin link. I would suggest you download the base osCommerce install and compare files to see if there is a place you changed your orders.php from the original somewhere that is causing the problem.

Hi Jan, is this a new install of the contrib or an upgrade? This new install just borrows the product_id grabbing string from the one used to pull up the returns link next to a product after it was returned. $returns_check_query = tep_db_query("SELECT r.rma_value, rp.products_id FROM " . TABLE_RETURNS . " r, " . TABLE_RETURNS_PRODUCTS_DATA . " rp where r.returns_id = rp.returns_id and r.order_id = '" . $oID . "' and rp.products_id = '" . $order->products[$i]['id'] . "' "); Grabs the product ID so if the previous version's link next to the product for an already scheduled return did not work then this will not work. Something is wrong with your code or you've altered something is all I can tell you. Try installing the old version and see if that returns product link works for you, if it doesn't work either then you've done something to your code elsewhere that is causing your problem, not the contrib.

FILENAME_RETURN AND FILENAME_RETURNS are two different files. So that is correct Jan. define('FILENAME_RETURNS', 'returns.php'); define('FILENAME_RETURN', 'return_product.php');

Please verify after: for ($i=0, $n=sizeof($order->products); $i<$n; $i++) { You have: //BEGIN RMA MODULE $returns_check_query = tep_db_query("SELECT r.rma_value, rp.products_id FROM " . TABLE_RETURNS . " r, " . TABLE_RETURNS_PRODUCTS_DATA . " rp where r.returns_id = rp.returns_id and r.order_id = '" . $oID . "' and rp.products_id = '" . $order->products[$i]['id'] . "' "); if (!tep_db_num_rows($returns_check_query)){ if ($order->products[$i]['return'] != '1') { $return_link = '<a href="' . tep_href_link(FILENAME_RETURN, 'order_id=' . $oID . '&products_id=' . ($order->products[$i]['id']), 'NONSSL') . '"><u>' . '<font color="818180">Schedule Return</font>' .'</a></u>'; } // Don't show Return link if order is still pending or processing // You can change this or comment it out as best fits your store configuration if (($orders_status == '1') OR ($orders_status == '2') ) { $return_link = ''; } } else { $returns = tep_db_fetch_array($returns_check_query); $return_link = '<a href=' . tep_href_link(FILENAME_RETURNS, 'cID=' . $returns['rma_value']) . '><font color=red><b><i>Returns</b></i></font></a>'; } //END RMA MODULE then the following code should be something simular: echo ' <tr class="dataTableRow">' . "\n" . ' <td class="dataTableContent" valign="top" align="right">' . $order->products[$i]['qty'] . ' x</td>' . "\n" . You should now be able to click to return an item in admin and the product id should be carried into the rma. I wonder if you being in another language effects this Jan?

It should not affect any other contributions, I have dozens installed and it affects none of them.... You are correct Step 3 should be, I'll correct the upload with a new version tommorrow after a couple more people have checked the instructions 3) admin/includes/filenames.php ADD: define('FILENAME_RETURN', 'return_product.php');

Just posted a new version 2.5 Upgrade instructions included. I hardcoded a few things to save time, but not much, hopefully this will be very useful to everyone! --- New Features --- * Ability to create RMAs from admin. * Shows RMAs that have not been completed in Red in Admin now. * Can list different contact email and contact name when creating from admin for customers who received item as a gift! --- Fixes --- * Clean up of some unrelated contribs in the install * Incorporated order # fix by Sean Stewart * Incorporated clickable url fix by Taryn Young * Improved layout in Product Returns edit section Enjoy! :thumbsup:

Ok as far as the ability to create RMAs in admin I've gotten to the point you can enter everything into the form but it is not processing for some reason. I need someone with a little better php skills to look this over and tell me whats causing the problem. Insert into your admin filenames.php define('FILENAME_RETURN', 'return_product.php'); Then change your in orders.php right after for ($i=0, $n=sizeof($order->products); $i<$n; $i++) { FROM: $returns_check_query = tep_db_query("SELECT r.rma_value, rp.products_id FROM " . TABLE_RETURNS . " r, " . TABLE_RETURNS_PRODUCTS_DATA . " rp where r.returns_id = rp.returns_id and r.order_id = '" . $oID . "' and rp.products_id = '" . $order->products[$i]['id'] . "' "); if (!tep_db_num_rows($returns_check_query)){ $return = ' '; } else { $returns = tep_db_fetch_array($returns_check_query); $return_link = '<a href=' . tep_href_link(FILENAME_RETURNS, 'cID=' . $returns['rma_value']) . '><font color=red><b><i>Returns</b></i></font></a>'; } TO: //BEGIN RMA MODULE $returns_check_query = tep_db_query("SELECT r.rma_value, rp.products_id FROM " . TABLE_RETURNS . " r, " . TABLE_RETURNS_PRODUCTS_DATA . " rp where r.returns_id = rp.returns_id and r.order_id = '" . $oID . "' and rp.products_id = '" . $order->products[$i]['id'] . "' "); if (!tep_db_num_rows($returns_check_query)){ if ($order->products[$i]['return'] != '1') { $return_link = '<a href="' . tep_href_link(FILENAME_RETURN, 'order_id=' . $oID . '&products_id=' . ($order->products[$i]['id']), 'NONSSL') . '"><u>' . '<font color="818180">Schedule Return</font>' .'</a></u>'; } // Don't show Return link if order is still pending or processing // You can change this or comment it out as best fits your store configuration if (($orders_status == '1') OR ($orders_status == '2') ) { $return_link = ''; } } else { $returns = tep_db_fetch_array($returns_check_query); $return_link = '<a href=' . tep_href_link(FILENAME_RETURNS, 'cID=' . $returns['rma_value']) . '><font color=red><b><i>Returns</b></i></font></a>'; } //END RMA MODULE Then copy both your return_product.php and return_emails.php language files to the admin language files directory. Upload this return_product.php into your admin directory. So you can see it all appears to be working great but is hanging on something when you submit the form. Can anyone tell me how to fix this? I've almost got it, but just can't see what is causing the hang! :blink: Attached is the return_product.php return_product.php

I'm working on the ability to create RMA requests from admin for customers who can't figure out the form and for customers who got the item as a gift. Basically what I'm trying to do is create a link next to each product that will take me the the return_product.php for admin (basically a modified version of the regular catalog one). I've got the link down fine but I'm having trouble displaying the dropdown fields in on the admin side. I'll post more when I have something that works correctly.

One more modification I came up with. I found that often times the shipping name and purchase name can differ, which can be a problem so I added a couple of lines that display the sold to name, ship to name, and shipping method choosen in the fedex module before shipment so you know in advance who its going to and if they chose FedEx to ship it or not without looking at a packingslip or going fully into the order. Just Find: <?php echo $order_item_html;?> </tr> And change it to the following: </tr> <tr> <td colspan="3" class="main" align="left"> <table border=0 cellpadding=0 cellspacing=0 width="500"> <tr> <td class="main" align="left"> <b>Sold To:</b><br> <?php echo $order_info['customers_name']; ?><br> </td> <td class="main" align="left"> <b>Shipping To:</b><br> <?php echo $order_info['delivery_name']; ?><br> </td> </tr> </table> </td> </tr> <tr> <td colspan="3" class="main" align="left"><b>Shipping Method:</b><br><?php echo $shipping_method ?><br> </td> </tr> <?php echo $order_item_html;?> [code] Then you're done, one additional step which makes it easier to read is to align the products sold to the left just find: $order_item_html = ''; and change a few likes below it on the <td statements to align="left" instead of align="center". :thumbsup:

The current version calculates shipping properly when your tare weight is more than the percentage weight but messes up the weight when the percentage weight is more than the tare. Here is my crude, but effective solution if anyone else would like to fix this: Change: $order_weight = $order_weight + SHIPPING_BOX_WEIGHT; TO: // Find out which weighs more tare or percentage shipping rate and display that rate // Change the 1.17 to reflect your percentage, Example 12% would be 1.12 $order_weight_tar = $order_weight + SHIPPING_BOX_WEIGHT; $order_weight_percent = ($order_weight * 1.17); if ($order_weight_percent < $order_weight_tar) { $order_weight = $order_weight_tar; } else { $order_weight = $order_weight_percent; } Just change the 1.17 to whatever your percent is, Example 12% would be 1.12 and it's fixed! :thumbsup:

I had a couple of ideas after using this contribution for awhile that could really make this contribution incredible. 1. Being able to return the entire order, not just item by item. 2. Being able to manually create RMA tickets for the customer, for those customers who can not figure it out themselves or for people who got them item as gifts and cannot enter a return themselves because it is under another person's account. Has anyone added these features to their site, and can anyone suggest how to go about doing these modifications? Thanks!

This is not a bug per-say it is a alternative way of invoicing. The rma system creates its own RMA invoices so that #3 you see is the rma return # not the customer order #.

Hi Steve, Thanks for the reply, I see it adds the refresh function but I do not know what I should be looking for and adding to my combined login/create account page. Can you elaborate on this further?

Ahh, I see what is happening it is just displaying the weight per box, and not the number of boxes. Thanks for your help and great contribution!

Looks like it will be a great addition to my site, however I am having one problem in testing. Since my login and create account are combined into one page it seems to be interfering with the login part of the site. Any ideas as to why and how to fix it? Thanks!

Any luck on figuring this out? I'm still stumped as well... :huh:

You really don't need that if you are shipping regularly, just call your fedex rep and tell them you want daily shipment pickup and you're done (P.S. fedex charges a fee, $12 I believe per week regardless of how many times they come or how many packages you ship)

Excellent contribution, but I just noticed today that when you get above 70 pounds the contribution freeks out and says the shipping weight is actually less than what is was with less items?

I'm banging my head against the wall, I've gone over and over the code line by line but I cannot figure this out still!!! >_< It will not display shipping modules with a zone set, how can I fix this? Anyone please????