Jump to content

Ian-San

Members
  • Content count

    761
  • Joined

  • Last visited

Posts posted by Ian-San


  1. If anyone used this hack from the archive forums to keep image proportions:

     

     

    In html_output.php (function tep_image)  

     

     

    replace:  

     

    if ( ($width) && ($height) ) {  

    $image .= ' width="' . $width . '" height="' . $height . '"';  

    }  

     

    with:  

     

    if ( ($width) && ($height) ) {  

    $image_size = @getimagesize($src);  

    $ratio = $width / $image_size[0];  

    if ($image_size[1]*$ratio > $height) {  

    $ratio = $height / $image_size[1];  

    $width = $image_size[0] * $ratio;  

    } else {  

    $height = $image_size[1] * $ratio;  

    }  

     

    $image .= ' width="' . $width . '" height="' . $height . '"';  

    }

     

    you should not that it is wrong as it stops pixel lines being drawn. The solution is simple:

     

    if ( ($width) && ($height) ) {

    $image_size = @getimagesize($src);

    if ($height > 1) {

    $ratio = $width / $image_size[0];

    if ($image_size[1]*$ratio > $height) {

    $ratio = $height / $image_size[1];

    $width = $image_size[0] * $ratio;

    } else {

    $height = $image_size[1] * $ratio;

    }

    }

    $image .= ' width="' . tep_parse_input_field_data($width, array('"' => '"')) . '" height="' . tep_parse_input_field_data($height, array('"' => '"')) . '"';

    }


  2. Mark

     

    I also did that trick with the random numbers, but the problem is that the confirmation email is being sent to the corrupted email as well. So I need to have a way to store the emails with random numbers (no problem) but then have all parts of the site remove them again if when the email is actually used. I'm working on it.

     

    So far, I have achieved this by integrating your solution back into the core files and adding some if statements. I am still working on the items with * shown but you can see it in operation in my site.

     

    1) A Guest can checkout without making an account, their password is generated by the computer as a random number so not even we know it. All their details are stored as normal and we can see them in Admin, email them updates to the order etc

     

    2) The Guest account stays open until either they log-off, or for 20 minutes after they close down Internet Explorer (e.g. Session Timeout)

     

    3) After a Guest account closes down, it can never be opened again as nobody knows the password, not even us. So it will just stay on the system as a pointless account until we delete it.

     

    4) After a Guest Account closes down, the guest will need to create a new Account to use the store again. All details from any old accounts will be lost to them ? e.g. they cannot see their previous purchases, see alternative delivery addresses, their name and address will need to be typed in again etc etc.

     

    5) A Guest can make as many accounts as they like using the same email address whereas a registered customer cannot.

     

    *6) As guests can have many old accounts all using the same email address, we need a process to clean them up, delete duplicates etc.

     

    *7) If we email out everyone on the system, we may have some duplicate email addresses unless we can clean it up first.

     

    8 ) Guest accounts are stored on the PC just like other accounts, the only difference being that they show ?-1? log-on attempts in Admin.

     

    9) If a Guest has only one account, they can use ?Password forgotten? to get the system to send them a new password by email ? but they will not know this of course ? and then they could log-in as a registered user, update their details etc without problem.

     

    *10) Guests with more than one account and who use password forgotten to get a new password, cannot change their details or password in the ?My Account? part of the site as it will discover they have duplicate emails names.

     

    *11) A Guest cannot go on to create a registered account unless we first delete all their existing guest accounts.

     

    12) Registered customers cannot log-in as Guests.


  3. Gregory

     

    I am not an expert on cookies but if OS manages to store a cookie on the customers computer, it turns off the SIDs in the URL as they are not required anymore. But when Google comes, clearly it does not accept cookies so the SID comes back.

     

    There is an enormous amount of stuff in these forums on cookies, Google, session IDs, SEFUs etc.

     

    Like a cold, there are so many cures because non of them really work 100%.

     

    Here is the cookie you stored on my computer:

     

    POSTNUKESID

    672c1113616f512a432f541ba329f063

    www.mountainwatersspa.com/

    1536

    309190016

    29524804

    2981840080

    29523395

    *

     

    clearly with SID. And here is one of my own:

     

    email_address

    XXXXXXXX(DELETED)XXXXXXX

    www.nowsayit.com/catalog_en

    1024

    1454922752

    29529413

    797726816

    29523379

    *

    first_name

    Ian

    www.nowsayit.com/catalog_en

    1024

    1454922752

    29529413

    797726816

    29523379

    *

     

    I am not sure, but it doesn't look like a SID to me. I have Ian's mod added as well.


  4. In reality if you were using allprods for customers then it should only list in one language anyway.

     

    Ian

     

    I think you are right here. The correct approach would be to use a modified, single language, allprods for customers and a second, hidden, multi-lingual one, for the robot.

     

    Anyway, we have to remember that allprods is a contribution, not part of the official code.

     

    If a customer clicks on a generated google link with kill_sid=true then if they immediatlely try to add to cart then it won't work, this is due to the tep_get_all_parameters function.

     

    This may be more of a problem for some but it is difficult to think that a customer will buy immediately on entering a store without clicking on something else first AND have cookies switched off!


  5. Ian

     

    Thst is certainly its purpose. However, it does make a nice way to list the whole product catalogue and I have seen it used this way in a few stores.

     

    Maybe not having browsing capability for allprods when cookies are off is a reasonable situation, I for one can live with it as (despite what many programmers say) I doubt if the average customer knows what a cookie is let alone how to turn it off - and IE comes by default with Cookies on.

     

    However, I was also thinking that the spider would pick up the link for the product and that this link would now include the &kill_sid=true in the url? In the same way as it currently picks up the SID - so when the customer follows the listed search engine link, it would be a problem if cookies are off. Maybe that is not the case?

     

    Or is it that when you return to the store, SID is turned on by the command $kill_sid = false; at the top of your mod to application_top despite the url saying &kill_sid=true?


  6. Okay - I dont know what your problem is :( but I can tell you that all your issues ARE related to the same problem which is to do with NOT completing the checkout_process.

     

    I can also tell you that I am using this module myself and just did a test transaction with no problem so there should be no issue with Worldpay or the mod.

     

    The issue to look at is why do you not complete the checkout_process or if you do, why does it not remeber the Session id? Really, you can only discover this if you check what is being posted and received back. ie make sure that the information that comes back from WP is the same as that sent and that both include the SID.


  7. I have worldpay enable in the options for cookies, is that what you are talking about?

    How do I alter session ids timing out or what are safe urls?

     

    safe urls use '/' rather than '?' - check your store urls to see what you are using.

     

    When IE security / Privacy is set to the highest level, all cookies are stopped so the store has to keep track of the customer by adding the session ids to the url string. But as it is, there are still problems with this aspect of OS. So if the session ids get 'lost' or time out, the store has no way to know who the customer was when it gets the return from WP. It is easy to tell actually. Just log in then close down all browser windows. Then go back to your store again. Are you still logged in?


  8. One further trick I have suggested before, is to replace the form post in the worldpay.php file with a mailto: youremailaddress so that you can see what is being posted to worldpay and check that session ids etc are shown. If you do this, you will get a visus warning from your PC and then an email to yourself with a txt file attachment.


  9. Lots of questions and lots of issues still with worldpay. half this forum is taken up with WorldPay issues (or so it seems..)

     

    The double ">"> is correct.

    You must load the c/y files from the mod to worldpay to work correctly.

     

    If you get the emails from worldpay and are directed back to the 'Success' part of the store but are not getting a completed order, then the problem could be with session ids timing out - or ... one thought, are you using search engine safe urls with all cookies disabled? As I dont think that will work either?


  10. Hi

     

    No - not that. Callback in worldpay is not actually used for this mod, so should be switched off.

     

    Return to the store is controlled by the c/y files. If the transaction is cancelled, the customer will be returned to the payment page and if it is successful, to the checkout confirmation page (actually checkout_process.php). Clearly, if you go back to the payment page the transaction is not completed so no order details added etc. And if the checkout confirmation page, then the order process will complete correctly.

     

    Does this happen? If not what does?


  11. Maybe others who have installed this mod could try this as I am getting mixed results:

     

    1) Set your browser security to maximum so as to prevent all cookies

    2) Make sure Search Engine Friendly URLs are not being used as this feature does not work anyway without cookies being allowed.

    3) Load your site and go straight to your login page without clicking anything else.

    4) Can you see the SID in the URL? can you log-in.

     

    Ian, if this IS a problem (not sure yet that it is), do you think that just adding:

     

    $kill_sid = false;

     

    to the login page would fix it?


  12. I modified the later WorldPay modules to work with version 2.2 and you should see WorldPay' as a payment option in admin if all the files are correctly installed in the catalog. I can't say if it will work with version 2.1 - there have been too many changes since I last used it :? !

     

    And the older modules, that might work with version 2.1, contain serious errors that will give you other problems if you try to use them.

     

    As version 2.2 is almost stable now, and a giant leap on version 2.1, this may be the time to think about upgrading!

×