Jump to content

Stephan Gebbers

♥Ambassador
  • Content count

    206
  • Joined

  • Last visited

  • Days Won

    2

Stephan Gebbers last won the day on May 8 2018

Stephan Gebbers had the most liked content!

6 Followers

Profile Information

  • Real Name
    Stephan Gebbers
  • Gender
    Male
  • Location
    Potsdam/Germany

Recent Profile Visitors

11,726 profile views
  1. Stephan Gebbers

    New management and osCommerce v4

    what i see, that this move forces phonix to be a fork and to be completely seperate from oscommerce in the future. why not focus on what has been accomplished with phoenix already? this is a waste of all the work that has put into phoenix already. at the end we have people working on phoenix and working on oscommerce and each and every payment module or other module has to be made twice if the systems start to be to different. i am not happy about a "new" oscommerce. we already have a new oscommerce. It is phoenix! i am dissapointed in harald, about him just beeing invisible for ages and now this..
  2. Stephan Gebbers

    Store Mode BS

    just a little hint. nothing serious, but.. /includes/modules/content/header/cm_header_store_mode.php still contains "Version 1.2.1" in the install function.
  3. Stephan Gebbers

    ULTIMATE Seo Urls 5 - by FWR Media

    Hey, any idea were i could look? everytime i choose a manufacturer in the manufacturers box and the shops shows the products by manufacturer, the language switches back to the shops default language.
  4. i got fooled by the way Oscommerce handles admin sessions again. when you use the build in htaccess protection it never logs you out (or automaticly logs you in with htaccess user/pass). i guess i gonna deactivate that and just use standard htaccess with differenc user/pass. confusing as F when you forget how it is supposed to work.

  5. I realy like your error handler vor mysql error messages! Good Job!

    you think it would work without problems with an older oscommerce version as well?

    1. Jack_mcs

      Jack_mcs

      Glad it was helpful. The changes are to parts of the code that are in all oscommerce shops so there shouldn't be any problems.

    2. Stephan Gebbers

      Stephan Gebbers

      btw: i'm not sure if it is a good idea to send the error_log to the root folder of the shop. i changed that, so it will save it as error_log.txt into folder includes and forbid web access to *.txt in the htaccess of includes folder

      also, the email is send but after the query nothing can be added to $msg. it will not show after the error query. not shure why.. i moved the URI line in front of the line with the error query and that shows up in email now.

    3. Jack_mcs

      Jack_mcs

      That's why there is an option to not send via email. :)

  6. Stephan Gebbers

    Fake accounts

    i have this in my create_account.php for 5minute emails and bad spam domains. maybe this could be done as a module also? i think the original contribution was from oscbooks.com back then.. // BANNED EMAILS $emails = file(DIR_WS_INCLUDES . 'emails-banned.txt'); for ($i=0, $n=sizeof($emails); $i<$n; $i++) { if (tep_not_null($emails[$i])) { $emaildomain = '@' . trim($emails[$i]); if (is_integer(strpos(strtolower($email_address), $emaildomain))) { $good_email = "no"; break; } } } // Email Whitelist $emails = file(DIR_WS_INCLUDES . 'emails-whitelisted.txt'); for ($i=0, $n=sizeof($emails); $i<$n; $i++) { if (tep_not_null($emails[$i])) { if (is_integer(strpos(strtolower($email_address), trim($emails[$i])))) { $good_email = "yes"; break; } } } if ($good_email == "no") { $error = true; $messageStack->add('create_account', ENTRY_EMAIL_NOT_ALLOWED_ERROR); } // BANNED EMAIL EOF
  7. Stephan Gebbers

    Fake accounts

    What about the Email Domains they are using? Would that be a way to block certain Domains on account creation?
  8. Stephan Gebbers

    ULTIMATE Seo Urls 5 - by FWR Media

    i just tried to make my product_info.php urls customizable, as i dont like that the url is gonna change once you change the product name just a little Modifications are made to work with the rewrite functionality (where you need to have rewrite rules in htaccess). page module index.php still needs to be modified to have the customized category urls there as well. categories.php in admin would need a modification if you want to edit the seo url database fields from there. based on v208 https://apps.oscommerce.com/Hj4y0&ultimate-seo-urls-5-for-responsive-oscom looks good so far for product_info.php, but a) i could need some help with page module index.php to show the categories with the customized urls also. b) will that break any of the usu5 modules functionality? add fields to database ======================================= in table categories_description add field categories_seo_url (varchar 255) in table products_description add field products_seo_url (varchar 255) modify page modules ======================================= in /includes/modules/ultimate_seo_urls5/page_modules/product_info.php find this: protected $dependencies = array( 'products_id' => array( 'marker' => '-p-', 'query' => "SELECT pd.products_name, m.manufacturers_name, cd.categories_name, p.products_model, p2c.categories_id FROM products_description pd INNER JOIN products_to_categories p2c ON p2c.products_id = pd.products_id INNER JOIN products p ON pd.products_id = p.products_id LEFT JOIN manufacturers m ON m.manufacturers_id = p.manufacturers_id INNER JOIN categories_description cd ON p2c.categories_id = cd.categories_id AND cd.language_id=':languages_id' WHERE pd.products_id=':pid' AND pd.language_id=':languages_id' LIMIT 1", 'to_replace' => array( ':languages_id', ':pid' ) ) ); and replace with this: protected $dependencies = array( 'products_id' => array( 'marker' => '-p-', 'query' => "SELECT pd.products_seo_url, pd.products_name, m.manufacturers_name, cd.categories_seo_url, cd.categories_name, p.products_model, p2c.categories_id FROM products_description pd INNER JOIN products_to_categories p2c ON p2c.products_id = pd.products_id INNER JOIN products p ON pd.products_id = p.products_id LEFT JOIN manufacturers m ON m.manufacturers_id = p.manufacturers_id INNER JOIN categories_description cd ON p2c.categories_id = cd.categories_id AND cd.language_id=':languages_id' WHERE pd.products_id=':pid' AND pd.language_id=':languages_id' LIMIT 1", 'to_replace' => array( ':languages_id', ':pid' ) ) ); right after: // manufacturers_name is gained through a left join and may not exist array_key_exists( 'manufacturers_name', $details ) ? $text_types['b'] = $details['manufacturers_name'] : null; add: //if we have a products_seo_url, we use that string instead of products_name if (!empty($details['products_seo_url'])) { $text_types['p'] = $details['products_seo_url']; } //if we have a categories_seo_url, we use that string instead of categories_name if (!empty($details['categories_seo_url'])) { $text_types['c'] = $details['categories_seo_url']; } Removing .html from the rewrite URLs ======================================= in /includes/modules/ultimate_seo_urls5/uri_modules/path_rewrite.php and in /includes/modules/ultimate_seo_urls5/uri_modules/rewrite.php replace: if ( false === strpos( Usu_Main::i()->getVar( 'request_uri' ), '.html' ) ) { // path_rewrite seo url must have .html return false; } with: /* if ( false === strpos( Usu_Main::i()->getVar( 'request_uri' ), '.html' ) ) { // path_rewrite seo url must have .html return false; } */ find: return usu5_multi_language( $separator = 'right' ) . $text . $seperator . $value . '.html'; and replace it with: return usu5_multi_language( $separator = 'right' ) . $text . $seperator . $value; in /.htaccess replace: RewriteRule ^([a-z0-9/-]+)-p-([0-9]+).html$ product_info.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-c-([0-9_]+).html$ index.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-m-([0-9]+).html$ index.php [NC,L,QSA] with: RewriteRule ^([a-z0-9/-]+)-p-([0-9]+)$ product_info.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-c-([0-9_]+)$ index.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-m-([0-9]+)$ index.php [NC,L,QSA]
  9. Stephan Gebbers

    SEO Friendly Urls - a new approach

    another question. if i change the language on a page, the page reloads, the language changes but the url does not refresh to the language url but stays and the initial language url alias like, if you select german coming from english: www.domain.de/en/alias?language=de initial url is www.domain.de/en/alias then you switch language and get www.domain.de/en/alias?language=de (with language on the page already switched to german and canonical link (from canonical module) in page source changed to german already) where i would expect the resulting url after language switching to be www.domain.de/de/alias
  10. Stephan Gebbers

    SEO Friendly Urls - a new approach

    @gadiol thanks for the modul and help on installation. i have a 2.3.4.1 CE Shop and 2 languages. german and english. The english language links seem to work as far i can see (with /en/ in front of the alias), but the standard german category links behave different. Currently i cant get the Category link in standard language to work. it just shows www.xxxxx.de/?cPath=22 instead of the alias. i also tried to define a custom alias, but still get the ?cPath=22 for that standard language link. also, do i have to clear the cache after changing SFU settings or just when changes to aliases or products are made?
  11. any chance that this module will get an update to be able to use minfraud score/insights/factors ?
  12. strange! i moved with my bootstrapped oscommerce to a new server (debian9, php7, mariadb) and mysql session timeout does not work again. even with the modifications from your addon. but only in admin. catalog user sessions timout as expected. any idea where to look?

    Regards,

    Stephan

    1. Show previous comments  3 more
    2. Demitry

      Demitry

      In theory, it should work fine. I mean the only thing that admin panel session time entry is doing is being stored in the database table to be applied to the conditional statement in /admin/includes/functions/sessions.php to evaluate the time passed since the last page load.

      And, it's the exact same script for the catalog side.

      Let me know if you find out. I'm semi-technical and not that great with sessions. I'd be curious to know. Thanks.

    3. Stephan Gebbers

      Stephan Gebbers

      good to waste some time :/

      so, after forever trying to find whats wrong, i took a closer look into the application_top and login.php

      check that. 

      application_top.php

      // try to automatically login with the HTTP Authentication values if it exists
            if (!tep_session_is_registered('auth_ignore')) {
              if (isset($_SERVER['PHP_AUTH_USER']) && !empty($_SERVER['PHP_AUTH_USER']) && isset($_SERVER['PHP_AUTH_PW']) && !empty($_SERVER['PHP_AUTH_PW'])) {
                $redirect_origin['auth_user'] = $_SERVER['PHP_AUTH_USER'];
                $redirect_origin['auth_pw'] = $_SERVER['PHP_AUTH_PW'];
              }
            }

      and login.php

              if (tep_session_is_registered('redirect_origin') && isset($redirect_origin['auth_user']) && !isset($HTTP_POST_VARS['username'])) {
                $username = tep_db_prepare_input($redirect_origin['auth_user']);
                $password = tep_db_prepare_input($redirect_origin['auth_pw']);
              } else {
                $username = tep_db_prepare_input($HTTP_POST_VARS['username']);
                $password = tep_db_prepare_input($HTTP_POST_VARS['password']);
              }

      so, it is made by design not to expire when you use htaccess/htpassword function build in with administrators manager within oscommerce. you are getting logged in again and again until you press logoff or restart your browser where you would have to login by httpauth again.

      good to know :/ so now, without the build in htaccess/htpasswd function it works as expected. the session runs out and i have to relogin. 

      but one question lasts.. why did it not work as supposed to on my old server? :D

    4. Demitry

      Demitry

      yeah, that's good to know, ...I have not set up the htpassword protection on the new BS Edge development site for the admin login yet. So, I did not test that piece of it with the modified contribution, though I thought it should not make a difference.

      I'm not sure as to why it did not work on the other server. 

      I'll try and test it on my set-up at some point. Thank you for the follow-up.

      Demitry

       

  13. Stephan Gebbers

    Slim Checkout for BS

    https://github.com/gburton/Responsive-osCommerce/pull/237 well, at least it would explain where the code is coming from. i try to keep up with all changes of 2.3.4BS as good as possible, but i dont use github directly but insert changes manually or with "beyond compare". maybe i did not realize that "closed" means its not going into the projects code. well, at least we found this error now. anyway, thanks again for the title fix @raiwa :)
  14. Stephan Gebbers

    Slim Checkout for BS

    not modified, but i updatet it to the most recent version now (inlcuding hardcoded paths) ok, it seems the noscript ht module has been updated compared to my version of the module. i got the version from github to overwrite my version now. That seems to fix the problem finally :) it changed this line in the noscript module $oscTemplate->addContent('<noscript><div class="no-script"><div class="no-script-inner">' . MODULE_HEADER_TAGS_NOSCRIPT_TEXT . '</div></div></noscript>', 'navigation'); to $oscTemplate->addBlock('<noscript><div class="no-script"><div class="no-script-inner">' . tep_output_string(MODULE_HEADER_TAGS_NOSCRIPT_TEXT) . '</div></div></noscript>', $this->group);
  15. Stephan Gebbers

    Slim Checkout for BS

    see attached image
×