Jump to content

frankl

♥Ambassador
  • Content count

    891
  • Joined

  • Last visited

  • Days Won

    44

Reputation Activity

  1. Like
    frankl reacted to 14steve14 in Product Page Layout   
    have been having a bit of a play with this on a new version of Frozen. I thought others may like to see the results. There have been no core file changes, and apart from a bit of padding in the button code nothing has been changed. The layout is created by using the method that Gary explained further up the thread. The product price will be played with later as I need to convert some code to make the layout different as I need to show customers the savings on the actual price and the buying price.
    The description is under the image disclaimer, as will be the cross sell products, recently viewed and the reviews and what ever else will be tagged onto the end of the page. These may even be placed inside Garys 28 days of code tabs so will have to see what looks best.
     

  2. Like
    frankl got a reaction from azpro in iDeal via ideal-checkout   
    @azpro Mijn ouders zijn Nederlands, ze emigreerden hier in 1959. Daarom is mijn Nederlands slecht 😀
  3. Like
    frankl reacted to burt in Product Page Layout   
    @rulegacy Did you try the way I suggested.  I've just done that on a test site and it worked well.
    @14steve14 My way you'd just add the Tabs module as the very last sort order (eg 1000) and set width to 12. 
    I don't understand why people are advocating core code changes when it can be done with none?
  4. Like
    frankl reacted to burt in Product Page Layout   
    Totally do-able, it is exactly as @raiwa says.
    Gallery 10 6
    Name 20 6
    Model 30 3
    Price 40 3
    Attributes 50 6
    Buy 60 3
    Reviews 70 3
    Description 80 6
    You are constrained by the DEPTH of the Gallery, so place a minimum height on this using CSS which would be placed in user.css
    @media only screen and (min-width : 768px) {   div.cm-pi-gallery {     min-height: 1000px;   } } Change the min-height on this to better reflect your needs.
    You will then also need to amend tpl_ files for product_info, at the very least;
    remove clearfix from reviews button tpl restyle price as it would look weird as a h* Prior to the extra tpl_ change for price, you would end up with something like:

    Of course, how this would look in XS...is debatable, and that is why you can micromanage the layout using those tpl_ files if you so wish.  My system for these modules uses only the SM layer.... however, that micro-management is where things get really complicated really quickly and hence why I did not put that level of management into Core.
     
  5. Like
    frankl got a reaction from oscMarket in BS Slick Image Gallery Question - 2.3.4.1 CE Compatible Image Gallery Module for Product Info   
    I haven't played with this addon, I'm merely relaying a message.
    What happens if you comment out that line entirely?
     
  6. Thanks
    frankl got a reaction from oscMarket in BS Slick Image Gallery Question - 2.3.4.1 CE Compatible Image Gallery Module for Product Info   
    In that case try this:
    Replace:
     
    $slicks[] = array('image' => $product_info['products_image'], 'htmlcontent' => null ); with:
     
    $slicks[] = array(); on line 42
  7. Like
    frankl got a reaction from Bobber in BS Slick Image Gallery Question - 2.3.4.1 CE Compatible Image Gallery Module for Product Info   
    Apparently this is the solution:
    Just replace:
     
    $slicks[] = array('image' => $product_info['products_image'], 'htmlcontent' => null ); with:
     
    $slicks[] = ''; on line 42
  8. Thanks
    frankl got a reaction from oscMarket in BS4 admin   
    I can guarantee you that any store owner that receives more than a few orders a day has had to modify their admin.
    Modularity, classes, hooks etc are the way to go for admin.
  9. Thanks
    frankl got a reaction from oscMarket in BS4 admin   
    I can guarantee you that any store owner that receives more than a few orders a day has had to modify their admin.
    Modularity, classes, hooks etc are the way to go for admin.
  10. Like
    frankl reacted to burt in Best practice to replace Admin module(s)   
    Thought about this a bit more.  I recently made for a client a system of assigning "best" products in a category and manufactuer/brand. 
    I could have put that into the admin/categories.php page, but that page is kind of complicated...  
    Instead I put it in it's own page:

    What you see there (admin side):
    New box module & language file for "best products" sidebox [2 files] New box module & language file for "in brand" link in that sidebox [2 files] ditto "in category" link [2 files] New page & language file for assigning products to categories [2 files] New page & language file for assigning products to manufacturers [2 files] Shop side:
    new module for index_products which looks for assigned products and displays them appropriately  [2 files] All of the above is a long winded way of saying what you could do is leave the base functionality alone and instead have an extra page just doing the bits you want to add.  Although this is 12 extra files, there is no touching of core code and the amount of time spent creating those 12 files is perhaps a few minutes more than trying to implement it all in admin/categories.php
  11. Like
    frankl reacted to burt in BS Bundled products at a discount addon required   
    This is a difficult one, but let's think about it;
    I'm thinking the simplest way would be;
    Create new Product: "MASTER", this would have the bundle price, description etc New Page in admin which allows you to select a MASTER, then add SLAVE(s) to it. 
    SLAVES are your usual products.  This Master/Slave relationship would be contained in a new DB table. 
    You could even hold quantity in this Table (eg this master needs 2 of this slave, 3 of this slave, and 1 each of these slaves)

    So far so Good.
      Shop Side (product_info), detect if the product is a MASTER If yes, display the SLAVES (like is done on a normal product that shows "also_purchased")

    Customer Adds to Cart the MASTER and checks out.
      At the end of the checkout ALL customers *should* end up on checkout_success
    A small module here to reduce stock of SLAVES based on that Master/Slave relationship table. Per our conversation, you know I've made (in the distant past) something similar which was abandoned as pretty much unworkable.  That was back in 2010/2011 before we had much (any?) modularisation... and the problem was reducing stock when people went off to pay.  Now we are a bit modular...I think it can be done;
    New Page in Admin for selecting which products are Master Same page (or maybe a different page) for attaching Slave(s) to Master(s) New Module Shop Side to display Slaves when customer is looking at a Master New Module for reducing Stock at checkout_success It *should* be doable with no Core Code Changes, if it is kept fairly simple.
  12. Like
    frankl reacted to burt in Frozen to BSv4   
    Some type of images system would have been high up the to-do list for a future release (probably Final).  I think I've talked about it previously;
    shopowner uploads one large image it is resized to (say) 5 different resolutions and saved appropriately tep_image is updated to use srcset 
    srcset automatically works out which image is best shown at which resolution Maybe in some future code?
  13. Like
    frankl reacted to burt in Frozen to BSv4   
    @timray @Stephan Gebbers
    It's possible to do whatever is required.  But as this is a test project ... it is not likely to happen that I spend my time making tweaks.
  14. Like
    frankl reacted to burt in Frozen to BSv4   
    The whole of bsv4 is using flexbox.  I found cards quite difficult to get a handle on.  I wasn't able to easily make them responsive, eg;
    XS: 1 (in a row)
    SM: 2 
    MD: 3
    LG and XL:  4
    I did get that working (hard coded), but it seemed like a "hack" to have to do.  I will try to get that "hacked" code into a Module for the index page -> new products and clean it up a bit.
  15. Like
    frankl reacted to burt in Frozen to BSv4   
    New progress bars are now on the Test Site.  Obviously if you wish to see them, you need to be checking out.  If you are checking you need an account, please at least use a real email address so that my server doesn't bounce back undeliverable messages at me, thanks.  I hate seeing people test stuff and using (eg) wenvjowe@venvoevn.com type of bullcrap.  
    Hooks System
    For anyone who knows a bit about the Hooks system, this has had an overhaul so that it is now possible to pass parameters through hooks;
    EG: checkout_shipping.php
    <?php echo $OSCOM_Hooks->call('progress', 'progressBar', [Parameters]); ?> And on EG checkout payment all you need to do is pass through a different Parameter, and that increases the display of the progress bar.  Henceforther shopowners/developers can have two or more pages using the same Listener...just passing thru a different Parameter.  And, even better, no limit on the what Parameters you want to pass through to your Listeners. #forward #we #go
  16. Like
    frankl got a reaction from Tsimi in Advanced Specials   
    https://apps.oscommerce.com/Gsxm9&advanced-special-offers-and-discounts-fo
    Let me know if you have any problems.
  17. Like
    frankl reacted to burt in Who in the EU has heard of GDPR and will it affect you   
    @14steve14
    Obviously with a backup done first!!  This first query is the "Master Blaster"...
    delete from customers where customers_id not in (select customers_id from orders) and customers_newsletter = 0 that will remove all customers that have never made an order AND are not a subscriber.
    You then need to clean out other tables, and we know that any ID that does not exist in the customers table, should not exist anywhere else;
    delete from action_recorder where user_id NOT IN (select customers_id from customers); delete from address_book where customers_id NOT IN (select customers_id from customers); delete from customers_basket where customers_id NOT IN (select customers_id from customers); delete from customers_basket_attributes where customers_id NOT IN (select customers_id from customers); delete from customers_info where customers_info_id NOT IN (select customers_id from customers); delete from products_notifications where customers_id NOT IN (select customers_id from customers); delete from whos_online where customer_id NOT IN (select customers_id from customers); delete from reviews where customer_id NOT IN (select customers_id from customers); delete from reviews_description where reviews_id NOT IN (select reviews_id from reviews);  
    And that should do it. But all of this is UNTESTED...
  18. Like
    frankl reacted to MrPhil in Frozen   
    It will happen only if Harald (who owns osC and this site) wishes for it to happen. He has given no indication that he does. Last August he promised a 2.3.5 upgrade release of some sort, and 2.3.6 (the CE version), within a few weeks, and it's been 8 months now. No one has heard from him in over 3 months, and we're starting to wonder if he's still above the grass. Anyone holding their breath, waiting for something to happen, is very blue by now. Most people have given up and are moving on to other projects. It's unfortunate, and even tragic (given the amount of work that he and others have put in), but he just does not know how to run a major project. You can not disappear for years at a time, crafting your solo personal project to perfection, and then suddenly present it for the world to ooh and aah over. The current offering has to be kept alive and updated and supported, and this just has not been happening.
  19. Thanks
    frankl reacted to burt in Frozen   
    Frozen is now in Sunset Status with EOL slated for 31/12/2019.  
    --
    https://github.com/gburton/Responsive-osCommerce/releases/tag/2341-Frozen
    There will be no further Code Changes.
    Issues will be immediately closed.
    What is broken, stays broken. PRs will be immediately closed.
    What is now there, is there. Thank You to all Shopowners and Developers who have supported the Project in the last 4 and a bit years. 
    Personal Thanks go out to all those Shopowners who were able to support my 28d bits and pieces for 3 of those 4 years - it is you guys who have made it possible for the hundreds of other Shopowners to continue using osCommerce.  A big Thank You and  from me, I will not leave you guys high and dry - you have my support always, we are a Band Of Brothers.
    Onwards!
  20. Thanks
    frankl got a reaction from raiwa in Anyone made a module for Afterpay or Zippay (Australia)   
    @raiwa
    I could never get the API to connect, and didn't get any help from Zippay.
  21. Like
    frankl reacted to burt in Modular Checkout   
    I plan on fixing a Final, then doing 1 round of bugfixes.  Anything not noticed or not fixed...stays broken.
    It's time for a change.
  22. Like
    frankl got a reaction from oscMarket in osCommerce Online Merchant Community 2.4 Edition   
    Anyone up for it?
    With the limitations of 2.3.4 becoming more evident and a lack of progress from the official branch making it difficult to move forward, we should "go it alone" on 2.4. 
    @burt has done a fantastic job of the Community Version so far but improving 2.3.4 any further isn't worth the effort, as he's already indicated by making it Final.
    I feel effort would be better spent on software more suitable for everyone.
    We have the basic building blocks:
    1. The software - https://www.oscommerce.com/Products
    2. How to build an app step by step - 
    3. Documentation - https://library.oscommerce.com/Online&en&oscom_2_4&developers
    We would need commitment from community members to make it happen!
    Already done according to the documentation:
    OSC\OM Framework
    Introduce a framework to replace legacy classes and functions with.
    Bootstrap Frontend Framework
    Replace the jQuery UI based Shop, Admin, and Setup frontend with Bootstrap.
    Self-Contained Apps
    Introduce self-contained Apps with support for self-defined modules and url routes.
    Hooks
    Introduce hook calls.
    Online Updates
    Introduce an online update feature for the core.
    INI Style Language Definitions
    Move the language definitions to ini style files.
    Still needs to be done (according to the documentation):
    Legacy Cleanup
    Move core modules to an osCommerce App.
    Migrate remaining classes to the new framework, including:
    Breadcrumb Currencies Language Message Stack Navigation History Shopping Cart SEO
    Introduce SEO features. Database Schema Comparison
    Introduce a database schema comparison tool existing store owners can use as part of their upgrade. Hook Action Calls
    Finalize hook action calls throughout the codebase. Online Updates
    Extend the online update feature to installed Apps. App Browser
    Introduce an online App browser and installer. Language Packs
    Support community maintained language packs and provide a list of ready to be used languages in the setup routine. Legacy Compatibility Module
    Automatically re-map legacy v2.3 classes, functions, and code to the new framework for compatibility with existing v2.3 add-ons. ------------------------------
    There would be a problem with the online app browser, installer and update feature of course, as that hasn't been implemented anywhere yet.
    There is also a hidden templating feature which would need to be worked on. There are templates for:
    Admin - includes/OSC/Sites/Admin/Templates/Sail
    Store - includes/OSC/Sites/Shop/Templates/Sail
    There would need to be admin to install and switch templates. I can't see that in the current code.
     
    So, I think the most important thing to do first would be to analyse what is important, what should be added (product, products, customer classes for instance?), what can be ported from 2.3.4 Community Edition (updated breadcrumb module etc) and then exactly what needs to be done. After that, a roadmap can be created.
    Time to leave 2.3.4 Community Edition behind and start on something new.
    Comments? Thoughts?
     
     
     
       
  23. Like
    frankl got a reaction from oscMarket in osCommerce Online Merchant Community 2.4 Edition   
    Anyone up for it?
    With the limitations of 2.3.4 becoming more evident and a lack of progress from the official branch making it difficult to move forward, we should "go it alone" on 2.4. 
    @burt has done a fantastic job of the Community Version so far but improving 2.3.4 any further isn't worth the effort, as he's already indicated by making it Final.
    I feel effort would be better spent on software more suitable for everyone.
    We have the basic building blocks:
    1. The software - https://www.oscommerce.com/Products
    2. How to build an app step by step - 
    3. Documentation - https://library.oscommerce.com/Online&en&oscom_2_4&developers
    We would need commitment from community members to make it happen!
    Already done according to the documentation:
    OSC\OM Framework
    Introduce a framework to replace legacy classes and functions with.
    Bootstrap Frontend Framework
    Replace the jQuery UI based Shop, Admin, and Setup frontend with Bootstrap.
    Self-Contained Apps
    Introduce self-contained Apps with support for self-defined modules and url routes.
    Hooks
    Introduce hook calls.
    Online Updates
    Introduce an online update feature for the core.
    INI Style Language Definitions
    Move the language definitions to ini style files.
    Still needs to be done (according to the documentation):
    Legacy Cleanup
    Move core modules to an osCommerce App.
    Migrate remaining classes to the new framework, including:
    Breadcrumb Currencies Language Message Stack Navigation History Shopping Cart SEO
    Introduce SEO features. Database Schema Comparison
    Introduce a database schema comparison tool existing store owners can use as part of their upgrade. Hook Action Calls
    Finalize hook action calls throughout the codebase. Online Updates
    Extend the online update feature to installed Apps. App Browser
    Introduce an online App browser and installer. Language Packs
    Support community maintained language packs and provide a list of ready to be used languages in the setup routine. Legacy Compatibility Module
    Automatically re-map legacy v2.3 classes, functions, and code to the new framework for compatibility with existing v2.3 add-ons. ------------------------------
    There would be a problem with the online app browser, installer and update feature of course, as that hasn't been implemented anywhere yet.
    There is also a hidden templating feature which would need to be worked on. There are templates for:
    Admin - includes/OSC/Sites/Admin/Templates/Sail
    Store - includes/OSC/Sites/Shop/Templates/Sail
    There would need to be admin to install and switch templates. I can't see that in the current code.
     
    So, I think the most important thing to do first would be to analyse what is important, what should be added (product, products, customer classes for instance?), what can be ported from 2.3.4 Community Edition (updated breadcrumb module etc) and then exactly what needs to be done. After that, a roadmap can be created.
    Time to leave 2.3.4 Community Edition behind and start on something new.
    Comments? Thoughts?
     
     
     
       
  24. Like
    frankl got a reaction from burt in Addon installer concept   
    @piernas You touched on this a little, but the sad thing is that 2.4 makes addons ultra easy to install and uninstall. It almost makes me cry to see the wasted opportunity there.
  25. Like
    frankl got a reaction from burt in Addon installer concept   
    @piernas You touched on this a little, but the sad thing is that 2.4 makes addons ultra easy to install and uninstall. It almost makes me cry to see the wasted opportunity there.
×