Jump to content
Latest News: (loading..)

rulegacy

Members
  • Content count

    11
  • Joined

  • Last visited

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. rulegacy

    PCI Compliance

    We use this. Perhaps it does write to the database (those 4 fields are still present in Frozen, by the way). We did consider switching to Sage Pay but all apps seem to be dated. Is anyone here using these? As for the cookie, is it possible to set the secure tag permanently? This issue affects everyone accepting cards in the U.S. and should be given as much attention as GDPR for those serving EU customers.
  2. rulegacy

    PCI Compliance

    @John W How do you (and any other U.S. merchants) deal with card data storage? Have you removed those 4 entries from the orders table and maybe something else as well?
  3. rulegacy

    PCI Compliance

    Stock orders database table contains 4 cc_ fields intended for data that may not actually be stored as per PCI DSS. Is it safe to remove those so that our card payment module couldn't write there? Recent PCI scan flagged osCsid as a cookie missing the "secure" flag. Our PCI vendor states that an exception request may only be granted if we attest that the cookie is not a session cookie. Since we know that it is, what could be done about this?
  4. Just an update to say that we have managed to get the desired layout without any core code changes as suggested by @burt. So don't touch the core. One thing we'd like to correct though is how price jumps under model in xs view. We do have both wrapped in p tags inside divs now.
  5. @burt Yes. We had it exactly as in your screenshot but the buy/review buttons and the module below it (we tried tabs in place of stock description) get overlayed in XS view. As seen in your screenshot, model/price also aren't on the same line as we want them to be. We are all for changes without touching the core but it seems trickier than expected. Either that or we are missing something.
  6. @BrockleyJohn Tried that but no progress. Does anything else stand out from the code?
  7. @BrockleyJohn Thank you so much. Finally got it. The only thing to correct is to make model and price sit on the same line as opposed to how it is now (image attached). They are currently set at 6/6 width. We tried floating template divs without success. On a completely separate but related note, we'd also like to include a reviews block (see image) right under the product name. Taking code from our current website (based on a ready-made theme), we converted it to a version with hardcoded links but something else is missing for it to work correctly. Perhaps the $HTTP_GET_VARS bit? <div itemprop="review" itemscope itemtype="http://data-vocabulary.org/Review-aggregate" class="reviews-box"> <?php $reviews_query = tep_db_query("select count(*) as count, r.reviews_rating from " . TABLE_REVIEWS . " r, " . TABLE_REVIEWS_DESCRIPTION . " rd where r.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and r.reviews_id = rd.reviews_id and rd.languages_id = '" . (int)$languages_id . "' and reviews_status = 1"); $reviews = tep_db_fetch_array($reviews_query); $review_query_rating = tep_db_query("SELECT ROUND(SUM(`reviews_rating`)/COUNT(`reviews_id`)) as rating FROM " . TABLE_REVIEWS . " WHERE products_id = '" . $product_info['products_id'] . "' AND `reviews_status` = 1"); $review_rating = tep_db_fetch_array($review_query_rating); if ($reviews['count'] == 0) { echo '<p class="no-rating">' .tep_draw_button(NO_RATING, 'comment', tep_href_link('product_reviews_write.php', tep_get_all_get_params()), 'primary').'</p>'; } else { echo '<div class="rating-stars"> '.rating_output($product_info['products_id']).'&nbsp;&nbsp;&nbsp;&nbsp; <a class="reviews_link" href="'.tep_href_link('product_reviews.php', 'products_id=' . $product_info['products_id']).'"><span itemprop="count">'.$reviews['count'].'</span>&nbsp;'.MENU_TEXT_REVIEWS.'</a>&nbsp;&nbsp;<span>|</span>&nbsp;&nbsp; '.tep_draw_button(ADD_REVIEW, 'comment', tep_href_link('product_reviews_write.php', tep_get_all_get_params()), 'primary').' </div>'; } ?> </div> ************ We also added the following function to includes/functions/general.php function rating_output($products_id) { $rating = ''; $review_query = tep_db_query( "SELECT ROUND(SUM(`reviews_rating`)/COUNT(`reviews_id`)) as rating FROM " . TABLE_REVIEWS . " WHERE products_id = '" . (int)$products_id . "' AND `reviews_status` = 1"); $review = tep_db_fetch_array($review_query); if ( !empty($review['rating']) ) { $rating .= '<strong>'; for ($i = 1; $i <= $review['rating']; $i ++) { $rating .= '<i class="icon-star"></i>'; } $rating .= '</strong>'; $k = 5 - $review['rating']; for ($j = 1; $j <= $k; $j ++) { $rating .= '<i class="icon-star"></i>'; } } else { $rating = ' <i class="icon-star"></i> <i class="icon-star"></i> <i class="icon-star"></i> <i class="icon-star"></i> <i class="icon-star"></i> '; } return '<div class="rating">'.$rating.'</div><meta itemprop="rating" content="'.$review['rating'].'" />' ; } Any advice would be greatly appreciated.
  8. @BrockleyJohn Thank you. Having done this, we used the following to arrange the columns but the modules are still all over the place. Do we want to use different CSS rules for both the row div and individual module divs in tpl files? Also how do we reset certain rules for XS view so that major parts are underneath one another? <div class="product-row"> <div class="col1"><?php echo $oscTemplate->getContent('product_info'); ?></div> <div class="col2"><?php echo $oscTemplate->getContent('product_info2'); ?></div> </div> .product-row {column-count:2;}
  9. @Hotclutch Could you please share how we would go about specifying what rows (modules) go into either of those columns? This must be basics but we would like to start somewhere. Many thanks in advance.
  10. Thank you all for chiming in. So far we have attempted to implement the changes suggested by @burt and see that buy/review buttons do get overlayed in smaller viewports despite attempts to pull or clear divs using CSS. That would be the main usability issue. Aestheticly, we'd prefer to have model/price on the same line but haven't been able to achieve that through styling either. Given the mobile view issues, is the two-module approach the way to go or could the template styling still get us there? Perhaps we are just not applying the styles correctly.
  11. We would like to set up the shown layout in Frozen on desktop. Having tried multiple variations of sort order and width for the respective modules, we are yet to achieve our goal. Either modules refuse to be positioned next to each other or run under gallery. Is this possible with stock means or do we want to employ styling as well? Any insight would be greatly appreciated.
×