Jump to content

Gyakutsuki

♥Ambassador
  • Content count

    713
  • Joined

  • Last visited

  • Days Won

    14

Reputation Activity

  1. Like
    Gyakutsuki got a reaction from valquiria23 in Vendor Login   
    @LeeFoster To make something in B2B, it's not so simple, some sql request must change, some function and classes must be changed. It's a big work, it's not to add just a module. It's more complex.
    Osc is correct for the B2C, as I said, there is some other e-commerce solution has this function very well implemented.
     
  2. Like
    Gyakutsuki reacted to Harald Ponce de Leon in Legacy Code and PHP 7.3 Compatibility Checks (HOWTO)   
    Hi All..
    Here are instructions on how to check how compatible your online store installation / PHP code is against all PHP versions from 5.0 up to the latest version (currently 7.3). This guide requires a minimum PHP 5.4 version to run.
    This is a medium level skill guide and requires the installation of Composer - a dependency manager for PHP that manages the installation and updates of third party libraries. I will link to the installation instructions of Composer instead of writing how to install it here.
    It's possible to perform this guide either remotely on the web server in a ssh terminal, or locally on a backup copy of the PHP code.
    Step 1 - Install Composer
    Composer can be installed on Windows, Linux, Mac, and Unix. If you're installing on Linux, there may be a Linux distribution package that can be installed depending on your access privileges on the server, otherwise a manual installation is required. The manual installation can be performed locally in your home directory without special user permissions.
    Instructions for how to install Composer on Windows can be found here:
    https://getcomposer.org/doc/00-intro.md#installation-windows
    Instructions for how to install Composer on Linux, Mac, and Unix can be found here:
    https://getcomposer.org/doc/00-intro.md#installation-linux-unix-macos
    Step 2 - Create Composer Project File
    Composer needs to create a composer project file in the directory where your online store installation or PHP code resides. This will create two files that will be publicly accessible through the web server - this will not pose any security issues. The setup will also eventually create a "vendor" directory however Composer will be configured to place this in the "includes" directory to block public web server requests to the directory.
    Copy and paste the following to composer.json in the directory where your online store installation resides:
    { "config": { "vendor-dir": "includes/thirdparty/composer" }, "require-dev": { "squizlabs/php_codesniffer": "^3.4", "phpcompatibility/php-compatibility": "^9.2" } } Step 3 - Install PHP_CodeSniffer
    PHP_Codesniffer detects violations of defined rules in your code. There are several coding standard rule sets available to make sure each PHP file meets the coding standards. There is no rule set currently available for OSCOM v2.x - for v3 the PSR12 rule set is used.
    As there will be a lot of violations running this with a coding standard, we will instead run it to use only one rule set to check compatibility against the latest PHP version. We will also configure PHP_CodeSniffer to ignore certain violations which is already taken care of in the online store installation.
    Run the following command to install PHP_CodeSniffer:
    composer install After this installs PHP_CodeSniffer and the PHP Compatibility rule set, a PHP_CodeSniffer configuration file will be created to configure the rule set that should be used.
    Copy and paste the following to phpcs.xml in the directory where your online store installation resides:
    <?xml version="1.0"?> <ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" name="PHP_CodeSniffer" xsi:noNamespaceSchemaLocation="phpcs.xsd"> <description>The coding standard for osCommerce.</description> <file>.</file> <exclude-pattern>*/includes/thirdparty/*$</exclude-pattern> <arg name="basepath" value="."/> <arg name="colors"/> <arg value="nps"/> <rule ref="PHPCompatibility"/> <config name="installed_paths" value="includes/thirdparty/composer/phpcompatibility/php-compatibility" /> </ruleset> Step 4 - Run PHP_CodeSniffer
    PHP_CodeSniffer can now be executed with the following command. It will automatically use the configuration file created in step 3:
    ./includes/thirdparty/composer/bin/phpcs which will produce the following output report:
    FILE: admin/includes/functions/compatibility.php --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AFFECTING 12 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 32 | ERROR | Global variable '$HTTP_GET_VARS' is deprecated since PHP 5.3 and removed since PHP 5.4; Use $_GET instead (PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_get_varsDeprecatedRemoved) 33 | ERROR | Global variable '$HTTP_POST_VARS' is deprecated since PHP 5.3 and removed since PHP 5.4; Use $_POST instead (PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_post_varsDeprecatedRemoved) 34 | ERROR | Global variable '$HTTP_COOKIE_VARS' is deprecated since PHP 5.3 and removed since PHP 5.4; Use $_COOKIE instead | | (PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_cookie_varsDeprecatedRemoved) FILE: admin/includes/functions/database.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 25 ERRORS AFFECTING 24 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 179 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead (PHPCompatibility.Extensions.RemovedExtensions.mysql_DeprecatedRemoved) 181 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead (PHPCompatibility.Extensions.RemovedExtensions.mysql_DeprecatedRemoved) 185 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead (PHPCompatibility.Extensions.RemovedExtensions.mysql_DeprecatedRemoved) Here we can see which files violate a PHP Compatibility rule set, the line in the file where the violation occurs, the reason for the violation, and the actual rule set that was violated that we'll be using to ignore the false positive reports with.
    In the example output, it states that $HTTP_GET_VARS, $HTTP_POST_VARS, and $HTTP_COOKIE_VARS are deprecated since PHP 5.3 and are still used in your online store installation. This is a false positive as osCommerce Online Merchant already has its own implementation to work with or around it. In this case, the variables are safely defined in admin/includes/functions/compatibility.php and includes/functions/compatibility.php.
    It also states that "mysql_" is deprecated in PHP 5.5 and still used in the online store installation. This is also a false positive as osCommerce Online Merchant wraps calls to the "mysql_" functions if "mysqli" does not exist.
    We'll add to the PHP_CodeSniffer configuration the rules that can be ignored. The rules can be seen in the output report in brackets ( ). Below is an updated phpcs.xml file with a list of rules being safely ignored for a osCommerce Online Merchant v2.3.4.1 installation:
    <?xml version="1.0"?> <ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" name="PHP_CodeSniffer" xsi:noNamespaceSchemaLocation="phpcs.xsd"> <description>The coding standard for osCommerce.</description> <file>.</file> <exclude-pattern>*/includes/thirdparty/*$</exclude-pattern> <arg name="basepath" value="."/> <arg name="colors"/> <arg value="nps"/> <rule ref="PHPCompatibility"/> <config name="installed_paths" value="includes/thirdparty/composer/phpcompatibility/php-compatibility" /> <rule ref="PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_get_varsDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_post_varsDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_cookie_varsDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_session_varsDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_server_varsDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_post_filesDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.Extensions.RemovedExtensions.mysql_DeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.IniDirectives.RemovedIniDirectives.session_bug_compat_42DeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.IniDirectives.RemovedIniDirectives.session_bug_compat_warnDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.FunctionUse.RemovedFunctions.session_registerDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.FunctionUse.RemovedFunctions.session_is_registeredDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.FunctionUse.RemovedFunctions.session_unregisterDeprecatedRemoved"> <severity>0</severity> </rule> <rule ref="PHPCompatibility.FunctionUse.RemovedFunctions.mysql_escape_stringDeprecatedRemoved"> <severity>0</severity> </rule> </ruleset> Please remember that a lot of false positives will be reported and will need to be individually checked to see if a workaround exists in the PHP code. Additional rules to ignore can be added to the PHP_CodeSniffer configuration file.
    Happy PHP 7.3 incompatibility hunting!
  3. Like
    Gyakutsuki got a reaction from valquiria23 in Naming Convention   
    @HPDL,
    Automatic updates will first arrive with v3 and v3 based CE releases Just a question. The 2.4 is stopped or it will be finished ?
  4. Like
    Gyakutsuki got a reaction from valquiria23 in How to expand the field "Product Name" in admin.   
    Look your Db and the varchar product name. You can change the number until 255.
     
  5. Like
    Gyakutsuki reacted to valquiria23 in version with php7.2   
    @Heatherbell
    If you do not like some addons do not use them, you did not pay for it and therefore you can not complain. It seems to me that you should apologize to that person to whom several others are very grateful.
    I appreciate if the administrators ( @Dan Cole  @Harald Ponce de Leon  @burt can make disappear these last unnecessary comments that are only to offend.
    Best regards.
    Valqui
  6. Like
    Gyakutsuki reacted to JcMagpie in Support thread for JcM Tart GDPR-cookie-widgets V1.0   
    Tart GDPR-cookie-widgets V1.0
    I have to thank @Gyakutsuki for all his help with this add-on and especially the multilingual code.
    let’s you add a cookie widget to your site. This will allow your customer to refuse cookies if they wish to and let you comply with legislation.
    What you allow will depend on who you are and what legal requirements you need to comply with. It is imposable to make an add-on that will work out of the box for all shops.
    So this has 2 modules, one is a header_tag which installs the main script which loads the main js and makes language selection. The other is a footer_suffix which allows you to enter the custom scripts for your cookies.
    You have 10 input boxes in footer_suffix admin to enter custom scripts. You do not need to use all 10, these are just to make management easy for most shops who will need only a few so can enter one into each box.
    If you need more than ten then just add extras all into one box.
    Included in the files is a list of some of the main scripts needed.
    Simply copy from <script to </script> and paste into input box and save.
    <script type="text/javascript">
    (tarteaucitron.job = tarteaucitron.job || []).push('adsense');
    </script>
     
    That’s all that is required. If you need more scripts then go to this website and search for the one you need.
    https://opt-out.ferank.eu/en/install/
    The script is multilingual but I have only added a few to the code. These are in the header_tag class so if you need more you can edit it and add them.
     
    $language_code == 'fr' ||
    $language_code == 'en' ||
    $language_code == 'nl' ||
    $language_code == 'de' ||
    $language_code == 'es' ||
    $language_code == 'it' ||
    $language_code == 'pt' ||
    $language_code == 'pl' ||
    $language_code == 'ru' ) {
     
    That’s it again as always copy everything over into correct directory's don't forget to copy the new js files to ext.
    Then go into admin and install and set up the 2 modules. You have to have both installed and set up. The rest is straightforward and should be self explanatory.
     
     
    Enjoy.



     
    Auto detect shop language.



  7. Like
    Gyakutsuki got a reaction from valquiria23 in Support thread for JcM GDPR & info Modal tabs V1.2   
    @JcMagpie
    Cool  You are a pro now !
  8. Thanks
    Gyakutsuki got a reaction from valquiria23 in Support thread for JcM GDPR & info Modal tabs V1.2   
    @valquiria23
    I have a conversation by email about that with JC. This is this contribution and I let him to decide what it wants to propose or not.
    If JC wants help because it has a problem, it can ask. I will be there. ('same with my little time !!)
  9. Thanks
    Gyakutsuki got a reaction from valquiria23 in Support thread for JcM GDPR & info Modal tabs V1.2   
    @valquiria23
    I have a conversation by email about that with JC. This is this contribution and I let him to decide what it wants to propose or not.
    If JC wants help because it has a problem, it can ask. I will be there. ('same with my little time !!)
  10. Like
    Gyakutsuki got a reaction from valquiria23 in Support thread for JcM GDPR & info Modal tabs V1.2   
    @valquiria23
    I don't look a code. It's just a critic to improve the modules.
    Mappy proposes to make a specific cookie because every shop owner has their needs. It can be an orientation also.
    There is no one way
  11. Like
    Gyakutsuki got a reaction from valquiria23 in Addon Feedback   
    Quality depends what do you want to include  ?
    Code or not, idea or not.
    Code :
    You can have a professional code make without OsCommerce knowledge  
    Professional coder knowing the osC ecosystem.
    It's not the same thing, not the same approach but in the both of case, the code is well coded.  Bad or good rating ?

    Beginner: You have people want to start to know php, people want to start and try change something inside the shop and at the end to share. Always bad rating ?
    Value : Again depends on the definition : For one can be nice, for another can be nothing. Bad or good rating ?  You can sell / create community  add on, without no value for the shop owner, no ?

    A forum needs dynamic people and create activity and attract some other people. Positive thinking, not bad thinking a forum must have. Do we have that ?
    Destroy someone because this participation is very important is no good for the forum (for any reason), it's no good for the community no good for the mentality. It's not a good sign.

    I prefer a rating like that :
    Works or not works with the lastest core : Yes / No. (In this case the script must be rewritten. All the script has obsolescence).
    Coding osC ecosystem ready : Yes / No
    Core modification : Yes / no
    The best approach is to create a thread, write a little comment and ask the community to verify the add on is correct or not. Some people can test, some people can look the look the cde and make comment.
    Collaboration, share, positive attitude is the best to create a dynamic.
    After a beginner can contact a "professional" by email and can ask to advise by a comment on the forum.



     
  12. Like
    Gyakutsuki got a reaction from valquiria23 in Addon Feedback   
    Quality depends what do you want to include  ?
    Code or not, idea or not.
    Code :
    You can have a professional code make without OsCommerce knowledge  
    Professional coder knowing the osC ecosystem.
    It's not the same thing, not the same approach but in the both of case, the code is well coded.  Bad or good rating ?

    Beginner: You have people want to start to know php, people want to start and try change something inside the shop and at the end to share. Always bad rating ?
    Value : Again depends on the definition : For one can be nice, for another can be nothing. Bad or good rating ?  You can sell / create community  add on, without no value for the shop owner, no ?

    A forum needs dynamic people and create activity and attract some other people. Positive thinking, not bad thinking a forum must have. Do we have that ?
    Destroy someone because this participation is very important is no good for the forum (for any reason), it's no good for the community no good for the mentality. It's not a good sign.

    I prefer a rating like that :
    Works or not works with the lastest core : Yes / No. (In this case the script must be rewritten. All the script has obsolescence).
    Coding osC ecosystem ready : Yes / No
    Core modification : Yes / no
    The best approach is to create a thread, write a little comment and ask the community to verify the add on is correct or not. Some people can test, some people can look the look the cde and make comment.
    Collaboration, share, positive attitude is the best to create a dynamic.
    After a beginner can contact a "professional" by email and can ask to advise by a comment on the forum.



     
  13. Thanks
    Gyakutsuki reacted to valquiria23 in Addon Feedback   
    This topic has a double intention, the first is visible, very logical and necessary. The continuous improvement makes man grow and perfect himself.
    But there is a hidden second intention and it is rediculizing and humiliating @JcMagpie and that does not seem good to me.
    You can not compare the work of an amater who is making his first addons with the addons of a professional coder that there is not even an addon updated in the store .....
    Instead of encouraging @JcMagpie for his contributions and his  attempts to improve the community, yo all only criticizing him.
    Better when you see an addon with errors report it, propose solutions and upload them to the store. I only see criticism and criticism and in the middle $$$.
    @burt, another thing, the site http://www.oscbooks.com/ is down.
    It is not good to have links to partners that when you arrive at them site, the site are fallen or broken,  
    Best regards.
    Valqui
  14. Thanks
    Gyakutsuki got a reaction from Cory_C in Square Payments Plugin for osCommerce   
    Remove this request and use only 
    MODULE_PAYMENT_SQUARE_APPLICATION_ID
  15. Thanks
    Gyakutsuki got a reaction from Cory_C in Square Payments Plugin for osCommerce   
    Remove this request and use only 
    MODULE_PAYMENT_SQUARE_APPLICATION_ID
  16. Like
    Gyakutsuki got a reaction from JcMagpie in Laravel Ecommerce System   
    Magento stores on an AWS micro or Digital Ocean $10 instances
    The case of there is a hosting platform, the price is less. It's very good when you start a new e-commerce and you don't want to know the technics. Shopify has a nice success on that.
    The problem appears when you start to make some money when you begin to have some visitors or a specific need in function of your business model.
    It's always the same thing, when you begin to have more success you want to improve the production and competivity. For that, you must customize the tool and the problem begin.
    It's right the tool has now an upgrade, wordpress system is very good under the condition your respect to not change anything inside the tool.
    the current osc2.3.x does'nt allow that. The 2.4 yes but ...
    In summary, there is always an advantage and an inconvenient. Now what is acceptable for you ?

     
  17. Like
    Gyakutsuki got a reaction from JcMagpie in Laravel Ecommerce System   
    Magento stores on an AWS micro or Digital Ocean $10 instances
    The case of there is a hosting platform, the price is less. It's very good when you start a new e-commerce and you don't want to know the technics. Shopify has a nice success on that.
    The problem appears when you start to make some money when you begin to have some visitors or a specific need in function of your business model.
    It's always the same thing, when you begin to have more success you want to improve the production and competivity. For that, you must customize the tool and the problem begin.
    It's right the tool has now an upgrade, wordpress system is very good under the condition your respect to not change anything inside the tool.
    the current osc2.3.x does'nt allow that. The 2.4 yes but ...
    In summary, there is always an advantage and an inconvenient. Now what is acceptable for you ?

     
  18. Like
    Gyakutsuki got a reaction from valquiria23 in Laravel Ecommerce System   
    @JcMappie, Ok Magento but for a little company go in this way it's crazy; The problem for this tool is the development and the maintenance. It's very expansive and need a specific knowledge if you want good performance.
    It's cool to present a framework like Laravel, or e-commerce platform like Magento, but there some solution like OpenCart, ClicShopping,  LiteCart ... can make a  best job without a big investment.
    Now the shopowner must evaluate what the need and what the evolution it wants.  It doesn't want to do anything, Shopify or similar can be very good,  to be more independent, it's another tool.
    The last thing is to take into consideration is the technology ecosystem and the maintenance for this ecosystem. Some tools can be good in a first approach, but in the time o be a disaster when you make a migration (example, prestashop) or an upgrade (odoo).
     
  19. Like
    Gyakutsuki got a reaction from valquiria23 in which payment module do you use in your shop ?   
    Hello,
    I would know with which modules do you use in shop.
    Depends on your location, you can use only a bank module or virtual bank (paypal ...).
    So you also can propose one or several.
    In your opinion how many payment solution must be proposed inside your shop to help to customer to make this choice and what is the most important payment solution to integrate inside a shop ?
     
  20. Like
    Gyakutsuki reacted to tgely in Who in the EU has heard of GDPR and will it affect you   
    Cookie Consent for CE BS version:
    https://github.com/Gergely/oscommerce_ce/compare/cookie_consent
     
  21. Like
    Gyakutsuki reacted to tgely in Who in the EU has heard of GDPR and will it affect you   
    Consent Cookies Managment are testing now so this could be used later in the official core. I have tried as close as possible to oscTemplate class and later this could be pull into oscTemplate.

    What core changes need?
    Cookie sensitive modules need a built in public array variable where defined the cookie consent group and apply the settings from oscConsent cookie and module have to use cookie managment logic oscTemplate class rebuild for cookie managments (next step now I use cooki_consent separated class) The best would be one footer modal module for user settings or cookie consent managment user page. Introduce oscConsent cookie  
    All modules could listing on consent setting page as Strict, Functional and 3.parties when cookie consent group variable is declared in self class body

    Functional cookies in generally from javascripts or 3. parties cookies deleted automatically when user switch off them so this will be GDPR complaint.
    If you have non cookie consent logic follow modules then you could change it later as developer implements this logic but this is not a big work.

    I will push cookie consent introduce commit at this weekend and we will be able to discuss oscTemplate implementations on next week.
  22. Thanks
    Gyakutsuki got a reaction from oscMarket in Addon installer concept   
    Impressive development :)
  23. Like
    Gyakutsuki got a reaction from tgely in Who in the EU has heard of GDPR and will it affect you   
    @tgely
    Let me more time to demonstrate something == I don't know ! :) Waiting
     
     
     
  24. Like
    Gyakutsuki reacted to tgely in Who in the EU has heard of GDPR and will it affect you   
    I keep my promise. First is v2.4
    https://github.com/osCommerce/oscommerce2/commit/ad48280d799f1a5fe61928b65dd0b6991d2d7c6f
  25. Like
    Gyakutsuki reacted to piernas in Admin responsive sidebar with bootstrap   
    This is a admin sidebar that replaces the stock menu. It can be expanded or condensed on a column of icons. It also adds bootstrap framework to admin. Hope you enjoy it.
    Please comment here if you have any improvements or find any problem.
    Download: https://apps.oscommerce.com/ebjVY&admin-responsive-sidebar-with-bootstrap


×