Jump to content

Gyakutsuki

♥Ambassador
  • Content count

    727
  • Joined

  • Last visited

  • Days Won

    15

Everything posted by Gyakutsuki

  1. Gyakutsuki

    Easy Upload Module

    If you use .phar, .xpi ... that 's the same problem ? it does'nt change with the actual process, just it's more simple. Also, lot of people download the zip and if there is a pb with a zip,allthe communauty will known quickly ? For example, with worldpressyou can download a zip since your own site, you don't know how to do the program and what it is inside ? To have a good system, a community manager must verify the every add on like prestashop do but it's not free. No is perfect. But if you have idea to do a best security, I am interesting.
  2. Gyakutsuki

    Easy Upload Module

    Tk Gergely for comments tep_CanonicalUrl () ==> include inside add on now (not tested butmust work) tep_image_button() change by tep_draw_button ==> done menu access module upload ==> done At this moment the question is who authenticate the modules for the uploader? I think the process must become a best pratice for all. That's the only way to have an homogene environment for the modules. The communication must be important like a post it to explain how to create a module. I created a new package including the comments.
  3. Gyakutsuki

    Easy Upload Module

    No other opinion ? Very easy to install for test, inside the contribution, I inserted an example to test.
  4. Gyakutsuki

    Modal Info Popup Layer for osc 2.3.4BS

    Why do you not use the banner function, do the same thing and with only one line ? tep_banner if I remember.
  5. nice Sugestion change FILENMAE_REDIRECT BY redirect.php and " . TABLE_CONFIGURATION . " by configuration ==> next release not include this element. It's better to do now andfor new contribution or update, I think :- if you want full size on image : .item img { background-color: #fff; width:100%; }
  6. Why do not use the banner manager and to improve this functionnalities ? or Also use the module template on the catalog (header for example, it's possible to use the banner manager and inside the module to insert the different element for that responsive,carousel .... no ?
  7. I think the hook cannot be desactivated and cannot use also to display until checkout_shipping for example. I think also the hook can be call in module to activate and deactivate ? no ?
  8. Dan, the next release, I think, delete the FILENAME constant also for your script : $call_to_checkout .= is $call_to_checkout = +
  9. Gyakutsuki

    I want French Language

    what is the error edit application top and insert this // Set the level of error reporting defined( 'E_DEPRECATED' ) ? error_reporting( E_ALL & ~E_NOTICE & ~E_DEPRECATED ) : error_reporting( E_ALL & ~E_NOTICE ); // error_reporting(E_ALL | E_STRICT); ini_set('display_errors', true); You must see where is the error.
  10. Gyakutsuki

    I want French Language

    you can find in add on section :http://addons.oscommerce.com/info/9159
  11. Gyakutsuki

    Dynamic Template System

    This is script pb, try this. // Alias function for module [boxes] configuration value // template system function tep_cfg_select_pages($key_value, $key = '') { $name = ((tep_not_null($key)) ? 'configuration[' . $key . '][]' : 'configuration_value'); $select_array = tep_list_catalog_files(); sort($select_array); $selected_array = explode(';', $key_value); if($key_value === 'all') { $checkall = "CHECKED"; } else { $checkall = "UNCHECKED"; } $string = '<fieldset>'; $string .= '<input type="radio" class="AllPages" name="' . $name . '" value="all" ' . $checkall . ' />' . ALL_PAGES . '<br />'; $string .= '<p><strong> ' . ONE_BY_ONE . '</strong><br />'; $string .= '<input type="checkbox" id="CheckAll" class="CheckAll" name="CheckAll" /><label id="CheckAllLabel" for="CheckAll">' . CHECK_ALL . '</label></p>'; for ($i=0, $n=sizeof($select_array); $i<$n; $i++) { $string .= ' <input type="checkbox" id="file_' . $i . '" class="ThisPage" name="' . $name . '" value="' . $select_array[$i] . ';"'; if ( isset($selected_array) ) { foreach($selected_array as $value) { if ($select_array[$i] == $value) $string .= ' CHECKED'; } } $string .= '><label class="ThisPage" for="file_' . $i . '">' . $select_array[$i] . '</label><br />'; } $string .= '</fieldset>'; $string .= "<script type=\"text/javascript\"> jQuery(document).ready(function () { $('.AllPages').click( function() { $('.ThisPage').prop('checked', false); $('.CheckAll').prop('checked', false); $('#CheckAllLabel').text('" . CHECK_ALL . "'); } ); $('.CheckAll').click( function () { $(this).parents('fieldset:eq(0)').find(':checkbox').prop('checked', this.checked); $('.AllPages').prop('checked', (!this.checked)); if (this.checked) { $('#CheckAllLabel').text('" . DESELECT_ALL . "'); } else { $('#CheckAllLabel').text('" . CHECK_ALL . "'); } } ); $('.ThisPage').click( function() { var n = $( \"input.ThisPage:checked\" ).length; if (n >0) { $('.AllPages').prop('checked', false); } else { $('.AllPages').prop('checked', true); } } ); }); </script>"; return $string; }
  12. the futur version of osc change, there repercussion some modification can affect an addon. Concerning the coupon, just little modification must be do also in checkout_confirmation.php $coupon, become $_SESSION['coupon']. But this modification can be done on the current version of osc.
  13. found solution In order.php find // discount coupons global $coupon; if( isset($_SESSION['coupon']) && tep_not_null( $coupon ) ) { $coupon = $_SESSION['coupon']; require(DIR_WS_CLASSES.'discount_coupon.php' ); $this->coupon = new discount_coupon( $coupon, $this->delivery ); $this->coupon->total_valid_products( $products ); $valid_products_count = 0; } replace by if( isset($_SESSION['coupon']) && tep_not_null($_SESSION['coupon']) ) { require(DIR_WS_CLASSES.'discount_coupon.php' ); $this->coupon = new discount_coupon( $_SESSION['coupon'], $this->delivery ); $this->coupon->total_valid_products( $products ); $valid_products_count = 0; } That's all. This solution must be apply for the futur version on osc.
  14. I continue my monologue but it can help someone if a day there is the same pb ! I found where is the pb, discount_coupon after checkout confirmation.php is not take in consideration. that's why the values is taken by order_total.php.
  15. ok, the pb is inside this order_total.php. between checkout_payment.php and checkout_confirmation.php, the process work fine with order_total.php between checkout_confirmation and checkout_processus.php (see above), the order_total.php put pb. See the result function process() { $order_total_array = array(); if (is_array($this->modules)) { var_dump($this->modules); =============> step 1 below ===> all is ok exit; foreach($this->modules as $value) { $class = substr($value, 0, strrpos($value, '.')); if ($GLOBALS[$class]->enabled) { $GLOBALS[$class]->output = array(); $GLOBALS[$class]->process(); for ($i=0, $n=sizeof($GLOBALS[$class]->output); $i<$n; $i++) { if (osc_not_null($GLOBALS[$class]->output[$i]['title']) && osc_not_null($GLOBALS[$class]->output[$i]['text'])) { $order_total_array[] = array('code' => $GLOBALS[$class]->code, 'title' => $GLOBALS[$class]->output[$i]['title'], 'text' => $GLOBALS[$class]->output[$i]['text'], 'value' => $GLOBALS[$class]->output[$i]['value'], 'sort_order' => $GLOBALS[$class]->sort_order); } } } } } var_dump($order_total_array); =============> step 2 ==> all is not ok after the loop exit; return $order_total_array; } step 1 ==> see the coupon array (size=5) 0 => string 'ot_subtotal.php' (length=15) 1 => string 'ot_discount_coupon.php' (length=22) 2 => string 'ot_shipping.php' (length=15) 3 => string 'ot_tax.php' (length=10) 4 => string 'ot_total.php' (length=12) step2: result array (size=3) 0 => array (size=5) 'code' => string 'ot_subtotal' (length=11) 'title' => string 'Sous-Total:' (length=11) 'text' => string '22.92$ CAD' (length=10) 'value' => float 22.92 'sort_order' => string '5' (length=1) 1 => array (size=5) 'code' => string 'ot_shipping' (length=11) 'title' => string 'Prix forfaitaire (Prix forfaitaire):' (length=36) 'text' => string '5.00$ CAD' (length=9) 'value' => string '5.00' (length=4) 'sort_order' => string '10' (length=2) 2 => array (size=5) 'code' => string 'ot_total' (length=8) 'title' => string 'Total:' (length=6) 'text' => string ' 27.92$ CAD ' (length=12) 'value' => float 27.92 'sort_order' => string '60' (length=2)
  16. the problem is between the 2 lines in checkout_process.php $order_total_modules = new order_total(); ===> see the coupon $order_totals = $order_total_modules->process(); ===> coupon deseapear I lost the something, why !!! researching.
  17. No the pb is not the free chipping. I change the shipping by flat and taken other. The problem is between checkout_confirmation.php and checkout_process.php and after this line in checkout_confirmation.php require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; $order_total_modules->process(); ==> a coupon appear with a var_dump Just to find !
  18. I continue my investigation classes/order_total.php function process() { $order_total_array = array(); if (is_array($this->modules)) { foreach($this->modules as $value) { $class = substr($value, 0, strrpos($value, '.')); if ($GLOBALS[$class]->enabled) { $GLOBALS[$class]->output = array(); $GLOBALS[$class]->process(); for ($i=0, $n=sizeof($GLOBALS[$class]->output); $i<$n; $i++) { if (osc_not_null($GLOBALS[$class]->output[$i]['title']) && osc_not_null($GLOBALS[$class]->output[$i]['text'])) { $order_total_array[] = array('code' => $GLOBALS[$class]->code, 'title' => $GLOBALS[$class]->output[$i]['title'], 'text' => $GLOBALS[$class]->output[$i]['text'], 'value' => $GLOBALS[$class]->output[$i]['value'], 'sort_order' => $GLOBALS[$class]->sort_order); } } } } } var_dump($order_total_array); exit; return $order_total_array; } result array (size=4) 0 => array (size=5) 'code' => string 'ot_subtotal' (length=11) 'title' => string 'Sous-Total:' (length=11) 'text' => string '121.00$ CAD' (length=11) 'value' => float 121 'sort_order' => string '5' (length=1) 1 => array (size=5) 'code' => string 'ot_discount_coupon' (length=18) 'title' => string 'Code coupon lancement applique:' (length=31) 'text' => string '5.00$ CAD' (length=9) 'value' => string '5' (length=1) 'sort_order' => string '9' (length=1) 2 => array (size=5) 'code' => string 'ot_shipping' (length=11) 'title' => string 'Livraison gratuite (livraison offerte dés 5.):' (length=54) 'text' => string '0.00$ CAD' (length=9) 'value' => string '0.00' (length=4) 'sort_order' => string '10' (length=2) 3 => array (size=5) 'code' => string 'ot_total' (length=8) 'title' => string 'Total:' (length=6) 'text' => string ' 116.00$ CAD ' (length=13) 'value' => float 116 'sort_order' => string '60' (length=2) I have my coupon and my coupon is displayed in checkout_confirmation.php ! ==> good. now I valide my checkout_confirmation.php code in checkout_process.php require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; $order_totals = $order_total_modules->process(); var_dump($order_total_modules); var_dump($order_totals); exit; Now the result object(order_total)[43] public 'modules' => array (size=5) 0 => string 'ot_subtotal.php' (length=15) 1 => string 'ot_discount_coupon.php' (length=22) 2 => string 'ot_shipping.php' (length=15) 3 => string 'ot_tax.php' (length=10) 4 => string 'ot_total.php' (length=12) array (size=3) 0 => array (size=5) 'code' => string 'ot_subtotal' (length=11) 'title' => string 'Sous-Total:' (length=11) 'text' => string '121.00$ CAD' (length=11) 'value' => float 121 'sort_order' => string '5' (length=1) 1 => array (size=5) 'code' => string 'ot_shipping' (length=11) 'title' => string 'Livraison gratuite (livraison offerte dés 5.):' (length=54) 'text' => string '0.00$ CAD' (length=9) 'value' => string '0.00' (length=4) 'sort_order' => string '10' (length=2) 2 => array (size=5) 'code' => string 'ot_total' (length=8) 'title' => string 'Total:' (length=6) 'text' => string ' 121.00$ CAD ' (length=13) 'value' => float 121 'sort_order' => string '60' (length=2) $order_total_modules ===> show the discount coupon but $order_total_modules->process() delete the discount coupon Do you havean idea because I don't see the solution. thank you
  19. Hi joli, I also try this option but it does'nt work. test class order total : show 4 method test in checkout_process : show 3 method. I try with discount by customer before subtotal and there is no problem.
  20. just last information in checkout_confirmation I have the 4. require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; $order_total_modules->process(); var_dump($order_total_modules->process()); exit; array (size=4) 0 => array (size=5) 'code' => string 'ot_discount_coupon' (length=18) 'title' => string 'Code coupon lancement applique:' (length=31) 'text' => string '-5.00$ CAD' (length=10) 'value' => string '-5' (length=2) 'sort_order' => string '3' (length=1) 1 => array (size=5) 'code' => string 'ot_subtotal' (length=11) 'title' => string 'Sous-Total:' (length=11) 'text' => string '22.92$ CAD' (length=10) 'value' => float 22.92 'sort_order' => string '5' (length=1) 2 => array (size=5) 'code' => string 'ot_shipping' (length=11) 'title' => string 'Livraison gratuite (livraison offerte dés 5.):' (length=54) 'text' => string '0.00$ CAD' (length=9) 'value' => string '0.00' (length=4) 'sort_order' => string '50' (length=2) 3 => array (size=5) 'code' => string 'ot_total' (length=8) 'title' => string 'Total:' (length=6) 'text' => string ' 17.92$ CAD ' (length=12) 'value' => float 17.92 'sort_order' => string '60' (length=2)
  21. The problem don't come of order.php class. it work fine That I can said In checkout_process.php require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; $order_totals = $order_total_modules->process(); print_r($order_totals); var_dump($order_totals); exit; the result is : Array ( [0] => Array ( [code] => ot_subtotal [title] => Sous-Total: [text] => 22.92$ CAD [value] => 22.92 [sort_order] => 5 ) [1] => Array ( [code] => ot_shipping [title] => Livraison gratuite (livraison offerte dés 5.): [text] => 0.00$ CAD [value] => 0.00 [sort_order] => 50 ) [2] => Array ( [code] => ot_total [title] => Total: [text] => 22.92$ CAD [value] => 22.92 [sort_order] => 60 ) )0 => array (size=5) 'code' => string 'ot_subtotal' (length=11) 'title' => string 'Sous-Total:' (length=11) 'text' => string '22.92$ CAD' (length=10) 'value' => float 22.92 'sort_order' => string '5' (length=1) 1 => array (size=5) 'code' => string 'ot_shipping' (length=11) 'title' => string 'Livraison gratuite (livraison offerte dés 5.):' (length=54) 'text' => string '0.00$ CAD' (length=9) 'value' => string '0.00' (length=4) 'sort_order' => string '50' (length=2) 2 => array (size=5) 'code' => string 'ot_total' (length=8) 'title' => string 'Total:' (length=6) 'text' => string ' 22.92$ CAD ' (length=12) 'value' => float 22.92 'sort_order' => string '60' (length=2) It forgot ot_discount_coupon. the loop in order_total.php class count only 3 order total and not 4. Where is the last ? Idea, I take and I continue my exploration.
  22. No it's the normal order process like check. the discount is not being carried over and when I count the number of order_total in checkout_process.php , I have 3 loop and not 4. One is forgotten an it's the coupon. I look your idea.
  23. Gyakutsuki

    Looking For Testers: New PayPal App

    Hi Harald I apply your patch. Ok, but lot of files and directories in admin, and catalog/include .... must in 777. Security for that is ok ? Else the patch is intalled with no problem
  24. Just a question, Do you have this problem ? In checkout_confirmation, I see my discount and all if correct, but when I confirm my order, the discount is not taken and does'nt appear in my order in my admin. Do you have this weird problem ?
  25. Gyakutsuki

    Looking For Testers: New PayPal App

    ok for me.
×