mcmannehan

@frankl at this moment i can't say that, because i still check the admin area and change the function tep_image_button, to the tep_draw_button function in some files. And clear the mess with the table colspan. Also there are some problems with different languages. If i am finish with all fixes and with the translation for German languages, i will give you Information. But need a litte bit time. BTW i did hidden from the admin the "Configuration -> RMA Returns". I think it's not nessecary to configure that, your returns_configuration.php do all the stuff.

@LeeFoster you are faster ;-) !!! but i did change like that in admin/includes/boxes/returns.php change if (RMA_RETURN_SYSTEM == '1') { $cl_box_groups[] = array( 'heading' => BOX_RETURNS_HEADING, to if (RMA_RETURN_SYSTEM == 'true') { $cl_box_groups[] = array( 'heading' => BOX_RETURNS_HEADING, In admin/returns_configuration.php change $rma_value_query = tep_db_query("select * from configuration where configuration_key = 'RMA_RETURN_SYSTEM'"); if (!tep_db_num_rows($rma_value_query)) { tep_db_query("insert into configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ( 'Use the RMA returns system?', 'RMA_RETURN_SYSTEM', '1', 'Turn the RMA System on or off', '" . $insert_id . "', '1','tep_cfg_select_option(array(\'true\', \'false\'), ', now())"); } to if (!tep_db_num_rows($rma_value_query)) { tep_db_query("insert into configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ( 'Use the RMA returns system?', 'RMA_RETURN_SYSTEM', 'true', 'Turn the RMA System on or off', '" . $insert_id . "', '1','tep_cfg_select_option(array(\'true\', \'false\'), ', now())"); }

Admin click configuration -> RMA Returns Change Use the RMA returns system? to true, than i think you will know what i mean. Your value in the database table is 1. After you change this the value is 'true', than the link in the admin "customer returns" show start all the links after the install are gone. I am working on it to fix this, but until now did not find the code for that. Also i did find a lot table colspan issues. I will fix it too. If i finish i will send u a complett new add-on also with German languages, because your add-on is very good to use for revocation in the EU/DE.

Info: date values in the create datebase should not be like 0000-00-00 00:00:00. In MySQL 5.7 with strict SQL Mode an error will occurse. I recommand change the value to 1970-01-01 00:00:00

And now, i did check a bug in the configuration table. if you change Use the RMA returns system? to true, than the installing is gone. Your value before change this, is 1.

and in refund_methods.php you did comment out the break, delete is working, but the case is not closed. case 'delete': $oID = tep_db_prepare_input($_GET['oID']); /* $status_query = tep_db_query("select count(*) as count from refund_method where orders_status = '" . tep_db_input($oID) . "'"); $status = tep_db_fetch_array($status_query); */ $remove_status = true; /* if ($oID == DEFAULT_ORDERS_STATUS_ID) { $remove_status = false; $messageStack->add(ERROR_REMOVE_DEFAULT_ORDER_STATUS, 'error'); } elseif ($status['count'] > 0) { $remove_status = false; $messageStack->add(ERROR_STATUS_USED_IN_ORDERS, 'error'); } else { $history_query = tep_db_query("select count(*) as count from " . TABLE_REFUND_METHOD_HISTORY . " where '" . tep_db_input($oID) . "' in (new_value, old_value)"); $history = tep_db_fetch_array($history_query); if ($history['count'] > 0) { $remove_status = false; $messageStack->add(ERROR_STATUS_USED_IN_HISTORY, 'error'); } } break; */

But i did find one thing. In the admin you still use the function tep_image_button, that should be the tep_draw_button function. in the file: returns_reasons.php and refund_methods.php

@frankl Thats a very good work u did. Works well after the fix. Thank you!!!

why you not use: //define('DIR_FS_DOCUMENT_ROOT', $DOCUMENT_ROOT); // where your pages are located on the server. if $DOCUMENT_ROOT doesnt suit you, //define('DIR_FS_ADMIN', DIR_FS_DOCUMENT_ROOT . DIR_WS_ADMIN); //define('DIR_FS_CATALOG', DIR_FS_DOCUMENT_ROOT . DIR_WS_CATALOG); It seems that your configure.php is wrong. Normaly, if you install your shop with the install routine, your configure files would be correct.

the add-on for 2.2 and 2.3.3 and 3.0 is still a mess. The Tax calculatuin and the order total totally wrong. This function function get_tax_rate_from_desc($tax_desc) { $tax_rate = 0.00; $tax_descriptions = explode(' + ', $tax_desc); foreach ($tax_descriptions as $tax_description) { $tax_query_str = "SELECT tax_rate FROM " . TABLE_TAX_RATES . " WHERE tax_description = '" . $tax_desc . "'"; $tax_query = tep_db_query($tax_query_str); if (tep_db_num_rows($tax_query)) { while ($tax = tep_db_fetch_array($tax_query)) { $tax_rate += $tax['tax_rate']; // <- the plus before the = is a big bug } } } return $tax_rate; } calculate the tax wrong, because if u have more than one Tax then the add the tax and use it for calculate. i change to function get_tax_rate_from_desc($tax_desc) { $tax_rate = 0.00; $tax_descriptions = explode(' + ', $tax_desc); foreach ($tax_descriptions as $tax_description) { $tax_query_str = "SELECT tax_rate FROM " . TABLE_TAX_RATES . " WHERE tax_description = '" . $tax_desc . "'"; $tax_query = tep_db_query($tax_query_str); if (tep_db_num_rows($tax_query)) { while ($tax = tep_db_fetch_array($tax_query)) { $tax_rate = $tax['tax_rate']; // <- here i delete the plus befor the = } } } return $tax_rate; } but the the total ist still wrong. any suggestions? The function for 3.0 looks differnt, but the same error with the plus in front the =

i did it and the banner is not show up. I used the banner manager and i named the banner group footer. Banner did'n show up. With my changing i named the banner group banner and it works.

in this version: https://github.com/gburton/Responsive-osCommerce/blob/master/includes/footer.php The banner, generated wit the banner manager want show up. so i did change in includes/footer.php to: <footer> <div class="<?php echo BOOTSTRAP_CONTAINER; ?>"> <div class="row"> <?php if ($banner = tep_banner_exists('dynamic', 'banner')) { echo tep_display_banner('static', $banner); } ?> </div> </div> <div class="footer"> <div class="<?php echo BOOTSTRAP_CONTAINER; ?>"> <div class="row"> <?php echo $oscTemplate->getContent('footer'); ?> </div> </div> </div> <div class="footer-extra"> <div class="<?php echo BOOTSTRAP_CONTAINER; ?>"> <div class="row"> <?php echo $oscTemplate->getContent('footer_suffix'); ?> </div> </div> </div> </footer> Or is there some other resolution?

@Xeno @beerbee you are right but sometimes the server is running on nginx or the don't consider the $_SERVER['PHP_AUTH_USER'] and $_SERVER['PHP_AUTH_PW'] than you can insert the follow to your .htaccess <IfModule mod_rewrite.c> RewriteEngine on RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}] </IfModule>

in catalog/admin/reviews.php the radiobutton for the reviews (bad/good) is not selected. i recommand to change: find in catalog/admin/reviews.php <?php echo TEXT_BAD; ?>&nbsp;<?php for ($i=1; $i<=5; $i++) echo tep_draw_radio_field('reviews_rating', $i, '', $rInfo->reviews_rating) . '&nbsp;'; echo TEXT_GOOD; ?> change to: <?php echo TEXT_BAD; ?>&nbsp; <?php for ($i=1; $i <= 5; $i++) { $selected = null; if ( $i == $rInfo->reviews_rating ) { $selected = true; } echo tep_draw_radio_field('reviews_rating', $i, $selected, $rInfo->reviews_rating) . '&nbsp;'; } echo TEXT_GOOD; ?>

after 17 years of osC now fix for that. Thats a shame...