Jump to content

hungryfrank

Members
  • Content count

    427
  • Joined

  • Last visited

  • Days Won

    3

Posts posted by hungryfrank


  1.  class nb_brand {
        var $code = 'nb_brand';
        var $group = 'navbar_modules_home';
        var $title;
        var $description;
        var $sort_order;
        var $enabled = false;    
        
        function __construct() {
          $this->title = MODULE_NAVBAR_BRAND_TITLE;
          $this->description = MODULE_NAVBAR_BRAND_DESCRIPTION;
    
        

       this is from one of the modules. if you have  function  named usps change it to _construct.

    function __construct() {.   

     

    18 hours ago, dculley said:

    I have upload your usps.php file and modified the modules.php file to this:

    modules.php

    This modules.php or the one orginal one in phoenix I sill get the below error messages. 

    Before installing the USPS in modules\shipping, when I click on install module red button- before I even click on the +install module org button i have these errors.

    Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; usps has a deprecated constructor in /home/xxxxx/xxxxxx/xxxxxx/includes/modules/shipping/usps.php on line 18

     

    After - When going to admin and installing the USPS at the very top there is this error:

    Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; usps has a deprecated constructor in /home/xxxxxx/xxxxxx/xxxxxx/includes/modules/shipping/usps.php on line 18

    line 18 is:  class usps {

    I'm not a programmer so I don't see anything wrong.

    I'm still getting the ( ; in the boxes.  unable to type and save a dollar amount. 

     


  2. 12 minutes ago, BrockleyJohn said:

    If you need to change ot_shipping.php - I don't think that's part of the addon. Check if you can reproduce on the shop checkout and if so raise a phoenix issue.

    no in the shop it is ok.  maybe if we add a tax class to shipping modules in the admin. i test that tomorrow. that would be the easiest way.

    maybe a 0 tax class.


  3. On 4/14/2020 at 11:32 AM, BrockleyJohn said:

    These notices are telling you that it cannot calculate the shipping order total because it can't find a match between the shipping quote stored in the session variable and the shipping classes stored in the global variable.

    The delivered code, fixed as suggested, doesn't do this. If you are running it in a test store you can put some debugging into ot_shipping so you can see what's not properly set. Check what $module gets set to in line 48 and if it doesn't look right, check the value of $_SESSION['shipping']['id']

    @burt had a solution.  back I the days. 

     


  4. 1 hour ago, domiosc said:

    Good work now run, I think button recalculate total no longer needed, because if you change option recalculate correctly.

    I like to view the print option in checkout confirmation.

    there are print orders for that. other aadd ons  I have the other one because at that. stage there is no order yet so the other addons won't work

    thanks


  5. did some work on error reporting
    changed the references of checkout_payment.php and checkout_shipping.php to checkout_payment_exp.php
    added option to bypass create_account_success.php  one less step 
    made T&C optional.

    uploaded new version.

    it should work with all payment methods that don't have input form in the checkout_payment.php without confirmation page

    can be adopted to work with them also like PSiGate. I have made sample changes for that payment module

     


  6. On 4/14/2020 at 8:08 AM, Patty said:

    Hi there!
    First of all, I'd like to congratulate you for a ton of great contributions that you are making to this project! Excellent job! ❤️

    Now the issue with this addon. On Phoenix v1.0.57 it's throwing the following error on the payment modules installation page:

    Would you be kind enough to update this addon so it will be compatible with the newer versions? Unfortunately I'm not a coder so this is a little beyond me to fix. 😕

    TIA for your help! And keep up the good work!

    take a look at the few posts around this on page 14  it might work.   at least to a point. 

     


  7. 55 minutes ago, BrockleyJohn said:

    it should be

    function __construct() {

    now I get two notices   much better than before. it added wrong.

    Notice: Undefined index: in /Library/WebServer/Documents/m6/includes/modules/order_total/ot_shipping.php on line 51

    Notice: Trying to get property of non-object in /Library/WebServer/Documents/m6/includes/modules/order_total/ot_shipping.php on line 51


  8. On 4/12/2020 at 12:11 PM, artfulweb said:

    Hi John,

    It shows fine as long as you do not touch the shipping, for example try to put it at 0 so the customer does not have to pay the shipping or add a discount, then it goes haywire.

    this worked for me.  

    in admin/order_editor/order_totalphp

    line 22 change  function order_total() {.  to     public function _order_total() {. 


  9. your error is because in the add-on the filenames were declared in a file , but now they are now hard coded. DC_BLOCKS should be hard coded as its actual name of the folder, and the / is missing..   but you will have more errors because of other changes


  10. I uploaded a new version.

    thanks to @raiwa tips, I made some changes.

    @domiosc  you can turn off the invoice from admin.  I will make the t&c optional in the next update.

    @yeno I don't know how to use GitHub. but I can use the help for sure.

    I added the checkout_confirmation also to the page via Ajax. 

    this way more of payment modules will work, with one page only.  some still might need the 2 page option.

    if you use it and it works on your shipping modules and payment modules please let me know,

    thanks

     


  11. 2 hours ago, hugo_064 said:

    hi Hungryfrank,

    Thank you for this addon ;)

    i try to use this modal in other page like "shopping_cart.php" with the "confirm order" 's button.

    Work fine with this modification in "loginpopout.php" :

     

    
    	  function listen_injectSiteEnd() {
    	  if (!tep_session_is_registered('customer_id')) {
    	     $this->siteend .= "       <script>
    $('a[href*=\"login.php\"]').on( \"click\", function(e) {
    e.preventDefault();
       $('#LoginModal').modal('show');
    });
    	
    $('a[href*=\"checkout_shipping.php\"]').on( \"click\", function(e) {
    e.preventDefault();
       $('#LoginModal').modal('show');
    });
    	</script>";
      }else{
         $this->siteend .= "       <script>
    $('a[href*=\"login.php\"]').on( \"click\", function(e) {
    e.preventDefault();
       $('#LoginModal').modal('show');
    });
    	</script>";
      }
    	

     

    Now i'll try to use addon with contact_us.php

    In contact_us.php

    After  "require('includes/application_top.php');"

    add

     

    
    	  if (!tep_session_is_registered('customer_id')) {
        $navigation->set_snapshot();
        tep_redirect(tep_href_link('login.php', '', 'SSL'));
      }
    	

     

    and in loginpopout.php

    after

    if (!tep_session_is_registered('customer_id')) {

         $this->siteend .= "       <script>
    $('a[href*=\"login.php\"]').on( \"click\", function(e) {
    e.preventDefault();
       $('#LoginModal').modal('show');
    });

    add

     

    
    	$('a[href*=\"contact_us.php\"]').on( \"click\", function(e) {
    e.preventDefault();
       $('#LoginModal').modal('show');
    });
    	

     

    But something wrong because after login back to index page and not to contact_us page.

    What do you thing about that.

    Have fun

     

    the form returns to the login.php, and you are not in contact_us.php.

    maybe  you can have the model to open onload. but then u can't check if the customer is logged in. 


  12. I think with these I am almost done 

    the onnnly thing is the validationn. I think and checking for errors on 7.3

    for one thing  I need to stop the payment module to be selected if there is a validation error

    I use the    check_form();   to get the error which works, but after the popup error warning. it still selects the payment module.

    for example the cc# is not filled but it still choses the payment. I want it to not choose the module till the error is resolved.

     

     

    checkout_payment_exp.php

    checkout_confirmation_ajax.php


  13. On 2/28/2020 at 5:20 PM, Jack_mcs said:

    @hungryfrankI haven't read through this thread but I am wondering if you are aware of this addon? Here is the support thread. I've been using it for years and it works great. I think I had to adjust the code due to how Phoenix loads jquery but that's all. Just thought I would mention it to save the reinvention. Your code may be better so it would be interesting if you had time to compare them.

    just playing around 


  14.  

    I have made some changes, and they should work.  without confirmation page

    I think  they should work.😊

    I am on php 7.1 so don't see error with the exception of  cc# and they shouldn't be difficult to see.

    checkout_payment_exp.php

    checkout_confirmation_ajax.php

    also I have only done for one but the jjquery has to be added to pass the value of input fields in payment module to checkout_confirmation_ajax.php

     

     

     

×