Jump to content

inra311

Members
  • Content count

    99
  • Joined

  • Last visited

Everything posted by inra311

  1. I cannot update the currencies in admin anymore (2.3.4.1 CE), with fixer When I go to http://api.fixer.io/ I get the impression something has changed there, you need an api key!? Anyone else who has this problem or even a solution? (I have not tried to get an api key yet, as I probably would not know how to integrate it in osc) As an alternative, I meanwhile edited admin/includes/application_top.php and admin/includes/functions/localization.php top as suggested here: This way currencies update with xe at least --> define('CURRENCY_SERVER_BACKUP', 'xe');
  2. I got an email from the authorities a few days ago telling me that from 2019 on I DO NOT HAVE to tax digital downloadable products differently for customers from different EU countries, as I had from 2015 on. 😃 I am not sure if this is new EU law or national law (I am from Germany), at least here In Germany you are freed of this when your company is located in only one EU country, and the downloadable product sales do not exceed 10,000 Euros per year.
  3. Not sure if this is a bug or if I am missing something. I just found that my shop does not send out the bank transfer data (like the IBAN etc.) in the confirmation email anymore, in case when 'money order' is the chosen payment option. The commit from May 3 commented out a line in moneyorder.php which made it stop working here: - $this->email_footer = MODULE_PAYMENT_MONEYORDER_TEXT_EMAIL_FOOTER; + //$this->email_footer = MODULE_PAYMENT_MONEYORDER_TEXT_EMAIL_FOOTER; When I remove the two // it works again. What am I missing here, should there be any new module instead that sends out this data and which is not setup correctly yet? And why is the line commented out and not simply removed when not needed anymore?
  4. No idea what is wrong. In my shop, customers can buy from all countries and can pay with every payment method. It worked alright from the beginning. If the payment module instantly switches the order status to 'money received' they get the download link automatically on the checkout_success page, if not - like bank transfer - the status is 'pending', and download is disabled. I manually have to set it on 'money received' when I get the money. In the downloads config menu, I have downloads and redirect to true, 7 days, 5 trials.
  5. You can enable/disable download access for each status of the order, or did I get you wrong?
  6. Not sure if I understand your question. Where the virtual products are specified as virtual? Maybe just when they have a download file linked to them under products attributes!? In the Filename field..
  7. I tried that addon but it does not work. I fixed two DIR_WS_INCLUDES but still get lots of fatal errors, with fseek(), fopen(), fread(), ftell()... maybe it does not like PHP 7.1?? I think the law requires two independent verifactions for the VAT rate, like IP and shipping address.. I'd wish those who make such laws had to offer solutions as well
  8. And with GDPR we need another MATC checkbox before sending out the IP to be externally checked, right? First thing the visitor of our shop has to do!? When buying at least the tax rate is based on the shipping address, right? And what about virtual products, any customer just needs to enter a non-EU address and he does not pay any tax at all, I am afraid...
  9. inra311

    MATC BS

    Works fine now !
  10. Cool, I was not aware of such an addon (luckily there are so MANY :) ) , and already modular as a header tag module, and only one line to add in functions/general :) Will try it soon, thanks for the hint
  11. inra311

    MATC BS

    I checked again and this time I made 100% sure I have only original files. The problem is still there! (Tested with Firefox and Microsoft Edge) I guess you missed it because of this: There seem to be (at least) two different 'error levels'. With just a 'minor' mistake the page 'reloads' like in the screenshot, with a popup note. No problem in this case, the MATC behaves correctly: Sometimes however the page reloads with a WARNING ON TOP (like password errors? or multiple errors? repeated errors? not sure why and when this is in contrast to the first error type): In this case the MATC button seems to be 'offset' with the checkbox (which is checked but no button): Unchecking will show the button now, 'Continue' will result in a MATC error: "you need to agree with the T & Cs.."
  12. inra311

    MATC BS

    I used Firefox, PHP 7.1 I made some little cosmetic changes to some files, like replacing the text next to the box with one with two html links (to conditions and to privacy_policy), and I set the check box left of the text instead of right. But I also tried with the original, unmodified files (I hope all...) to make sure that the problem was not related to my changes, and it was still there. Maybe I missed something? Will check again tomorrow.
  13. Right, I have tax zones for each possible rate, called e.g. Downloads 17%, Downloads 18%, Downloads 19%,.... Within these "folders" you add all the countries with the respective vat rate. See pictures, they say more than words. In the product description, you select 'Downloads' for each virtual product.
  14. You can do this with the out-of-the-box features, no addon required. You need to setup many tax rates, tax zones etc. Search for a documentation, it has been discussed here. Only prolem: No idea how to display the correct tax rates to a customer BEFORE he logs in, as it is required per law.
  15. inra311

    MATC BS

    I found a problem with the MATC module on the create_account page. When the customer enters data incorrectly so that the Continue button does not lead to the success page but reloads the page with an error warning , the MATC module bevaves weird. (I am talking about the case when there is a warning box on top of the page, small or first (?) errors like too short entries sometimes just open a pop-up hint, no problem in this case) The problem: all entered data is still there and the matc checkbox is still checked (which is alright) BUT the Continue button is hidden. The button will be shown when you UNCHECK the checkbox now!! A click on the button will reload the page with the error note that you must check the checkbox! At least then the checkbox is again unchecked, when you check it the button appears and this time the account will be succesfully created. Apparently, the customer's data and the state of the check box were recovered when reloading the create_account page after the first error but the button is hidden by the code on top of matc.php nevertheless. So the button state (show/hide) does not match the state (checked/unchecked) of the checkbox. I found a solution for me but it is probably not the ideal one. Maybe anyone better in coding can sort out how to fix it properly (maybe to set 'checked' always to false whenever the page is loaded) (My solution was to show the button always, by removing the script on top of matc.php. I am fine with this as it is the way it is on many websites. I had to paste in the script in the template of the buy button on checkout_confirmation instead as otherwise you could buy there without checking the MATC checkbox)
  16. inra311

    MATC BS

    Unfortunately I don't really understand what the code does but I can confirm that the error seems to be related to the 5th parameter of tep_draw_button which is 'id="TheSubmitButton"' When I change tep_draw_button(IMAGE_BUTTON_CONTINUE, 'fa fa-angle-right', null, 'primary', 'id="TheSubmitButton"', 'btn-success'); to tep_draw_button(IMAGE_BUTTON_CONTINUE, 'fa fa-angle-right', null, 'primary', null, 'btn-success'); it does not produce the error, and still seems to work (I don't have the popup or textarea option enabled, is the parameter needed for some javascript for these??) ... but as said I don't really understand what I am doing there so probably not a good idea?! Also I found that 'id="TheSubmitButton"' does not appear in any core files, neither in the addon except within the tep_draw_button. Shouldn't it be defined somewhere? error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_DEPRECATED); This did not change anything (the error is in the error log, not onscreen)
  17. inra311

    MATC BS

    I set the MATC to checkout_confirmation. It works fine it seems but I get the following error warnings when calling up checkout_confirmation.php (PHP 7.1): PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 350 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 353 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 354 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 357 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 367 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 375 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 394
  18. https://github.com/gburton/Responsive-osCommerce/commit/3c82890e63dbb647e0ede849eb4d9f19d8abb0b4 --> Default to XS so buttons sits side by side. Clearfix the first button to solve long description or long gallery.
  19. I put the <div class="clearfix"></div> at the end of the button template so that it can be used with any module to follow!? Seems to work so far..
  20. There is the option 'Require telephone number' in the PWA settings (admin/modules/content --> Login without account form) that must be set to true. Then the telephone number can be entered at the bottom of the form.
  21. Thanks, will do... But you are right that it depends on the sort order. The buy button works when it is not followed by certain modules. It works e.g. before e.g. the product name but not before description. Maybe it works when the module coming next to it contains two DIV in the template, at least this is what the ones that are allright have in common??!!
  22. This cures the review button but still not the buy button
  23. Just found this has nothing to do with PC / Android but just with screen size: when I resize the window on the desktop more and more smaller, the button finally stops working. Does not change colour when mouse hovering, and does not work. Just try here yourself: https://tbyb.co.uk/product_info.php/microsoft-internet-keyboard-ps2-p-25
  24. I feel there is something wrong with the review and Add to cart buttons on product_info. While they work fine on a desktop PC, they do not work at all (nothing happens) on the three Android mobiles I have to test here. However, on the Android tablet they work. I have this error not only in my shop but also with @JcMagpie 's demo shop at tbyb.co.uk (e.g. when I try to put the keyboard into the cart which works fine on the PC) When I use the product_info.php from before March 15 (commit Remove Hardcoded Buttons), it works again on my mobile.
×