Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

inra311

Members
  • Posts

    99
  • Joined

  • Last visited

Everything posted by inra311

  1. Works fine now !
  2. I checked again and this time I made 100% sure I have only original files. The problem is still there! (Tested with Firefox and Microsoft Edge) I guess you missed it because of this: There seem to be (at least) two different 'error levels'. With just a 'minor' mistake the page 'reloads' like in the screenshot, with a popup note. No problem in this case, the MATC behaves correctly: Sometimes however the page reloads with a WARNING ON TOP (like password errors? or multiple errors? repeated errors? not sure why and when this is in contrast to the first error type): In this case the MATC button seems to be 'offset' with the checkbox (which is checked but no button): Unchecking will show the button now, 'Continue' will result in a MATC error: "you need to agree with the T & Cs.."
  3. I used Firefox, PHP 7.1 I made some little cosmetic changes to some files, like replacing the text next to the box with one with two html links (to conditions and to privacy_policy), and I set the check box left of the text instead of right. But I also tried with the original, unmodified files (I hope all...) to make sure that the problem was not related to my changes, and it was still there. Maybe I missed something? Will check again tomorrow.
  4. I found a problem with the MATC module on the create_account page. When the customer enters data incorrectly so that the Continue button does not lead to the success page but reloads the page with an error warning , the MATC module bevaves weird. (I am talking about the case when there is a warning box on top of the page, small or first (?) errors like too short entries sometimes just open a pop-up hint, no problem in this case) The problem: all entered data is still there and the matc checkbox is still checked (which is alright) BUT the Continue button is hidden. The button will be shown when you UNCHECK the checkbox now!! A click on the button will reload the page with the error note that you must check the checkbox! At least then the checkbox is again unchecked, when you check it the button appears and this time the account will be succesfully created. Apparently, the customer's data and the state of the check box were recovered when reloading the create_account page after the first error but the button is hidden by the code on top of matc.php nevertheless. So the button state (show/hide) does not match the state (checked/unchecked) of the checkbox. I found a solution for me but it is probably not the ideal one. Maybe anyone better in coding can sort out how to fix it properly (maybe to set 'checked' always to false whenever the page is loaded) (My solution was to show the button always, by removing the script on top of matc.php. I am fine with this as it is the way it is on many websites. I had to paste in the script in the template of the buy button on checkout_confirmation instead as otherwise you could buy there without checking the MATC checkbox)
  5. Unfortunately I don't really understand what the code does but I can confirm that the error seems to be related to the 5th parameter of tep_draw_button which is 'id="TheSubmitButton"' When I change tep_draw_button(IMAGE_BUTTON_CONTINUE, 'fa fa-angle-right', null, 'primary', 'id="TheSubmitButton"', 'btn-success'); to tep_draw_button(IMAGE_BUTTON_CONTINUE, 'fa fa-angle-right', null, 'primary', null, 'btn-success'); it does not produce the error, and still seems to work (I don't have the popup or textarea option enabled, is the parameter needed for some javascript for these??) ... but as said I don't really understand what I am doing there so probably not a good idea?! Also I found that 'id="TheSubmitButton"' does not appear in any core files, neither in the addon except within the tep_draw_button. Shouldn't it be defined somewhere? error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_DEPRECATED); This did not change anything (the error is in the error log, not onscreen)
  6. I set the MATC to checkout_confirmation. It works fine it seems but I get the following error warnings when calling up checkout_confirmation.php (PHP 7.1): PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 350 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 353 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 354 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 357 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 367 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 375 PHP Warning: Illegal string offset 'type' in .../includes/functions/html_output.php on line 394
  7. I am using this addon together with @Raiwa 's modular checkout & ship in cart estimator: Just some minutes ago a customer bought virtual products and I noticed that there is no shipping or billing address in the order. When I open the order in the order editor, it crahes, as it seems because of the customer's state which contains a ' ! (Country: France , state: Val d'Oise ) 1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Oise' OR zone_code = 'Val d'Oise')' at line 1 select zone_id from zones where zone_country_id = '73' and (zone_name = 'Val d'Oise' OR zone_code = 'Val d'Oise') I can't tell if this has to do with any of the addons involved here, or with 2.3.4.1 CE. What I can tell is that an older order with virtual products by the same customer from last year works and appears alright!
  8. I just added the first one, worked like a charm I will try the other option now...
  9. Big thank you, Rainer I will add the changes this evening and report back the result
  10. I have installed this great addon :) I am wondering if there is an easy mod for the following problem: As EU dealer, I must display all prices with 19% VAT. I have many customers from outside the EU, and I was hoping the addon would not only display shippig costs for these but the order total as well - in other words the final price (with or without VAT, depending from the country they come from.) After selecting the country, all the VAT itself of the shipping costs and product costs is displayed properly (so there are all kind of routines to check tax rates for logged-in or non-logged-in customers anyway) BUT the subtotal is still the price with VAT , e.g. 400€ instead of 340€. The customer still needs to create an account an log-in just to see how much the product will cost him :( Any ideas how to change this? (sorry if this has already been discussed, I scanned the previous posts but there are 36 pages...)
  11. Thanks, that helped, I get results now for "sc', 'sch' ... :) There was one little mistake in the fix: replace preg_with mb_ereg_replace I guess it should be replace preg_replace with mb_ereg_replace I still occasionally get the mistake 'no matches' at all with German language in MS Edge, but only when I open the start page in Edge and do the search before anything else. I guess it has to do with an addon for the EU cookie acceptance ('with continuing you agree to the usage as per our cookie policy' *) as it works when I do a few clicks on my site before searching. *Hmm, makes me think of an off-topic here: Is the cookie message still up to the latest GDPR laws as it implicitly assumes confirmation by just continuing to use the site?? (It is the header tag module called 'Cookie Compliance Message') Everything else should be GDPR-ready on my site by now, but I did not think about this addon.
  12. Another addition: After switching languages a few times, it suddenly also works in German with Edge/IE (?!)
  13. EDIT: I just found the problems a) und b) are both only for German language, when English is selcted it is all fine) More problems/questions: a) "No matches" when I search for "sc" or "sch" although it finds 45 matches for "sche"?? !! ( Min Characters Required on 2) (works properly for "fe", "fen", "fend", just not "sch") b) It does not seem to work at all with MS Edge / Internet Explorer here. Whatever I type into the search field: no matches (Both your demo site and the grandpas site work with these browsers as well here) Sorry for the many question :( The css editing worked fine :)
  14. Thanks, that was the reason. One remaining problem: where can I change some background or text colours of the search results shown in the box? With my current theme (from some theme switcher module) it is black text on dark grey background, not readable at all :(
  15. I just installed the addon to my 2.3.4.1 CE shop (full package from the 234BS folder). Installation worked fine and says it is installed properly, but it does not work at all: The search behaviour (tested with the header search field and a box search field) is like it always was. No search result show up while typing. What can be wrong? Am I missing something?
  16. Thanks for answering. Oops, sorry, I confused modular shopping-cart with modular check-out it seems. Just contacted burt..
  17. I found the solution for a) myself. Changing line 25 of /includes/modules/content/checkout_confirmation/templates/tpl_cm_cc_finalize_order_button.php from echo tep_draw_button(IMAGE_BUTTON_FINALISE_ORDER, 'fas fa-check-circle', null, 'primary', null, 'btn-success btn-block btn-lg'); to echo tep_draw_button(IMAGE_BUTTON_FINALISE_ORDER, 'fas fa-check-circle', null, 'primary', null, 'btn-success'); did the trick. The button is then aligned to the right, and the position changes with the width setting in the module setup in admin :) Still wondering about b)... ?
  18. I installed the add-on, works great so far. Big thank you. Two things however are still bugging me: a) The last 'Finalize my order' button is extremely wide which makes it look rather like an information bar than like a button. This might confuse the customer. When I reduce the width to make it smaller, it moves to the left which is odd somehow. The customer might be used to have it on the right bottom side as in most other shops. How to make it go there? b) Is there a module for checkout_confirmation which adds a check box and a text like 'I accept the TOS ....'. I think it is a must for at least German shops, with GDRP even for all EU shops I believed. ?
  19. I must say that now I am more confused than before. After reading the last posts of this thread - and the other thread that @@Mikepo links to - I understand that very soon (end of March!!) there will be an official v.2.4. What does this mean for me? A) Is this good news for me (the 2.3.4 BS Edge aka 'master' I finally got running at this point will seamless and easily merge into the next version 2.4) ... ... or B )... is it bad news for me (the terrible last three weeks with long nights to get all customer data from my broken old shop into the latest version, adding language file adaptions, changing code for so many details I need, installing all contributions I need, , some luckily modular, others not ... ) have been a waste of time and something similar is necessary again to update to v2.4 ..or.. C) ...I will not care about the official version as the community version is and will be the way to go (it will integrate all improvements and possible new features from the official version) ?? PS: >>If you do not want to wait Not that I could not wait, but with the latest Edge version paypal does not work (customer does not end on checkout_success but in an empty cart) so I was hoping the update of the Paypal app to 5.xx would take care of that, see above..
  20. So I assume that the paypal 5.010 works for others just not for me!? Or am I the only onw with the latest master version using the new paypal app?? As my old OSC shop broke in February (v2.2 updated to a 2.3.1 'Frankenstore' version) I followed the advise from this forum and started with a fresh installation of the responsive 'master' version. So I am using the latest, recommended version, and Paypal is surely the most common payment method, something that must work. It came with the Paypal app 4.039 which one day told me to update to 5.00. I did but this did not work as the new version uses DIR_WS paths. There was no hint that it is not compatible with my version. I updated the paypal app as the master version did not make the customer land on checkout_success (later I found the mistake in line 818 of paypal_standard.php, it links to checkout_process.php instead of checkout_success.php) I use the 5.010 with the paypal_standard.php from the master version now (with line 818 corrected, see above). Or can anyone send me a corrected (FILENAME, DIR_WS,..) version of the paypal_standard.php of 5.010? The one I tried to correct myself sends double emails, one without an order id, and does not show a download link on checkout_succes
  21. I see but it is already installed (and works fine with the other paypal_standard.php). Removing/reinstalling did not help either. I also noticed that with the latest paypal_standard.php sometimes the order id is missing in the confirmation email (both in the text and in the URL to the customer's account product page), or that sometimes there are two confirmation emails, one with the correct order no. and one without. I changed the FILENAME and DIR_WS_ expressions in the file to make it work with my version. What I did NOT change is the TABLE stuff. Is this required as well? What I mean is: Line from paypal_standard.php 5.010: db_query('delete from ' . TABLE_ORDERS . ' where orders_id = "' . (int)$or... The same line in the version that works here (from the latest gburton Master version): db_query('delete from orders where orders_id = "' . (int)$or..
  22. Never heard of a downloads *module*... of course downloads are enabled in admin/configuration. And as said before, the download is still possible from the My account->my orders page, just not on the checkout_success.php And the download link comes back to checkout_success as soon as I use the older paypal_standard.php instead, nothing else changed than going back to this one.
  23. The order status is alright (money received). The customer can also download from his account history, but not from the success page. As said, everything else seems to work as it should.
×
×
  • Create New...