Jump to content


  • Content count

  • Joined

  • Last visited

Everything posted by cupidare

  1. cupidare

    DHL as shipping module

    It is good, that it was a help. For the future it would be nice to make a functional module for this. If you want to contribute feel free to do this on github. Regarding your questions: - To get access to the status I believe you will need an additional code from dhl to get access to this ... I was considering that in the future but helped me out by collecting the tracking data from the previous shipments (the data is stored in the filename) and then check on dhl... - I didn't try the https version... I believe they don't change fixed links... but no idea - I didn't try v3 as it is still working fine
  2. cupidare

    DHL as shipping module

    Hello everybody, I wonder whether there is a live module (best for 234 bs edge) in existence (even for purchase) which enables to create DHL- shipping labels right out of the admin-area and then provide tracking possiblilites for the user ...? If not, how do you effectively manage to send your packages with DHL / oscommerce? Have a nice day cupidare
  3. cupidare

    DHL as shipping module

    Hello @philpla I have a quick and dirty solution that works for me... it's an adaption from an answer at the dev-portal as there is / was no official guide how to use it in php when I needed it. There is a quite interesting work at github https://github.com/Petschko/dhl-php-sdk which deals about this more deeply but as my solution worked for me I never implemented this into my system. so goto https://github.com/cupidare/dhl-labels this applies some changes to orders.php in admin and adds a new file which needs your login/profile information. Please not that every comment is in german. This was never thought as an official module as I am no professional coder. That's why it is far from modular and very basic. Additional create a folder where to store the labels (in this case dhl_labels) The idea is to go to the order in admin, enter the weight of the package and create the label. This is based on v.2.2 of the dhl-api. It should still be working despite v3 is available.
  4. Hello, recently I have a problem with buttons (since updating to frozen and php 7.1). when I define a button without specifying the type the following strange thing appears in function tep_draw_button() // Output a jQuery UI Button function tep_draw_button($title = null, $icon = null, $link = null, $priority = null, $params = null, $style = null) { static $button_counter = 1; $types = array('submit', 'button', 'reset'); if ( !isset($params['type']) ) { $params['type'] = 'submit'; //here the value assignment is "s" instead of "submit" } And therefore the buttons don't work with a link. Has anyone a hint?
  5. by adding a product to the cart, the shopping_cart.php seems to be broken:
  6. OSCOM CE Phoenix & other I am a little bit confused regarding the language files: - in some there is "const" in some "define" - some include a closing "?>" tag - some don't Is there any mechanism according to which one could bring a little order to it? Thanks in advance
  7. cupidare

    conventions in language files

    @burt Thank you for pointing this out again. According to https://www.php.net/manual/en/language.basic-syntax.phptags.php it is preferable to omit the closing tag in all files containing only php code. Does it mean, that we should omit all ?> on all ends of the pages here? This wouldn't affect the languages files only... Do I understand correctly that the reason is to avoid unwanted character addition to the output and any accidently added char would trigger an error (which informs one, that there are unwanted chars)? Personally I would prefer const over define in language definitions for readability (we don't need conditions there)
  8. I can encourage everyone to update to the latest version including bs4: My page increased at PageSpeed Insights from frozen to the latest version from a score of 91 to 98... Thank you to Gary and all those contributing
  9. cupidare

    Are you ready for Brexit?

    I believe the intention of this thread is not to discuss pros and cons [here] but to prepare yourself. Preparation is always a good thing... I found the durch discussing funny... No need to delete it... Just my opinion
  10. Thank you very much for the quick response. My problem is that when entering an email-address that already exists a warning appears that this mail already exists. That's the case when an registered user tries to pwa with the same address. That's why I wanted to remove the check. But now I understand the problem of duplicated accounts. What kind of checks depend on unique mail addresses? I already removed the necessity of logins for reviews and testimonials and replaced it by google capcha.
  11. I like this module very much and more than 80% of our useres use this module ... Just a simple stupid question: Why is the mail checked in account_pwa.php? Shouldn't be it up to the user to enter whatever mail he wants? What is with returning visitors? I am planning to make it more easy for custumers to checkout and I am thinking of removing the login modules by just using account_pwa. Of course, customers don't have so much overview about former orders but to be honest: the benefit of a faster and more efficient checkout with the possiblility to decrease the amount of abandoned orders compensates this for sure. In times of auto-filling forms it is faster to enter the address details then to remember a password. I recently made an order the same way - without the question of creating an account. It was extremely fast and I was able to track my orders via an unique key in the confirmation mail. So my question again: are there some problems in the background when one removes the check for existing mail addresses? Thank you!
  12. cupidare

    Frozen: tep_draw_button problem

    I believe by now, that the problem is connected to this https://tehnoblog.org/php-7-1-warnings-illegal-string-offset-cannot-assign-empty-string-to-string-offset-working-fine-in-php-7-0-and-lower/ That means in php 7.1+ an array cannot be defined by an empty string without specifying it an array. Not sure whether this affects other parts of the code
  13. cupidare

    Frozen: tep_draw_button problem

    I changed (hopefully) all references with ' ' to null. But I was curious if anybody else has this kind of problem. Thank you!
  14. cupidare

    Frozen: tep_draw_button problem

    It is definetly a new behaviour. I used also some addons which also define the button with ' ' instead of Null... Is it a "problem" with php?
  15. cupidare

    Frozen: tep_draw_button problem

    Hello @Tsimi, Thank you for your reply. Your way of button creation normally works for me. I want the following button tep_draw_button('call me', 'fa fa-lg fa-phone', "tel:0049XXXXXX", '', '', 'btn-info') The button itself appears, but it doesn't work (the link is missing). The re-definition of the button (None -> to "submit") just defines to "s" instead to "submit" EDIT: It works only when using Null instead of "" (empty). Is this something new?
  16. An open source software that relys only on one person is not open source but one source. Harald did a good job and now he should acknowledge that time is moving on. Oscommerce is a great project and only needs a little more structure and marketing in my opinion.
  17. why is it impossible to make CE an official release? its just a link on the main page of oscommerce.com - isn't it? I don't think it's dead. Everybody now has a stabile code base which won't change rapidly and one can make sofisticated easy addons. It's more up to date (php 7+) and more flexible than ever before. And with fully integration of gdpr (thanks to @Burt) Where the devolopment goes? I hope Gary has a plan for this. Off course this has not to be the same code base. Maybe time for something new? We have to prove unity here: yes we want an open source solution, yes we know, that developers need financial support
  18. maybe in checkout_process.php one has to remove the hook- registration since this is done in application_top recently...
  19. just a cosmetic question: are the $HTTP_POST_VARS declarations in admin/orders.php to be transformed to $_POST and so on in the future (I know, there is the compatibility var still running)? Thank you for maintainig this great addon! It is more or less mandatory for all shops due to the gdpr regulation...
  20. cupidare

    Product listing

    Hello @raiwa , I believe it was already asked - but I didn't find an answer: Is there a way to use the .webp format instead of jpg or png? Thank you for the great module
  21. Hello, I installed a fresh the (latest bs-) oscommerce and configured Paypal. Everything is working (order is processed, order status set, email send) but Paypal returns to an empty cart. Of course I added PDT, set checkout_process in the return url (Indeed, if the PDT is not entered into the configuration, the checkout_process doesn't load at all with an error). I have no idea how to proceed. the only way the checkout confirmation.php is shown is when changing checkout_process.php; // if there is nothing in the customers cart, redirect them to the shopping cart page if ($cart->count_contents() < 1) { // tep_redirect(tep_href_link('shopping_cart.php')); } tep_redirect(tep_href_link('checkout_success.php')); } But this should not be the right way. It seems that the cart is emptied somewhere and then forwarding the user to the empty cart. Any hints? Thank you!
  22. cupidare

    paypal returns to empty shopping cart

    it only affects the out-of-the-box bs installation... As far as I know v5.018 is not really official bs-compatible. It seems that the patches are still pushed out in the "old-fashion" After this tiny change everything works well for me
  23. cupidare

    paypal returns to empty shopping cart

    Thank you for your reply I am using the paypal app of course. the error is in my opinion in includes/modules/payment/paypal_standard.php function after_process() { global $cart; $cart->reset(true); // unregister session variables used during checkout tep_session_unregister('sendto'); tep_session_unregister('billto'); tep_session_unregister('shipping'); tep_session_unregister('payment'); tep_session_unregister('comments'); tep_session_unregister('cart_PayPal_Standard_ID'); //wrong //tep_redirect(tep_href_link('checkout_process.php', '', 'SSL')); //right tep_redirect(tep_href_link('checkout_success.php', '', 'SSL')); } It should be changed in the git-respository
  24. cupidare

    Slim Checkout for BS

    This is a really nice addon, and it works without any trouble here... one question: what do you think about including login.php to the hiding options? It's just if one decided to order the cart there shouldn't be any anoying stuff... Thank you for sharing this module
  25. What do you mean with "end of the road"?