Jump to content


  • Content count

  • Joined

  • Last visited

1 Follower

Profile Information

  • Real Name

Recent Profile Visitors

4,534 profile views
  1. I can encourage everyone to update to the latest version including bs4: My page increased at PageSpeed Insights from frozen to the latest version from a score of 91 to 98... Thank you to Gary and all those contributing
  2. cupidare

    Are you ready for Brexit?

    I believe the intention of this thread is not to discuss pros and cons [here] but to prepare yourself. Preparation is always a good thing... I found the durch discussing funny... No need to delete it... Just my opinion
  3. Thank you very much for the quick response. My problem is that when entering an email-address that already exists a warning appears that this mail already exists. That's the case when an registered user tries to pwa with the same address. That's why I wanted to remove the check. But now I understand the problem of duplicated accounts. What kind of checks depend on unique mail addresses? I already removed the necessity of logins for reviews and testimonials and replaced it by google capcha.
  4. I like this module very much and more than 80% of our useres use this module ... Just a simple stupid question: Why is the mail checked in account_pwa.php? Shouldn't be it up to the user to enter whatever mail he wants? What is with returning visitors? I am planning to make it more easy for custumers to checkout and I am thinking of removing the login modules by just using account_pwa. Of course, customers don't have so much overview about former orders but to be honest: the benefit of a faster and more efficient checkout with the possiblility to decrease the amount of abandoned orders compensates this for sure. In times of auto-filling forms it is faster to enter the address details then to remember a password. I recently made an order the same way - without the question of creating an account. It was extremely fast and I was able to track my orders via an unique key in the confirmation mail. So my question again: are there some problems in the background when one removes the check for existing mail addresses? Thank you!
  5. cupidare

    product reviews google indexing

    These changes were applied to ht_canonical.php in includes/modules/header_tags ...
  6. cupidare

    product reviews google indexing

    It seems that that this module has no support for page=XX in some pages (such as products_new.php or similar)... this worked for me (also for my other pages, with "page" such as my testimonials page) : case 'products_new.php': if (isset($_GET['page']) && tep_not_null($_GET['page'])) { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, 'page=' . (int)$_GET['page'], 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } else { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, null, 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } break; and the canonical link shows to the correct page (at least in my understanding)
  7. cupidare

    Frozen: tep_draw_button problem

    I believe by now, that the problem is connected to this https://tehnoblog.org/php-7-1-warnings-illegal-string-offset-cannot-assign-empty-string-to-string-offset-working-fine-in-php-7-0-and-lower/ That means in php 7.1+ an array cannot be defined by an empty string without specifying it an array. Not sure whether this affects other parts of the code
  8. cupidare

    Frozen: tep_draw_button problem

    I changed (hopefully) all references with ' ' to null. But I was curious if anybody else has this kind of problem. Thank you!
  9. cupidare

    Frozen: tep_draw_button problem

    It is definetly a new behaviour. I used also some addons which also define the button with ' ' instead of Null... Is it a "problem" with php?
  10. cupidare

    Frozen: tep_draw_button problem

    Hello @Tsimi, Thank you for your reply. Your way of button creation normally works for me. I want the following button tep_draw_button('call me', 'fa fa-lg fa-phone', "tel:0049XXXXXX", '', '', 'btn-info') The button itself appears, but it doesn't work (the link is missing). The re-definition of the button (None -> to "submit") just defines to "s" instead to "submit" EDIT: It works only when using Null instead of "" (empty). Is this something new?
  11. Hello, recently I have a problem with buttons (since updating to frozen and php 7.1). when I define a button without specifying the type the following strange thing appears in function tep_draw_button() // Output a jQuery UI Button function tep_draw_button($title = null, $icon = null, $link = null, $priority = null, $params = null, $style = null) { static $button_counter = 1; $types = array('submit', 'button', 'reset'); if ( !isset($params['type']) ) { $params['type'] = 'submit'; //here the value assignment is "s" instead of "submit" } And therefore the buttons don't work with a link. Has anyone a hint?
  12. An open source software that relys only on one person is not open source but one source. Harald did a good job and now he should acknowledge that time is moving on. Oscommerce is a great project and only needs a little more structure and marketing in my opinion.
  13. why is it impossible to make CE an official release? its just a link on the main page of oscommerce.com - isn't it? I don't think it's dead. Everybody now has a stabile code base which won't change rapidly and one can make sofisticated easy addons. It's more up to date (php 7+) and more flexible than ever before. And with fully integration of gdpr (thanks to @Burt) Where the devolopment goes? I hope Gary has a plan for this. Off course this has not to be the same code base. Maybe time for something new? We have to prove unity here: yes we want an open source solution, yes we know, that developers need financial support
  14. maybe in checkout_process.php one has to remove the hook- registration since this is done in application_top recently...
  15. just a cosmetic question: are the $HTTP_POST_VARS declarations in admin/orders.php to be transformed to $_POST and so on in the future (I know, there is the compatibility var still running)? Thank you for maintainig this great addon! It is more or less mandatory for all shops due to the gdpr regulation...