Jump to content

cupidare

Members
  • Content count

    58
  • Joined

  • Last visited

2 Followers

Profile Information

  • Real Name
    JK

Recent Profile Visitors

5,959 profile views
  1. cupidare

    DHL as shipping module

    It is good, that it was a help. For the future it would be nice to make a functional module for this. If you want to contribute feel free to do this on github. Regarding your questions: - To get access to the status I believe you will need an additional code from dhl to get access to this ... I was considering that in the future but helped me out by collecting the tracking data from the previous shipments (the data is stored in the filename) and then check on dhl... - I didn't try the https version... I believe they don't change fixed links... but no idea - I didn't try v3 as it is still working fine
  2. cupidare

    DHL as shipping module

    Hello @philpla I have a quick and dirty solution that works for me... it's an adaption from an answer at the dev-portal as there is / was no official guide how to use it in php when I needed it. There is a quite interesting work at github https://github.com/Petschko/dhl-php-sdk which deals about this more deeply but as my solution worked for me I never implemented this into my system. so goto https://github.com/cupidare/dhl-labels this applies some changes to orders.php in admin and adds a new file which needs your login/profile information. Please not that every comment is in german. This was never thought as an official module as I am no professional coder. That's why it is far from modular and very basic. Additional create a folder where to store the labels (in this case dhl_labels) The idea is to go to the order in admin, enter the weight of the package and create the label. This is based on v.2.2 of the dhl-api. It should still be working despite v3 is available.
  3. by adding a product to the cart, the shopping_cart.php seems to be broken:
  4. cupidare

    conventions in language files

    @burt Thank you for pointing this out again. According to https://www.php.net/manual/en/language.basic-syntax.phptags.php it is preferable to omit the closing tag in all files containing only php code. Does it mean, that we should omit all ?> on all ends of the pages here? This wouldn't affect the languages files only... Do I understand correctly that the reason is to avoid unwanted character addition to the output and any accidently added char would trigger an error (which informs one, that there are unwanted chars)? Personally I would prefer const over define in language definitions for readability (we don't need conditions there)
  5. OSCOM CE Phoenix & other I am a little bit confused regarding the language files: - in some there is "const" in some "define" - some include a closing "?>" tag - some don't Is there any mechanism according to which one could bring a little order to it? Thanks in advance
  6. I can encourage everyone to update to the latest version including bs4: My page increased at PageSpeed Insights from frozen to the latest version from a score of 91 to 98... Thank you to Gary and all those contributing
  7. cupidare

    Are you ready for Brexit?

    I believe the intention of this thread is not to discuss pros and cons [here] but to prepare yourself. Preparation is always a good thing... I found the durch discussing funny... No need to delete it... Just my opinion
  8. Thank you very much for the quick response. My problem is that when entering an email-address that already exists a warning appears that this mail already exists. That's the case when an registered user tries to pwa with the same address. That's why I wanted to remove the check. But now I understand the problem of duplicated accounts. What kind of checks depend on unique mail addresses? I already removed the necessity of logins for reviews and testimonials and replaced it by google capcha.
  9. I like this module very much and more than 80% of our useres use this module ... Just a simple stupid question: Why is the mail checked in account_pwa.php? Shouldn't be it up to the user to enter whatever mail he wants? What is with returning visitors? I am planning to make it more easy for custumers to checkout and I am thinking of removing the login modules by just using account_pwa. Of course, customers don't have so much overview about former orders but to be honest: the benefit of a faster and more efficient checkout with the possiblility to decrease the amount of abandoned orders compensates this for sure. In times of auto-filling forms it is faster to enter the address details then to remember a password. I recently made an order the same way - without the question of creating an account. It was extremely fast and I was able to track my orders via an unique key in the confirmation mail. So my question again: are there some problems in the background when one removes the check for existing mail addresses? Thank you!
  10. cupidare

    product reviews google indexing

    These changes were applied to ht_canonical.php in includes/modules/header_tags ...
  11. cupidare

    product reviews google indexing

    It seems that that this module has no support for page=XX in some pages (such as products_new.php or similar)... this worked for me (also for my other pages, with "page" such as my testimonials page) : case 'products_new.php': if (isset($_GET['page']) && tep_not_null($_GET['page'])) { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, 'page=' . (int)$_GET['page'], 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } else { $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, null, 'NONSSL', false) . '" />' . PHP_EOL, $this->group); } break; and the canonical link shows to the correct page (at least in my understanding)
  12. cupidare

    Frozen: tep_draw_button problem

    I believe by now, that the problem is connected to this https://tehnoblog.org/php-7-1-warnings-illegal-string-offset-cannot-assign-empty-string-to-string-offset-working-fine-in-php-7-0-and-lower/ That means in php 7.1+ an array cannot be defined by an empty string without specifying it an array. Not sure whether this affects other parts of the code
  13. cupidare

    Frozen: tep_draw_button problem

    I changed (hopefully) all references with ' ' to null. But I was curious if anybody else has this kind of problem. Thank you!
  14. cupidare

    Frozen: tep_draw_button problem

    It is definetly a new behaviour. I used also some addons which also define the button with ' ' instead of Null... Is it a "problem" with php?
  15. cupidare

    Frozen: tep_draw_button problem

    Hello @Tsimi, Thank you for your reply. Your way of button creation normally works for me. I want the following button tep_draw_button('call me', 'fa fa-lg fa-phone', "tel:0049XXXXXX", '', '', 'btn-info') The button itself appears, but it doesn't work (the link is missing). The re-definition of the button (None -> to "submit") just defines to "s" instead to "submit" EDIT: It works only when using Null instead of "" (empty). Is this something new?
×