Jump to content

Martin1

Members
  • Content count

    52
  • Joined

  • Last visited

  • Days Won

    1

Martin1 last won the day on June 23 2014

Martin1 had the most liked content!

1 Follower

Profile Information

  • Real Name
    Martin Christensen
  1. Thank you, Strangely enough the tax is now calculated exactly like I want it on my site after I changed it back from vat to the standard setting. I presume something on my site caused it to get it wrong before but it's strange because I hardly changed anything which is a bit scary. I tried with the exact same amount in my shopping basket and now got the values I expected to begin with. So everything seems to work. I excluded my gift certificate and this works as well.
  2. Oh ok. My case is special because actually the stock items that has 0 tax should preferably also be ignored by the quantity discount, so actually I don't really need it to be able to handle different tax rates. It is a gift certificates, which should not be taxed on purchase or have quantity discount since the tax and the discount are applied when the gift certificate is used. So what I wish for in my wildest dreams ;) 1. That it could calculate the tax according to how I did it in my example. 2. That it could be set to ignore specific stock items. However if you wished to add support for several tax rates in the same purchase I could imagine that simply calculating the average tax rate in the beginning would require the fewest code changes. Example: Stock 1 (price before tax): 100 tax: 10% Stock 2 (price before tax): 200 tax: 25% Average tax rate = (100*10 + 200*25)/(100+200) = 20% Are there any chance you would develop, what I wish for perhaps if I make a donation for you?
  3. Yes I tried it earlier and now again with some numbers that are a bit easier for me to grasp. I got this result: Sub total: 100 quantity discount (10%) = 8 tax: 18,40 total: 92 However it's not quite what I need. Below I tried to express how the calculation is normally done in Denmark. We simply subtract the discount before tax which then gives the amount eligible for taxation. (It is also possible to subtract the discount after taxes is applied, however then the final tax has to be calculated in the end, which is actually how it worked on my site before I needed different tax rates on different products) Taxable_amount = Sub_total_before_tax - Total_discount Tax = Taxable_amount * Tax_rate_as_fraction Total = Taxable_amount + Tax Or with the numbers: Sub_total_before_tax = 80 Total_discount (80*10/100) = 8 Taxable_amount (80 - 8) = 72 Tax_rate_as_fraction = (25/100) or 0.25 Tax = 72*0.25 = 18 Total = 72 + 18 = 90 I tried to look at the code to see if perhaps I could edit the Vat calculation to suit my needs, but I don't really know where to start because I have close to zero programming skills :-/
  4. Not having taxes included is not an option for me either since the Danish law requires tax included in prices. What I did before was using an addon that calculated the tax afterwards, so all my prices was just entered with tax included and the show with taxes option was set to false. However this doesn't work for me anymore because I have goods with zero tax now and goods with 25% tax. The way I describe it is the only way to do it in Denmark, the total tax should always end being exactly 25% of the total price (Except in cases where the tax is 0 of course). Because it is the the final sales price after deductions that are taxed in Denmark.
  5. I used this contribution for some time and it worked great, but at that time I didn't need it to do tax calculations, since all my prices already included tax. However Now I do and I can't quite understand the results. I tested with the following tax rate: 25% quantity discount: 10% Include tax: false Re-calculate tax: standard I got this result: Sub total: 100 quantity discount (10%) = 8 tax: 14 total: 86 What I expected was this: Sub total: 100 quantity discount (10%) = 8 tax: 18 total: 90 In the result, the price before tax is 80 and after the discount it is 72. 25% of 72 = 18 but the result shows 14. What could be going wrong. By the way I am using osc 2.3.4.
  6. Actually it seems to work well when this code is removed, since I can then only process the payment in case the gift voucher covers the entire amount which is exactly as intended. I'll update if I find any problems with this.
  7. I found that it is the following piece of code, in "checkout_process.php" that redirects to the no payment method error. If I remove it, then it works, however then I can process the payment without selecting a payment method which obviously is not good. if ( ($payment_modules->selected_module != $payment) || ( is_array($payment_modules->modules) && (sizeof($payment_modules->modules) > 1) && !is_object($$payment) ) || (is_object($$payment) && ($$payment->enabled == false)) ) { tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, 'error_message=' . urlencode(ERROR_NO_PAYMENT_MODULE_SELECTED), 'SSL')); }
  8. I am trying to get ccgv to work with osc 2.3.4, and it seems so close to working for me but I seem to be having one issue. If I use a gift certificate and it covers the entire amount then I get to the checkout_confirmation but without any payment method selected (probably intended?) But then when I click to confirm the order, I am trown back to the checkout payment with the message that no payment method has been selected. Does anyone have a clue on how to solve this? I have another issue, which is not a bug but I also use quantity discounts, however it doesn't make sense to have quantity discounts when buying a gift certificate since the quantity discount is also applied when using it. Currently I am without any ideas how to solve this.
  9. Martin1

    Credit Class & Gift Vouchers for 2.3.4

    I am actually trying to get ccgv to work with osc 2.3.4. I seem to be having one issue. If I use a gift certificate and it covers the entire amount then I get to the checkout_confirmation but without any payment method selected (probably intended?) But then when I click to confirm the order, I am trown back to the checkout payment with the message that no payment method has been selected. I have another issue. I also use quantity discounts, but it doesn't make sense to have quantity discounts when buying a gift certificate since the quantity discount is also applied when using it. Currently I am without any ideas how to solve this.
  10. Martin1

    Danish bank transfer

    The old one for osc 2.2 seems to still work properly for osc 2.3 http://addons.oscommerce.com/info/1683
  11. Martin1

    Danish bank transfer

    I am looking for a bank transfer module for oscommerce 2.3, that works well for a danish shop. Does anyone know of one? For oscommerce 2.2 there was this one http://addons.oscommerce.com/info/1683
×