Jump to content

Kolingua

Members
  • Content count

    39
  • Joined

  • Last visited

1 Follower

Profile Information

  1. @@ggbig If I understand right, the idea now is to develop osC 2.4 asap incorporating BS, so maybe it would be more efficient if you fork https://github.com/osCommerce/oscommerce2and make a pull request there with your work on the admin side, and post in http://forums.oscommerce.com/topic/400819-upcoming-changes/
  2. Simple really after you said it, so I don't regret having started this discussion, which has also produced @@frankl's excelent post.
  3. I mean, the first 11 posts of this thread were first published in http://forums.oscommerce.com/topic/399514-bugs-in-gold-version-of-234-responsive/ and later @@burt moved them here. @@burt, I understand you feel disappointed and uncredited for your effort, and I'm sorry for having contributed to that, in part due to my lack of experience here. Anyway, I want to say that I still consider the hardcoding I mentioned as a "bug" in the sense that you claim to mirror osC 2.3.4 and you're not doing so in this point. If I know that in conventional 2.3.4 I can change table names and reflect the new names in /includes/database_tables.php, I expect that I'm able to the same in the bootstrap version. That's how I found the issue: because it didn't work. That this will work differently in future versions of osC is a different issue.
  4. Now this thread IS the place to discuss it. I said that in another thread and then it was moved here. Thanks and sorry @@burt
  5. @@Gergely, that makes a lot of sense, but table names is a different issue. I agree that this thread is not the place to discuss it, but maybe you can give a good reason in short as you did for filenames, or link to somewhere else it's dealt with.
  6. Changing the file names may make sense for a store whose default language is other than English, and unique table names may provide a little extra protection against SQL injection attacks. A poll seems a good idea.
  7. Deprecated as a general osC policy? Do you mean that these files will be suppressed in next versions of osC and file and table names will be hardcoded everywhere and thus not changeable?
  8. Database tables' names are hardcoded in line 36 of catalog/includes/modules/boxes/bm_specials.php, it should be changed to if ($random_product = tep_random_select("select p.products_id, pd.products_name, p.products_price, p.products_tax_class_id, p.products_image, s.specials_new_products_price from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_SPECIALS . " s where p.products_status = '1' and p.products_id = s.products_id and pd.products_id = s.products_id and pd.language_id = '" . (int)$languages_id . "' and s.status = '1' order by s.specials_date_added desc limit " . MAX_RANDOM_SELECT_SPECIALS)) {
  9. Kolingua

    [Addon} Modular Front Page

    Jim, I wonder if it's useful for you to have the file I edited and how to make it reach you.
  10. Kolingua

    [Addon} Modular Front Page

    Thank you, I managed to do that by copying from featured.php, it wasn't difficult.
  11. Kolingua

    [Addon} Modular Front Page

    Great contribution! Is there any reason why the Categories Images module doesn't allow to introduce tittles in the different languages? Would it be very difficult to solve that by copying some code from the other modules? Regards, Juan Antonio
  12. Kolingua

    [Addon} Theme Switcher

    The ThemeRoller Dev Tool bookmarklet seems to be working nicely for seeing changes directly on the store pages but not for downloading. If I click on a download button under a theme name within the gallery tab, the ThemeRoller control panel just goes black and I have to reload the page to get it to work again. If I click on the Download theme button after editing a theme, it does download but without giving the opportunity of checking/choosing the components or version, and the resulting theme folder under development-bundle/themes only contains five .css files (plus the images folder), and does not work properly if I try to use it. Regards,
  13. Kolingua

    [Addon} Theme Switcher

    Yes, that worked! Thanks a lot!
  14. Kolingua

    [Addon} Theme Switcher

    Thank you for your code, you excellent documentation and the help you offer here. After installing Theme Switcher I have lost the localization of the datepicker. I have copied catalog/includes/languages/english/modules/header_tags/ht_theme_switcher.php to catalog/includes/languages/swedish/modules/header_tags/ht_theme_switcher.php (by the way, it would be a good idea to warn in the documentation that this step is needed when using more languages), and I have checked that I have the line define('JQUERY_DATEPICKER_I18N_CODE', 'sv'); in both catalog/includes/languages/swedish.php and catalog/admin/includes/languages/swedish.php, and that i have the filecatalog/ext/jquery/ui/i18n/jquery.ui.datepicker-sv.js with the right settings, but the default English datepicker appears on Swedish pages.
×