New 
lucsangel
-
Posts
47 -
Joined
-
Last visited
-
Days Won
1
Posts posted by lucsangel
-
-
6 minutes ago, lucsangel said:
You made me think of something.... in attributeManagerConfig.class.php I had AM_DELETE_ZERO_STOCK in the QTPro section set to true (as I had AM_USE_QT_PRO obviously set to true as I use it), now set it to false :
$this->add('AM_DELETE_ZERO_STOCK', false); // if true, deletes options combinations with zero quantity from stock
and now the error is gone (with of course the changes you suggested line by line above).
Just in case her are my zipped files
Thank you Rainer
Oh yes, in the zipped files the change to false is not shown as I zipped it before thinking of the QTPro stock deletion.
Sorry for all the trouble.
Bobbee
-
You made me think of something.... in attributeManagerConfig.class.php I had AM_DELETE_ZERO_STOCK in the QTPro section set to true (as I had AM_USE_QT_PRO obviously set to true as I use it), now set it to false :
$this->add('AM_DELETE_ZERO_STOCK', false); // if true, deletes options combinations with zero quantity from stock
and now the error is gone (with of course the changes you suggested line by line above).
Just in case her are my zipped files
Thank you Rainer
-
16 minutes ago, raiwa said:
Hello @lucsangel,
I get an error:
Notice: Undefined index: code_suffix in C:\xampp_php_7_2\htdocs\2341-Frozen-QTPro\admin\attributeManager\classes\attributeManagerInstant.class.php on line 605
related to attributes code only if in attributeManagerConfigclass.php
the correspondant setting is switched to "true":
$this->add('AM_USE_ATTRIBUTE_CODE' , true);So if you do not use attributes code and don't have the correspondant add-on installed you have to keep this switched off instead to remove the code:
$this->add('AM_USE_ATTRIBUTE_CODE' , false);In general any additional add-on support setting should only be switched on if you have the correspondant add-on correct installed. Otherwise it's logic that you get error messages.
Hello Rainer,
It is switched off, never switched it on so why would the part of code in the function mentioned above throw the error?
Bobbee
-
Found that commenting out the code lines 415-430 for Product Attribute Code it goes away and all functions. I do not use Product Attribute Code so I do not know if commenting it out is correct or not but the error does go away. Wonder if I should comment it out elsewhere ?
Also picked up 3 missing semi-colons :
line 402 : <?php echo AM_AJAX_IMAGE?>
line 436: <?php echo AM_AJAX_WEIGHT_PREFIX?>
line 439: <?php echo AM_AJAX_WEIGHT?>
Don't know if they affect anything...
Thank you again for your help !
Bobbee
-
2 hours ago, Jack_mcs said:
@lucsangelI can't see that the SHOW_INVOICE_SHIPPING was ever declared in any of the versions for this addon. So the change you made will stop the error but it will cause the code to always skip that part. Without the change you made, it would most likely do the same since it was not declared and would probably be set to 0. I'll take a closer look at the code when I can and fix that as needed. Thanks for reporting it.
Thank you Jack. It is a great addon.
-
Thank you Rainer.
-
This time I have
Warning/homepages/11/d570016152/htdocs/osc234/cav2mt/attributeManager/attributeManager.php417
Still with Quantity Tracking Professional (QT Pro)
underneath the color option as in the screenshot, so somehow it must have a problem with the QTPro
-
Now it says : Parse error: syntax error, unexpected '$rec' (T_VARIABLE) in /xxx/attributeManager/attributeManager.php on line 536
line 536 with the quotes <?php echo $rec['products_stock_id']; ?>
-
Hello Rainer,
Just uploaded the new version and have a little error that seems to come with QTPro and Attribute Manager but I can not figure out what it is referring to (screenshot included :
Warning /xxxxx/xxxx/attributeManager/attributeManager.php 526line 526 : $val_array=explode(",",$rec[products_stock_attributes]);
On FROZEN CE BS3, PHP 7.2
QTPro was functioning fine and is set to true in attribute manager. There is stock for the product attributes. What do you think?
Bobbee
-
Just now, lucsangel said:
Hello Jack I am using the latest version you uploades v.1.5 https://apps.oscommerce.com/8oFiX&additional-orders-info with FROZEN BS3 and see no control in configuration Additionnal Info for this in particular. So many of the
addons are throwing these types of errors. (sorry my hand slipped and posted without finishing). It happens on PHP 7.2, not in the earlier versions
-
1 minute ago, Jack_mcs said:
@lucsangelIt looks like the reason for the failure in this case is because 'SHOW_INVOICE_SHIPPING' is not defined. I looked in V 1.5 (the last released version) and don't see it there. What version of this addon are you using? And what version of oscommerce? Is there a setting in this addons settings that allows you to control that item?
Hello Jack I am using the latest version you uploades v.1.5 https://apps.oscommerce.com/8oFiX&additional-orders-info with FROZEN BS3 and see no control in configuration Additionnal Info for this in particular. So many of the
-
Hi Jack,
I see that there has been no activity in a while but just to update for those who are still using this useful add-on... passing to php 7.2 on the admin side, when you click "invoice" for an order the undefined constant error comes up for SHOW_INVOICE_SHIPPING.
To fix it I just put it in single quotes 'SHOW_INVOICE_SHIPPING', so in admin/includes/functions/general.php :
CHANGE
***************************************************
////
/*** BOF: Additional Orders Info ***/
// Return orders shipping method
function tep_get_orders_shipping_method($order_id) {
$check_order_query= tep_db_query("select title from " . TABLE_ORDERS_TOTAL . " where orders_id='" . $order_id . "' and class='ot_shipping'");
$check_order= tep_db_fetch_array($check_order_query);
if (SHOW_INVOICE_SHIPPING=='2' and ($check_order['title']=='United Parcel Service' or $check_order['title']=='United States Postal Service')) {
// return short version on UPS and USPS***************************************
TO
**************************************
////
/*** BOF: Additional Orders Info ***/
// Return orders shipping method
function tep_get_orders_shipping_method($order_id) {
$check_order_query= tep_db_query("select title from " . TABLE_ORDERS_TOTAL . " where orders_id='" . $order_id . "' and class='ot_shipping'");
$check_order= tep_db_fetch_array($check_order_query);
if ('SHOW_INVOICE_SHIPPING'=='2' and ($check_order['title']=='United Parcel Service' or $check_order['title']=='United States Postal Service')) {
// return short version on UPS and USPS*******************************************************
Works for me but you are the programmer so you can check to see if it is the right fix.
Bobbee
-
Thank you Rainer, that did do the trick ! Have a good day.
Bobbee
-
Hello All,
Having used this for years testing on PHP 7.2 does pick up an error :
"Warning: Use of undefined constant title - assumed 'title' (this will throw an Error in a future version of PHP) in xxx/catalog/admin/mm_responsemail.php on line 228"
Easy to fix :
Find around line 228 (244 in the original file):
$output_subject = $mail[title];
CHANGE TO (missing the quotes around title):
$output_subject = $mail['title'];Also for those having error "Headers already sent" the easiest way to fix it is to go to the templates in the database and take out all the white space in each one. Works like a charm.
Bobbee
-
Rainer I have for years promoted your add-ons as I feel they are excellent and recommend them to everyone. And yes there are hosters out there who are apparently trying to get onto PHP 7.2 as fast as possible (why on earth I do not know why, just noted that some going to the cloud now are forcing as if the cloud needs it), stating that as of Dec. 2018 they will be charging for support if not accepting the change ! One of my hosters does give till dec. 2019 before charging but as I have diversified hosting to test for those people that I help on the most popular hosters I find the problems they have myself with brutal surprises. And yes I have folks in "panic" mode as you call it because time is too short to find and switch hosters in such a short delay. I know I can count on certain "Ambassadors" and others when there is a problem as they are the ones who wrote the code. SInce I had always had little problems with this add-on I slipped it into the new test for FROZEN BS4 on my public site sure not to have a problem on PHP7.1 as I am trying to promote the excellent responsive work that everyone has done on it.
I was not putting "pressure" on you... I only made one post without begging you to find an answer ! You are offended and I am too. I pulled the site temporarily as I have to help the others I assist for free as this does not bring me a dime but takes a hell of a lot of time.
So I will not bother you any longer. Once I help the others, hoping they won't ask for this add-on, I will be slipping the new test site on to another hoster and in the meantime just work with those on the FROZEN version BS3.
Bobbee
-
16 hours ago, raiwa said:
Errors produced in checkout_process.php shouldn't show puplicly except for fatal errors which stop the page to be processed. This page only processes the order, so it never shows on the screen any content and neither warning errors.
You have got info how to supress the warning errors:
You should also be able to revert your php level to 7.1 until you have solved all errors.
Please don't write that kind of "Panic" messages, I saw your other messages regarding PHP 7.2 warning and notice errors.
Anyway you should test your store under PHP 7.2 in a develop environment before going online. No one here will assume any responsability that your live store breaks or shows errors under PHP 7.2.
I can only help you if you give me the information I asked, so I can try to reproduce the error.
By "stock" I refer to your settings in Admin => Stock
"Please don't write that kind of "Panic" messages, I saw your other messages regarding PHP 7.2 warning and notice errors."
John it was not a "panic" message just factual. I have 5 test sites on which I am trying to find and fix all php 7.2 errors to help others like me who suddenly find themselves thrown onto php 7.2 - THEY probably have operational sites and are in panic mode and we need to find solutions for the most appreciated add-ons like this one. My test sites help the add-on developpers to improve the add-ons before there is a panic so if this offends you I am sorry you take it that way. I will be slipping this particular site into a sub folder for more testing on your add-on.
-
On 10/26/2018 at 9:15 PM, HVACMan said:
I guess I am the earliest to post on the newest version of the Seo Urls 5
I thank FWR Media for puttng this up and directions for how to install. The author give a list of files that need to be "modified" but no way to know what part need to be modified to what. May be I am too new to post this message. any one there has any clue?
also they talked about file compare, If I do a fresh install, nothing is changed, what the compare is for?
any answer is appreciated.
Thanks.
JohnM
Hi John,
What you need is to download Winmerge which allows to compare files.
Next open in WInmerge in the left side one of FWR Media's files from the "compare files" folder, for example in "admin" the file categories.php and in the right window open the file by the same name in the same folder from your installed files. Winmerge will highlight the changes so you can modify the file easily. Once you get the hang of it editing files becomes easy. Then you upload the modified file to your server. I generally keep a copy of the file changed prior to changes just is case I have to roll back.
Hope this helps.
Bobbee
-
Hello,
I had a fresh install of 2.3.4.1 CE FROZEN (uploaded this week from GitHub with all latest merge) and installed your QTPro as the first add-on - nothing else installed. All looked good and functioned perfectly and the next day the server passed to php 7.2 and bingo, the errors. Had to shut it down as the errors showed publicly so I can not get back in. All was configured as you explained to do and it did work like a charm until the fatal passage. Comparing all the files they compare perfectly to yours (and it was working).
Barbara
-
Hello,
Fell upon a php 7.2 error in checkout on FROZEN with your last update (all worked fine before the server switched from 7.0 to 7.2) :
Warning: Cannot assign an empty string to a string offset in /xxx/xx/xxx/xx/catalog/includes/hooks/shop/checkout_process/qtpro_hooks.php on line 38
Warning: Cannot modify header information - headers already sent by (output started at /xxx/xx/xx/xx/catalog/includes/hooks/shop/checkout_process/qtpro_hooks.php:38) in /xxx/xx/xxx/xxx/catalog/includes/functions/general.php on line 49
line 38 is
$check_stock[$i] = $this->check_stock_qtpro($order->products[$i]['id'], $order->products[$i]['qty']);
Thank you in advance for your help.Bobbee
-
Perfect Jack ! Thank you.
-
-
Hi Jack,
All worked great in FROZEN until php 7.2 reared it's head on my server, now getting in admin :
Warning: count(): Parameter must be an array or an object that implements Countable in /xxx/xx/xxx/xx/xx/xx/includes/functions/sitemap.php on line 47
Oh the joys of php…. what else lies ahead for us
Bobbee
-
Hello,
I have your most recent version installed on Frozen and get this error with php 7.2 :
Warning: count(): Parameter must be an array or an object that implements Countable in /xxx/xx/xx/xx/catalog/includes/modules/content/shopping_cart/cm_sc_continue_recently_viewed.php on line 66
Line 65-69 are:$back = sizeof($navigation->path)-2;
$count = count($products);
if( isset($products[$count-1]['id']) ) {
$continueButtonId = tep_get_product_path(str_replace(strstr($products[$count-1]['id'], '{'), '', $products[$count-1]['id']));
}Any ideas would be greatly appreciated.
Barbara
-
Hi Jack ! Just to say thanks for this add-on as Nivo Slider has always had hiccups. In comparison, this is so easy to install and has so many different transitions AND is truly responsive so forget the others !!! As always we can count on you to come up with the best solutions. Thanks again, Jack.
AJAX Attribute Manager support
in General Add-Ons Support
Posted
Rziner I do not have the error anymore. The image of the error was in one of my previous posts. For now all is well after setting that call to false.