mattjt83
-
Content count
557 -
Joined
-
Last visited
-
Days Won
24
-
I had a quick look at that addon and there isn't anything in it that allows you to customize the image shown. You may be able to grab some custom code from the addthis website but I'm not sure since I don't use it.
-
If you can post the code for the addon and also which addon you are referring to someone can probably give you a little better guidance as to what needs to be changed.
-
-
Support thread for JcM Adaptive Images addon
mattjt83 replied to JcMagpie's topic in osCommerce Online Merchant Community Bootstrap Edition
The stray </form> tag could cause unforeseen issues and invalidates the html. Not relevant though since you updated the module to a header_tag. I can appreciate what you are doing and I think it's great you're giving back to the community. I have edited your header_tag module so that it is coded according to the proper standards and hopefully doesn't cause issues for users. <?php /* $Id$ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2018 osCommerce Released under the GNU General Public License V1.0 JcM Adaptive Images 16-7-2018 Adaptive Images by Matt Wilcox is licensed under a Creative Commons Attribution 3.0 Unported License. This addon uses the code by MattWilcox/Adaptive-Images from GitHub It is used as supplied and all credit is with original author. All this add-on does is allow you to install in as a module you can turn on and off. */ class ht_jcm_adaptive_images { var $code = 'ht_jcm_adaptive_images'; var $group = 'header_tags'; var $title; var $description; var $sort_order; var $enabled = false; function __construct() { $this->title = MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_TITLE; $this->description = MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_DESCRIPTION; if ( defined('MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_STATUS') ) { $this->sort_order = MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_SORT_ORDER; $this->enabled = (MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_STATUS == 'True'); } } function execute() { global $oscTemplate; $output = <<<EOD <script>document.cookie='resolution='+Math.max(screen.width,screen.height)+'; path=/';</script> EOD; $oscTemplate->addBlock($output, $this->group); } function isEnabled() { return $this->enabled; } function check() { return defined('MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_STATUS'); } function install() { tep_db_query("insert into configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable JcM Adaptive Images Module', 'MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_STATUS', 'True', 'Do you want to allow images script to be added to the page header?', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())"); tep_db_query("insert into configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Adaptive Images for OcS', 'MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_DESCRIPTION_STATUS', 'True', 'adaptive images', '6', '0', 'tep_cfg_select_option(array(\'True\'), ', now())"); tep_db_query("insert into configuration (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_SORT_ORDER', '0', 'Sort order of display. Lowest is displayed first.', '6', '0', now())"); } function remove() { tep_db_query("delete from configuration where configuration_key in ('" . implode("', '", $this->keys()) . "')"); } function keys() { return array('MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_STATUS', 'MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_DESCRIPTION_STATUS', 'MODULE_HEADER_TAGS_JCM_ADAPTIVE_IMAGES_SORT_ORDER'); } } ?> -
Support thread for JcM Adaptive Images addon
mattjt83 replied to JcMagpie's topic in osCommerce Online Merchant Community Bootstrap Edition
I looked at the code again and I'm not seeing an opening <form> tag. Also there is zero need for a <form></form> to be used with this snippet or a <div></div>. A header tag would make a lot more sense in this circumstance and would also get the script into the <head> like the author suggests. -
-
Support thread for JcM Adaptive Images addon
mattjt83 replied to JcMagpie's topic in osCommerce Online Merchant Community Bootstrap Edition
@JcMagpie You have a stray </form> in your template file. Also, just a couple thoughts... 1. This probably could/should be a header_tag module rather than a content module since it just inserts a single line of javascript. No use in sticking it inside a <div> and also he recommends it being in the <head> section preferably before any other scripts. 2. I think any file that is using the code from Matt Wilcox should give him credit. -
-
[Contribution] Customer Support Portal
mattjt83 replied to GLWalker's topic in General Add-Ons Support
@GLWalker That would be awesome. If you need some incentive just PM me the details :)- 31 replies
-
- 1
-
-
- manual order entry
- administration
- (and 3 more)
-
[Contribution] Customer Support Portal
mattjt83 replied to GLWalker's topic in General Add-Ons Support
Typo in includes/modules/header_tags/customer_service/modules/bstour/dashboard.js { element: ".tour-step.dashboard-outro", orphan: true, backdrop: true, title: "Dashboard Complete!", content: "Congratulations! You finished the dashboard tour. Perform any action to take another tour and learn about it. When you complete all the tours, ask an adminstrtor to switch it off for your account." } Should be { element: ".tour-step.dashboard-outro", orphan: true, backdrop: true, title: "Dashboard Complete!", content: "Congratulations! You finished the dashboard tour. Perform any action to take another tour and learn about it. When you complete all the tours, ask an administrator to switch it off for your account." } -
[Contribution] Customer Support Portal
mattjt83 replied to GLWalker's topic in General Add-Ons Support
Found a typo in includes/modules/header_tags/customer_service/template_top.php <div class="alert-message alert-message-succss"> Assuming it should be <div class="alert-message alert-message-success"> -
[Contribution] Customer Support Portal
mattjt83 replied to GLWalker's topic in General Add-Ons Support
Just noting a couple of errors... in #scModal <input type="email" name="user_email" required aria-required="true" placeholder="Search..." class="form-control" class="form-control"/> In #osModal <input type="text" name="oID" required aria-required="true" placeholder="Search..." class="form-control" class="form-control"/> in #csModal <input type="text" name="search" required aria-required="true" placeholder="Search..." class="form-control" class="form-control"/> All pages are missing (includes/modules/header_tags/customer_service/template_top.php) <!DOCTYPE html> -
[Contribution] Customer Support Portal
mattjt83 replied to GLWalker's topic in General Add-Ons Support
@GLWalker Is there a way to edit existing orders? I'm giving this a spin but I didn't see that option. -
Can't load the two new topics Harald posted. Are they not publicly available?
-
UK shipping module needed for 2.3.4 BS and works on PHP7
mattjt83 replied to Enzo_UK's topic in Shipping Modules
@burt I thought you had also partially merged into the Matrix? :) -
I've been working on this for a while now but real life has been getting in the way. The difference with mine is just that you don't have to create an account first. Yes, eventually the person will have to enter the data regardless but it's how they perceive the task that matters. I think it's very important to understand your customers and design your site/checkout experience around that. If most of your customers are one-off sort of things than a guest checkout can make a lot of sense.
-
Here's a good article: https://www.smashingmagazine.com/2017/05/better-form-design-one-thing-per-page/ I might actually rework my checkout with this in mind.
-
I had a one page checkout on my site and it led to all sorts of issues. It was inherently glitchy and confused customers. After that I decided to code and sell Better Checkout. I still use it on my site but I do not sell it anymore because I don't like all the changes required to make payment modules work properly. Basically, your customers can checkout with or without an account and it's seamless. It splits the checkout up into manageable chunks for customers and is easier to maintain code-wise. You are welcome to check it out on my site and see what you think maybe just to get some ideas. Mine is highly customized. The more that I read on the topic it seems that people in general do better with small simple checkout pages and don't mind having to complete 3 or 4 SIMPLE steps (pages).
