Jump to content

Ted Thompson

Members
  • Content count

    18
  • Joined

  • Last visited

1 Follower

About Ted Thompson

  • Birthday 06/19/1970

Profile Information

  1. Perfect, but I mut point out that <td class="main"><?php echo sprintf(TEXT_MORE_INFORMATION, tep_href_link(FILENAME_REDIRECT, 'action=url&goto=' . urlencode($product_info['products_url']), 'NONSSL', true, false)); ?></td> is actually <div class="product_url"><?php echo sprintf(TEXT_MORE_INFORMATION, tep_href_link(FILENAME_REDIRECT, 'action=url&goto=' . urlencode($product_info['products_url']), 'NONSSL', true, false)); ?></div> I don't *think* I changed that... but I could be wrong... Also, aren't we "supposed" to be using $_get now? (really I don't know)
  2. Your security addon strips / out of the $_get which is killing "Product URL"s where they are "www.somesite.com/somefolder" - it comes back as www.somesite.comsomefolder Which would be better? Changing product_info.php to just create a straight link, skipping the call to redirect.php or altering the $_get cleansing to allow / through?? Based on you saying that allowing "/" through is a big big risk, it sounds like I should alter product_info.php to build a direct link and avoid using redirect.php - yes?
  3. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    I switched to & in an attempt to get it to validate, but I missed this fix earlier in the thread. I'll patch and see how it goes. POST PATCH: That seems to have fixed it, thanks.
  4. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    Another trouble... Your security addon strips / out of the $_get which is killing "Product URL"s where they are "www.somesite.com/somefolder" - it comes back as www.somesite.comsomefolder Which would be better? Changing product_info.php to just create a straight link, skipping the call to redirect.php or altering the $_get cleansing to allow / through??
  5. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    Possible Trouble in usu5.php When checking validation via validator.w3.org - it complained of the use of '&' in links on the page. A few were found in other locations, but the "more information" link which uses redirect.php kept giving trouble. I found that I had to do the following: public function hrefLink( $page, $parameters, $connection, $add_session_id, $search_engine_safe ) { // Badly coded shops often pass in odd characters // $parameters = str_replace( array( '&', 'amp;' ), array( '&', '', ), $parameters ); Note that the str_replace line is commented out, once I did that the & got passed as & and not '&'
  6. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    Thank YOU for the support!! :lol:
  7. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    So this is what I have now # If you are getting errors you may need to comment this out like .. # Options +FollowSymLinks Options +SymLinksIfOwnerMatch <IfModule mod_rewrite.c> RewriteEngine On # RewriteBase instructions # Change RewriteBase dependent on how your shop is accessed as below. # http://www.mysite.com = RewriteBase / # http://www.mysite.com/catalog/ = RewriteBase /catalog/ # http://www.mysite.com/catalog/shop/ = RewriteBase /catalog/shop/ # Change RewriteBase using the instructions above RewriteBase / # 500 RewriteRule ^([a-z0-9-/]+).html$ product_info.php [NC,L,QSA] # W RewriteRule ^([a-z0-9/-]+).html$ product_info.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-p-([0-9]+).html$ product_info.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-c-([0-9_]+).html$ index.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-m-([0-9]+).html$ index.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-pi-([0-9]+).html$ popup_image.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-pr-([0-9]+).html$ product_reviews.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-pri-([0-9]+).html$ product_reviews_info.php [NC,L,QSA] # Articles contribution RewriteRule ^([a-z0-9/-]+)-t-([0-9_]+).html$ articles.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-au-([0-9]+).html$ articles.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-a-([0-9]+).html$ article_info.php [NC,L,QSA] # Information pages RewriteRule ^([a-z0-9/-]+)-i-([0-9]+).html$ information.php [NC,L,QSA] # Links contribution RewriteRule ^([a-z0-9/-]+)-links-([0-9_]+).html$ links.php [NC,L,QSA] # Newsdesk contribution RewriteRule ^([a-z0-9/-]+)-n-([0-9]+).html$ newsdesk_info.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-nc-([0-9]+).html$ newsdesk_index.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-nri-([0-9]+).html$ newsdesk_reviews_info.php [NC,L,QSA] RewriteRule ^([a-z0-9/-]+)-nra-([0-9]+).html$ newsdesk_reviews_article.php [NC,L,QSA] </IfModule> Correct?
  8. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    # 500 RewriteRule ^([a-z0-9-/]+).html$ product_info.php [NC,L,QSA] # W RewriteRule ^([a-z0-9/-]+).html$ product_info.php [NC,L,QSA] Again, "500" errs, and "W" works, so it would appear that you are correct. (I don't get any of these comparison strings myself...)
  9. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    # 500 RewriteRule ^([a-z0-9-\/]+).html$ product_info.php [NC,L,QSA] # 500 RewriteRule ^([a-z0-9\-/]+).html$ product_info.php [NC,L,QSA] # W RewriteRule ^([a-z0-9/-]+).html$ product_info.php [NC,L,QSA] # W RewriteRule ^([a-z0-9\/-]+).html$ product_info.php [NC,L,QSA] # W RewriteRule ^([a-z0-9/\-]+).html$ product_info.php [NC,L,QSA] Where I used "W" it worked fine, no difference in behavior from what I could see. Where I used "500" it threw a 500 Internal Server Error at me. :shrugs: :huh: (So which one should I use? :blink: ) Fair enough! :D
  10. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    Also, just FYI, your 404 page for when items/cats are not found is missing <html><head> and <body> tags...
  11. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    It does NOT cause a 500 error, but it does result in a 404 error...
  12. Ted Thompson

    ULTIMATE Seo Urls 5 - by FWR Media

    I was having trouble with the htaccess too. But since I know 1and1 "tech support" are total tools, I just mucked about to find an answer. Here's what seems to work. (BTW FRW Media, TOP SHELF addon here. Great docs, etc. I had to hand add it to a modded 2.3 site and your directions were spot on!) <IfModule mod_rewrite.c> RewriteEngine On # RewriteBase instructions # Change RewriteBase dependent on how your shop is accessed as below. # http://www.mysite.com = RewriteBase / # http://www.mysite.com/catalog/ = RewriteBase /catalog/ # http://www.mysite.com/catalog/shop/ = RewriteBase /catalog/shop/ # Change RewriteBase using the instructions above RewriteBase / RewriteRule ^(.*)-p-([0-9]+).html$ product_info.php [NC,L,QSA] RewriteRule ^(.*)-c-([0-9_]+).html$ index.php [NC,L,QSA] RewriteRule ^(.*)-m-([0-9]+).html$ index.php [NC,L,QSA] RewriteRule ^(.*)-pi-([0-9]+).html$ popup_image.php [NC,L,QSA] RewriteRule ^(.*)-pr-([0-9]+).html$ product_reviews.php [NC,L,QSA] RewriteRule ^(.*)-pri-([0-9]+).html$ product_reviews_info.php [NC,L,QSA] # Articles contribution RewriteRule ^(.*)-t-([0-9_]+).html$ articles.php [NC,L,QSA] RewriteRule ^(.*)-a-([0-9]+).html$ article_info.php [NC,L,QSA] # Information pages RewriteRule ^(.*)-i-([0-9]+).html$ information.php [NC,L,QSA] # Links contribution RewriteRule ^(.*)-links-([0-9_]+).html$ links.php [NC,L,QSA] # Newsdesk contribution RewriteRule ^(.*)-n-([0-9]+).html$ newsdesk_info.php [NC,L,QSA] RewriteRule ^(.*)-nc-([0-9]+).html$ newsdesk_index.php [NC,L,QSA] RewriteRule ^(.*)-nri-([0-9]+).html$ newsdesk_reviews_info.php [NC,L,QSA] RewriteRule ^(.*)-nra-([0-9]+).html$ newsdesk_reviews_article.php [NC,L,QSA] </IfModule> So it seems that the "[a-z0-9-/]+" part of the rules is the bone in contention on 1and1 (bear in mind they use a server farm of C64s powered by malnourished squirrels). So, do you see any potential problem with my version? Also, it doesn't seeem to matter if I use +FollowSymLinks or +SymLinksIfOwnerMatch, so which should I use? Or should I use both?
×