kevinb456

I've got this to work with 'per item' mode (whoop!), it seems the following are important; discount should be in the 'discount_amount_cart' parameter there should be NO tax_1, tax_2, etc parameters declared. declare the full tax in the 'tax_cart' parameter instead The second point is crucial, if these variables are declared, then paypal ignores the discount amount. So to fix; Step 1 - Comment out the following line: $parameters['tax_' . $item] = number_format($tax_value * $currencies->get_value($my_currency), $currencies->get_decimal_places($my_currency)); Step 2 - Change the discount code added from my previous post (quoted at the bottom), to instead be; if (isset($order_total['ot_discount'])) { $parameters['discount_amount_cart'] = number_format(($order_total['ot_discount']) * $currencies->get_value($my_currency), $currencies->get_decimal_places($my_currency)); if (MOVE_TAX_TO_TOTAL_AMOUNT != 'True') $parameters['tax_cart'] = $tax_total; } The method will apply generally to other setups, just you will have to figure out where to code the parameters. (my original post quoted below is the code I added for my setup)

Well, If I set 'HTML Page title', 'meta description' and 'meta keywords' fields when making an article, they then appear in the title, meta description and keywords parts of the HTML once I navigate to the article page. The only part wrong is that there are also other things included in the title/description/keywords which I think are some default ones I set ages ago in KissMT, but I'm pretty sure I can remove them just haven't put the time in to find out where they're defined yet. I don't know... perhaps I've inadvertantly installed Header Tag SEO. I don't really know what files are which, but I didn't download that contribution specifically so I assumed I didn't. But I DO have the file includes/article_header_tags.php on my server, which is what pulls the title and meta tags from the database and inserts them in the head, so I'm not too surprised that it works - the code is there after all! This does seem like a direct 'include' of 'article_header_tags.php' though, and this file, entirely on its own, sets the title and header tags. So I still don't see even if I did install Header Tags SEO how would it hook-in to it? Jeez maybe I just installed a different version of the contribution to what I thought.... no idea lol. As you say though, if it works who cares. Thanks for your assistance. Be happy all. Live it.

well you *could* remove the 'htmlspecialchars' and 'stripslashes' functions so that it doesn't mess around with what you type at all (e.g. just using '$articles_description[$languages[$i]['id']]' on its own as the 2nd argument to the tep_draw_hidden_field function - though you will never know how its going to appear in the final page. Its also less secure (in general), although since this is in your admin and on you are editing it this is less of an issue. If its important to you, try it, but it may mess the appearance up. HTML tags work in the main body of the article fine if I'm not mistaken so maybe reserve them for there? Thats what I thought. From what I can see it wont break anything to use that instead of Header Tags SEO. I'll wait until Jack proves me wrong :)

Try creating a specific title and meta tags for the various pages without it. I have, and it works (for article pages). So thats not an issue related to getting the article manager working (it sets article page titles / meta tags fine without Header Tags SEO). If a.) Article Manager works without Header Tags SEO installed and b.) Doing this doesn't break my existing setup, - then surely Header Tags SEO is not 'REQUIRED'. What aspect makes it "required" ?

Hi Jack. With ref to the reply you made to me a month ago (http://forums.oscomm...ost__p__1599532); Thanks for explaining. I see things have to move on and it doesnt make sense to hang on to outdated code etc. So now I really want to install the article manager and get a move on and see how I can integrate Header Tags SEO with my existing KissMT Dynamic SEO contribution. Though there are still a few things I don't understand because I'm not familiar with how the header tag controller used to work etc. The dynamic SEO contribution(s) set page title, keyword meta tag & description meta tag dynamically based on the words in the page. It is my understanding that Header Tags SEO does the same job but you set them manually, hence allowing you complete control over what keywords are targeted. Is this correct? Is it possible to install Header Tags SEO and only insert the necessary code on pages I choose, e.g. on article pages, so that I can leave all other pages unchanged? i.e. Can it run side by side with other dynamic SEO contributions without affecting their operation? And lastly, maybe this is a silly question, but I have installed Article Manager 1.57_7 on its own (without the Header Tags SEO), and it seems to be working fine (The page title, description and meta tags you enter for the article are all correctly placed in the header and tite of the of the page). So....what exactly does Header Tags SEO do? lol! Sorry I'm a bit oblivious here. I expected it to completely explode if Header Tags SEO is required but not installed, but it seems to be working fine! What am I missing? Thanks a bunch Kevin

Sorry, Header Tags SEO is what I meant, I didn't navigate back to see the full name. Thanks for your reply and the information. I do have to disagree with your reasoning though - once someone has released a new version more often than not that is the one that gets taken forward and updated by other people (yes, people are free to choose whatever version they want but human nature means they dont! - its usually the latest upload that gets built upon and has fixes incorporated into it). If previous versions contain a different way of doing things, then that gets lost as they become outdated. And making a 'new version' doesn't mean anything (every single upload is a new version). You acknowledged that not every shop owner would want to install Header Tags SEO so hopefully you can see that by taking the contribution in this direction it is now unusable to that group of people. In any case, please dont take to heart - but hopefully you will consider this view and take it on board for future changes. To the practicalities - If I install version 1.57 as it is (with Header Tags SEO) - will the Header Tags SEO mod interfere with my rudimentary other SEO contribution (it was the FWR media one I installed if i recall correctly)? Im just asking this because Im not 100% clear what Header Tags SEO does (title, description, keyword tags etc for all pages Im guessing? but specified explicitly instead of 'guessing' - I realise this is far more useful for articles where certain keywords are being targetted) Cheers

I would like to use the latest version (1.57_7) by jack - so I get all the fixes etc since the last major release of 1.5.6 waaaaaay back in 2008. BUT I dont want to use header SEO for my page/keyword SEO naming. I've already got a mod that does that fine! How can I get round this - can I install header SEO mod without actually making it 'active' ? Or can I just use 1.57 anyway and have the SEO part not work very well (how bad would it be?) ? How much work would it be exactly to modify 1.57 so that it doesn't place these dependancies on people? (I really appreciate all the effort you've put in Jack, but I do have to say Im not a big fan of people taking contributions and forcing them in another direction, especially when it means mandating the use of other mods which are their own as well. They then become unusable to alot of people.) Aside from those thoughts - youve done a brilliant job :P ) Thanks.

Just in case anyone comes across this same language error I did, I found a solution by trial and error; (maybe I did something wrong in the first place to cause this however!). Using KissMT version of this mod; Whenever I un-commented the "//define('DEFAULT_LANGUAGE', 1);" line this would correctly execute the SQL using this variable, but I would get the following error when it tried to run using cron; <b>Fatal error</b>: require() [<a href='function.require'>function.require</a>]: Failed opening required 'includes/languages/.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in <b>/home/********/public_html/shop/includes/application_top.php</b> on line <b>352</b><br /> If i left that define commented then somewhere along the line 'DEFAULT_LANGUAGE' would get set to 'en' and the SQL would fail. Solution; Un-comment the define, and make a new define; define('LANGUAGE_ID', 1); Then replace 'DEFAULT_LANGUAGE' with 'LANGUAGE_ID' wherever it is used within SQL queries in googlefeeder.php. HTH Kevin

I have installed v2.1 of this contribution so theres probably a difference, but if you give a bit more info I'll see if I can lend any suggestions. I did install together with the newsletter unsubscribe mod at the same time, plus various bug fixes and other stuff I found was necessary along the way. The version I use (v2.1) includes the Advanced Bulk Mail contribution and I did have to add some code to get it to work otherwise the emails would be sent out - but im not sure if this was induced by something additional I did. What actually happens when you go to send a mail? Add some debugging code to the newsletter functions just to send a debug email or print something to the screen so you know its atleast being run. Would be useful to see the code near the end of /catalog/admin/includes/modules/newsletters/newsletter.php

Also just in case it helps anyone, something I had to change to get it to work correctly with my implementation (although this may not affect yours, because I had to move some code to paypal_ipn.php to work with Paypal IPN contribution). Also, I'm not sure if this is specific to v2.5 or just a general thing. Code placed in checkout_process.php: if (MODULE_ORDER_TOTAL_DISCOUNT_STATUS == 'true') { if (!empty($discount)) { $discount_codes_query = tep_db_query("select discount_codes_id from " . TABLE_DISCOUNT_CODES . " where discount_codes = '" . tep_db_input($sess_discount_code) . "'"); $discount_codes = tep_db_fetch_array($discount_codes_query); tep_db_perform(TABLE_CUSTOMERS_TO_DISCOUNT_CODES, array('customers_id' => $customer_id, 'discount_codes_id' => $discount_codes['discount_codes_id'])); tep_db_query("update " . TABLE_DISCOUNT_CODES . " set number_of_orders = number_of_orders + 1 where discount_codes_id = '" . (int)$discount_codes['discount_codes_id'] . "'"); tep_session_unregister('sess_discount_code'); } } I changed the inner if() clause to read: //if (!empty($discount)) { $sess_discount_code = $_SESSION['sess_discount_code']; if (!empty($sess_discount_code)) { because the $discount variable wasn't passed for me (I have no idea where this is meant to come from - its not given in checkout_process.php either!). For me, this caused the discount code not to be updated/checked against the database once the order was processed. I don't know whether this is necessary for all. Possibly you could use the corresponding GET variable if the default code doesn't work for you (is it $_GET['discount_code'] ?? ).

Yes, the "<br><br>" looks like you have an extra line placed in the code file. This may be from the original code you copied across or from an extra one you added by accident. Because this is inside the 'sprintf' function, whatever you add in the appearance of the code is actually counted as part of the string sent to the 'tep_db_query' function. I also checked the IF() function because I thought that might be the problem - but it is still a valid construct for MySQL v3/4, so thats not a problem. Also - I'm confused about the following part of the SQL: select count(*) as total from discount_codes dc, customers_to_d .... If this valid? Why the space inbetween 'discount_codes' and 'dc', or does the 'dc' mean something special? I haven't seen this before, but its in the PHP code as well, and I have checked my version of 2.5 (which works on my site) and the code is the same so this must be OK, just interested as it looks unusual to me. The subsequent SQL seems to suggest this is the name of a table.

My personal opinion is that the "Paypal IPN" contribution is far superior to the 'official' Paypal Website Payments Standard module, after switching I have a lot less headaches.

They both do the 'same' job, the "PayPal Website Payments Standard module" is the 'official' one (made by paypal?) whereas "Paypal IPN" is the community one. I got very frustrated with the 'official' one and it is my impression that most people ditch it in favour of Paypal IPN which actually does things PROPERLY! (The official one doesnt even seem to use the IPN and you must have the user return to the store for it to work).

I have the newest version from the authors website (v2.5 from http://high-quality-php-coding.com/discount_code_module_for_oscommerce.html - you have to install the updates, there's no full package.). The percentages work correctly on mine. I haven't used any previous version (I went straight to v2.5) so I would conclude that this issue has been fixed!

Just incase anyone else is searching for this. Although this will remove the address check, (it overrides it, although I'm not certain what good it does) it is a work around which stops the error, so job done in my book. Open /catalog/includes/modules/payment/paypal_ipn.php Find: $parameters['address_override'] = '1'; Replace with: $parameters['address_override'] = '0'; // Fix to stop paypal whining (default '1').