-
Posts
2,353 -
Joined
-
Last visited
-
Days Won
85
Reputation Activity
-
Tsimi reacted to raiwa in Slim Checkout for BS
I consider the actual Git Hub version final. Resume of the last updates:
optional hide on checkout pages (login.php, checkout_shipping.php, checkout_payment.phpheckout_confirmation.php and checkout_success) select on which pages to hide each area by checkbox list select each group to hide (navbar, header area, boxes, footer and footer suffix define content width if side columns are hidden, allows to control if main content gets stretched or keeps withe space for side columns optional customized list of header modules to keep showing if header area is hidden. Update from previous versions: uninstall ht module, replace ht module, reinstall ht module.
I'll keep it for around one week without touching. Please try and let me know any issues.
Then it will be published.
If I find time Ill try to go for the version to control each individual module.
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
Hello @Tsimi,
Sorry for the late reply, I was out all day.
For the errors reported by @dnbvinyl: I couldn't reproduce them neither.
For the ot bug#11:
I can confirm the bug, but there is an easier solution. We do not need to use our own custom functions. Just use "$currencies->format_raw" instead of "number_format":
$order->info['total'] = $currencies->format_raw($order->info['total'] - tep_calc_shopping_pvalue($customer_shopping_points_spending)); I pushed the fix, please check and then ok for update.
-
-
Tsimi got a reaction from raiwa in Converting Points and Rewards system for osC BS
@raiwa
Fixed typo in path for install steps 2 and 4 Added version number to amended files only Updated install manual with a change log Added fix for Bug 11 (needs further testing to 100% sure ) You want me to send a pull request or do you want to have a look before?
-
Tsimi reacted to raiwa in Slim Checkout for BS
new version updated in git hub:
module hide list for each checkout page class extension moved into ht module class extension clean up in direction Henry pointed out (still much more to do, I'll go for it tomorrow.) Update: uninstall ht, replace ht, install ht, remove class extension.
Once this is clean and well working, I'll try to go for a separate admin page with control over each module and any page.
-
Tsimi got a reaction from bruyndoncx in Slim Checkout for BS
@raiwa
Well done!
We appreciate all the hard work you put into your addons and projects but please do me a favor and don't work too much/hard. In the past I/we have lost 2 very good friends from this forum and the last thing I remember was, they were working hard on some addons/projects and it could have been just mere coincidence or just fact that they overworked themselfs till their body gave up. You maintain multiple addons, you work with me on the Point and Rewards module, Sloppy words cleaner and, and, and....
Long story short, watch your health and take enough rest so that we will be able to enjoy you and your work for many years to come.
That goes for all of you out there. osC is nice and all but it won't bring you anything if you work yourself to death.
Now back to work....
-
Tsimi reacted to raiwa in Slim Checkout for BS
@Tsimi,
Thank you very much for the advice. I'm taking care of my health, do not worry. I'm breaking regularly my coding hours by long walks trhough the beautiful nature surrounding my place, cooking, handcrafting jewellery, diy woodworking projects and much more. Times of letting things stressing me have past since years.
This project was born by using manual hiding modules during checkout in my wife's 2.3.4 BS store since the beginning 2 years ago. I just was curious how to do it in a more simple way and first looked into template_top and bottom where the modules are included. Then i found no way to control them there without core changes and began to dig into the osc_template class to find out how to condition the module inclusions. It was palaying around to discover things rather than a working goal.
-
Tsimi got a reaction from raiwa in Slim Checkout for BS
@raiwa
Well done!
We appreciate all the hard work you put into your addons and projects but please do me a favor and don't work too much/hard. In the past I/we have lost 2 very good friends from this forum and the last thing I remember was, they were working hard on some addons/projects and it could have been just mere coincidence or just fact that they overworked themselfs till their body gave up. You maintain multiple addons, you work with me on the Point and Rewards module, Sloppy words cleaner and, and, and....
Long story short, watch your health and take enough rest so that we will be able to enjoy you and your work for many years to come.
That goes for all of you out there. osC is nice and all but it won't bring you anything if you work yourself to death.
Now back to work....
-
Tsimi got a reaction from discxpress in Slim Checkout for BS
@raiwa
Well done!
We appreciate all the hard work you put into your addons and projects but please do me a favor and don't work too much/hard. In the past I/we have lost 2 very good friends from this forum and the last thing I remember was, they were working hard on some addons/projects and it could have been just mere coincidence or just fact that they overworked themselfs till their body gave up. You maintain multiple addons, you work with me on the Point and Rewards module, Sloppy words cleaner and, and, and....
Long story short, watch your health and take enough rest so that we will be able to enjoy you and your work for many years to come.
That goes for all of you out there. osC is nice and all but it won't bring you anything if you work yourself to death.
Now back to work....
-
Tsimi got a reaction from Moxamint in Slim Checkout for BS
@raiwa
Well done!
We appreciate all the hard work you put into your addons and projects but please do me a favor and don't work too much/hard. In the past I/we have lost 2 very good friends from this forum and the last thing I remember was, they were working hard on some addons/projects and it could have been just mere coincidence or just fact that they overworked themselfs till their body gave up. You maintain multiple addons, you work with me on the Point and Rewards module, Sloppy words cleaner and, and, and....
Long story short, watch your health and take enough rest so that we will be able to enjoy you and your work for many years to come.
That goes for all of you out there. osC is nice and all but it won't bring you anything if you work yourself to death.
Now back to work....
-
Tsimi got a reaction from Dan Cole in Slim Checkout for BS
@raiwa
Well done!
We appreciate all the hard work you put into your addons and projects but please do me a favor and don't work too much/hard. In the past I/we have lost 2 very good friends from this forum and the last thing I remember was, they were working hard on some addons/projects and it could have been just mere coincidence or just fact that they overworked themselfs till their body gave up. You maintain multiple addons, you work with me on the Point and Rewards module, Sloppy words cleaner and, and, and....
Long story short, watch your health and take enough rest so that we will be able to enjoy you and your work for many years to come.
That goes for all of you out there. osC is nice and all but it won't bring you anything if you work yourself to death.
Now back to work....
-
Tsimi reacted to raiwa in Slim Checkout for BS
Slim-Checkout
Common opinion is that the checkout process should be as "slim" as possible. This means to hide all page elements which are not strict necessary to show to the customer a simple clean layout, so nothing disturbs his attention from the purchase process.
This add-on allows to do it by simple settings in a Header Tag module.
Git Hub Repository: https://github.com/raiwa/Slim-Checkout/tree/master
What it does:
- allows to hide elements on checkout pages
- optional hide on checkout pages (checkout_shipping.php, checkout_payment.phpheckout_confirmation.php and checkout_success)
- optional hide also on shopping_cart.php
- select each group to hide (navbar, header area, boxes, footer and footer suffix
Installation:
- copy all new files
- install and adjust Slim Checkout Header Tag
testing , Bug reports and suggestions very welcome.
rgds
Rainer
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
Thats why I kept the checkboxes and added the toggle script
EDIT: I also had the idea to add 3 radios, one with default option "None", but I believe the checkboxes fit better.
-
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
YEP, I didn't check the point to redeem (points_selection) display, only the referral display. I thought nothing at all, neither the referral part was shown.
You are 100% right, I must have accidentally deleted this line when I added the PWA support. Will restore and push right now.
-
Tsimi got a reaction from raiwa in Converting Points and Rewards system for osC BS
@raiwa
I think I found it.
I unfortunately deleted all my old files except for the first BETA package of mine and an older package of yours.
So I compared the hook contents for the payment page and in your older package you had this function inside.
echo points_selection($cart_show_total); If I add that piece of code inside the current hook file the blue box with the points text and checkbox is showing.
This is my current hook file for the payment page
<?php /* $Id: points.php $Loc: catalog/includes/hooks/shop/checkout_payment/ originally coded by Ben Zukrel Improved and converted for osC Bootstrap by @Tsimi and @raiwa Rainer Schmied / [email protected] / www.oscaddons.com Additional credits to @LeeFoster for bug reports and fixes German translation by @Tsimi German revision by @raiwa Spanish translation by @TITO4 Spanish revision by @PiLLaO osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2017 osCommerce Released under the GNU General Public License */ class hook_shop_checkout_payment_points { function __construct() { require_once(DIR_FS_CATALOG . 'includes/functions/redemptions.php'); } function listen_CheckoutPaymentPoints() { global $cart, $order, $language; require('includes/languages/' . $language . '/hooks/shop/checkout_payment/points.php'); if ((MODULE_HEADER_TAGS_POINTS_REWARDS_USE_POINTS_SYSTEM == 'True') && (MODULE_HEADER_TAGS_POINTS_REWARDS_USE_REDEEM_SYSTEM == 'True')) { $cart_show_total= $cart->show_total(); echo points_selection($cart_show_total); // PWA guest checkout support BEGIN if ( defined('MODULE_CONTENT_PWA_LOGIN_STATUS') && MODULE_CONTENT_PWA_LOGIN_STATUS == 'True' && tep_session_is_registered('customer_is_guest') ) { $orders_check_query = tep_db_query("select count(*) as total from orders o, orders_status s where o.customers_email_address = '" . $order->customer['email_address'] . "'"); $orders_check = tep_db_fetch_array($orders_check_query); $check_first_order = $orders_check['total']; } else { $check_first_order = tep_count_customer_orders(); } // PWA guest checkout support END if (tep_not_null(MODULE_HEADER_TAGS_POINTS_REWARDS_POINTS_USE_REFERRAL_SYSTEM) && ($check_first_order == 0)) { echo referral_input(); } } } } // end class Maybe that piece of code got accidentally deleted?
-
Tsimi got a reaction from raiwa in Converting Points and Rewards system for osC BS
Yeah, that would definitely be a good idea.
Give me some time to test the latest changes.
I will trash my github fork first and start from scratch by re-forking you latest github.
Then I'll do some testing.
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
@Tsimi
Pushed the updates to sync to last published version (I found only the difference you mentioned and the install manual)
Pushed the german language file update
Pushed the auto tick update for admin/orders.php
-
Tsimi got a reaction from TITO4 in Converting Points and Rewards system for osC BS
@raiwa
Regarding 1.
Should such fixes for various addons be mentioned inside the install manual?
I don't really want to add code fixes for 265165433818 addons which might clutter up the files. I remember, the Order Editor addon was one of those addons that had various code pieces inside to fix compatibility for addons that maybe a few use.
Mention it inside the install manual however seems to be a good idea don't you think?
Regarding 2.
I thought about a similar approach, add an empty entry inside the HT module where admins/shop owners can doe the following.
Add a Status ID activates that function and confirms the pending points if the order is set to that certain Status ID. If the setting entry is empty then no auto confirmation happens at any Status ID.
Not sure what and Que and Delete do function wise.
and Que means confirm points and add it to the My Account listing? and Delete means confirm points but don't show inside the My Account listing? Is that correct?
If that is the case then maybe if selected Status ID = true -> and Que only. So that customers can see that their points have been added to their account.
Regarding 3.
Is that fix ( get_pages_pr ) something you gonna implement into the current code base of the addon?
Or is this like case in 1. ?
@TITO4
Thanks for your help with the Spanish language files, very appreciate it.
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
Sorry for the mess. I'll update my master with the good files from the uploaded add-on.
-
Tsimi got a reaction from raiwa in Converting Points and Rewards system for osC BS
@raiwa
I added the German translation for the FAQ 18 part to my github fork.
You cannot merge everything since I don't have the exact same files as you do. You used older files for your latest changes which included some old minor bugs.
For example; inside the customers_points_pending.php file you have this $uInfo = new objectInfo($pending_points); twice in there which will cause some weird behavior with the table row select feature.
Just download my fork files and take the German language files and upload them to your github.
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
Pull down would only allow the auto tick for one status. Coma separated list allows to use it for more than one status.
There are store owners using different status (more than one) for final order status. It's just more flexible like this.
-
Tsimi reacted to raiwa in Converting Points and Rewards system for osC BS
allows the function to be only available and used inside the own class
-
Tsimi got a reaction from TITO4 in Converting Points and Rewards system for osC BS
Addon is now available. Congratulations!
-
Tsimi got a reaction from CGhoST in Converting Points and Rewards system for osC BS
@CGhoST
Sorry another typo was inside the previous code. I just hide that post to not confuse you.
Use this inside the points payment module.
FIND:
function update_status() { global $order, $cart, $max_points; REPLACE WITH:
function update_status() { global $order, $cart, $max_points, $PHP_SELF; if(basename($PHP_SELF) == 'edit_orders.php') { require_once('../includes/functions/redemptions.php'); } That should do it now.