Tsimi

Yes, we do test our stuff before uploading it to the addons area. Attitude or comments like that won't help you either.You still haven't provided the information I asked you for in the other discount thread you posted. Keep in mind more info YOU provide the better and accurate we can help.
Anyways, looking at your store from the link you posted I can see that you are running the "normal" osC 2.3.4 version. THIS addon, Discount Codes BS, was made/adapted for osC Bootstrap only. You cannot use that addon for your current shop. So you have two choices, either you install and use a Bootstrap version of osC or you install a Discount Codes addon that is compatible with your shop. For example with this one.
 
http://addons.oscommerce.com/info/7700
 
If you want to know more about the community build Bootstrap stuff read here.
 
http://www.oscommerce.com/forums/topic/396152-bootstrap-3-in-234-responsive-from-the-get-go/page-1
 
One more thing, if you see addons that have the 2 letters "BS" in their title name then they are most likely made for the Bootstrap version and are therefore not compatible with your current shop version.

Hi, @Tsimi
the languages bug solved.
catalog/admin/options_images.php fixed:
(int)$languages_id instead of $language_id (lines 87, 122, 194) Deleted temporary line 12:  $language_id = '1'; options_images.php

@14steve14
Hi Steve
I had another look at this Options as Images and I was able to improve the install process. Now it can be installed without core code changes at all.
I also changed the looks of it to more modern style as shown in many shop demos. Just color tiles without any text or radio buttons. Now you can click on the image to select it.
It might not be what everyone likes or needs but it wouldn't be all too hard to change it back as it was or change the style to a more individual matching layout.
Here the package: Options_as_Images BS v2.2.zip
I might upload it to the apps section but it would need more testing to make sure all corners are covered so to speak.
I don't have 54234234 images to see how it brakes to a new row so if you or anyone out there wants to give this a go and report back I'd appreciate it.

Update on above
Can confirm that I have done as Rainer suggested, installed modular shopping cart, ship-i-cart reloaded, and discount codes, haven't switched Paypal express on yet but i wouldn't have thought its a issue, all the data is there
all is working great, installed on 2.3.4.1 CE, bootstrap 4 with, PHP 7.2.14 
couple of css changes to update to BS4, but thats only visual, worked straight out of the box, as I knew nothing about bs4 it was interesting playing with it, probably forget it all tomorrow though
the only thing i couldn't work out is why the work Tax or VAT is not written on the estimated order total, but since noticed its also missing further into the check-out so there must be a language file somewhere that i have yet to find,  job for another day with fresh eyes
Anyway just a vote for the above add on's makes the checkout much better with all that info on one page before checkout continues
Regards
David

@Shoppertroppen
Download the zip package from my post here.

@LeeFoster
Best would be to create a github repository. Then we can download it or have a look at your current files.
Then you should proceed the same way we did with the Points and Rewards addon. Create a to do list, create a bug list if needed.

A new version has been uploaded with these changes:
Added cancel and delete buttons back in. Added commands to remove backslashes on the shops FAQ page. Corrected code for the delete function. Found by member Tismi, Merged a number of functions into the code since they were not needed. Removed the tep_set_faq_visible function. Found by member luboshsh. Removed $_GET from function calls that were left over from the previous addon and no longer needed.  

Uploaded update with the above posted fixes:
https://apps.oscommerce.com/mKsGy&ajax-attribute-manager-bs
AJAX Attribute Manager BS 2.9.3
+ Fixed undefined errors
+ Fixed PHP 7.2 warning errors.
 

Thanks @raiwa
The error has been corrected I think. I had something mixed up with the data inside the database and the data shown in the shop.
I emptied the database table and now the error is gone and I cannot recreate it either. 🤔
So the only code that needs fixing to be PHP 7.2 compatible is the code fix Omar posted above.
Thanks again for looking into it.

@Tsimi
I couldn't recreate this error, but try this:
if ( is_array($uInfo_array) && (!isset($_GET['uID']) || (isset($_GET['uID']) && ($_GET['uID'] == $pending_points['unique_id']))) && !isset($uInfo) ) { $uInfo = new objectInfo($uInfo_array); } or this:
if ( isset($uInfo_array) && (!isset($_GET['uID']) || (isset($_GET['uID']) && ($_GET['uID'] == $pending_points['unique_id']))) && !isset($uInfo) ) { $uInfo = new objectInfo($uInfo_array); }  

Hello @Tsimi   and any one have the same issue
for this
Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/xxx/www/shop/xxx/customers_points_referral.php on line 451 change this in  customers_points_referral.php on line 451
if (sizeof($reviews) > 0) to
if (is_array($reviews) && sizeof($reviews) > 0) BR
Omar

@Tsimi, I had read your question and forgot to reply. I was very busy today.
I believe @Omar_one's fix is correct, thanks.
rgds
Rainer
 

Uploaded update:
Version v2.9.2
+ updated for PHP 7.2 compatibility. Changed deprecated while...each loops to foreach loops. Fixed undefined errors.
+ Added sort order support for 2.3.4.1 CE Frozen modular Product Info page.

https://apps.oscommerce.com/mKsGy&ajax-attribute-manager-bs

@raiwa
Man I am glad to hear/read that. What a great timing. Thanks

@TsimiIt needs some update which I have already prepared. I'll upload it within the next 2 days.

You can keep the code in there. It shouldn't matter if you use later the horizontal menu or not.

@ce7
Open your ..includes/classes/category_tree.php file
FIND:
if ( ($this->follow_cpath === true) && in_array($category_id, $this->cpath_array) ) { $link_title = $this->cpath_start_string . $category['name'] . $this->cpath_end_string; } else { $link_title = $category['name']; }
REPLACE WITH:        
if ( ($this->follow_cpath === true) && in_array($category_id, $this->cpath_array) ) { $link_title = $this->cpath_start_string . tep_image('images/' . $category['image'], $category['name'], SMALL_IMAGE_WIDTH*0.5, SMALL_IMAGE_HEIGHT*0.5, 'style="display:inline-block;"') . ' ' . $category['name'] . $this->cpath_end_string; } else { $link_title = tep_image('images/' . $category['image'], $category['name'], SMALL_IMAGE_WIDTH*0.5, SMALL_IMAGE_HEIGHT*0.5, 'style="display:inline-block;"') . ' ' . $category['name']; }  

@ce7
Open your ..includes/classes/category_tree.php file
FIND:
if ( ($this->follow_cpath === true) && in_array($category_id, $this->cpath_array) ) { $link_title = $this->cpath_start_string . $category['name'] . $this->cpath_end_string; } else { $link_title = $category['name']; }
REPLACE WITH:        
if ( ($this->follow_cpath === true) && in_array($category_id, $this->cpath_array) ) { $link_title = $this->cpath_start_string . tep_image('images/' . $category['image'], $category['name'], SMALL_IMAGE_WIDTH*0.5, SMALL_IMAGE_HEIGHT*0.5, 'style="display:inline-block;"') . ' ' . $category['name'] . $this->cpath_end_string; } else { $link_title = tep_image('images/' . $category['image'], $category['name'], SMALL_IMAGE_WIDTH*0.5, SMALL_IMAGE_HEIGHT*0.5, 'style="display:inline-block;"') . ' ' . $category['name']; }  

You're right,  it appears to be an issue with my product. 
Note to self - 'Don't use " in product description'
The other error I have fixed, there is an instance of cpb_product_builder_name that is missing ' ' around it.

@JcMagpie, @Tsimi, @altoid,
Thanks for the time to test. You are right, all good on a fresh new installation.
My PHP 7.2 develop-test store's configuration entries were corrupted.
New version 5.6.2. with the last fixes uploaded
Best regards
Rainer

@raiwa
I installed this quickly into a fresh, new Frozen shop on my local server (XAMPP) running PHP 7.2.1 and I don't get any duplicate entries. Everything looks good here.
 

@raiwa
I installed this quickly into a fresh, new Frozen shop on my local server (XAMPP) running PHP 7.2.1 and I don't get any duplicate entries. Everything looks good here.
 

If you want another options as images module there is always this one. It may need a bit of an update for use on the latest version as I havent looked at it in a while. Sorry to link away from this thread and version
https://apps.oscommerce.com/b277x&options-as-images

No problem guys. I wasn't really doing much either.
But I had a bit time recently and did some progress. I got most of the install reduced using modules or combining codes into already existing add-on files.
Right now it requires 2 code additions/changes inside 2 files. And it only works with the FROZEN version (PHP 7.0.21). EDGE and GOLD are not supported at the moment.
I also got the catalog side layout done. I can create a custom product now and add it to the cart. I must say the add-on is very difficult coded. A lot javascript and onclick functions involved but it does seem to work.
I didn't had time to test it further than that. Didn't go into the checkout and I don't know if it reduces the stock of the added items.

The only real bug thus far is the image dropdown selection after a custom product has been deleted. You'll know what I mean once you try it out.
So here is the package for those who are interested to have a look at it. (Please do not install and use this in a live store! You have been warned.)
Custom-Product-Builder-for-BS-Tsimi.zip
 

This is the support thread for the Option Types BS App.
I wanted to keep this separated from the other, normal Option Types support thread.
New version uploaded. Now compatible with the latest and greatest osC CE Frozen
Download is here: https://apps.oscommerce.com/SOFpK&option-types-bs