Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Tsimi

♥Ambassador
  • Posts

    2,353
  • Joined

  • Last visited

  • Days Won

    85

Everything posted by Tsimi

  1. @raiwa I added the German translation for the FAQ 18 part to my github fork. You cannot merge everything since I don't have the exact same files as you do. You used older files for your latest changes which included some old minor bugs. For example; inside the customers_points_pending.php file you have this $uInfo = new objectInfo($pending_points); twice in there which will cause some weird behavior with the table row select feature. Just download my fork files and take the German language files and upload them to your github.
  2. @LeeFoster Most people won't be using multiple Status IDs. So that means you just add one number in there and you're done.
  3. My guess, and Que means confirm points and add it to the My Account listing? and Delete means remove entry in the My Account listing and don't show?
  4. @raiwa Inside the HT module, what is that private before the function for? What does it do?
  5. @raiwa Regarding 1. Should such fixes for various addons be mentioned inside the install manual? I don't really want to add code fixes for 265165433818 addons which might clutter up the files. I remember, the Order Editor addon was one of those addons that had various code pieces inside to fix compatibility for addons that maybe a few use. Mention it inside the install manual however seems to be a good idea don't you think? Regarding 2. I thought about a similar approach, add an empty entry inside the HT module where admins/shop owners can doe the following. Add a Status ID activates that function and confirms the pending points if the order is set to that certain Status ID. If the setting entry is empty then no auto confirmation happens at any Status ID. Not sure what and Que and Delete do function wise. and Que means confirm points and add it to the My Account listing? and Delete means confirm points but don't show inside the My Account listing? Is that correct? If that is the case then maybe if selected Status ID = true -> and Que only. So that customers can see that their points have been added to their account. Regarding 3. Is that fix ( get_pages_pr ) something you gonna implement into the current code base of the addon? Or is this like case in 1. ? @TITO4 Thanks for your help with the Spanish language files, very appreciate it.
  6. As far I know you have to confirm the points manually no matter the order status. Dan Cole mentioned also something like when status is set to delivered or complete the points should be automatically confirmed. Maybe add something like a status id check? Where a store owner can type in the settings at what status id the points should be confirmed. @raiwa what you think about that idea?
  7. @raiwa 1. sounds good to me. 2. On my initial test run the referral part was showing every time even as registered customer that has already referred someone already. I'll test this again with your new code and report back. 3. OK, OK I'll do my best.
  8. @CGhoST Sorry another typo was inside the previous code. I just hide that post to not confuse you. Use this inside the points payment module. FIND: function update_status() { global $order, $cart, $max_points; REPLACE WITH: function update_status() { global $order, $cart, $max_points, $PHP_SELF; if(basename($PHP_SELF) == 'edit_orders.php') { require_once('../includes/functions/redemptions.php'); } That should do it now.
  9. @raiwa The first fix to delete the pending points if the guest doesn't want to create an account works. The second fix however shows the referral part every time now. Even as a registered customer which should not happen if you once referred someone already as registered user. As guest it shows now every time as it should be.
  10. @discxpress I am not familiar with burt's key system but I did install the PWA addon from raiwa and I placed a couple of test orders. Well, the Points and Rewards addon works just fine even with the PWA installed. However it will need some additional modifications to handle certain situations that are only happening with the PWA addon for example; 1.) When placing an order as guest and at the end you refuse to create an account the points should be also deleted from the pending table same with the customer info. This doesn't happen at the moment. So even you don't have that guest's data the points are there on the pending page. 2.) Not sure if it happens because I use the same PC to place the test orders but the Referral part shows only one time in the payment page when going as guest to checkout. Ideally it should show every time a guest goes to checkout. A registered customer sees that Referral part only on the first order. The good thing is if a guest decides to set a password at the end of the checkout process the points can be written in to that new account and the customer can benefit from the points system even if he initially went as guest to checkout. Not sure if there are more issues with it though. It will need more thorough testing to be 100% sure. But from what I have seen thus far except those 2 mentioned points all works as it should.
  11. Never tested with the PWA addon. Will install it once and see how it goes. How do you expect it to work with the PWA addon? Give points to guests?
  12. @CGhoST Regarding that error message in the order editor I'll look into it. I have no test shop with Order Editor at the moment so I'll have to install it first. If you get all green messages when installing the HT module then no you won't need to do manual changes to files. Getting that message 3 times in the product info page means something went wrong and you might have 3 times the call for the product_points module. Open your product_info.php file and look for this code <!-- BOF POINTS REWARDS BS //--> <div class="row"> <?php echo $oscTemplate->getContent('product_info_points'); ?> </div> <!-- EOF POINTS REWARDS BS //--> I think you have it 3 times in there. Did you install and uninstall the HT module a couple times? At this point you should double check all affected files.
  13. Just uninstall the reviews_points module if you installed it. To tell more we would need to have a look at burt's "Write Review" files. Be aware if it is a commercial addon don't post any code of it here in the forum. You'll have to contact burt to get more help in this case. If it is a free addon then go ahead and share some information please.
  14. @discxpress If you are 100% sure that the orders you get are final and won't be cancelled or if you find it easier to remove points for orders that are not completed then you could try to use the Auto Credit Pending Points function in the HT module. Set it to 0 for same day confirmation. Then you won't have to do it manually anymore.
  15. Adding a bulk feature would sure help if you have a lot orders daily to check through. But the down side will be the e-mails. I am not sure how osC handles e-mail sending to multiple customers at once. The older version of this Points and Rewards addon had this following text inside the manual. I have the check boxes in place and also the select all function works but I have a hard time to make the system confirm all the selected points at once and evtl send or not send notifications and queue or don't queue the table at once. Adding check boxes also interferes with the stock osC table row select function. But not sure that is needed once the check boxes are in place.
  16. @raiwa You made it in time. I was working on the screenshots and title image for the addon. Just finished the images now I will prep the package and upload it. UPDATE: Package has been uploaded with 7 screenshots and one header image. Hope the header image is OK. I am not so good with graphics stuff. Now we need to wait until it is approved.
  17. Never mind the bug. Just fixed it. There was a line of code too much inside it that is why it had a conflict. I'll push the fix to github and prep the package for upload.
  18. @raiwa Just send the last pull request before uploading the package. Check the manual please and confirm if this is good for you then I'll start to zip it up and upload it and take some screenshots for the addons page. UPDATE! Just found a bug. Nothing big but still disturbing. On the customers_points_pending.php page in the admin are if you have multiple pending entries listed the mouse over effect doesn't work and also all rows are selected/highlighted.
  19. @raiwa I send you a pull request for the missing German core files translation. I also had a quick look at the package to make sure there is nothing missing before we officially upload it. This is what I found; The modified core files Spanish language file is in English and it is missing the modules/boxes/ language file Did you remove the Auto Expire and Auto Credit links in the admin area? If yes, then we could remove the two cron script files right? (customers_points_credit.php and customers_points_expire.php) Other then that all looks good on my end and I think we can release it to the world officially. Anything arise we can update it and upload a new version again. Just for safety we should maybe keep the github alive for now till we can say that it is 100% bug free.
  20. @raiwa Pull request send. Please double check the German and Spanish language files and also check the module code. Thx.
  21. Working on it. Creating the language files for German and Spanish now. Will push it as soon I'm done.
  22. @raiwa I was just adding the module warning messages into this account module when I realized that your module (HT) injects/adds the hooks codes automatically into all necessary files when installing the HT module. Holy shit! THAT is some genius work there. I didn't realize that till today. That will reduce the install manual to a few lines of text, lol How the hell did you get that idea to add code lines like that? That is really cool. Last time I had seen something like that was with the Discount Codes BS addon but that was only a piece of code into one file. Well done!
  23. UPDATE! Never mind. I got it! Heureka! God how could I miss that. Here is the code that works function execute() { global $oscTemplate, $language, $customer_id, $currencies; if (MODULE_HEADER_TAGS_POINTS_REWARDS_USE_POINTS_SYSTEM == 'True') { require_once('includes/functions/redemptions.php'); $has_points = tep_get_shopping_points($customer_id); $oscTemplate->_data[$this->group] += array('points' => array('title' => MODULE_CONTENT_ACCOUNT_POINTS_TITLE, 'sort_order' => MODULE_CONTENT_ACCOUNT_POINTS_SORT_ORDER, 'links' => array('points_balance' => array('title' => '<div class="alert alert-info">' . sprintf(MODULE_CONTENT_ACCOUNT_POINTS_CURRENT_BALANCE, number_format($has_points, MODULE_HEADER_TAGS_POINTS_REWARDS_POINTS_POINTS_DECIMAL_PLACES), $currencies->format(tep_calc_shopping_pvalue($has_points))) . '</div>', 'link' => NULL, 'icon' => NULL), 'view' => array('title' => MODULE_CONTENT_ACCOUNT_POINTS_VIEW, 'link' => tep_href_link('my_points.php', '', 'SSL'), 'icon' => 'fa fa-plus'), 'view_help' => array('title' => MODULE_CONTENT_ACCOUNT_POINTS_VIEW_HELP, 'link' => tep_href_link('my_points_help.php', '', 'SSL'), 'icon' => 'fa fa-info-circle')))); } } I just needed to add a + before the array code. $oscTemplate->_data[$this->group] += array('points' => etc.... also added this 'sort_order' => MODULE_CONTENT_ACCOUNT_POINTS_SORT_ORDER, now the sort order can be set via admin module settings.
×
×
  • Create New...