Jump to content

Antonio Garcia

♥Ambassador
  • Content count

    115
  • Joined

  • Last visited

Posts posted by Antonio Garcia


  1. @JcMagpie Thanks for the addon and for the work fixing the bugs found!

    @multimixer Thanks for report the issue and take your time  reading / understanding / finding bugs in the code written for others.

    @valquiria23 Gracias por tu amable optimismo! (Thanks to be positive, as always!)

    My quote:

    "Write code as if it were to be read by a psychopath who knows where you live ..."

    (Unknown for me, may be Winston Churchill, Napoleon, Einstein or may be Carl Sagan...)

     


  2. 14 hours ago, burt said:

    If the view has changed in the last few days, based on what the OP has stated (that he is in touch with HPDL), well that is (good) news to me.  There is an awful lot of crap in the addons area - some of dating back years and some of it mine 😂

    So, if you are right, I'm happy too!!!

    Harald, please, please, PLEASE, can you re-desing the addons area were we can find the following?

    • Estate the Compatibility with the osC versions?
    • Rating of the users
    • Languages availables and how can contribute to this.
    • Allow 'lite' addons of commercial ones
    • A warning with very old addons...
    • A good starting point:  https://es.wordpress.org/plugins/

    If you can't do it, please ALLOW to do it by the rest of this OPEN SOURCE comunity.

    Thanks!

    (copy to HPDL by PM)


  3. 2 hours ago, burt said:

    NONE OF US (me included) have the right to upload addons for "CE" to the "apps marketplace" (what used to be called addons area or contributions area) - we never have had that right, we (likely) never will have that right.   Only official osC is allowed...so it's extremely likely addons that are not directly for official osc...will be removed in the near future. 

    Let the OP make his addons.  Hopefully when he gets advice to make them better...he'll listen.  We were all n00b-coders once upon a time. 

     

    Sorry if I don't understand fully. Please, I only try to understand:

    1.- Are the CE compatible  addons  banned here? I see a lot of good, usefull, interesting ones in the addoms area being the 'blood' of this almost catatonic project. With good people trying 'go forward' this project.

    2.- Doing only addons for the  official 2.3.4.1 is as usefull as make  adons for a Spectrum... or for 2.2...

    4.- You, with your HUGE work (with a few colleages) make a 'fresh' update with CE. You said in another places here, that is not official but 'allowed'. Why cut the few people that try to help with addons for 'your' CE version? If someone delete the addons for CE may be he will be correct in the terms but also it will killing the few energy remaining here of people like you, like waiwa, like Jack_cms, etc. etc.

    5.- Bad coding: I learned PHP and, I''m sure,  the same of a lot of the rest, reading the  oscommerce code. I see good and usefull addons uploaded. Others so so good and/or interesting according my point of view. The autors need to take care of their 'sons' and the rest of us may ask for issues, new features, technical questions, etc. I think that it's not good to create factions and war againts one to others. Can someone of us confirm us that, when uploading, he discover that there are a mistake and he was forced to re-upload this. A lot of cases with gentle people that in a constructive way inform to the developer or someone that detect a bug in the code.. I'm wrong?!?

    6.- I agree with Rwe that the adoms area need a 'rebuild'... but I KNOW that Burt and NONE OF US here can do it... This is the IMPORTANT THING, the sad thing, the impotent thing....

    Me, as the rest of you, LOVE oscommerce.

    We are less and less people remaining here every day...

    Can we be at least to be polite? Can we be constructive?

    +1 peace, love, PATIENCE.


  4. 17 hours ago, JcMagpie said:

    Good to see progress being made by all. I recently tested the latest offering by  @Gyakutsuki   which is already Bootstrap 4, shop and admin and it's looking very good. So looks like we will have a good selection of options to move forwared with.

     

    Dear JcMagpie:

    Can you supply to the rest of the mortals the link of their github ?

    If this (put a link here) 'violates' something, I would be very happy if you want send a PM with the info.

    Thanks and Happy New Year to you and the rest of the crew!!!


  5. Unfortunately offsetting columns are not controlled from 'configuration' (neiter every posible value in all "Extra small devices Phones", "Small devices Tablets", "Medium devices Desktops", "Large devices Desktops" or set if you can disable this in one or more views).

    For cover this you will need to add 'by hand" some classes into the html part of the module.

    May be this link can help you:

    https://getbootstrap.com/docs/3.3/css/#grid-offsetting

     


  6. 7 hours ago, deepsonline said:

    I am using the osCommerce 2.2-MS2 version.

    It is responsive. This is an existing store and we are using php7.0.

    .... and you modded your web with foundation, bootstrap 3, bootstrap 4, W3.CSS, material design ?

    If you used bootsrap 3, please see this link (or google it) :

    If you did all the changes from <tables> to <divs> this should be trivial for you!!

     


  7. 16 hours ago, raiwa said:

    You could have a look into my installation script

    Yes, I saw these scripts and also I think that they should be a good starting point.

    All these functions packed in a generic class plus another zip class that handles read/copy, etc may do the work.

    (Guau! How easy is make code whitout write it!) :laugh:

    In the other hand, I'm a 2.3 hooligan, so in the next osC football match competition I like play with the 2.3 team, with the number 4...


  8. May be I'm wrong but I think almost the 60% osC installations are 2.2.  Why they can't update? We all know why, right?

    30% 2.3, why? Some new shops with a version with an ongoing increase of goods contributions that does the life easy. The effors that some of you for adapt from 2.2 a lot of contributions confirm my suspects.

    5%  with 3.0 -> only for intrepid people

    5% with 2.4 -> only for intrepid people. Good coding but with very few contributions, I think.

    IF in 2.4 is easy to add contributions, don need this code/contribution, but 2.3 needs it as wordpress need it or magento needs it, or open cart, etc.

    A scrip that does a backup to your database is essential.

    A script that install contributions and help you to keep them updated in a easy way is also essential.... of course in the osC version that I needs...

    Shopowners want to sell products and don't think in php to much. We like to open our IDE, run our local server or our beyond compare to spend a single evening find why 'this' or 'that' code don't work...:laugh:


  9. Estimado Piernas:

    Happy with your proposal!!!

    How we can help you?

    It needs to be into core? nooooooooo if it does the  life easy to shopowners they simply use it (as they use others contrib).

    Here, as ALWAYS, we need find a place where find the instructions to make the zip an the extra files to 'order' the installation.

    My point of view:

    A contribution needs to add new files and EDIT old (core or not) files, so:

    * zip file with all the files needed from a /catalog/ dir.

    * in the root (not in catalog) a .php file that does the install. why not installer.php? You put it  the list of 'steeps' for make the installer: -check ver, files permisions, existence of files, etc but also the hooks for add/edit the new code.

    In a second step, 'We' need study the way to make a log of the orders that 'installer.php' did, may be using a variation of 'Contribution Tracker'. In a future these orders may be executed in reverse to 'unninstall' the addom.

    I suggest you that you see here:

    https://apps.oscommerce.com/JWbl5&core-code-of-the-autoinstaller-script

    https://apps.oscommerce.com/Profile&247516-pektsekye

    They do almost the 75% of the needes you listed. The only drawback is that the 'list of steps' is written BY HAND in a xml file.

    If you make a class or a sort of functions that can translate a list of human readable actions (located in an array, for example) to a xml file you will do it!

    Whe array has 'verbs' that trigger a kind of functions like that:

    $instrucctions_array = array (

      'action' => 'insertCode',    //  <-- this verb will trigger the actions listed below
     'file' =>  '/admin/customers.php',
      'line' => 56,
      'beforWhere' => '<div class="located place">,
      'codeToBeInserted' => '<p>A buen precio va el tomate</p>'


    )

    tep_insert_in_cofiguration_table ( $paramName, array $arrayOfBeautifullParams) if needed...

    tep_insert_in_configuration_table ( $paramName, array $arrayOfBeautifullParams) if needed...

    tep_insert_in_file_this_code

    tep_uncomment_in_file_this_code

    tep_add_in_file_this_hook

    tep_edit_language_file_with

     

    tep_write_in_log_when_installation_is_sucessfull

    Another suggestion: STOP adding in classes params that almost never are used. Where need we  to  know the value of MY_N_MODULE_VERSION_NUMBER ? In the modules.php page?

    If not the infinite number of define()'s will be as crazy as useless, I think)

    https://generatewp.com/plugin-readme/?clone=test-plugin-readme-txt-file


  10. Very good entry!

    My sort reply is 'easy'.

    ...the long one:

    Watching the others alternatives of osCom that are the winners...

    https://trends.google.com/trends/explore?date=today 5-y&q=oscommerce,magento,prestashop,shopify,%2Fm%2F0xpxtgc

    - Easy installation of contributions / languages / templates. The customer upload a zip file and install it. May be the code used for update the core flies used in  2.4 may be a starting point. Also is needed to decouple core files for 'new files/folders' from app's / contributions. Isolate the core from contributions, isolate the application core from representation (templates). No more search in the branches of directories of directories of directories  from our lovely osC for add/edit/delete apps, contributions, languages files or templates files, the ussual issue when someone try to install a new contribution.

    - Easy installation, creation of templates and avoid coupling/dependency from a framework (bootstrap, jquery). Avoid insert html classes into code that works only in bootstrap. No more js into php, no more css into php, no more echo "<div class="btn"..." or class="col-", etc. If not we can't update to bootstrap 4 easily  (right, Gary?) or foundation or material desing or even try to add classes to a new template unless you search into classes or may be a page file or may be an configuration param...

    - Options/attributes: Need to rethinking how handle grouped options (a T-shirt red XL, printed in back/front), add EAN, weight, dimensions

    - Admin: Some efforts to make a responsive admin are not fully public (even unkown) for a lot of customers. It's a good news that this will be solved according the 'official roadmap'. Tables that can be sorted (customers, categories), ajax (?), a page for install contributions, etc.

    - How to handle modules: I think that the recent 'ultra' modularisation of page-components into 'modules' is good but I think someone must start thinking the best way to handle 250 modules in a easy way. The 'modules.php' must be redesigned, Piernas is doing a good try but I think that is only the first steep of a needed complete remodelation of this file. Seeing the admin side of wordpress may help us to thinking in make 'bulk changes' in params instead one by one.

    - A easy way to update database from previous versios to 2.3: Need for an 'official' script to make an automatic update from previous versions. A recurring issue for a lot of shopowners that would like to try. Yes, I know, there are a sql script, or is easy if you know that mysqladmin exist but is not the regular for a shopowner. The current oscommerce have some scripts that do something with the database but NOT an update from previous versions. If they are in core and they are almost usseless (may be someone uses it ONE time in their entire life) why not add another script of the same  nature?

    - Try to make parallel programing to avoid drastic disruptions from versions: I think is time to learn something from the past. Why 2.4 or 3.0 are a fault versions? Good coding (may be a little cryptic) with new programming paradigms but nobody's use it because the lack of contributions (well, frankl uses it, I know :laugh:). I think that 'sometimes' the official osCom development is good for learn PHP but core-developpers don't care if people will use the new or not. You can develop/code as you can/want but is good to see that the others are doing to try to keep customers/coders close. For example the 'new' feature for updating core versions (2.4) must be implemented in 2.3.

    ... and another NON related comments:

    - When 2.34 edge will be into the official download page? To much good work hidden in oscure forums links supplied for users... The 99% of people don't use this web as us (searching in every corner for news) but they need a easy way to be informed.

    - When a (decent) wiki where developers can read how to code, which functions classes exist (to avoid reinvent the reel) ,how name functions, conventions about dir  namming, class naming, etc. etc.?

    - When a (decent) language area where people can contribute to update/edit/download languages apart the english?

    - When a decent app's area where you can check if a app/contribution is good for you, the osC verssion that can support, the rating by ussers, link for forum, link for bug / suggestions? Why I CAN'T search for UPS or API or CSS?!?!? (please!!!!! decrease the minimun search characters for make the search in the app area)


  11. Is anybody there that can check the stats about the more donwloaded addoms to track, for example, the 25 more downloaded in the last year? Can share with us this list?

     

    This will help us to know the desires/thougs. At least the same that the thoughts of everyone of us writting here.

     

    My grain (focused in the admin area):

     

    1.- As soon as possible, create a core code that can be reusable in every next version. Try to avoid to create a 'wall' between osc and the shopers every time a new verssion arrives ( plus no compatibility of old addoms).

     

    2.- A database import from 2.2 to 2.X. I kow, I know, that this is easy, you can do it in 2 minutes, etc. But I think that the more important for a busisness is the info that it ownes (their customers, their product info...). A trusted addom that import easy your/their sensitive data will be welcome and, may be, a few more people should be seduced to 'go forward', instead to be in the 'Groundhog Day of php 5.2 / osC 2.2'...

     

    3.- Edit all sort of things: orders, cotomers detaills, invoices, products (when ckeditor or something like that will be in by default?) a decent attributes editor, etc.

     

    4.- Sort all kind of pages: customers, categories -> no need to show the tree of categories but ALL the products in a table that would be filtered - if necesary by a dropdown menu-; orders, reviews...

     

    5.- Stock control (including attributes), margin control.

     

    And, of course (sorry, I don't think that the following is 'out of topic'):

     

    1.- A decent addoms area in oscommerce where to find your favorite addom, where you can RATE or share with others that 'this addom don't work with 2.3.99' or 'It's is great with a clean interface' and also inform (from developer or users) if this addom are compatible with that osc version, etc. No original (WP users are familiar with that), I know...

     

    2.- The work that Burt and others did in the past year is laudable, but it seems that the BS version is almost a cryptic femonema that only the initianes can find. When will see that GOOD NEWS in <H1> in the very first page of oscommerce.com with a link to invite to download (download me / see all the compatible addons 25 and adding every day).

    Instead create a entry in this forum to list the BS compatible addoms, why no put in the addoms page at last a 'caterogy of 2.3.4BS' to filter the addoms?

     

    Spare time to coding. Perfect!

     

    But, at least, all of us (ejem, Your) will like to spread your code to all, right?

     

    Open the hive and show the honey!


  12. May be a seller wants something like that:

     

    http://devheart.org/examples/jquery-customizable-layout-using-drag-and-drop/3-implementation-in-a-real-design/index.html

     

    even a 'simplified' version of:

     

    http://neokoenig.github.io/jQuery-gridmanager/demo/simple.html

     

    No more numbers, % or know if bootstrap has 12 or 14 colums. I think.

     

    I think that prestashop does somethink like that (a 'live editor'  for the front page).

     

    A 'live previev' (in products_info or even index - including columns) will be 'the paradise' of all (including coders) :thumbsup:


  13. @@wHiTeHaT:

     

    abuse of store database configuration:

     

    Yes, may be but how time takes the database to perform a query with compile all the config. parameters, 0.01 sec.?

     

    May be I'm wrong, but may be the problem should be the memory and not the database performance.

     

    May be is better to write these kind of params into a file instead in database, a 'file read' was faster than 'query database' but, in this moment this is not 100% true.

     

    God thread (database performance)...


  14. Sorry, timeout of the blog, I try to put all the code propposed now:

     

     

     

    @@burt:

     

    1.- I don't want offend anyone.

    2.- If someday I became idiot and want to offend to someone in this blog YOU will be the last person that will be the target of my words. Why? You are in this moment the almost ONLY person (in the staff level) that try to clean the 'obsolete oscommerce' to bring it to the XXI. I know that my limitations of the knowledge of your language will cause some misunderstandings. So, from now to the end of times I BEG YOUR PARDON and beg the pardon of everyone that thinks that my writting is frivolous.

     

    If you need further comments of explanations from my side, please, send a PM and, sure, we will arrange everything.

     

    Now, social and etiquette apart, go to the code:

     

    1.- Goto:

    osCommerce-2334-bootstrap / includes / modules / header_tags / ht_product_colorbox.php

     

    2.- insert in line 21:

     

    // variables for made the life easy to shoppers nº1
    var $gutter_that_shopper_wants = MODULE_HEADER_TAGS_PRODUCT_COLORBOX_GUTTER_THAT_SHOPER_WANTS;
    var $image_width_that_shopper_wants = MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMAGE_WIDTH_THAT_SHOPPER_WANTS;
    

     

    3.- In line 28. Wait! Now is NOT 28 but 31... Replace:

     

    }
    

     

    with:

     

    $this->gutter_that_shopper_wants = MODULE_HEADER_TAGS_PRODUCT_COLORBOX_GUTTER_THAT_SHOPER_WANTS;
    $this->image_width_that_shopper_wants = MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMAGE_WIDTH_THAT_SHOPPER_WANTS;
    }
    

     

    4.- In line 49 (ok, ok, may be a little bellow!):

     

    Replace

     

    	 $oscTemplate->addBlock('<script>var ImgCount = $("#piGal").data("imgcount"); $(function() {$("#piGal").hide();$(\'#piGal\').photosetGrid({layout: ""+ ImgCount +"",width: \'250px\',highresLinks: true,rel: \'pigallery\',onComplete: function() {$(\'#piGal\').css({ \'visibility\': \'visible\'});$(\'#piGal a\').colorbox({maxHeight: \'90%\',maxWidth: \'90%\',rel: \'pigallery\'});$(\'#piGal img\').each(function() {var imgid = $(this).attr(\'id\').substring(9);if ( $(\'#piGalDiv_\' + imgid).length ) {$(this).parent().colorbox({ inline: true, href: "#piGalDiv_" + imgid });}});}});$("#piGal").show();});</script>', $this->group);
    

     

    With:

     

    
    	 $oscTemplate->addBlock('<script>var ImgCount = $("#piGal").data("imgcount"); $(function() {$("#piGal").hide();$(\'#piGal\').photosetGrid({layout: ""+ ImgCount +"",width: \'' $this->image_width_that_shopper_wants ''\', gutter: \'' $this->image_width_that_shopper_wants '', highresLinks: true,rel: \'pigallery\',onComplete: function() {$(\'#piGal\').css({ \'visibility\': \'visible\'});$(\'#piGal a\').colorbox({maxHeight: \'90%\',maxWidth: \'90%\',rel: \'pigallery\'});$(\'#piGal img\').each(function() {var imgid = $(this).attr(\'id\').substring(9);if ( $(\'#piGalDiv_\' + imgid).length ) {$(this).parent().colorbox({ inline: true, href: "#piGalDiv_" + imgid });}});}});$("#piGal").show();});</script>', $this->group);
    

     

    Sorry, this block is written 'by hand' with no IDE in front of me to check if the "'" added are right or break the js...

     

    5.- In line 66.... replace:

     

    tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_SORT_ORDER', '910', 'Sort order of display. Lowest is displayed first.', '6', '0', now())");
    }
    

     

    with:

     

     

     

    
    tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_SORT_ORDER', '910', 'Sort order of display. Lowest is displayed first.', '6', '0', now())");
    tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_GUTTER_THAT_SHOPER_WANTS', '910', 'Gap wetween images (in pixels)', '6', '0', now())");
    tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMAGE_WIDTH_THAT_SHOPPER_WANTS', '910', 'Max width of the image (in px)', '6', '250', now())");
    }
    

     

    6.- In line 74 replace:

     

     return array('MODULE_HEADER_TAGS_PRODUCT_COLORBOX_STATUS', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMG_LAYOUT', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_PAGES', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_SORT_ORDER');
    

     

     

    with:

     

     

    
     return array('MODULE_HEADER_TAGS_PRODUCT_COLORBOX_STATUS', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMG_LAYOUT', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_PAGES', 'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_SORT_ORDER',
    'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_GUTTER_THAT_SHOPER_WANTS',
    'MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMAGE_WIDTH_THAT_SHOPPER_WANTS'
    );
    

     

     

    My apologies again. And, please, tell me if someone, apart @@wHiTeHaT, thinks that this 'code' may be is a good idea or not.


  15. @@burt:

     

    1.- I don't want offend anyone.

    2.- If someday I became idiot and want to offend to someone in this blog YOU will be the last person that will be the target of my words. Why? You are in this moment the almost ONLY person (in the staff level) that try to clean the 'obsolete oscommerce' to bring it to the XXI. I know that my limitations of the knowledge of your language will cause some misunderstandings. So, from now to the end of times I BEG YOUR PARDON and beg the pardon of everyone that thinks that my writting is frivolous.

     

    If you need further comments of explanations from my side, please, send a PM and, sure, we will arrange everything.

     

    Now, social and etiquette apart, go to the code:

     

    1.- Goto:

    osCommerce-2334-bootstrap / includes / modules / header_tags / ht_product_colorbox.php

     

    2.- insert in line 21:

     

    // variables for made the life easy to shoppers nº1
    var $gutter_that_shopper_wants = MODULE_HEADER_TAGS_PRODUCT_COLORBOX_GUTTER_THAT_SHOPER_WANTS;
    var $image_width_that_shopper_wants = MODULE_HEADER_TAGS_PRODUCT_COLORBOX_IMAGE_WIDTH_THAT_SHOPPER_WANTS;
    


  16. @@bruyndoncx:

     

    All right, all right!!!

     

    So, WHY no add a variable accesible when you install this module (apart of the numbers to define the layout of the images) with a input form where the user may enter a integer that defines the number of pixels to define the space between images?

     

    Please, see the attached image. If someone thought in it and he can desing it, we will be able to do the same and much better!!!! :thumbsup:

     

    A new module should avoid the this kind of sin of deSINg, Well, if it it is intended to be used by people that don't know the term 'IDE'.... :-

     

×