Jump to content

molafish

Members
  • Content count

    72
  • Joined

  • Last visited

1 Follower

Profile Information

  • Real Name
    molafish
  • Gender
    Not Telling
  1. molafish

    FedEx - Web Services v9

    I'm trying to figure out why I have an order without a shipping charge, when this module is the only shipping module enabled. I have free shipping under the Order Total module disabled. So the only thing I can think of is checkout was able to continue when the soap service was down? Is that possible? I tried changing the url to something else to test what happens when the url is down, and that just threw php errors. So, I've come here to see what the expected behavior should be. I've seen mention of a "please enter zip code" message when people have auth problems. But does checkout still proceed after that message is displayed?
  2. molafish

    [Contribution] Option Types v2

    I would like to help make this work. I have not spent a whole lot of time understanding the attributeManager code, nor do I have lots of free time, but I would be willing to follow through on whatever todo lists you have to resolve the issues reported in the Linked Products support thread. The first thing that stands out to me is missing column 'type_show_product_as' reported there. How is that intended to be used in the product_types table? Please contact me via email at: my first name at first initial last name .net My name is Ian Freeman. ie firstname@firstinitiallastname.net Thanks.
  3. molafish

    Easy Populate Version 3

    Anything is possible. Not everything is desirable. This was suggested, by the way.
  4. Coupon Admin rollup 3 posted today. This release only adds one new feature to the coupon admin page (without having to click on report): - number of redemptions - date of last redemption - redeemed coupons view filter This rollup is comprehensive, in that it includes all the changes from the coupon admin bug rollup packages 1 and 2 that I posted earlier. I've included a screenshot in the package for your viewing pleasure.
  5. insomniac2, The code I changed in coupon_admin.php for number_format() and decimal precision seems the way it outght to be. If a dollar amount or percent has no post decimal data ($10.00 or 10.00%), then only display $10 or 10%. What you did was override the logic of the ternary operators I inserted. Basically, each ternary IF statement is now asking "Is the amount an integer? If so, then display to 2 decimals. If not, then display to 2 decimals." The code I wrote was intended to do this: "Is the amount an integer? If so, then display with 0 decimals. If not, then display to 2 decimals." If you want to always display decimals, why not replace all the ternary instances with just the number_format() call? It would clean up your code...
  6. I have finished a second round of bug fixes for the coupon admin page. It's available at the CCGV contrib page. Thanks to primadude for helping me find bugs here. You guys let me know if there are other bugs you find.
  7. Strange. Try applying the coupon admin rollup 2 package from the contrib section and see if it still does it.
  8. There are different sections of code that display based on which action mode was passed to the page. What is the action GET variable when you are having the problem? And what section of the $action switch is this code in? It looks like the 'new' case...
  9. If anyone has made this change and incorporates taxes in the coupon value, let me know if your order total math is coming out correct. Fred's code doesn't work because $cart is not set when he called product_price(). But I fail to see why we need Fred's change, because I am unfamiliar with the VAT shop setup. Somebody let me know how this works out with your tax settings (I don't let coupons deduct the tax amount).
  10. Try Textpad. It has file diff capability. It has other useful text editing features too like syntax highlighting, customizable modules, and line number matching for command line tools (configurable). I don't know if the demo is time limited or feature limited... Many have already done it. Open the install instructions for the contribs on the ccgv contrib page. There are line by line instructions in some. However, I don't know if 5.15a1 or a2 have those instructions. I have built comprehensive instructions for modded stores in the release I'm working on. I have now replied. I am currently testing the code myself (in a sort of alpha phase). After that has been finished, I will ask for greater widespread beta testing from others here. But before doing that, I will post the contrib so that you can all download it, in keeping with the forum rules. Sorry if it seems I'm not around. I do have full time school, 3 part time jobs, and on the side programming work to load balance...
  11. I've done a lot of fix work to admin/coupon_admin.php tonight. I'm going to put it up on the contrib page. Here's the highlights: Fixed coupon_admin from overwriting dates and customer uses fields to defaults when editing or displaying an error. (default uses per customer is 1 and default date range is now() to now() + 1 year). removed non-working length check of coupon_name field in coupon_admin, fixed other possibly non-working checks. (instead of fixing the check, I made the name optional. It was desirable for me to have the option to display just the coupon code to the customer). fixed problem where free shipping coupons deduct an additional amount (if the amount was specified on the coupon_admin page) above the shipping cost. During coupon creation now, the amount will be zeroed out if free shipping is checked. (You will need to edit all of your previous coupons which have both an amount and free shipping checked for this to take effect). fixed missing or hard coded language text used on coupon_admin page for errors and buttons. changed Coupon Name help text to reflect the unrequired nature of that field. (Your contrib probably still displays nothing if the name field is blank for a language - I have changed all instances of that to display the coupon code instead in my unpublished contrib. Until I put up the full contrib, just continue to enter the coupon name field to avoid this). All these changes are made only to one file: admin/coupon_admin.php. Except for the missing language text item, which will require you to add these 6 lines to your admin/includes/languages/[language]/coupon_admin.php file: define('ERROR_NO_COUPON_AMOUNT', 'Error: No coupon amount has been entered. Either enter an amount or select free shipping.'); define('ERROR_COUPON_EXISTS', 'Error: A coupon with the same coupon code already exists.'); define('COUPON_BUTTON_EMAIL_VOUCHER', 'Email Voucher'); define('COUPON_BUTTON_EDIT_VOUCHER', 'Edit Voucher'); define('COUPON_BUTTON_DELETE_VOUCHER', 'Delete Voucher'); define('COUPON_BUTTON_VOUCHER_REPORT', 'Voucher Report');
  12. In my last post, where I said "free checking" I meant "free shipping." Does the ability to edit your own post expire after a set amount of time?
  13. Right now the documentation (next to the free checking checkbox on the admin page) says: "The coupon gives free shipping on an order. Note. This overrides the coupon_amount figure but respects the minimum order value." The "overrides" part is by design. Really, the amount should not be recorded if free checking is checked. If that checks conceptually with everyone, I'll change that in the admin tool. It seems that the free shipping coupon is not working as expected anyway. If you do enter a dollar amount or percentage with free shipping checked, the percentage is changed to a dollar amount and that dollar amount is ADDED to whatever the shipping cost is to derive the order discount. Example: shipping costs 5 dollars. If a coupon is applied which has free checking checked and has 2.5 in the amount field, the discount showing on checkout_confirmation.php is $7.50. I have to rethink how checkout_confirmation should show the free shipping. The fixed sort order complicates things a little. Obviously, this should not happen. It should deduct 5.00. I'll post the fix here.
  14. He felt it was easier to code the communication to the user about the coupons and gift vouchers during the checkout process by using the error reporting process. I don't like this, and it should be changed. It also causes problems with special characters (such as umlauts in german) being displayed because all html chars are stripped out as a security precaution as they are parsed from the html query. With that being said, it can be put on the backburner. Primadude in the meantime has modified the stack so that the customer is not scared by a red warning which says Congratulations!
  15. If anyone knows, it's molafish. Ask him. You are right. The contrib as it stands currently is an abysmal mess. All the more reason to stop by and help test! This happened because we didn't have anyone take charge of the contribution and guide development and bug fixing. This will get better, I promise. Update on my progress: I have a working copy installed on a server. I am going through now and fixing known bugs. Every time I do I find three more. After I've done my testing I will post it. Stay tuned.
×