Jump to content

raiwa

♥Ambassador
  • Content count

    3,794
  • Joined

  • Last visited

  • Days Won

    129

Posts posted by raiwa


  1. 9 hours ago, Heatherbell said:

    Sorry to bother but just upgraded to phoenix 1.0.3.0.
    Trying to apply wholesale (SPPC Lite) changes to new 1.0.3.0 admin/categories.php - no success.
    Any advice is greatly appreciated.

    There are some minor adaptations required:

    - all database table name constants need to be replaced with the "real" database table names
    - point 3e is not required any more due to placeholders are used now to retrieve all database table entries
    - point 3h needs some style modifications to fit modified html
    - point 3i just add "updateGrossWS();" under "updateGross();"

    As I applied already the modifications in my develop store, here the modified 1.0.3.0 file:

    categories.php

    I'll update the Wholesale lite addon soon to fit Phoenix 1.0.3.0 and all admin/categories.php modifications will be hooked.

     


  2. Uploaded updated Store Mode:

    Store Mode Phoenix 1.3.1.

    Changes 1.3.1:
    - fixed typo in header module english language file. Thanks to @mhsuffolk
    - fixed undefined error message. Thanks to @mhsuffolk

    Changes 1.3.0:
    - header module updated for Phoenix BS 4
    - Updated header module message to show correct offline time if 2h auto setting is used
    - Updated admin header module message for 2h auto setting


  3. Updated for Phoenix:

    Store Mode Phoenix 1.3.1.

    Changes 1.3.1:
    - fixed typo in header module english language file. Thanks to @mhsuffolk
    - fixed undefined error message. Thanks to @mhsuffolk

    Changes 1.3.0:
    - header module updated for Phoenix BS 4
    - Updated header module message to show correct offline time if 2h auto setting is used
    - Updated admin header module message for 2h auto setting


  4. 1 hour ago, yahalimu said:

    Hi,

    My current 2.3.4 site uses SEO URLS 5.

    I'm just about to start on a a Phoenix site replacement.

    What is the latest compatible version should I use for this and can I configure it to keep the URL's the same on the new site as the old?

     

    The support thread for ULTIMATE SEO URLS 5 is this one:

    https://forums.oscommerce.com/topic/349814-ultimate-seo-urls-5-pro/?page=24&tab=comments#comment-1797284


  5. I did it oposite, use the new categories.php and add the ajax attributes manager code and all works fine. You ll find it in the product specific tab.

    Only thing is that the code reference for the first modification needs to be updated to hardcoded database table name:

              tep_db_perform('products', $sql_data_array, 'update', "products_id = '" . (int)$products_id . "'");
            }

    instead of:

              tep_db_perform(TABLE_PRODUCTS, $sql_data_array, 'update', "products_id = '" . (int)$products_id . "'");
            }

     


  6. 28 minutes ago, Heatherbell said:

    @raiwa

    Thanks again for this addon - I have just upgraded to 1.0.3.0 and sadly it has "disappeared" from view :(
    Do you know a 'quick fix'?

    I ignore how you updated, but if you replaced the admin/categories.php file with the new 1.0.3.0 version, you'll need to appliy again the ajax attributes manager modifications. Otherwise there may be an update required. I'll have a look when I find some time.


  7. 44 minutes ago, piernas said:

    1. Language class has been fixed. USU 5 does not use $lng but its own class to handle languages. It was loading languages class file without setting $lng so the next part of code that tried to load the class triggered that error. I think it could be good to load the class in navbar core module by checking first if the file has been included already (as other modules like paypal does).

    What do you mean with "should be secured"?

    • Switch arrror reporting to ALL
    • Do a new installation in a multilanguage store.
    • Have the core language navbar installed
    • Load the first time a store page
    • You'll get the posted error
      WIth "secure" I mean add a check or whatever to make the error disappear or advise in the instructions to remove the core version (not a good solution)
    44 minutes ago, piernas said:

    2. I made the hook to load only if multilanguage is enabled for USU5, so no need to selective copy.

    Fine, wasn't aware of the setting to be needed for to show href lang tags

     

    44 minutes ago, piernas said:

    3. it's not throwing any errors here but I'll watch it . Where is cache object set?

    I don't know where it is set. I saw this error in an error log and fixed it like this. Maybe it shows only when the cache is reset, then on first page load.

    37 minutes ago, piernas said:

    Did you see any page that should not have the tag? At first I cannot think of any...

    No, that's why I thought also that the page list is unnecessary. There are some pages where teh language tags are not needed because Google will never see them (checkout pages, account pages, download.php etc.), but it also makes no harm.


  8. 7 minutes ago, piernas said:

    move HT module to Hook -> good idea

    Juanma, did you read this and my other points:

    3 hours ago, raiwa said:

    2.:

    • The ht href language module is an optional module only for multilanguage stores
    • It adds the href language meta tag to the header, the most typical use for ht modules
    • hook => would need to be selective copied when installed (copy only if store languages > 1)
      or
    • hook => would need a check if store languages >1 => check would be executed on each page load
    • the ht module has page selection: ht can be configured via admin - hook would need to be edited to change pages list
    • Otherwise: does it need the page selection? for which reason the tags should not show on certain pages?
    • Suggestion: add an auto install script for the ht language module which installs it during installation of the other config entries only if store has more than 1 language.

     

     


  9. 8 hours ago, piernas said:

    It's ready.

    - Latest oscommerce (phoenix 1.0.3.0) compatible.
    - Fixed more cache issues. Now sqlite and memcache are only enabled if system supports the methods.
    - Moved admin edits to hooks. Now only two files on catalog needs to be modified.
    - Removed database table constants.
    - TODO: Allow to processs links outside root folder (ie. ext/directory). This is useful for addons like Twitter typeahead.

    Can someone test the atached files before uploading to addons?

    USU5_210.zip

    Tested on Phoenix 1.0.3.0:

    1.:
    - first time store page load (installation):
     

    Fatal error: Cannot declare class language, because the name is already in use in C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\classes\language.php on line 16

    - uninstalled language navbar module => error disappears

    - installed USU5 language navbar module => all ok

    => should be secured

    2.:

    1 hour ago, burt said:

    Possible changes, something to think about;

    • move HT module to Hook
    • The ht href language module is an optional module only for multilanguage stores
    • It adds the href language meta tag to the header, the most typical use for ht modules
    • hook => would need to be selective copied when installed (copy only if store languages > 1)
      or
    • hook => would need a check if store languages >1 => check would be executed on each page load
    • the ht module has page selection: ht can be configured via admin - hook would need to be edited to change pages list
    • Otherwise: does it need the page selection? for which reason the tags should not show on certain pages?
    • Suggestion: add an auto install script for the ht language module which installs it during installation of the other config entries only if store has more than 1 language.

    3. :

    In one live store I had to add an additional is_object check in: includes/modules/ultimate_seo_urls5/main/usu5-php line 77 to avoid an error message:

          if ( defined( 'USU5_ENABLED' ) && ( USU5_ENABLED == 'true' ) &&( USU5_CACHE_ON == 'true') && is_object('cache') ) {

     

    4. :

    Suggestion: add an uninstall config option for the whole USU5 installation to remove the config entries.

     

    Otherwise, all seems to be ok. Great job Juanma!


  10. 6 hours ago, piernas said:

    I'm checking the code. Cache system is set by default to sqlite only if it's installed on the system:

    
      if ( !class_exists( 'SQLite3' ) ) {
        $standard_cache_strategy = 'file';
      } else $standard_cache_strategy = 'sqlite';

    Table definitions were already changed in earlier revisions, even before these were changed in oscommerce BS.

    I can't find any error related to USU 5 on  a PHP73 server running live so (unless I changed something and forgot to update the addon) it's PHP 7.3 ready. Please, if someone that uses this addon could check error logs we'll be sure.

    Hola Juanma,

    With Ultimate Seo Urls 5 for Responsive Oscom R2.09 (october 2018):.

    OSCOM CE Phoenix v1.0.2.5 under local develop installation with XAMPP and PHP 7.3.2 and error reporting set to ALL

    I get on first time page load in the shop the following error:

    
    Warning: Can not find cache system: sqlite - NOT supported on this system in C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\main\bootstrap.php on line 529
    
    Fatal error: Uncaught Error: Call to a member function retrieve() on bool in C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\main\bootstrap.php:539 Stack trace: #0 C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\main\bootstrap.php(87): Usu5_Bootstrap->setRegistry() #1 C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\main\usu5.php(120): Usu5_Bootstrap->bootStrapper(Array) #2 C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\application_top.php(281): Usu_Main->initiate(Array, '2', 'espanol') #3 C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\index.php(13): require('C:\\xampp_php_7_...') #4 {main} thrown in C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\main\bootstrap.php on line 539

    In Admin : Configuration Seo Urls 5 : Select your chosen cache system? : I see: sqlite - NOT supported on this system

    When I switch cache system to file, I get:

    Warning: Use of undefined constant TABLE_CATEGORIES_DESCRIPTION - assumed 'TABLE_CATEGORIES_DESCRIPTION' (this will throw an Error in a future version of PHP) in C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\page_modules\index.php on line 169
    
    Warning: Use of undefined constant TABLE_CATEGORIES - assumed 'TABLE_CATEGORIES' (this will throw an Error in a future version of PHP) in C:\xampp_php_7_3_2\htdocs\Phoenix_Git\Responsive-osCommerce\includes\modules\ultimate_seo_urls5\page_modules\index.php on line 169
    1146 - Table 'phoenix_git_ultimate_seo.table_categories' doesn't exist
    
    SELECT cd2.categories_name AS pName, cd.categories_name AS cName FROM TABLE_CATEGORIES c LEFT JOIN TABLE_CATEGORIES_DESCRIPTION cd2 ON c.parent_id = cd2.categories_id AND c.parent_id = cd2.categories_id AND cd2.language_id = 2, TABLE_CATEGORIES_DESCRIPTION cd WHERE c.categories_id = cd.categories_id AND c.categories_id = 1 AND cd.language_id = 2

    In the index page file I see in line 34-39:

        protected $dependencies = array( 'cPath'            => array( 'marker'     => '-c-',
                                                                      'query'      => "SELECT cd2.categories_name AS pName, cd.categories_name AS cName FROM :TABLE_CATEGORIES c LEFT JOIN :TABLE_CATEGORIES_DESCRIPTION cd2 ON c.parent_id = cd2.categories_id AND c.parent_id = cd2.categories_id AND cd2.language_id = :languages_id, :TABLE_CATEGORIES_DESCRIPTION cd WHERE c.categories_id = cd.categories_id AND c.categories_id = :cid AND cd.language_id = :languages_id",
                                                                      'to_replace' => array( ':TABLE_CATEGORIES_DESCRIPTION', ':TABLE_CATEGORIES', ':languages_id', ':cid' ) ),
                                                                      'manufacturers_id' => array( 'marker'     => '-m-',
                                                                      'query'      => "SELECT manufacturers_name FROM :TABLE_MANUFACTURERS WHERE manufacturers_id=':manufacturers_id' LIMIT 1",
                                                                      'to_replace' => array( ':TABLE_MANUFACTURERS', ':manufacturers_id' ) ) );

    I didn't check further.

    Best regards
    Rainer


  11. 24 minutes ago, Denzel said:

    Hi Folks,

    got the same Error and found 

    
    if (@mysql_get_server_info($db_link)) {

    in attributeManager.php in Line 23. Changed to:

    
    if (@mysqli_get_server_info($db_link)) {

    and the Error 500 past away ;)

    See Ya,

    Denzel.

    Then you are using an outdated version.

    And your fix is incorrect if you only changed the line you posted.

    Since 2.9 it uses:

    // Determine connection type
    if (@mysqli_get_server_info($db_link)) {
      define ('AM_MYSQL_CONNECTION_TYPE', 'mysqli');
    } else {
      define ('AM_MYSQL_CONNECTION_TYPE', 'mysql');
    }

    Not the same error like reported by @Garret Krampe


  12. 3 hours ago, Peper said:

    Thanks for update

    I have a question.

    in includes/modules/product_listing_ws.php you specified schema example itemscope itemtype="https://schema.org/Offer

    With Phoenix there is a header tags module breadrumb and product JSON-LD that already does this.

    Is the schema still needed in product_listing_ws?

    Hello Pepper,

    As stated in the instructions of wholesale 4.0.1., the supplied files are compatible and based on Phoenix 1.0.1.x-

    The product listings have been modified for 1.0.2.x (I don't remember the exact point version) and you'll need to apply the modifications in the supplied files comparing with the core files for your Phonix version for 100% compatibility. I'll update as soon as I find some time.

    rgds
    Rainer


  13. 21 hours ago, piernas said:

    Can you post the error log file to fix it? I can't find any USU errors on mine.

    I don't have Phoenix installed and I won't install it for now, so can't say if there are differences, but for what I've seen it should work on it.

    Hola Juanma,

    I'm sorry I have no time to do a deeper research.

    For a first aproach:

    - cache system should be set to file or mysql by default, not to sqlite which is not supported on all systems and throws an error on installation
    - database table definitions have been removed and need to be updated to hardcoded table names
    - there are probably PHP 7.3 compatibility errors

    It would be really nice if you could do the update for Phoenix.

    Un saludo cordial
    Rainer

×