Jump to content

raiwa

♥Ambassador
  • Content count

    3,621
  • Joined

  • Last visited

  • Days Won

    124

Everything posted by raiwa

  1. raiwa

    Stripe v3 module for SCA

    Please do not use 1.0.7 for now. The code for order_status_history and order mails is removed/wrong. I have sent a PM to the author already and I suppose he will fix it in the next update.
  2. Uploaded Ajax attributes manager update for Phoenix: AJAX Attribute Manager BS 3.0.0.
  3. Phoenix ready Addons: The following free Addons are updated for Phoenix and available on the Marketplace: Spanish Language Pack: https://apps.oscommerce.com/f8hiQ&espanol-para-osc-ce https://github.com/raiwa/OSCOM-CE-Phoenix-Spanish-language-idioma-espanol Recently Viewed Products: https://apps.oscommerce.com/z7iA8&recently-viewed-products-ce Related Products: https://apps.oscommerce.com/y0rDZ&related-products-ce Featured Products: https://apps.oscommerce.com/TyAIr&featured-products-bs&p=2 Holiday Message: https://apps.oscommerce.com/G3NiL&holiday-promotional-message-ce Shop by Price: https://apps.oscommerce.com/Lia0H&shop-by-price-ce Wholesale Lite https://apps.oscommerce.com/VWUpG&wholesale-sppc-lite Discount Codes https://apps.oscommerce.com/iIUE4&discount-codes-bs Checked and compatible with Phoenix: Slim Checkout: https://apps.oscommerce.com/pgaC2&slim-checkout Modules Control: https://apps.oscommerce.com/FM65c&modules-control Coming soon: KissIt Image Thumbnailer only one small update needed see: https://forums.oscommerce.com/topic/388022-kissit-image-thumnailer/?do=findComment&comment=1790276 PWA (Purchase without account – Guest Checkout) QTPro Reviews Navbar Header Module Store Hotline Store Mode Sloppy Words Cleaner I’ll keep this lists updated when I’ll have ready new modules for Phoenix
  4. raiwa

    AJAX Attribute Manager support

    Uploaded update for Phoenix: AJAX Attribute Manager BS 3.0.0. Updated for Phoenix 1.0.x.x compatibility Added code reference for Phoenix Fixed some undefined notice errors.
  5. $listing_sql = "select distinct " . $select_column_list
  6. raiwa

    QTPro BS

    QTPro BS 5.0 I'm working on a new version based on QTpro for osc 2.3 version 4.6.1 plus newer updates and fixes. Planned Changes: coding updates for latest 2.3.4 BS EDGE Community version with hardcoded filenames, database table names, paths and superglobals content modules for product info, shopping cart hooked modifications or separate functions where possible to avoid core file changes (stock checks etc in checkout pages) final product prices shown in option/attribute combinations on product info page also for more than one option/combinations general code clean up language constants/definitions for all texts for full multilanguage support To do list: update qtprodoctor.php hardcoded stuff, superglobals language constants/definitions update stats_low_stock_attrib.php hardcoded stuff, superglobals language constants/definitions update stock.php hardcoded stuff, superglobals language constants/definitions replace mods in admin/boxes/tools.php by separate file replace mods in admin/boxes/reports.php by separate file avoid mods in admin/includes/functions/general.php load function file in modules replace core function mods by own functions? modularize product info options modularize product info stock table versions for Modular Product Page by kymation alternative product listing module for modularized shopping cart order class extension to avoid mods in core order class replace all mods in checkout files by hooks? check compatibility with ajax attribute manager add support for attribute sort order update instructions It would be great if there appear testers for the mods. Who has the old version already installed: - replace the admin files - upload and install the product info content modules and (IMPORTANT!) uncomment the complete options/attributes section in product_info.php For new installations: - instructions are not updated yet follow the old instructions except A.: don't modify admin/includes/boxes/tools.php and reports.php, upload the nwe files instead B.: upload and install the product info content modules and (IMPORTANT!) uncomment the complete options/attributes section in product_info.php instead to apply the mods Most important for now are the changes in the product info option modules to show final prices according to the option selection even if there are muliple option combinations (single drop down and single radios) GitHub repository Thanks and best regards Rainer
  7. raiwa

    CONSTANT check

    In some older contributions I find the following check if a constant is true: if (CONSTANT) { ... } Is this still useable/allowed in PHP 7.3 or should it better be replaced with: if ( defined('CONSTANT') && CONSTANT === true ) { ...... }
  8. raiwa

    Stripe v3 module for SCA

    @mhsuffolk, OK, thanks for confirming. Then let's see what the author @asro2004 says about. He will better know how to further debug this.
  9. raiwa

    Stripe v3 module for SCA

    Sorry, I was wrong. The old module uses "MODULE_PAYMENT_STRIPE_SECRET_KEY", the first versions of the new module were using "MODULE_PAYMENT_STRIPE_SCA_SECRET_KEY". The newer versions are using "MODULE_PAYMENT_STRIPE_SCA_LIVE_SECRET_KEY" and "MODULE_PAYMENT_STRIPE_SCA_TEST_SECRET_KEY". So the explanation may be that you @mhsuffolk, didn't uninstall the module before updating to the version which uses both live and test constants. Like this the old constant "MODULE_PAYMENT_STRIPE_SCA_SECRET_KEY" stays in the database.
  10. raiwa

    Stripe v3 module for SCA

    Sorry, forgot this: The discount code hook condition should be secured like this: if (defined('MODULE_ORDER_TOTAL_DISCOUNT_STATUS') && (MODULE_ORDER_TOTAL_DISCOUNT_STATUS == 'true' || MODULE_ORDER_TOTAL_DISCOUNT_STATUS == 'True') && file_exists(DIR_FS_CATALOG . 'includes/hooks/shop/checkout_process/discount_code.php') { In the older versions lower case 'true' is used, in the Phoenix version I updated to upper case 'True' to match other modules.
  11. raiwa

    Stripe v3 module for SCA

    I checked with the discount hook commented out and the same, no order mails. I also observed that no order status history is saved to the database. Order status stays in "Preparing [Stripe SCA]" and order status history is empty. I had a look and found that the Secret Key constant has not been updated in the webhook and payment_intent. It is still "MODULE_PAYMENT_STRIPE_SCA_SECRET_KEY". I changed it in payment_intent.php to: // supply an API key $secret_key = MODULE_PAYMENT_STRIPE_SCA_TRANSACTION_SERVER == 'Live' ? MODULE_PAYMENT_STRIPE_SCA_LIVE_SECRET_KEY : MODULE_PAYMENT_STRIPE_SCA_TEST_SECRET_KEY; \Stripe\Stripe::setApiKey($secret_key); and in webhook.php line 55-56 to: $secret_key = MODULE_PAYMENT_STRIPE_SCA_TRANSACTION_SERVER == 'Live' ? MODULE_PAYMENT_STRIPE_SCA_LIVE_SECRET_KEY : MODULE_PAYMENT_STRIPE_SCA_TEST_SECRET_KEY; \Stripe\Stripe::setApiKey($secret_key); But no luck, still no order mail and no order status history. I guess that @mhsuffolk and others which have it correct working have still the old stripe module installed with the old constant defined. It seems there is still some bug in the process_payment or update_order_status functions. Any idea where to check else? rgds Rainer
  12. Not on my addons list, but required for QTPro: Updated Options Images for Phoenix 1.0.2.x: Options Images CE Phoenix 1.6
  13. Uploaded Versión 1.0.2.4 for OSCOM CE Phoenix 1.0.2.4 Español para OsC CE https://github.com/raiwa/OSCOM-CE-Phoenix-Spanish-language-idioma-espanol
  14. raiwa

    Stripe v3 module for SCA

    Thanks, I'll check, must be something in my store then. You are using v 1.0.5?
  15. raiwa

    Stripe v3 module for SCA

    I do not get the order confirmation mails with the stripe sca module. I checked and I get it with the other payment module (PayPal express) I'm using. I also checked with different languages including the original english language file, and the same, no order confirmation mail is sent. Anybody else exprerience the same problem or do I need to analyse my store?
  16. raiwa

    Stripe v3 module for SCA

    @asro2004, Tested v. 1.0.5 and all fine. It seems I found an easy fix for the discount module which should also work for all other third party order total modules: in stripe_sca.php line 127 add "order_total_modules->process();" function confirmation() { global $oscTemplate, $cartID, $cart_Stripe_SCA_ID, $customer_id, $languages_id, $order, $currencies, $currency, $stripe_payment_intent_id, $order_total_modules; $order_total_modules->process();
  17. raiwa

    Stripe v3 module for SCA

    Works fine. But I found another issue. The text for the labels is hardcoded. In stripe_sca.php lines 346-349 should be: $content .= '<div id="stripe_table_new_card">' . '<div class="form-group"><label for="cardholder-name" class="control-label">' . MODULE_PAYMENT_STRIPE_SCA_CREDITCARD_OWNER . '</label>' . '<div class="col-sm-16"><input type="text" id="cardholder-name" class="form-control" value="' . tep_output_string($order->billing['firstname'] . ' ' . $order->billing['lastname']) . '" required></text></div></div>' . '<div class="form-group"><label for="card-element" class="control-label">' . MODULE_PAYMENT_STRIPE_SCA_CREDITCARD_NUMBER . '</label>' .
  18. raiwa

    QTPro BS

    Uploaded version 6.0.0. for Phoenix 1.0.2.x: https://apps.oscommerce.com/e317m&qtpro-bs Change Log: - updated for CE Phoenix 1.0.2.x - replaced ht module by sitewide hook - updated Options Images suport for v.1.6
  19. Uploaded Versión 1.0.2.3 for OSCOM CE Phoenix 1.0.2.3 Español para OsC CE https://github.com/raiwa/OSCOM-CE-Phoenix-Spanish-language-idioma-espanol
  20. Your choice. See the description.
  21. Which Optional Related Products version are you trying to install?
  22. raiwa

    Stripe v3 module for SCA

    Thank you @asro2004, I tested on a live shop and found the following: - in test mode: stucks on checkout_confirmation.php => card data filled in => pressed confirmation button => button stays disabled => doesn't forward, no payment processed - in live mode: payment got processed,but I got redirected to the empty shopping cart instead of checkout success. Payment correct registered, but order is not processed neither saved in the store db. Some issues: - the option "Save Card for next purchase?" shows on checkout_confirmation.php even it is disabled in the module. - "CVC" shows on checkout_confirmation.php even it is disabled in the module.
  23. raiwa

    Stripe v3 module for SCA

    I believe there is a typo: should be: "'payment_event.payment_failed" is not in the drop down list
  24. @SCH_001, You could just make a copy of the module and place it in modules/content/shopping_cart/ (supposed you are using modular shopping cart) you should rename the files, class name and all constants matching the naming convention of the other shopping cart modules. For the checkout_payment page, there is my modular checkout pages addon which would allow to do the same there.
×