Jump to content

raiwa

♥Ambassador
  • Content count

    3,620
  • Joined

  • Last visited

  • Days Won

    123

raiwa last won the day on August 26

raiwa had the most liked content!

Profile Information

  • Real Name
    Rainer Schmied
  • Gender
    Male
  • Location
    Sant Iscle de Vallalta, Barcelona, Spain
  • Website

Recent Profile Visitors

51,110 profile views
  1. Uploaded Ajax attributes manager update for Phoenix: AJAX Attribute Manager BS 3.0.0.
  2. raiwa

    AJAX Attribute Manager support

    Uploaded update for Phoenix: AJAX Attribute Manager BS 3.0.0. Updated for Phoenix 1.0.x.x compatibility Added code reference for Phoenix Fixed some undefined notice errors.
  3. $listing_sql = "select distinct " . $select_column_list
  4. raiwa

    CONSTANT check

    In some older contributions I find the following check if a constant is true: if (CONSTANT) { ... } Is this still useable/allowed in PHP 7.3 or should it better be replaced with: if ( defined('CONSTANT') && CONSTANT === true ) { ...... }
  5. raiwa

    Stripe v3 module for SCA

    @mhsuffolk, OK, thanks for confirming. Then let's see what the author @asro2004 says about. He will better know how to further debug this.
  6. raiwa

    Stripe v3 module for SCA

    Sorry, I was wrong. The old module uses "MODULE_PAYMENT_STRIPE_SECRET_KEY", the first versions of the new module were using "MODULE_PAYMENT_STRIPE_SCA_SECRET_KEY". The newer versions are using "MODULE_PAYMENT_STRIPE_SCA_LIVE_SECRET_KEY" and "MODULE_PAYMENT_STRIPE_SCA_TEST_SECRET_KEY". So the explanation may be that you @mhsuffolk, didn't uninstall the module before updating to the version which uses both live and test constants. Like this the old constant "MODULE_PAYMENT_STRIPE_SCA_SECRET_KEY" stays in the database.
  7. raiwa

    Stripe v3 module for SCA

    Sorry, forgot this: The discount code hook condition should be secured like this: if (defined('MODULE_ORDER_TOTAL_DISCOUNT_STATUS') && (MODULE_ORDER_TOTAL_DISCOUNT_STATUS == 'true' || MODULE_ORDER_TOTAL_DISCOUNT_STATUS == 'True') && file_exists(DIR_FS_CATALOG . 'includes/hooks/shop/checkout_process/discount_code.php') { In the older versions lower case 'true' is used, in the Phoenix version I updated to upper case 'True' to match other modules.
  8. raiwa

    Stripe v3 module for SCA

    I checked with the discount hook commented out and the same, no order mails. I also observed that no order status history is saved to the database. Order status stays in "Preparing [Stripe SCA]" and order status history is empty. I had a look and found that the Secret Key constant has not been updated in the webhook and payment_intent. It is still "MODULE_PAYMENT_STRIPE_SCA_SECRET_KEY". I changed it in payment_intent.php to: // supply an API key $secret_key = MODULE_PAYMENT_STRIPE_SCA_TRANSACTION_SERVER == 'Live' ? MODULE_PAYMENT_STRIPE_SCA_LIVE_SECRET_KEY : MODULE_PAYMENT_STRIPE_SCA_TEST_SECRET_KEY; \Stripe\Stripe::setApiKey($secret_key); and in webhook.php line 55-56 to: $secret_key = MODULE_PAYMENT_STRIPE_SCA_TRANSACTION_SERVER == 'Live' ? MODULE_PAYMENT_STRIPE_SCA_LIVE_SECRET_KEY : MODULE_PAYMENT_STRIPE_SCA_TEST_SECRET_KEY; \Stripe\Stripe::setApiKey($secret_key); But no luck, still no order mail and no order status history. I guess that @mhsuffolk and others which have it correct working have still the old stripe module installed with the old constant defined. It seems there is still some bug in the process_payment or update_order_status functions. Any idea where to check else? rgds Rainer
  9. Not on my addons list, but required for QTPro: Updated Options Images for Phoenix 1.0.2.x: Options Images CE Phoenix 1.6
  10. Uploaded Versión 1.0.2.4 for OSCOM CE Phoenix 1.0.2.4 Español para OsC CE https://github.com/raiwa/OSCOM-CE-Phoenix-Spanish-language-idioma-espanol
  11. raiwa

    Stripe v3 module for SCA

    Thanks, I'll check, must be something in my store then. You are using v 1.0.5?
  12. raiwa

    Stripe v3 module for SCA

    I do not get the order confirmation mails with the stripe sca module. I checked and I get it with the other payment module (PayPal express) I'm using. I also checked with different languages including the original english language file, and the same, no order confirmation mail is sent. Anybody else exprerience the same problem or do I need to analyse my store?
  13. raiwa

    Stripe v3 module for SCA

    @asro2004, Tested v. 1.0.5 and all fine. It seems I found an easy fix for the discount module which should also work for all other third party order total modules: in stripe_sca.php line 127 add "order_total_modules->process();" function confirmation() { global $oscTemplate, $cartID, $cart_Stripe_SCA_ID, $customer_id, $languages_id, $order, $currencies, $currency, $stripe_payment_intent_id, $order_total_modules; $order_total_modules->process();
  14. raiwa

    Stripe v3 module for SCA

    Works fine. But I found another issue. The text for the labels is hardcoded. In stripe_sca.php lines 346-349 should be: $content .= '<div id="stripe_table_new_card">' . '<div class="form-group"><label for="cardholder-name" class="control-label">' . MODULE_PAYMENT_STRIPE_SCA_CREDITCARD_OWNER . '</label>' . '<div class="col-sm-16"><input type="text" id="cardholder-name" class="form-control" value="' . tep_output_string($order->billing['firstname'] . ' ' . $order->billing['lastname']) . '" required></text></div></div>' . '<div class="form-group"><label for="card-element" class="control-label">' . MODULE_PAYMENT_STRIPE_SCA_CREDITCARD_NUMBER . '</label>' .
×