Jump to content

raiwa

♥Ambassador
  • Content count

    3,369
  • Joined

  • Last visited

  • Days Won

    114

Everything posted by raiwa

  1. raiwa

    Confusion over osC Versions.

    Done. @Dan Cole hope you do not mind that I just copied yours 😉
  2. @Tsimi, @MITCH70, I played around a bit more and found a solution where the ht module would only be required for the session unregister of the discount code. The only scenario where this makes sense/is required is the following: - discount input is allowed for guests/not logged in users in shopping cart - customer logged in and goes to checkout and introduces a discount code - he doesn't finish the order logs off and leaves the computer. - another user uses the same computer/session and goes as a guest to shopping cart, he will see the discount code from the other user which abandoned the checkout. - if he continues a purchase he can use the discount code which may have not been given to him Is this a real live problem or just a theorical unperfectness? EDIT: The same can happen in the old version if input in shopping cart is allowed to guests and the guest introduces a discount code and leaves the computer. Another user can see the code if he uses the computer before session expires. The complete settings would be: + no ht module required + application_top.php code moved to discount_code.php file in the root + 2 content modules (shopping cart and checkout payment) containing the validation script + checkout_process.php code moved into a hook + I believe the optional mod for paypal standard can also be hooked, needs to be tested. Like this the only core changes left would be the content module and hook calls Your thoughts?
  3. raiwa

    Modules Control

    New add-on Modules Control Extended and more complete version of Slim Checkout to control each individual content module for each store page. Download: https://github.com/raiwa/Module_Control/tree/master/New_Files/catalog/admin/includes/languages What it does: - add Module Control Page to Admin/Modules - allows to define controlled pages - allows to decide separate for each installed module and for each controlled page to be hidden. - control for each store root page (file) - control for each installed module of the following groups: - navbar - header - boxes - footer - footer_suffix Install: - copy all files from "New Files" folder - copy and replace "osc_template.php" from "Modified File" folder. Go to Admin/Modules/Modules Control This is Beta version. Please try and test. Any bug report and suggestion very welcome. rgds Rainer
  4. raiwa

    Modules Control

    New Version uploaded: Module Control 1.2.0 Changes: - Added back and fixed support for navbar modules. - Added modified navbar content module with modules control support - Fixed undefined warnings in navbar if no navbar modules are active in a navbar group
  5. Thank you Mitch for testing. The apply button is only required in shopping cart for to reload the page and show the discount in the ship in cart order total module. But you gave me the idea to link it there to the case when ship in cart ot module is used. Otherwise it is not required there neither.
  6. @Tsimi and other testers. Some more thoughts: I forgot that the old header tag also includes code to unregister the discount code from the session when a customer logs off. Thinking about it seems to me that this is not rquired. What harm can be done if the discount code keeps session registered? Anyway the discount codes are validated again on each checkout_confirmation load. Also when logging in again a new session is created anyway. Or do I miss something on this? But if we keep the ht module, we could do the following: + move the code from application_top.php to the ht module: one important core modification less + we can move the validation script from the content modules to the header tag module: only one copy of the script -> easier maintenance and update + we can keep the session unregister code for any case as in the old version - one module (ht) more in the package I created the above scenario version hewre it is for testing: - remove the code in application_top.php - install the new ht moduel test, test ,test give feedback Thank you Discount_Codes_5.0.0_beta_01.zip
  7. Sorry, yes the template filename need to be updated. Please rename the shopping cart template file from "discount_code.php" to "tpl_cm_sc_discount_code.php"
  8. raiwa

    NEW! Complete Order Editing Tool!

    Remove target="_blank" from the link
  9. raiwa

    Modules Control

    New Version uploaded: Module Control 1.1.0 Changes: - removed support for navbar modules. Thanks to @Omar_one for the error report - fixed typo for filename "osc_template.php" in instructions. Thanks to @Omar_one for the report
  10. raiwa

    Modules Control

    Hello @Omar_one, I had a deeper look now and found that the navbar modules are not processed at all in osc_template.php class. They are processed and included in the navbar parent module. Therefore it does not make sense to include them in Modules Control. I'll remove them and update. Anyway it's not common to switch off the navbar modules for selected pages and if needed it can be done in the modules themself. Thanks for your help and patience. Best regards Rainer
  11. @Tsimi, @MITCH70, @DAVID3733, and all other BS4 users: Here the BS4 content modules for shoppin_cart.php and checkout_payment.php. Only the modules and english language files are included. All other files from FROZEN should work. Make sure to: - uninstall the discount code ht-module - remove the hardcoded example Tsimi has posted above (if you have added) - add the following lines to checkout_payment.php just above the comments section line 226: <div class="row"> <?php echo $oscTemplate->getContent('checkout_payment'); ?> </div> - install the shopping cart and checkout payment content modules test, test , test give feedback, please PS: Maybe some fine tuning of the html output can be added Tsimi, I suggest to name the new version "Discount_Codes_5.0.0_BS4" or "Discount_Codes_5.0.0_BS3_BS4" or just leave it in "Discount_Codes_5.0.0_BS" and explain the other stuff in the description? I would include the generic files in a catalog folder like now and add one folder with the content modules for BS4 and another for BS3. For coherency I would also add a checkout_payment content module for BS3 and remove the ht-module. Your thoughts? 2.3.4._EDGE_BS4.zip
  12. @Tsimi, just to be sure, are you testing this on the latest EDGE BS4 and Discount_Codes_4.4.3_BS? I just repeated installation on latest vanilla EDGE BS4 and the same, input shows, spinner moves, "not validated" icon shows on any code I tried. When I continue to checkout confirmation, no discount code shows up. But discount code is correct registered in session. EDIT: Was running too fast, I read now the instructions and saw that I forgot like a bloody beginner to add the code to application_top.php. LOL 😂
  13. raiwa

    Confusion over osC Versions.

    CE stands for Community Edition and refers (now) to the complete series of Burt's bootstrapped edition. From early 2.3.3. 2014 repo until actual 2.3.4.1 EDGE BS4, including the fixed GOLD and FROZEN versions. The name "CE" appeared maybe a couple of years ago just to distinguish Burt's repos made with the help of other "Community" members from the "official" versions.
  14. Thats different, I can make changes and the non validated icon shows always after the spinner.
  15. No worries, this was a general statement, not opposed to your question 😉
  16. OK, thanks, I'll retry and keep you up to date.
  17. @Tsimi, Played with the shopping cart and ht module under EDGE BS4 and got it to show up correct, but couldn't get the validation script to work. I always get unvalidated icon. The same when I tried with your hardcoded solution. Do you have the same issue? Any ideas?
  18. Hello @Tsimi, I do have no plans to update add-ons to EDGE BS4 right now. My plans are to wait for the next stable release, CE BS4 or official BS4. I really have no time any more to run constantly behind EDGE updates. Anyway EDGE BS4 is intended for people who are able to update the add-ons themselve. Now in the case of discount code, the code breaks on a more serious way than just BS4 tags. So I'll see if I can find some time to bite the bullet and update it. Beside the change to footer-scripts group, the class selector in the ht-template needs to be changed to the following: $('div.contentContainer .form-group').before('<h2><?php echo TEXT_DISCOUNT_CODE; ?></h2><div class="col-xs-6 col-sm-3">\n\ As a general suggestion I would use the opportunity to remove the ht-module and replace it by a hook or better by a content module for the checkout_payment page. My favorite is a content module because of the following reasons: + we use already a content module for shopping cart, more coherency within the add-on + content module can beter controlled in admin: module width and sort order (if used with modular checkout) + fits perfect with modular checkout + stable and independent of core updates/changes or customizations - needs one line of additional code (content module call) in checkout_payment.php if modular checkout is not used Your thoughts? Kind regards Rainer
  19. raiwa

    Modules Control

    Hello @Omar_one, I got it finally to show the error. It only is produced for the navbar modules. If one of the navbar groups is empty the error shows together with another notice error. I tested before with all module groups except the navbar, thats why I couldn't reproduce it until now 😉. Your fix only solves the warning error you posted, but not the notice error. Anyway I found by the way that the module controle doesn't work with navbar modules. Even they are ticked to be hidden, they still show up. It seems to be related to the fact that navbar modules are a subgroup of the navbar content module. I believe this bug is the underlaying reason for the error messages. Once the navbar modules will work properly, the errors should also disappear. I'll dive back into the code to find a fix when I find some time. For now, just leave the navbar modules unticked. (I believe the error shows only if one navbar group is empty which should not be the case in a real store).
  20. raiwa

    Modules Control

    Frozen or EDGE BS4?
  21. raiwa

    Modules Control

    @Omar_one, I tried again and impossible to get the warning message. I switched off all footer modules, echoed the following: if ( $group == 'footer_scripts' ) { echo '<br><br>$this->_blocks[$group])' . print_r($this->_blocks[$group]); die; } And get displayed: Array ( [0] => [1] => ) without error message. My error settings are: error_reporting(E_ALL); ini_set('display_errors','1'); So I can only guess that you have some additional modifications or specific settings which produce it on your site. Do you have added any group which is not core like a second navbar with it's group? Which group you have empty? On which page the error shows up?
  22. raiwa

    Modules Control

    thanks, but this error may also occur in core. This line of code is unmodified and identical in core. Anyway I’ll test and include it in the next update. Is this stable? Shouldn’t there be a condition if empty or similar. Otherwise what happens if the group is not empty? Array on an array? Could it be better to put this line in a condition which checks if it’s an array.
  23. raiwa

    Modules Control

    @Omar_one, Thanks for the report, I’ll fix it in the next update. I’ll give it another try to reproduce your error, but I’m pretty sure I did the same and didn’t see it.,
  24. Sorry, but this info is contradictory. If it’s FROZEN, it’s BS3, if it’s BS4, it’s EDGE (not FROZEN). Anyway search the marketplace for admin levels, there are several add-ons available. All of them are older and may need some update.
  25. raiwa

    Modules Control

    New Version 1.0.3 uploaded.  Modules Control Changes Version 1.0.3: - added script to admin/modules_control.php to scroll back to top after update to show success message.
×