Jump to content

mhsuffolk

Members
  • Content count

    328
  • Joined

  • Last visited

  • Days Won

    1

Everything posted by mhsuffolk

  1. Thanks for that. The Stripe issue has been fixed, it was the new Stripe SCA module at fault, now corrected
  2. Us users of Stripe have been very fortunate in that a new forum member @asro2004 appeared from nowhere and has updated the Stripe module for SCA and, along with some testing support from @raiwa and myself, we now have a compliant system. Hopefully somebody will offer their help, but I am afraid it will not be HPDL.
  3. mhsuffolk

    Stripe v3 module for SCA

    Try this, it is not very pretty but it should help to lead the blind includes/languages/modules/payment/stripe_sca.php Find define('MODULE_PAYMENT_STRIPE_SCA_CREDITCARD_TYPE', 'Credit or Debit card'); Replace with define('MODULE_PAYMENT_STRIPE_SCA_CREDITCARD_TYPE', 'Credit or Debit card_____Expiry Date Security No');
  4. To illustrate, discount rate is 30%
  5. @swguy When installing your new Phoenix version on PHP 7.2 it installs but I get numerous versions of this: [26-Sep-2019 17:08:23 Europe/London] PHP Warning: Use of undefined constant MODULE_ORDER_TOTAL_QUANTITY_DISCOUNT_AMOUNT_1 - assumed 'MODULE_ORDER_TOTAL_QUANTITY_DISCOUNT_AMOUNT_1' (this will throw an Error in a future version of PHP) in /home/*****/********/includes/modules/order_total/ot_quantity_discount.php on line 106 Also, you may have seen there are issues with the new Stripe module. The discount is calculated correctly on the checkout confirmation screen and in the confirmation email but it is shown once and deducted twice in admin and the Stripe transaction.
  6. mhsuffolk

    Stripe v3 module for SCA

    No, it is not a coupon addon It is this but is an updated Phoenix version that is on his website. @swguyis the author. It works perfectly with all my other payment modules and worked with the original Stripe module.
  7. mhsuffolk

    Stripe v3 module for SCA

    Interestingly the confirmation emails have the correct discount calculation, it is just the admin and the actual amount that is fed to Stripe that is incorrect.
  8. mhsuffolk

    Stripe v3 module for SCA

    Thank you @asro2004 for the update. I have tested this and can confirm that the more than 7 items problem is resolved as is the missing order totals in the email. @raiwa The discount issue remains. This is NOT a hurry up, merely a confirmation that the discount problem remains.
  9. mhsuffolk

    Stripe v3 module for SCA

    Update. Tried a test transaction with 8 different items and I get this at the bottom of the checkout confirmation page. Fatal error: Uncaught Stripe\Error\InvalidRequest: Metadata can have up to 50 keys, but you've set 51. Email us at support+metadata@stripe.com for more information. in D:\Phoenix_7_3\htdocs\includes\modules\payment\stripe_sca\lib\ApiRequestor.php:210 from API request 'req_qLTjoeFcjFlStD' Stack trace: #0 D:\Phoenix_7_3\htdocs\includes\modules\payment\stripe_sca\lib\ApiRequestor.php(173): Stripe\ApiRequestor::_specificAPIError('{\n "error": {\n...', 400, Object(Stripe\Util\CaseInsensitiveArray), Array, Array) #1 D:\Phoenix_7_3\htdocs\includes\modules\payment\stripe_sca\lib\ApiRequestor.php(473): Stripe\ApiRequestor->handleErrorResponse('{\n "error": {\n...', 400, Object(Stripe\Util\CaseInsensitiveArray), Array) #2 D:\Phoenix_7_3\htdocs\includes\modules\payment\stripe_sca\lib\ApiRequestor.php(126): Stripe\ApiRequestor->_interpretResponse('{\n "error": {\n...', 400, Object(Stripe\Util\CaseInsensitiveArray)) #3 D:\Phoenix_7_3\htdocs\includes\modules\payment\stripe_sca\lib\ApiOperations\Request.php(57): Stripe\ApiRequestor-> in D:\Phoenix_7_3\htdocs\includes\modules\payment\stripe_sca\lib\ApiRequestor.php on line 210 At this stage the discount and totals on the customers screen are correct but it will not let him go any further. The order is in admin at the preparing Status but it has the discount shown once but calculated twice. If I remove 1 item from the cart it progresses to completion on the Stripe dashboard. However the discount issue remains.. If I disable the Discount module all is fine with 7 items or less. I appreciate the discount issue may be caused by the addon but IMO the number of items is the Stripe module issue.
  10. mhsuffolk

    Stripe v3 module for SCA

    New Bugs 1. Just had a customer order 15 different items, he tried 3 times to use Stripe and failed. The Stripe log in their dashboard shows a 400 error with this comment in the Response body section. "message": "Metadata can have up to 50 keys, but you've set 93 2. I use the Quantity Discounts by That Software Guy addon for Phoenix. It calculated the correct discount but somewhere in the process the discount amount got deducted twice. The shipping charge was correct. This error appears to be similar to @John P problem but relates to discount, his was tax. The old Stripe module worked correctly with this addon as do other payment modules
  11. mhsuffolk

    Stripe v3 module for SCA

    1. I can confirm that the confirmation email does not contain totals. I must confess that I had not noticed it. 2. As I am not VAT registered my prices are tax inclusive so I cannot test this issue.
  12. mhsuffolk

    Stripe v3 module for SCA

    Earlier today you said So presumably the comment would not appear on the invoice as it is not in the last status.
  13. mhsuffolk

    PayPal fee changes

    Mine is a small business. I offer "PayPal" at the bottom of my payment options list which has Bank Transfer, Cheque and Phone with Payment options, all under the top option which is "Credit and Debit Cards". There is no mention of it being Stripe as the payment method. I used to use Worldpay but that took the customer off to their website like PP Standard does. Stripe does not do this so I cannot see how a customer would not buy from me because I use Stripe.
  14. mhsuffolk

    PayPal fee changes

    Thankfully we have nearly got the updated Stripe add on de-bugged, which is SCA compliant. I did not realise Stripe has such a large share of the market compared to all the others. Does the PayPal figure include ebay payments? It is also interesting to me that Amazon, as a seller, is so successful and they do not accept PayPal...
  15. mhsuffolk

    PayPal fee changes

    If only we could find some way to break the general public's obsession with PayPal. They think it is more secure, it probably isn't, they do not have to enter their card details for every purchase, other payment options provide this also. Stripe can store their card details securely, it does not refund the fees of a refund BUT in the UK it is only 1.75% plus 20p, less for us to pay and less to lose if there is a refund. I turn off the PayPal module on my store sometimes and I have had regular customers move over to Stripe as it was the only option, but when I have had it on again, back they go to PayPal.
  16. mhsuffolk

    Stripe v3 module for SCA

    Yes, those lines are there. I have just noticed that indeed the comment was there but because it was last in the list, that is first to be created I did not spot it. The old Stripe module put the comments beside the order processed status, that is at the top of the list. I believe other payment modules do this also.
  17. mhsuffolk

    Stripe v3 module for SCA

    @asro2004 @raiwa Have tested 1.0.9 Status updates now appear to behave correctly. However, customers comments appear correctly in the email confirmation but not in the comments in admin against the order. If I add a comment in admin as I update the status that comment does appear.
  18. mhsuffolk

    Stripe v3 module for SCA

    @asro2004 Updated to 1.0.7 Under 1.0.6 in the order admin I get this and confirmation emails are received Line 2 is Order processed status. Line 3 is Transaction order status. (I have changed the label text) Under 1.0.7 I get this only and no emails are received. That is the Order processed status is not reached, payments have completed correctly in Stripe dashboard.
  19. mhsuffolk

    Stripe v3 module for SCA

    Your strange look picture seems to have disappeared. The file in question should be in includes/languages/english/modules/payment/stripe_sca.php I fear you have it in the wrong location as the strange look is due to missing language definitions. If it is there, has it 83 lines, the previous file was much shorter.
  20. mhsuffolk

    Stripe v3 module for SCA

    Have you installed version 1.0.7 It has had many English message labels moved to a language file, has that been missed?
  21. mhsuffolk

    Stripe v3 module for SCA

    Found it @asro2004 In ext/modules/content/account/stripe_sca/cards.php Line 21 if ( defined('MODULE_PAYMENT_INSTALLED') && tep_not_null(MODULE_PAYMENT_INSTALLED) && in_array('stripe.php', explode(';', MODULE_PAYMENT_INSTALLED)) ) { Change to if ( defined('MODULE_PAYMENT_INSTALLED') && tep_not_null(MODULE_PAYMENT_INSTALLED) && in_array('stripe_sca.php', explode(';', MODULE_PAYMENT_INSTALLED)) ) { This fault appeared after I had uninstalled the old Stripe module, previously it must have been using the old module's configuration values.
  22. mhsuffolk

    Stripe v3 module for SCA

    When you get to the checkout_confirmation page, before you have even entered a card number, you should have Preparing [Stripe SCA] in your admin and in the Stripe Dashboard under Developers/logs you should have a log entry like this. What do you get? Click on the row and you should have this.
  23. mhsuffolk

    Stripe v3 module for SCA

    Yes, it is the manage saved cards page. No errors in my PHP logs. I don't know if I should be able to, but if I call includes/modules/content/account/cm_account_stripe_sca_cards.php it returns a 403 error. I notice that the hyperlink on the accounts.php page is returning ext/modules/content/account/stripe_sca/cards.php Is this correct?
  24. mhsuffolk

    Stripe v3 module for SCA

    Update, I can now save cards and use them in test mode. I did not change anything apart from creating a new customer. it appears to have healed itself. However I still cannot access the saved cards page in test or live.
  25. mhsuffolk

    Stripe v3 module for SCA

    I have installed 1.0.6 Still cannot save cards in test mode. Not tried live. Stripe dashboard error says { "error": { "code": "resource_missing", "doc_url": "https://stripe.com/docs/error-codes/resource-missing", "message": "No such customer: cus_************; a similar object exists in live mode, but a test mode key was used to make this request.", "param": "customer", "type": "invalid_request_error" Cannot access saved cards in live that were saved by the old module. Token exists in the database, with the same customer hash as the blanked out one above. When I click the saved Cards link on the account page the screen just flicks and comes back to where it was.
×