Spikolynn

I'd say "Language is hardcoded as 1" is debugging information. Also my previous post has several points on how to improve documentation. But it does not work, yes :(

ok, from some debugging, it seems that the correct language is not being used - in Grid constructor language is hard coded as 1 and it does not seem to be changed, which is not correct for my store. also you should ommit the AUTO_INCREMENT setting in table creation ok, i spent 5 hours with this addon and now that it is working it is not working as it should. It is badly written and lacks good documentation. I will now spend another hour to remove it :(

Hey, I'm installing your addon now and from what I've seen it is good. Since you wanted some feedback I will describe my problems as I go. Please don't take this as negative criticism, I'm only trying to make your good addon even better :) Does not work after installation - in admin, the select boxes are empty and the error log lists 4 PHP Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in ..catalog\\admin\\includes\\functions\\database.php on line 99, referer: http://localhost:8088/catalog/admin/catego...ion=new_product documentation: instructions for new function tep_get_uprid($prid, $params ,$gid=0) are missing an } at the end, and they get split on two pages , so my foxit pdf reader inserts also the page title in the code which has to be removed. also some line breaks are incorrect with this pdf reader. consider having documentation as a HTML page. Also doc claims it's for version 1.2, though filename is gridversion1.4.zip function tep_check_stock( should be in documentation before tep_get_uprid as it is in the file. your tabulation and placement of { are inconsistent for new functions in general.php and some other places. Also you sometimes insctruct to remove { and then don't include it in your replacement code ("if (isset($HTTP_GET_VARS['pID']) && empty($HTTP_POST_VARS)) {" for instance and there was at least one more) . functions calculate() and get_products() - you should mention that one must first find these parts - it is not as you have written "Add new Method:" I know what this means, but you should be more descriptive. in admin/categories.php also the lines "<script language="JavaScript" type="text/javascript">" and "</script>" have to be added line $inputs = ''; is not after what you marked to delete, but much further. also a few lines before, when you delete "<select name="option_id">" you do not delete the closing </select> Serious error: you mention to change (in includes/classes/shopping_cart.php) if (($check_product !== false) && ($check_product['products_status'] == '1')) { if ($notify == true) { with if (($check_product !== false) && ($check_product['products_status'] == '1')&&( (int)$grid_id=='0' || $check_grid['grid_status']=='1')) { this will cause an error because one { will be missing. I did not delete if ($notify == true) { (but i moved it one line down) and it seems to be ok but I dunno what this will do. i also think it would actually be quicker/more clear to patch if you followed the somewhat standard find/replace/insert/delete syntax, maybe with line numbers. Thank you for the addon!