Latest News: (loading..)

Denkster

Members
  • Content count

    89
  • Joined

  • Last visited

2 Followers

About Denkster

Profile Information

  • Real Name
    Eveline Bernard
  1. I want to do it right.. Made mistakes before.. Can you please explain what the purpose is of statements like this: <?php if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { ?> Thanks in advance.. Eveline
  2. Hi Dan, Yes, you are right, I have got it working now. Translations for those: FILENAME_EMAIL_STATUS, FILENAME_EMAIL_ORDER_TEXT, FILENAME_ORDERS_LABEL, FILENAME_GOOGLE_MAP are not required, it seems. What do you think, should I post my version of the package (as a full package for order editor) to http://addons.oscommerce.com/info/7844 ? Eveline
  3. Hi Dan, Thank you, yes, I know about the compatibility add-on. But I reckon it is not very nice to name a contribution " ..for_2.3.4_BS" and still need a compatibility add-on. The version v1.2.4.1 of this (Order editor) contribution is not really old, is it? So I started to replace the FILENAME_.. and DIR_WS... occurrences as good as I could. Until now I did not have issues with the items that I could not replace FILENAME_EMAIL_STATUS, FILENAME_EMAIL_ORDER_TEXT, FILENAME_ORDERS_LABEL, FILENAME_GOOGLE_MAP I did not find these names in the compatibility add-on anyway. I checked http://addons.oscommerce.com/info/9506 "Add-On Compatibility support for OsCommerce 2.3.4 BS EDGE versions since September 2016" I suppose above mentioned file names have effect only with a contribution which I do not use? Thanks for caring! Eveline 7844_Denkster_3th_corrections on 7844_Order_editor_for_2.3.4BS.zip
  4. MORE Replaced path/filename parameters with actual paths and translations See attachment. Translations for Gwenn's orfder total modules included! 7844_Denkster_corrections on 7844_Order_editor_for_2.3.4BS.zip
  5. Replaced path/filename parameters with actual paths Although the contribution 7844 is called Order_Editor_for_2.3.4_BS_v1.2.4.1, I found it is not fully compatible with OsCommerce 2.3.4BS Edge. In OsCommerce 2.3.4BS Edge, the files catalog/includes/filenames.php and catalog/admin/includes/filenames.php no longer exist. All path/filename references are supposed to be hard coded So I edited the files I found via http://addons.oscommerce.com/info/7844 All went well except for the following lines of edit_orders.php: 181: if (FILENAME_EMAIL_STATUS !== 'FILENAME_EMAIL_STATUS' ) { 247 if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { 784 if ( FILENAME_EMAIL_ORDER_TEXT !== 'FILENAME_EMAIL_ORDER_TEXT' ){ 907 if ('invoice_pdf.php' !== 'FILENAME_PDF_INVOICE' ) { 1128-1141 <!- bof 5.0.8 --> <?php if ('invoice_pdf.php' !== 'FILENAME_PDF_INVOICE' ) { ?> <li><?php echo '<a href="' . tep_href_link('invoice_pdf.php', 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_invoice_pdf.gif', IMAGE_ORDERS_INVOICE) . '</a>'; ?></li> <?php } ?> <?php if ('packingslip_pdf.php' !== 'FILENAME_PDF_PACKINGSLIP' ) { ?> <li><?php echo '<a href="' . tep_href_link('packingslip_pdf.php', 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_packingslip_pdf.gif', IMAGE_ORDERS_PACKINGSLIP) . '</a>'; ?></li> <?php } ?> <?php if (FILENAME_ORDERS_LABEL !== 'FILENAME_ORDERS_LABEL' ) { ?> <li><?php echo '<a href="' . tep_href_link(FILENAME_ORDERS_LABEL, 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_label.gif', IMAGE_ORDERS_LABEL) . '</a>'; ?></li> <?php } ?> <?php if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { ?> <li><?php echo '<a href="' . tep_href_link(FILENAME_GOOGLE_MAP, 'oID=' . $HTTP_GET_VARS['oID']) . '" TARGET="_blank">' . tep_image_button('button_google_directions.gif', IMAGE_GOOGLE_DIRECTIONS) . '</a>'; ?></li> <?php } ?> <!- eof 5.0.8 --> What Should be done with these lines? Help, explain, please? So I updated the files asto the best of my knowledge. I corrected the layout (statement indentation, which was a mess). I also translated the language file to Dutch The results are attached. If you think I did it right, please update the contribution at http://addons.oscommerce.com/info/7844 using my input? Best regards Eveline Denkster_corrections on 7844_Order_editor_for_2.3.4BS.zip
  6. I solved my problem 'Sent back to login. Failed to decode session object. Session has been destroyed'. I am not sure which of my acts actually was the solution. 1. I removed this form my configure.php files: define('CFG_TIME_ZONE', 'UTC'); I doubt if that helped, since it was in both configure.php files and did not experience my problem in the admin. 2. I added a missing error message translation in my /catalog/includes/languages/dutch/checkout_process.php Could that have been the cause? Anyway, problem solved.
  7. Hi all, Thank you for your help. I solved the issue by starting all over with a clean install of 2.3.4BS Edge. So it seems to have been a configuration issue indeed. Eveline
  8. Hi Thank you very much for your kind and clear explanations, of the solution and of the answer policy. I am grateful I could learn from you that I was wrong and why. Thank you. Eveline
  9. Hi Dan, Thank you for that information, sad as it is. I am sorry. May he rest in peace. He will live on in his work, I hope. Unfortunately his add-on page is closed for others to post. Eveline
  10. utf8_unicode_ci Same as all other tables+
  11. More information: attached is a page_parse_time.log. At line 9 the session key is set. At line 245 the session is still available. At line 249 a query is made for a session key with the value '': select session_id from whos_online where session_id = '' limit 1 How .. ?? Eveline
  12. Hi Dan, THank you for taking the trouble of answering! Yes: https://www.denkster.nl/winkel/ But the problem manifests itself with existing clients only. I will send you an login by private message. Eveline
  13. Hi Do you use MySQL 5.7? It is more strict on queries! Check this out:https://dev.mysql.com/doc/refman/5.7/en/mysql-nutshell.html : Also see http://forums.oscommerce.com/topic/410833-osc-234bs-edge-sql-code-and-install-script-issues/#entry1754242
  14. I am not sure wether adding this: @mysqli_query($link, 'set session sql_mode=""'); is the best solution. What it does is disable the new security feature of MySQL v5.7 (see https://dev.mysql.com/doc/refman/5.7/en/mysql-nutshell.html: Maybe for now (it solves issues with all 'suspect' queries), but on the long run it is not a good idea to disable improvements of the platform, or? Rewriting the queries like this person did: is necessary. Eveline
  15. Thank you @mannehan. I just found your GIT repository. Cool job! Which are the 5 files with queries that needed rework to comply with MySql 5.7 safety standards? Much obliged! Eveline