Latest News: (loading..)

Denkster

Members
  • Content count

    94
  • Joined

  • Last visited

2 Followers

About Denkster

Profile Information

  • Real Name
    Eveline Bernard
  1. Dear Dan, Your advice worked out (after some adjustments) fine! Strange, if someone had asked me the question I asked you, I probably would have given the same answer you did. Somehow I needed you to convince me ... Of course I needed to change the change the original copy of that file, replace the FILENAME_... variables with hard coded filenames and the folder variable names with hard coded names of the folders. And I needed to replace the odd tests of this kind: if (FILENAME_EMAIL_STATUS !== 'email_status.php') { with statements of this shape: if ( file_exists('email_status.php') ) { But after those changes, I did not get double sets of order_totals anymore. So I am quite happy again, thanks to you , Dan, Thank you!
  2. The next problem... When I open an order for editing I get a URL like this: ../edit_orders.php?page=1&oID=1695&action=edit I normally find four order total lines on that page. Having changed NOTHING, When I click on the update button below the order total lines the system updates the order in a very peculiar way. I get an extra set of 4 order total lines, identical to the set of 4 which I already had! When I click once again, 4 more order total lines appear! Is this a known problem? I checked the parse time log, these queries are executed: 04/06/2017 19:12:33 [QUERY] DELETE FROM orders_total WHERE orders_id = '1695' 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'Zone tarieven (Naar NL : 165 kg):', '€ 7,20', '7.2', 'ot_shipping', '1') 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'BTW hoog:', '€ 3,85', '3.8528937768595', 'ot_tax', '2') 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'Subtotaal incl. BTW:', '€ 15,00', '15.000007', 'ot_subtotal', '3') 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'Totaal:', '<strong>€ 22,20</strong>', '22.200007', 'ot_total', '4') But the 4 inserts are done multiple times! I am perplexed! Any idea? Eveline
  3. Ok Dan, I can agree and will go with your explanation. I found 8 occurrences of this odd test. If I look at the occurrences where I recognize the file name, I see that the code is intended to place a button on screen, with a link to the file mentioned in the test. So I will assume that the test is meant to check if the corresponding file (and hopefully the module) exists.. Thanks for guiding me through the discovery process. Eveline
  4. You mean the code would become: if (FILENAME_EMAIL_STATUS !== 'email_status.php') { Sorry, I don't want to be a nuisance, I may just be stupid, but I still don't get it. Suppose filenames are no longer defined. In that case the variable FILENAME_EMAIL_STATUS is supposed to not be in use anywhere. It is meaningless. What would be the meaning of the above code then? Wouldn't it be better to use something like this: if ( file_exists('email_status.php') ) { Or am I missing the point again? Eveline
  5. Thanks Dan, Apart from the purpose of the unknown add on it seems to be related to, I was wondering how a statement like this was meant to work: if (FILENAME_EMAIL_STATUS !== 'FILENAME_EMAIL_STATUS' ) { I guess it checks if the variable FILENAME_EMAIL_STATUS is defined? How would that work in the new situation, where filenames are no longer represented with variables, but hard coded? Eveline
  6. I want to do it right.. Made mistakes before.. Can you please explain what the purpose is of statements like this: <?php if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { ?> Thanks in advance.. Eveline
  7. Hi Dan, Yes, you are right, I have got it working now. Translations for those: FILENAME_EMAIL_STATUS, FILENAME_EMAIL_ORDER_TEXT, FILENAME_ORDERS_LABEL, FILENAME_GOOGLE_MAP are not required, it seems. What do you think, should I post my version of the package (as a full package for order editor) to http://addons.oscommerce.com/info/7844 ? Eveline
  8. Hi Dan, Thank you, yes, I know about the compatibility add-on. But I reckon it is not very nice to name a contribution " ..for_2.3.4_BS" and still need a compatibility add-on. The version v1.2.4.1 of this (Order editor) contribution is not really old, is it? So I started to replace the FILENAME_.. and DIR_WS... occurrences as good as I could. Until now I did not have issues with the items that I could not replace FILENAME_EMAIL_STATUS, FILENAME_EMAIL_ORDER_TEXT, FILENAME_ORDERS_LABEL, FILENAME_GOOGLE_MAP I did not find these names in the compatibility add-on anyway. I checked http://addons.oscommerce.com/info/9506 "Add-On Compatibility support for OsCommerce 2.3.4 BS EDGE versions since September 2016" I suppose above mentioned file names have effect only with a contribution which I do not use? Thanks for caring! Eveline 7844_Denkster_3th_corrections on 7844_Order_editor_for_2.3.4BS.zip
  9. MORE Replaced path/filename parameters with actual paths and translations See attachment. Translations for Gwenn's orfder total modules included! 7844_Denkster_corrections on 7844_Order_editor_for_2.3.4BS.zip
  10. Replaced path/filename parameters with actual paths Although the contribution 7844 is called Order_Editor_for_2.3.4_BS_v1.2.4.1, I found it is not fully compatible with OsCommerce 2.3.4BS Edge. In OsCommerce 2.3.4BS Edge, the files catalog/includes/filenames.php and catalog/admin/includes/filenames.php no longer exist. All path/filename references are supposed to be hard coded So I edited the files I found via http://addons.oscommerce.com/info/7844 All went well except for the following lines of edit_orders.php: 181: if (FILENAME_EMAIL_STATUS !== 'FILENAME_EMAIL_STATUS' ) { 247 if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { 784 if ( FILENAME_EMAIL_ORDER_TEXT !== 'FILENAME_EMAIL_ORDER_TEXT' ){ 907 if ('invoice_pdf.php' !== 'FILENAME_PDF_INVOICE' ) { 1128-1141 <!- bof 5.0.8 --> <?php if ('invoice_pdf.php' !== 'FILENAME_PDF_INVOICE' ) { ?> <li><?php echo '<a href="' . tep_href_link('invoice_pdf.php', 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_invoice_pdf.gif', IMAGE_ORDERS_INVOICE) . '</a>'; ?></li> <?php } ?> <?php if ('packingslip_pdf.php' !== 'FILENAME_PDF_PACKINGSLIP' ) { ?> <li><?php echo '<a href="' . tep_href_link('packingslip_pdf.php', 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_packingslip_pdf.gif', IMAGE_ORDERS_PACKINGSLIP) . '</a>'; ?></li> <?php } ?> <?php if (FILENAME_ORDERS_LABEL !== 'FILENAME_ORDERS_LABEL' ) { ?> <li><?php echo '<a href="' . tep_href_link(FILENAME_ORDERS_LABEL, 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_label.gif', IMAGE_ORDERS_LABEL) . '</a>'; ?></li> <?php } ?> <?php if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { ?> <li><?php echo '<a href="' . tep_href_link(FILENAME_GOOGLE_MAP, 'oID=' . $HTTP_GET_VARS['oID']) . '" TARGET="_blank">' . tep_image_button('button_google_directions.gif', IMAGE_GOOGLE_DIRECTIONS) . '</a>'; ?></li> <?php } ?> <!- eof 5.0.8 --> What Should be done with these lines? Help, explain, please? So I updated the files asto the best of my knowledge. I corrected the layout (statement indentation, which was a mess). I also translated the language file to Dutch The results are attached. If you think I did it right, please update the contribution at http://addons.oscommerce.com/info/7844 using my input? Best regards Eveline Denkster_corrections on 7844_Order_editor_for_2.3.4BS.zip
  11. I solved my problem 'Sent back to login. Failed to decode session object. Session has been destroyed'. I am not sure which of my acts actually was the solution. 1. I removed this form my configure.php files: define('CFG_TIME_ZONE', 'UTC'); I doubt if that helped, since it was in both configure.php files and did not experience my problem in the admin. 2. I added a missing error message translation in my /catalog/includes/languages/dutch/checkout_process.php Could that have been the cause? Anyway, problem solved.
  12. Hi all, Thank you for your help. I solved the issue by starting all over with a clean install of 2.3.4BS Edge. So it seems to have been a configuration issue indeed. Eveline
  13. Hi Thank you very much for your kind and clear explanations, of the solution and of the answer policy. I am grateful I could learn from you that I was wrong and why. Thank you. Eveline
  14. Hi Dan, Thank you for that information, sad as it is. I am sorry. May he rest in peace. He will live on in his work, I hope. Unfortunately his add-on page is closed for others to post. Eveline
  15. utf8_unicode_ci Same as all other tables+