Jump to content

Denkster

Members
  • Content count

    94
  • Joined

  • Last visited

2 Followers

Profile Information

  • Real Name
    Eveline Bernard

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. Denkster

    NEW! Complete Order Editing Tool!

    Dear Dan, Your advice worked out (after some adjustments) fine! Strange, if someone had asked me the question I asked you, I probably would have given the same answer you did. Somehow I needed you to convince me ... Of course I needed to change the change the original copy of that file, replace the FILENAME_... variables with hard coded filenames and the folder variable names with hard coded names of the folders. And I needed to replace the odd tests of this kind: if (FILENAME_EMAIL_STATUS !== 'email_status.php') { with statements of this shape: if ( file_exists('email_status.php') ) { But after those changes, I did not get double sets of order_totals anymore. So I am quite happy again, thanks to you , Dan, Thank you!
  2. Denkster

    NEW! Complete Order Editing Tool!

    The next problem... When I open an order for editing I get a URL like this: ../edit_orders.php?page=1&oID=1695&action=edit I normally find four order total lines on that page. Having changed NOTHING, When I click on the update button below the order total lines the system updates the order in a very peculiar way. I get an extra set of 4 order total lines, identical to the set of 4 which I already had! When I click once again, 4 more order total lines appear! Is this a known problem? I checked the parse time log, these queries are executed: 04/06/2017 19:12:33 [QUERY] DELETE FROM orders_total WHERE orders_id = '1695' 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'Zone tarieven (Naar NL : 165 kg):', '€ 7,20', '7.2', 'ot_shipping', '1') 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'BTW hoog:', '€ 3,85', '3.8528937768595', 'ot_tax', '2') 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'Subtotaal incl. BTW:', '€ 15,00', '15.000007', 'ot_subtotal', '3') 04/06/2017 19:12:33 [QUERY] insert into orders_total (orders_id, title, text, value, class, sort_order) values ('1695', 'Totaal:', '<strong>€ 22,20</strong>', '22.200007', 'ot_total', '4') But the 4 inserts are done multiple times! I am perplexed! Any idea? Eveline
  3. Denkster

    NEW! Complete Order Editing Tool!

    Ok Dan, I can agree and will go with your explanation. I found 8 occurrences of this odd test. If I look at the occurrences where I recognize the file name, I see that the code is intended to place a button on screen, with a link to the file mentioned in the test. So I will assume that the test is meant to check if the corresponding file (and hopefully the module) exists.. Thanks for guiding me through the discovery process. Eveline
  4. Denkster

    NEW! Complete Order Editing Tool!

    You mean the code would become: if (FILENAME_EMAIL_STATUS !== 'email_status.php') { Sorry, I don't want to be a nuisance, I may just be stupid, but I still don't get it. Suppose filenames are no longer defined. In that case the variable FILENAME_EMAIL_STATUS is supposed to not be in use anywhere. It is meaningless. What would be the meaning of the above code then? Wouldn't it be better to use something like this: if ( file_exists('email_status.php') ) { Or am I missing the point again? Eveline
  5. Denkster

    NEW! Complete Order Editing Tool!

    Thanks Dan, Apart from the purpose of the unknown add on it seems to be related to, I was wondering how a statement like this was meant to work: if (FILENAME_EMAIL_STATUS !== 'FILENAME_EMAIL_STATUS' ) { I guess it checks if the variable FILENAME_EMAIL_STATUS is defined? How would that work in the new situation, where filenames are no longer represented with variables, but hard coded? Eveline
  6. Denkster

    NEW! Complete Order Editing Tool!

    I want to do it right.. Made mistakes before.. Can you please explain what the purpose is of statements like this: <?php if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { ?> Thanks in advance.. Eveline
  7. Denkster

    NEW! Complete Order Editing Tool!

    Hi Dan, Yes, you are right, I have got it working now. Translations for those: FILENAME_EMAIL_STATUS, FILENAME_EMAIL_ORDER_TEXT, FILENAME_ORDERS_LABEL, FILENAME_GOOGLE_MAP are not required, it seems. What do you think, should I post my version of the package (as a full package for order editor) to http://addons.oscommerce.com/info/7844 ? Eveline
  8. Denkster

    NEW! Complete Order Editing Tool!

    Hi Dan, Thank you, yes, I know about the compatibility add-on. But I reckon it is not very nice to name a contribution " ..for_2.3.4_BS" and still need a compatibility add-on. The version v1.2.4.1 of this (Order editor) contribution is not really old, is it? So I started to replace the FILENAME_.. and DIR_WS... occurrences as good as I could. Until now I did not have issues with the items that I could not replace FILENAME_EMAIL_STATUS, FILENAME_EMAIL_ORDER_TEXT, FILENAME_ORDERS_LABEL, FILENAME_GOOGLE_MAP I did not find these names in the compatibility add-on anyway. I checked http://addons.oscommerce.com/info/9506 "Add-On Compatibility support for OsCommerce 2.3.4 BS EDGE versions since September 2016" I suppose above mentioned file names have effect only with a contribution which I do not use? Thanks for caring! Eveline 7844_Denkster_3th_corrections on 7844_Order_editor_for_2.3.4BS.zip
  9. Denkster

    NEW! Complete Order Editing Tool!

    MORE Replaced path/filename parameters with actual paths and translations See attachment. Translations for Gwenn's orfder total modules included! 7844_Denkster_corrections on 7844_Order_editor_for_2.3.4BS.zip
  10. Denkster

    NEW! Complete Order Editing Tool!

    Replaced path/filename parameters with actual paths Although the contribution 7844 is called Order_Editor_for_2.3.4_BS_v1.2.4.1, I found it is not fully compatible with OsCommerce 2.3.4BS Edge. In OsCommerce 2.3.4BS Edge, the files catalog/includes/filenames.php and catalog/admin/includes/filenames.php no longer exist. All path/filename references are supposed to be hard coded So I edited the files I found via http://addons.oscommerce.com/info/7844 All went well except for the following lines of edit_orders.php: 181: if (FILENAME_EMAIL_STATUS !== 'FILENAME_EMAIL_STATUS' ) { 247 if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { 784 if ( FILENAME_EMAIL_ORDER_TEXT !== 'FILENAME_EMAIL_ORDER_TEXT' ){ 907 if ('invoice_pdf.php' !== 'FILENAME_PDF_INVOICE' ) { 1128-1141 <!- bof 5.0.8 --> <?php if ('invoice_pdf.php' !== 'FILENAME_PDF_INVOICE' ) { ?> <li><?php echo '<a href="' . tep_href_link('invoice_pdf.php', 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_invoice_pdf.gif', IMAGE_ORDERS_INVOICE) . '</a>'; ?></li> <?php } ?> <?php if ('packingslip_pdf.php' !== 'FILENAME_PDF_PACKINGSLIP' ) { ?> <li><?php echo '<a href="' . tep_href_link('packingslip_pdf.php', 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_packingslip_pdf.gif', IMAGE_ORDERS_PACKINGSLIP) . '</a>'; ?></li> <?php } ?> <?php if (FILENAME_ORDERS_LABEL !== 'FILENAME_ORDERS_LABEL' ) { ?> <li><?php echo '<a href="' . tep_href_link(FILENAME_ORDERS_LABEL, 'oID=' . $_GET['oID']) . '" TARGET="_blank">' . tep_image_button('button_label.gif', IMAGE_ORDERS_LABEL) . '</a>'; ?></li> <?php } ?> <?php if (FILENAME_GOOGLE_MAP !== 'FILENAME_GOOGLE_MAP' ) { ?> <li><?php echo '<a href="' . tep_href_link(FILENAME_GOOGLE_MAP, 'oID=' . $HTTP_GET_VARS['oID']) . '" TARGET="_blank">' . tep_image_button('button_google_directions.gif', IMAGE_GOOGLE_DIRECTIONS) . '</a>'; ?></li> <?php } ?> <!- eof 5.0.8 --> What Should be done with these lines? Help, explain, please? So I updated the files asto the best of my knowledge. I corrected the layout (statement indentation, which was a mess). I also translated the language file to Dutch The results are attached. If you think I did it right, please update the contribution at http://addons.oscommerce.com/info/7844 using my input? Best regards Eveline Denkster_corrections on 7844_Order_editor_for_2.3.4BS.zip
  11. Denkster

    Invoice Editor 1.0

    Hi Dan, Thank you for that information, sad as it is. I am sorry. May he rest in peace. He will live on in his work, I hope. Unfortunately his add-on page is closed for others to post. Eveline
  12. Denkster

    Invoice Editor 1.0

    Hi Dokta, I updated your Addon 8885_Invoice Editor, to comply with 2.3.4BS Edge. It is now 8885_Invoice_Editor_v.1.4_for_2.3.4_BS. 20170324 by Denkster Changes in 1.4: - adapted to OsC 2.3.4BS - replaced <table.><tr><td> layout elements with <div> layout elements - Removed admin/includes/filenames.php - hard coded folder names and file names in code lines - replaced tpdf (not maintained) by fpdf (is maintained) - updated Install.txt Complete package attached. Eveline Bernard 8885_Invoice_Editor_v.1.4_for_2.3.4_BS.zip
  13. Denkster

    ULTIMATE Seo Urls 5 - by FWR Media

    Hi, Anyone still having problems with image contributions and USU5? As Robert is telling us over and over, "the problem lies outside USU5", and he is right. For those who are still struggling to know where outside, here are two posts of mine that show image contributions, which I revised to work correctly with USU5. 1032 Additional images module see my post http://forums.oscommerce.com/topic/35801-contribution-additional-images-module/page__view__findpost__p__1594131 6238 Product Cycle Slideshow see my post http://forums.oscommerce.com/topic/315453-products-cycle-slideshow/page__view__findpost__p__1593933 Please use them to our mutual advantage and feel free to comment. Regards Eveline
  14. Denkster

    [Contribution] Additional Images Module

    Sorry for delay in answering. I was not watching this forum, while searching for the cause and a solution myself. Please correct me if I'm wrong, here are my thoughts. The problem I found with USU5 in combination with image add-ons was that USU5 did not redirect correctly after putting a product in the shopping cart. The cause of the problem seemed to be: (I'm not sure if the cause was Additional Images only or Product Cycle Slideshow too) USU5 requires strict and correct use of the function tep_href_link($page = '', $parameters = '', $connection = 'NONSSL'). Linking to a page directly (without tep_href_link), or with a different function, is not allowed when using USU5. The parameters in the page URL must be inside the brackets. Parameters cannot be added outside tep_href_link(), or USU5 will redirect to an unintended location. This goes for the front end of the shop; AFAIK USU does not change the admin. In at least one link of an image application I found link-URL parameters outside the function brackets (type 1 error). I found an error of the first type, in line 150 of displayimages.php document.write(\'<a href="' . (!$this->onpagemenu ? 'javascript:popupWindow(\\\'' : '') . tep_href_link( $this->linkurl, ($item==0&&$this->groupwithparent=='true'?'pID='.$products_id:'imagesID='.$addimages_images[$item]['id'])) . (!empty($_GET['products_id']) ? '&products_id='.$_GET['products_id'] : '') . (!empty($_GET['cPath']) ? '&cPath='.$_GET['cPath'] : '') . (!$this->onpagemenu ? '\\\')' : '') . '"' . $t_menu_mouseover . '>' . tep_image(DIR_WS_IMAGES . $addimages_images[$item]['image'], addslashes($addimages_images[$item]['desc']), (ADDIMAGES_RESTRICT_PARENT=='false'&&$item==0&&$this->groupwithparent=='true'?'':$addimages_image_width), (ADDIMAGES_RESTRICT_PARENT=='false'&&$item==0&&$this->groupwithparent=='true'?'':$addimages_image_height), 'hspace="5" vspace="5"') . '<br>' . (!empty($addimages_images[$item]['desc'])?addslashes($addimages_images[$item]['desc']):TEXT_CLICK_TO_ENLARGE) . '</a>\'); In that line, these URL parameters (if !empty) are outside the brackets op tep_href_link(): '&products_id='.$_GET['products_id'] .'&cPath='.$_GET['cPath'] I found an error of the 2nd type (link notusing tep_href_link) in line 407 of additional_images.php $lc_text = ' <a href="javascript:popupWindow(\'additional_images_popup.php?'.(!empty($listing['additional_images_id'])?'additional_images_id='.$listing['additional_images_id']:'products_id='.$listing['products_id']).'\')">' . ($_GET['show_images'] == 'y' ? tep_image(DIR_WS_CATALOG . DIR_WS_IMAGES . (!empty($listing['products_image']) ? $listing['products_image'] : (!empty($listing['products_image_med']) ? $listing['products_image_med'] : (!empty($listing['products_image_pop']) ? $listing['products_image_pop'] : '' ) ) ), $listing['products_name'], (ADDIMAGES_RESTRICT_IMAGE_SIZE=='true'?SMALL_IMAGE_WIDTH:''), (ADDIMAGES_RESTRICT_IMAGE_SIZE=='true'?SMALL_IMAGE_HEIGHT:'')) : '') . '</a> '; And in line 142 of displayimages.php document.write(\'<a href="images/' . $addimages_images[$item]['popimage'] . '"target="_blank" rel="lightbox[group]" title="' . addslashes(htmlspecialchars($addimages_images[$item]['desc'])) .'"' . $t_menu_mouseover . '>' . tep_image(DIR_WS_IMAGES . $addimages_images[$item]['image'], addslashes(htmlspecialchars($addimages_images[$item]['desc'])), (ADDIMAGES_RESTRICT_PARENT=='false'&&$item==0&&$this->groupwithparent=='true'?'':$addimages_image_width), (ADDIMAGES_RESTRICT_PARENT=='false'&&$item==0&&$this->groupwithparent=='true'?'':$addimages_image_height), 'hspace="5" vspace="5"') . '<br>' . (!empty($addimages_images[$item]['desc'])?addslashes($addimages_images[$item]['desc']):TEXT_CLICK_TO_ENLARGE). '</a>\'); And in line 35 of categories.php define('TEXT_PRODUCT_MORE_INFORMATION', 'For more information, please visit this products <a href="http://%s" target="blank"><u>webpage</u></a>.');
×